GNU bug report logs - #39511
github tokens being deprecated

Previous Next

Package: guix;

Reported by: Matt Wette <matt.wette <at> gmail.com>

Date: Sat, 8 Feb 2020 14:51:02 UTC

Severity: normal

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Matt Wette <matt.wette <at> gmail.com>
To: 39511 <at> debbugs.gnu.org
Subject: bug#39511: github auth
Date: Sat, 15 Feb 2020 10:43:56 -0800

I have not gotten into testing, but according to email and references
provided previously the patch below might work.


--- github.scm-orig    2020-02-15 10:32:52.209481329 -0800
+++ github.scm    2020-02-15 10:40:36.958144491 -0800
@@ -154,14 +154,12 @@
     ;; Ask for version 3 of the API as suggested at
     ;; <https://developer.github.com/v3/>.
     `((Accept . "application/vnd.github.v3+json")
+      ,@(if (%github-token)
+        `(Authorization . ,(string-append "token " (%github-token)))
+        '())
       (user-agent . "GNU Guile")))

-  (define (decorate url)
-    (if (%github-token)
-        (string-append url "?access_token=" (%github-token))
-        url))
-
-  (match (json-fetch (decorate release-url) #:headers headers)
+  (match (json-fetch release-url #:headers headers)
     (#()
      ;; We got the empty list, presumably because the user didn't use 
GitHub's
      ;; "release" mechanism, but hopefully they did use Git tags.
This bug report was last modified 4 years and 314 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.