GNU bug report logs - #39491
28.0.50; two bugs in battery-upower

Previous Next

Package: emacs;

Reported by: rms <at> gnu.org

Date: Fri, 7 Feb 2020 20:16:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 28.0.50

Fixed in version 28.1

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 39491 <at> debbugs.gnu.org, lg.zevlg <at> gmail.com, Richard Stallman <rms <at> gnu.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#39491: 28.0.50; two bugs in battery-upower
Date: Thu, 11 Jun 2020 20:41:04 +0100

Michael Albinus <michael.albinus <at> gmx.de> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> --- a/test/lisp/battery-tests.el
>> +++ b/test/lisp/battery-tests.el
>> @@ -48,6 +48,69 @@ battery-linux-proc-apm-regexp
>>      (should (equal (match-string 8 str) "1792"))
>>      (should (equal (match-string 9 str) "min"))))
>>
>> +(ert-deftest battery-upower-state ()
>> +(ert-deftest battery-upower-state-unknown ()
>
> Shouldn't theses tests be skipped, unless battery-upower is used?

No, because they test a pure function that depends only on its
arguments.

-- 
Basil
This bug report was last modified 5 years and 57 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.