GNU bug report logs - #39491
28.0.50; two bugs in battery-upower

Previous Next

Package: emacs;

Reported by: rms <at> gnu.org

Date: Fri, 7 Feb 2020 20:16:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 28.0.50

Fixed in version 28.1

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Nicolas Richard <youngfrog <at> members.fsf.org>
To: lg.zevlg <at> gmail.com
Cc: 39491 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, rms <at> gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#39491: 28.0.50; two bugs in battery-upower
Date: Sat, 21 Mar 2020 11:45:36 +0100

(I'm sorry if this comes to you as a duplicate, I think I sent it by error
to the wrong set of people)

lg.zevlg <at> gmail.com writes:
> If level is unavailable and AC is off-line/unknown, then it should be empty string I think.  User could see the battery level is low/critical by percentage

I committed a oneliner doing that, pushed as fix/bug-39491

See: https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=fix/bug-39491

It's been a long time since I didn't commit to emacs, can you check if
it's OK to merge ?

I'm aware that it is not a full fix because it doesn't address the
following :

> OK, we should generalize multi-battery code then, so each status func
> won’t reimplement multi battery handling.

but at least it stops the error.

-- 
Nicolas
This bug report was last modified 5 years and 57 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.