GNU bug report logs - #39480
[PATCH] gnu: Add zig compiler

Previous Next

Full log

Message #11 received at 39480 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Simon Nielsen <tauoverpi <at> yandex.com>
Cc: 39480 <at> debbugs.gnu.org
Subject: Re: [bug#39480] [PATCH] gnu: Add zig compiler
Date: Fri, 20 Nov 2020 20:38:23 +0000

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Fri, Feb 07, 2020 at 01:40:41PM +0100, Simon Nielsen wrote:
>> Hi,
>> 
>> Adds the zig compiler as a new file in `gnu/packages/`
>
> Thanks! Please add it to 'gnu/local.mk'.
>
>> +(define-public zig-0.5.0
>
> We can name it 'zig' until there are multiple versions in Guix.
>
>> +     `(#:tests? #f
>
> Why are the tests disabled? Is it because there is no test suite? Or
> something else? Please add a brief code comment explaining it.
>
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'build 'fix-build
>> +           (lambda _ (setenv "HOME" "/tmp") #t)))))
>
> I guess that the build tries to access $HOME?
>
>> +    (description
>> +      "Programming languaged designed for robustness, optimality, and clarity")
>
> Can you try to make a more detailed description here? At least it should
> be a complete sentence.
>
>> +    (synopsis
>> +      "Programming languaged designed for robustness, optimality, and clarity")
>
> Typo: languaged

It's been a few months, is this patch still relevant?

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.