GNU bug report logs - #39476
[PATCH] gnu: sane-backends: Disable genesys_unit_tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39476 in the body.
You can then email your comments to 39476 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: guix-patches <at> gnu.org
Cc: 39449 <at> debbugs.gnu.org
Subject: [PATCH] gnu: sane-backends: Disable genesys_unit_tests.
Date: Thu,  6 Feb 2020 23:39:55 +0100

* gnu/packages/scanner.scm (sane-backends)[arguments]<#:phases>:
Add disable-failing-backend-tests.
---
 gnu/packages/scanner.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/scanner.scm b/gnu/packages/scanner.scm
index 6adaba18cd..3f922a4747 100644
--- a/gnu/packages/scanner.scm
+++ b/gnu/packages/scanner.scm
@@ -131,6 +131,10 @@ package contains the library, but no drivers.")
        ((#:phases phases)
         `(modify-phases ,phases
            (delete 'disable-backends)
+           (add-after 'disable-failing-tests 'disable-failing-backend-tests
+             (lambda _
+               (substitute* "testsuite/backend/genesys/Makefile.in"
+                  ((" genesys_unit_tests\\$\\(EXEEXT\\)") ""))))
            (add-after 'unpack 'add-backends
              (lambda _
                (substitute* "backend/dll.conf.in"
-- 
2.25.0

Message #8 received at 39476 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 39476 <at> debbugs.gnu.org, 39449 <at> debbugs.gnu.org
Subject: Re: [bug#39476] [PATCH] gnu: sane-backends: Disable
 genesys_unit_tests.
Date: Thu, 13 Feb 2020 23:36:44 +0100

Hi,

Leo Prikler <leo.prikler <at> student.tugraz.at> skribis:

> * gnu/packages/scanner.scm (sane-backends)[arguments]<#:phases>:
> Add disable-failing-backend-tests.
> ---
>  gnu/packages/scanner.scm | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/gnu/packages/scanner.scm b/gnu/packages/scanner.scm
> index 6adaba18cd..3f922a4747 100644
> --- a/gnu/packages/scanner.scm
> +++ b/gnu/packages/scanner.scm
> @@ -131,6 +131,10 @@ package contains the library, but no drivers.")
>         ((#:phases phases)
>          `(modify-phases ,phases
>             (delete 'disable-backends)
> +           (add-after 'disable-failing-tests 'disable-failing-backend-tests
> +             (lambda _
> +               (substitute* "testsuite/backend/genesys/Makefile.in"
> +                  ((" genesys_unit_tests\\$\\(EXEEXT\\)") ""))))

Applied with two things: returning #t, and adding a comment linking to
the bug report.

Danny: this is actually on i686, not on x86_64.  See the build logs:

--8<---------------cut here---------------start------------->8---
$ guix build sane-backends -s i686-linux --log-file --no-grafts
https://ci.guix.gnu.org/log/w150bi6vvqqll31qqy99vm1iwwj4hgm9-sane-backends-1.0.29
$ guix build sane-backends -s x86_64-linux --log-file --no-grafts
https://ci.guix.gnu.org/log/m8mdg866lkzw6jnbgdz8b4spk61mx2y6-sane-backends-1.0.29
$ guix describe
Generacio 128   Feb 10 2020 22:29:47    (nuna)
  guix 8a0dd28
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 8a0dd289c5b201ebfdd5465d412230bb81110e4c
--8<---------------cut here---------------end--------------->8---

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.