GNU bug report logs - #39452
[PATCH] vc-git-state fails for filenames with wildcards

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, Noam Postavsky <npostavs <at> gmail.com>, 39452 <at> debbugs.gnu.org, Wolfgang.Scherer <at> gmx.de
Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards
Date: Fri, 27 Aug 2021 20:10:13 +0300

>> -  (vc-git-command nil 0 (vc-git--literal-pathspecs (list old new)) "mv" "-f" "--"))
>> +  (vc-git-command nil 0 (list old new) "mv" "-f" "--"))
>
> Looks like the proper fix, thanks. Feel free to push it right away, if
> you like.

Pushed now.

I wonder how many git commands still remain broken
and will go unnoticed to the release?  Such as
vc-git-delete-file and vc-git-mark-resolved, etc.

> Would be great to add some test, though. vc-tests.el currently doesn't
> exercise vc-rename-file at all.

Indeed, covering all git commands will avoid the danger of breaking
some commands.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.