GNU bug report logs - #39452
[PATCH] vc-git-state fails for filenames with wildcards

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Noam Postavsky <npostavs <at> gmail.com>, 39452 <at> debbugs.gnu.org, Wolfgang.Scherer <at> gmx.de
Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards
Date: Sat, 14 Aug 2021 13:56:36 +0200

Dmitry Gutov <dgutov <at> yandex.ru> writes:

>> Nobody had any opinions, and the "if it's good enough for Magit"
>> argument is a good one.  So I went ahead and applied Dmitry's patch to
>> Emacs 28, and we'll see whether there's any push back on that...
>
> As luck would have it, I have a bit of code (namely
> project--vc-list-files) that got broken with that change.
>
> Because, when EXTRA-IGNORES are present, it constructs some
> non-literal pathspecs, which naturally fail (get misinterpreted) with
> GIT_LITERAL_PATHSPECS=1.
>
> So we need an escape hatch to turn off this feature, which could take
> form of a dynamic variable, like in the patch below.
>
> Or we could revert to the other approach. What do people think?

If we've seen one piece of code break here already, then perhaps
reverting and moving to the other (safer, but more invasive) approach is
the right way to go.  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.