Subject: bug#39447: closed (Re: [bug#39447] [PATCH] gnu: Add python-gandi.cli.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 13 Feb 2020 23:26:02 +0000

Your bug report

#39447: [PATCH] gnu: Add python-gandi.cli.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
39447: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39447
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#39447] [PATCH] gnu: Add python-gandi.cli.
From: Tobias Geerinckx-Rice <[email-masked]>
To: [email-masked], Amin Bandali <[email-masked]>
Date: Fri, 14 Feb 2020 00:25:55 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Amin,

Amin Bandali 写道：
> * gnu/packages/python-xyz.scm (python-gandi.cli): New variable.

Thanks!  This package is already in Guix as ‘gandi.cli’ — we avoid 
the ‘python-’ prefix for stand-alone programmes since being 
written in Python (or any other language) is irrelevant.

+    (propagated-inputs
+     `(("git" ,git)
+       ("openssh" ,openssh)
+       ("openssl" ,openssl)
+       ("python-click" ,python-click)
+       ("python-ipy" ,python-ipy)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-requests" ,python-requests)
+       ("python-setuptools" ,python-setuptools)))

Propagation should be avoided when possible, although it's (sadly) 
more common in Python packages than elsewhere.

However, propagating inputs like git, openssh, openssl, 
python-setuptools… is definitely wrong.  Was this deliberate? 
Which problem were you trying to solve?  Take a look at 
gandi.cli's ‘embed-store-file-names’ for a different approach that 
avoids propagation altogether.

I'm closing this bug, but please let me know if the existing 
gandi.cli is missing features.  I added it but haven't used it in 
a while.

Kind regards,

T G-R

Subject: [PATCH] gnu: Add python-gandi.cli.
From: Amin Bandali <[email-masked]>
To: [email-masked]
Cc: Amin Bandali <[email-masked]>
Date: Wed, 5 Feb 2020 22:13:05 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/python-xyz.scm (python-gandi.cli): New variable.
---
 gnu/packages/python-xyz.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index dcc1595446..2472890dae 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -69,6 +69,7 @@
 ;;; Copyright © 2019 Tanguy Le Carrour <[email-masked]>
 ;;; Copyright © 2019 Mădălin Ionel Patrașcu <[email-masked]>
 ;;; Copyright © 2020 Jakub Kądziołka <[email-masked]>
+;;; Copyright © 2020 Amin Bandali <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -17467,3 +17468,35 @@ extensive support of PNG features.  It can also read and write Netpbm PAM
 files, with a focus on its use as an intermediate format for implementing
 custom PNG processing.")
     (license license:expat)))
+
+(define-public python-gandi.cli
+  (package
+    (name "python-gandi.cli")
+    (version "1.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "gandi.cli" version))
+       (sha256
+        (base32
+         "110wc9zgxsrvw4yzp21p0ian5lcf7vhcpxhnmsc4fg9pzl2bwxd5"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("git" ,git)
+       ("openssh" ,openssh)
+       ("openssl" ,openssl)
+       ("python-click" ,python-click)
+       ("python-ipy" ,python-ipy)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-requests" ,python-requests)
+       ("python-setuptools" ,python-setuptools)))
+    (native-inputs
+     `(("python-pytest" ,python-pytest)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-tox" ,python-tox)))
+    (home-page "https://github.com/Gandi/gandi.cli")
+    (synopsis "Gandi command line interface")
+    (description "Gandi CLI is a command line interface for creating and
+managing Gandi.net products (domains, certificates, servers, etc) using
+Gandi's public API.")
+    (license license:gpl3+)))
-- 
2.25.0