GNU bug report logs - #39447
[PATCH] gnu: Add python-gandi.cli.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39447 in the body.
You can then email your comments to 39447 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Amin Bandali <mab <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Amin Bandali <mab <at> gnu.org>
Subject: [PATCH] gnu: Add python-gandi.cli.
Date: Wed,  5 Feb 2020 22:13:05 -0500

* gnu/packages/python-xyz.scm (python-gandi.cli): New variable.
---
 gnu/packages/python-xyz.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index dcc1595446..2472890dae 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -69,6 +69,7 @@
 ;;; Copyright © 2019 Tanguy Le Carrour <tanguy <at> bioneland.org>
 ;;; Copyright © 2019 Mădălin Ionel Patrașcu <madalinionel.patrascu <at> mdc-berlin.de>
 ;;; Copyright © 2020 Jakub Kądziołka <kuba <at> kadziolka.net>
+;;; Copyright © 2020 Amin Bandali <mab <at> gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -17467,3 +17468,35 @@ extensive support of PNG features.  It can also read and write Netpbm PAM
 files, with a focus on its use as an intermediate format for implementing
 custom PNG processing.")
     (license license:expat)))
+
+(define-public python-gandi.cli
+  (package
+    (name "python-gandi.cli")
+    (version "1.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "gandi.cli" version))
+       (sha256
+        (base32
+         "110wc9zgxsrvw4yzp21p0ian5lcf7vhcpxhnmsc4fg9pzl2bwxd5"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("git" ,git)
+       ("openssh" ,openssh)
+       ("openssl" ,openssl)
+       ("python-click" ,python-click)
+       ("python-ipy" ,python-ipy)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-requests" ,python-requests)
+       ("python-setuptools" ,python-setuptools)))
+    (native-inputs
+     `(("python-pytest" ,python-pytest)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-tox" ,python-tox)))
+    (home-page "https://github.com/Gandi/gandi.cli")
+    (synopsis "Gandi command line interface")
+    (description "Gandi CLI is a command line interface for creating and
+managing Gandi.net products (domains, certificates, servers, etc) using
+Gandi's public API.")
+    (license license:gpl3+)))
-- 
2.25.0

Message #8 received at 39447 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Amin Bandali <mab <at> gnu.org>
Cc: 39447 <at> debbugs.gnu.org
Subject: Re: [bug#39447] [PATCH] gnu: Add python-gandi.cli.
Date: Thu, 13 Feb 2020 23:25:33 +0100

Hi,

Amin Bandali <mab <at> gnu.org> skribis:

> * gnu/packages/python-xyz.scm (python-gandi.cli): New variable.

LGTM, thanks!

Ludo’.

Message #13 received at 39447-close <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 39447-close <at> debbugs.gnu.org, Amin Bandali <mab <at> gnu.org>
Subject: Re: [bug#39447] [PATCH] gnu: Add python-gandi.cli.
Date: Fri, 14 Feb 2020 00:25:55 +0100

[Message part 1 (text/plain, inline)]

Amin,

Amin Bandali 写道：
> * gnu/packages/python-xyz.scm (python-gandi.cli): New variable.

Thanks!  This package is already in Guix as ‘gandi.cli’ — we avoid 
the ‘python-’ prefix for stand-alone programmes since being 
written in Python (or any other language) is irrelevant.

+    (propagated-inputs
+     `(("git" ,git)
+       ("openssh" ,openssh)
+       ("openssl" ,openssl)
+       ("python-click" ,python-click)
+       ("python-ipy" ,python-ipy)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-requests" ,python-requests)
+       ("python-setuptools" ,python-setuptools)))

Propagation should be avoided when possible, although it's (sadly) 
more common in Python packages than elsewhere.

However, propagating inputs like git, openssh, openssl, 
python-setuptools… is definitely wrong.  Was this deliberate? 
Which problem were you trying to solve?  Take a look at 
gandi.cli's ‘embed-store-file-names’ for a different approach that 
avoids propagation altogether.

I'm closing this bug, but please let me know if the existing 
gandi.cli is missing features.  I added it but haven't used it in 
a while.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.