From unknown Wed Sep 10 10:35:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39446: 28.0.50; Use quit-restore-window to close tab Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Feb 2020 22:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 39446@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15809424637979 (code B ref -1); Wed, 05 Feb 2020 22:42:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Feb 2020 22:41:03 +0000 Received: from localhost ([127.0.0.1]:46919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izTLz-00024b-2G for submit@debbugs.gnu.org; Wed, 05 Feb 2020 17:41:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:44851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izTLw-00023z-Kw for submit@debbugs.gnu.org; Wed, 05 Feb 2020 17:41:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55729) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izTLv-0006Vg-22 for bug-gnu-emacs@gnu.org; Wed, 05 Feb 2020 17:41:00 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05, RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izTLt-00018h-EQ for bug-gnu-emacs@gnu.org; Wed, 05 Feb 2020 17:40:58 -0500 Received: from black.elm.relay.mailchannels.net ([23.83.212.19]:7763) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1izTLs-00014J-Vv for bug-gnu-emacs@gnu.org; Wed, 05 Feb 2020 17:40:57 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 665401A1516 for ; Wed, 5 Feb 2020 22:40:54 +0000 (UTC) Received: from pdx1-sub0-mail-a97.g.dreamhost.com (100-96-206-172.trex.outbound.svc.cluster.local [100.96.206.172]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E9F061A150C for ; Wed, 5 Feb 2020 22:40:53 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a97.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 05 Feb 2020 22:40:54 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Stop-Plucky: 0828b5c461372651_1580942454192_2845449410 X-MC-Loop-Signature: 1580942454192:1124801324 X-MC-Ingress-Time: 1580942454192 Received: from pdx1-sub0-mail-a97.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a97.g.dreamhost.com (Postfix) with ESMTP id A0F737F0E0 for ; Wed, 5 Feb 2020 14:40:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type; s= linkov.net; bh=UZDjFueUyinRp1w2DyJSRh9iulA=; b=cA0sXU04rjTDsA7DV wynpc7vNbcBWiC4NM958xVb4qjDXkYGirlwh1hw/j686LDm/vNfQTABdHmuT9WeU EkOX6DOOo4mc036Be1Z5M8i4WuFdxI9GXs82D/KAN4DXEvbUnyp191NfPqJF+5Bn XefoLJVGy9mamt5bFRlSye6PDk= Received: from mail.jurta.org (m91-129-105-126.cust.tele2.ee [91.129.105.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a97.g.dreamhost.com (Postfix) with ESMTPSA id A3F047F108 for ; Wed, 5 Feb 2020 14:40:49 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a97 From: Juri Linkov Organization: LINKOV.NET Date: Wed, 05 Feb 2020 23:53:13 +0200 Message-ID: <87wo90emmm.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrhedvgddtudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofffkfgggtgesmhdtreertdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdehrdduvdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdehrdduvdeipdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepsghughdqghhnuhdqvghmrggtshesghhnuhdrohhrgh X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 23.83.212.19 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain Version: 28.0.50 Tags: patch The same way as quit-window deletes the frame when quitting the last window on the frame with e.g. C-x 5 d RET q this patch implements the same behavior for tabs: C-x t d RET q closes the tab. This is for master since it will take time to tweak. For example, it works fine everywhere except Gnus that doesn't call quit-window when exiting a summary buffer typing `q' (gnus-summary-exit) in a summary buffer that was automatically displayed in a new tab, so needed to customize Gnus by (add-hook 'gnus-summary-exit-hook 'quit-window) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=close-tab-quit-restore-window.patch diff --git a/lisp/window.el b/lisp/window.el index 40c4bf5ad4..bd825c09e1 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -5008,6 +5008,13 @@ quit-restore-window prev-buffer))) quad entry) (cond + ((and (not prev-buffer) + (eq (nth 1 quit-restore) 'tab) + (eq (nth 3 quit-restore) buffer)) + (tab-bar-close-tab) + ;; If the previously selected window is still alive, select it. + (when (window-live-p (nth 2 quit-restore)) + (select-window (nth 2 quit-restore)))) ((and (not prev-buffer) (or (eq (nth 1 quit-restore) 'frame) (and (eq (nth 1 quit-restore) 'window) @@ -6367,7 +6374,12 @@ display-buffer-record-window ;; WINDOW has been created on a new frame. (set-window-parameter window 'quit-restore - (list 'frame 'frame (selected-window) buffer))))) + (list 'frame 'frame (selected-window) buffer))) + ((eq type 'tab) + ;; WINDOW has been created on a new tab. + (set-window-parameter + window 'quit-restore + (list 'tab 'tab (selected-window) buffer))))) (defcustom display-buffer-function nil "If non-nil, function to call to handle `display-buffer'. @@ -7034,7 +7046,7 @@ window--display-buffer ;; use that. (display-buffer-mark-dedicated (set-window-dedicated-p window display-buffer-mark-dedicated)))) - (when (memq type '(window frame)) + (when (memq type '(window frame tab)) (set-window-prev-buffers window nil)) (let ((quit-restore (window-parameter window 'quit-restore)) (height (cdr (assq 'window-height alist))) diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index ebb0c566ad..d761000993 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -1480,26 +1479,55 @@ display-buffer-in-tab (tab-bar-select-tab (1+ index))) (when (get-buffer-window buffer frame) (select-window (get-buffer-window buffer frame)))) + (let ((tab-name (alist-get 'tab-name alist))) + (when (functionp tab-name) + (setq tab-name (funcall tab-name buffer alist))) + (if tab-name + (let ((tab-index (tab-bar--tab-index-by-name tab-name))) + (if tab-index + (progn + (tab-bar-select-tab (1+ tab-index)) + (when (get-buffer-window buffer) + (select-window (get-buffer-window buffer)))) + (display-buffer-in-new-tab buffer alist))) + (display-buffer-in-new-tab buffer alist)))))) + +(defun display-buffer-in-new-tab (buffer alist) + "Display BUFFER in a new tab. +ALIST is an association list of action symbols and values. See +Info node `(elisp) Buffer Display Action Alists' for details of +such alists. + +Like `display-buffer-in-tab', but always creates a new tab unconditionally, +without checking if a suitable tab already exists. + +If ALIST contains a `tab-name' entry, it creates a new tab with that name +and displays BUFFER in a new tab. The `tab-name' entry can be a function, +then it is called with two arguments: BUFFER and ALIST, and should return +the tab name. When a `tab-name' entry is omitted, create a new tab without +an explicit name. + +This is an action function for buffer display, see Info +node `(elisp) Buffer Display Action Functions'. It should be +called only by `display-buffer' or a function directly or +indirectly called by the latter." + (let ((tab-bar-new-tab-choice t)) + (tab-bar-new-tab) + (let ((tab-name (alist-get 'tab-name alist))) (when (functionp tab-name) (setq tab-name (funcall tab-name buffer alist))) - (if tab-name - (let ((tab-index (tab-bar--tab-index-by-name tab-name))) - (if tab-index - (tab-bar-select-tab (1+ tab-index)) - (let ((tab-bar-new-tab-choice t)) - (tab-bar-new-tab) - (tab-bar-rename-tab tab-name)))) - (let ((tab-bar-new-tab-choice t)) - (tab-bar-new-tab)))))) + (when tab-name + (tab-bar-rename-tab tab-name))) + (window--display-buffer buffer (selected-window) 'tab alist))) (defun switch-to-buffer-other-tab (buffer-or-name &optional norecord) "Switch to buffer BUFFER-OR-NAME in another tab. Like \\[switch-to-buffer-other-frame] (which see), but creates a new tab." (interactive (list (read-buffer-to-switch "Switch to buffer in other tab: "))) - (display-buffer buffer-or-name '((display-buffer-in-tab - display-buffer-same-window) - (inhibit-same-window . nil)) + (display-buffer buffer-or-name '((display-buffer-in-tab) + (inhibit-same-window . nil) + (reusable-frames . t)) norecord)) (defun find-file-other-tab (filename &optional wildcards) --=-=-=-- From unknown Wed Sep 10 10:35:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39446: 28.0.50; Use quit-restore-window to close tab Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Feb 2020 03:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: 39446@debbugs.gnu.org Received: via spool by 39446-submit@debbugs.gnu.org id=B39446.15809599702210 (code B ref 39446); Thu, 06 Feb 2020 03:33:01 +0000 Received: (at 39446) by debbugs.gnu.org; 6 Feb 2020 03:32:50 +0000 Received: from localhost ([127.0.0.1]:46983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izXuM-0000Za-9R for submit@debbugs.gnu.org; Wed, 05 Feb 2020 22:32:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izXuK-0000ZL-5y for 39446@debbugs.gnu.org; Wed, 05 Feb 2020 22:32:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1izXuE-0003S7-A4; Wed, 05 Feb 2020 22:32:42 -0500 Received: from [176.228.60.248] (port=4833 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1izXuD-0004ch-Lt; Wed, 05 Feb 2020 22:32:42 -0500 Date: Thu, 06 Feb 2020 05:32:38 +0200 Message-Id: <83sgjofl0p.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87wo90emmm.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 05 Feb 2020 23:53:13 +0200) References: <87wo90emmm.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Juri Linkov > Date: Wed, 05 Feb 2020 23:53:13 +0200 > > The same way as quit-window deletes the frame > when quitting the last window on the frame with e.g. > > C-x 5 d RET q This doesn't delete the frame here. Is the key sequence above correct? If so, can you show a detailed use case where such deletion-on-quit happens? Thanks. From unknown Wed Sep 10 10:35:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39446: 28.0.50; Use quit-restore-window to close tab Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Feb 2020 00:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 39446@debbugs.gnu.org Received: via spool by 39446-submit@debbugs.gnu.org id=B39446.158103617012286 (code B ref 39446); Fri, 07 Feb 2020 00:43:02 +0000 Received: (at 39446) by debbugs.gnu.org; 7 Feb 2020 00:42:50 +0000 Received: from localhost ([127.0.0.1]:48752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izrjN-0003C6-QO for submit@debbugs.gnu.org; Thu, 06 Feb 2020 19:42:50 -0500 Received: from dog.birch.relay.mailchannels.net ([23.83.209.48]:54276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izrjL-0003Bw-Eg for 39446@debbugs.gnu.org; Thu, 06 Feb 2020 19:42:48 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 2BD89120A27; Fri, 7 Feb 2020 00:42:46 +0000 (UTC) Received: from pdx1-sub0-mail-a28.g.dreamhost.com (100-96-0-7.trex.outbound.svc.cluster.local [100.96.0.7]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B8BB6120A59; Fri, 7 Feb 2020 00:42:45 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a28.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Fri, 07 Feb 2020 00:42:46 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Fearful-Belong: 472328863e966356_1581036165975_4117617444 X-MC-Loop-Signature: 1581036165975:2922505429 X-MC-Ingress-Time: 1581036165974 Received: from pdx1-sub0-mail-a28.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a28.g.dreamhost.com (Postfix) with ESMTP id B7D40817E1; Thu, 6 Feb 2020 16:42:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=Tb3uoSSNqIOTAMova2UIj8oZg8Q=; b= tNFBqNUVwft5buigBZ7aoBr2dBBeOxt4COnV/SjuSIlpr/FortAbM3WGlHU+tCRd JmAndbEFRc1SnrwJ8wYRbiTjOS9W5nV1mQdgAmaI78LIeoc+cqH83ScQ/VD8aIx4 jyEjPaEvtz2VjnedPEYeznWImFkXjfEZ9pULCHBIpoM= Received: from mail.jurta.org (m91-129-105-126.cust.tele2.ee [91.129.105.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a28.g.dreamhost.com (Postfix) with ESMTPSA id 2E584817C9; Thu, 6 Feb 2020 16:42:42 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a28 From: Juri Linkov Organization: LINKOV.NET References: <87wo90emmm.fsf@mail.linkov.net> <83sgjofl0p.fsf@gnu.org> Date: Fri, 07 Feb 2020 02:17:45 +0200 In-Reply-To: <83sgjofl0p.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 06 Feb 2020 05:32:38 +0200") Message-ID: <87blqb48oq.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrheeggddvhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddthedruddvieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedruddviedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> The same way as quit-window deletes the frame >> when quitting the last window on the frame with e.g. >> >> C-x 5 d RET q > > This doesn't delete the frame here. Is the key sequence above > correct? If so, can you show a detailed use case where such > deletion-on-quit happens? Indeed. I thought that it deletes the frame, but it only minimizes/buries/hides the frame. The frame is deleted only when quit-window is called with a prefix arg, e.g. C-x 5 d RET C-u q Since there is no such thing as tab minimizing, it should be fine to just close the tab. From unknown Wed Sep 10 10:35:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39446: 28.0.50; Use quit-restore-window to close tab Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Feb 2020 08:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: 39446@debbugs.gnu.org Received: via spool by 39446-submit@debbugs.gnu.org id=B39446.158106289028072 (code B ref 39446); Fri, 07 Feb 2020 08:09:01 +0000 Received: (at 39446) by debbugs.gnu.org; 7 Feb 2020 08:08:10 +0000 Received: from localhost ([127.0.0.1]:48837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izygM-0007Ii-CO for submit@debbugs.gnu.org; Fri, 07 Feb 2020 03:08:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58159) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izygK-0007IV-H8 for 39446@debbugs.gnu.org; Fri, 07 Feb 2020 03:08:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1izygF-0002kG-7S; Fri, 07 Feb 2020 03:08:03 -0500 Received: from [176.228.60.248] (port=1433 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1izygE-0003rd-OO; Fri, 07 Feb 2020 03:08:03 -0500 Date: Fri, 07 Feb 2020 10:07:42 +0200 Message-Id: <83eev6g6r5.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87blqb48oq.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 07 Feb 2020 02:17:45 +0200) References: <87wo90emmm.fsf@mail.linkov.net> <83sgjofl0p.fsf@gnu.org> <87blqb48oq.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Juri Linkov > Cc: 39446@debbugs.gnu.org > Date: Fri, 07 Feb 2020 02:17:45 +0200 > > The frame is deleted only when quit-window is called > with a prefix arg, e.g. > > C-x 5 d RET C-u q > > Since there is no such thing as tab minimizing, > it should be fine to just close the tab. But I think 'q' here is not the important part, because in most major modes it just inserts 'q'. You are saying that quit-window, when called with KILL argument non-nil, will close the tab if this is the last window in that tab's window-configuration, is that right? From unknown Wed Sep 10 10:35:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39446: 28.0.50; Use quit-restore-window to close tab Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Feb 2020 00:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 39446@debbugs.gnu.org Received: via spool by 39446-submit@debbugs.gnu.org id=B39446.158120904121792 (code B ref 39446); Sun, 09 Feb 2020 00:44:02 +0000 Received: (at 39446) by debbugs.gnu.org; 9 Feb 2020 00:44:01 +0000 Received: from localhost ([127.0.0.1]:51963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0ahd-0005fG-4S for submit@debbugs.gnu.org; Sat, 08 Feb 2020 19:44:01 -0500 Received: from aye.elm.relay.mailchannels.net ([23.83.212.6]:27998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0ahb-0005f8-Nu for 39446@debbugs.gnu.org; Sat, 08 Feb 2020 19:44:00 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 57CC63C0F69; Sun, 9 Feb 2020 00:43:58 +0000 (UTC) Received: from pdx1-sub0-mail-a62.g.dreamhost.com (100-96-217-5.trex.outbound.svc.cluster.local [100.96.217.5]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 9D6CB3C0D38; Sun, 9 Feb 2020 00:43:57 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a62.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sun, 09 Feb 2020 00:43:57 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Eight-Illegal: 27226a634fec1eb0_1581209037856_1389907546 X-MC-Loop-Signature: 1581209037856:3951037519 X-MC-Ingress-Time: 1581209037855 Received: from pdx1-sub0-mail-a62.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a62.g.dreamhost.com (Postfix) with ESMTP id 823DC803F2; Sat, 8 Feb 2020 16:43:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=hhOUXFG4DNhrx+Z1bg83y3ZVQS8=; b= qOaAaWVpKAEGqhrJUiJPiZSu7fR1LHwdoKIiku2+KoMBa39zEYIt/INCGjHKWWfH cHR7KNfAaSE0cxEDX20mDwh1E4UMOMeAG18MoVkyoPKtnc3iEfrUvAqW3wpBjiPT kNR26WAsXueWq3FdUEklGAdQZkUmEYu+wnTaVPha9wg= Received: from mail.jurta.org (m91-129-105-126.cust.tele2.ee [91.129.105.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a62.g.dreamhost.com (Postfix) with ESMTPSA id E24047FF8F; Sat, 8 Feb 2020 16:43:52 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a62 From: Juri Linkov Organization: LINKOV.NET References: <87wo90emmm.fsf@mail.linkov.net> <83sgjofl0p.fsf@gnu.org> <87blqb48oq.fsf@mail.linkov.net> <83eev6g6r5.fsf@gnu.org> Date: Sun, 09 Feb 2020 02:35:25 +0200 In-Reply-To: <83eev6g6r5.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 07 Feb 2020 10:07:42 +0200") Message-ID: <87zhdsh9xa.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrheekgddvudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddthedruddvieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedruddviedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> The frame is deleted only when quit-window is called >> with a prefix arg, e.g. >> >> C-x 5 d RET C-u q >> >> Since there is no such thing as tab minimizing, >> it should be fine to just close the tab. > > But I think 'q' here is not the important part, because in most major > modes it just inserts 'q'. You are saying that quit-window, when > called with KILL argument non-nil, will close the tab if this is the > last window in that tab's window-configuration, is that right? Right, this is what I meant. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 09 19:51:39 2020 Received: (at control) by debbugs.gnu.org; 10 Feb 2020 00:51:40 +0000 Received: from localhost ([127.0.0.1]:53495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0xIZ-0004S1-Md for submit@debbugs.gnu.org; Sun, 09 Feb 2020 19:51:39 -0500 Received: from eastern.birch.relay.mailchannels.net ([23.83.209.55]:30470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0xIY-0004Rs-4I for control@debbugs.gnu.org; Sun, 09 Feb 2020 19:51:38 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id F3D9F920AA3 for ; Mon, 10 Feb 2020 00:51:36 +0000 (UTC) Received: from pdx1-sub0-mail-a69.g.dreamhost.com (100-96-1-6.trex.outbound.svc.cluster.local [100.96.1.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B5FFC920A30 for ; Mon, 10 Feb 2020 00:51:36 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a69.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Mon, 10 Feb 2020 00:51:36 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Versed-Macabre: 71670cbe34c39735_1581295896773_3883679891 X-MC-Loop-Signature: 1581295896773:2149675242 X-MC-Ingress-Time: 1581295896773 Received: from pdx1-sub0-mail-a69.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a69.g.dreamhost.com (Postfix) with ESMTP id EB78E81B1F for ; Sun, 9 Feb 2020 16:51:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=oZ+84H75hzLQDdeRp/D8BDKJLdc=; b= vEb8VmpTqJ72omsWikH4v7vx51p2cNMd1NOgoJF8dba8x4coJfksv4K0VBVWQNg4 jH+w0QD1cgN9Jqb5Go5Id8qsHtzXKAnsxjsW8l5fou/x3cJIiO0P7pdG+jgiUk2z thKTcjIhy1HRPAdZnG2ZVAfDb0x8+0AlR9UuywzcQw0= Received: from mail.jurta.org (m91-129-105-126.cust.tele2.ee [91.129.105.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a69.g.dreamhost.com (Postfix) with ESMTPSA id CC92A808AD for ; Sun, 9 Feb 2020 16:51:31 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a69 From: Juri Linkov To: control@debbugs.gnu.org Subject: Re: bug#39446: 28.0.50; Use quit-restore-window to close tab Organization: LINKOV.NET References: <87wo90emmm.fsf@mail.linkov.net> <83sgjofl0p.fsf@gnu.org> <87blqb48oq.fsf@mail.linkov.net> <83eev6g6r5.fsf@gnu.org> <87zhdsh9xa.fsf@mail.linkov.net> Date: Mon, 10 Feb 2020 02:50:20 +0200 In-Reply-To: <87zhdsh9xa.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 09 Feb 2020 02:35:25 +0200") Message-ID: <87imkf5kqb.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrheelgdduieekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddthedruddvieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedruddviedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegtohhnthhrohhlseguvggssghughhsrdhgnhhurdhorhhg X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 39446 fixed close 39446 28.0.50 quit