From unknown Wed Sep 10 09:28:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#39445 <39445@debbugs.gnu.org> To: bug#39445 <39445@debbugs.gnu.org> Subject: Status: [PATCH] gnu: ripgrep: Install the manpage. Reply-To: bug#39445 <39445@debbugs.gnu.org> Date: Wed, 10 Sep 2025 16:28:48 +0000 retitle 39445 [PATCH] gnu: ripgrep: Install the manpage. reassign 39445 guix-patches submitter 39445 Jakub K=C4=85dzio=C5=82ka severity 39445 normal tag 39445 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 05 16:36:33 2020 Received: (at submit) by debbugs.gnu.org; 5 Feb 2020 21:36:33 +0000 Received: from localhost ([127.0.0.1]:46894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izSLZ-0000Zn-59 for submit@debbugs.gnu.org; Wed, 05 Feb 2020 16:36:33 -0500 Received: from lists.gnu.org ([209.51.188.17]:45742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izSLX-0000Zd-1X for submit@debbugs.gnu.org; Wed, 05 Feb 2020 16:36:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49004) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izSLR-0002EF-Jo for guix-patches@gnu.org; Wed, 05 Feb 2020 16:36:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izSLP-0005HC-Kf for guix-patches@gnu.org; Wed, 05 Feb 2020 16:36:25 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:42604) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1izSLP-0005B3-AV for guix-patches@gnu.org; Wed, 05 Feb 2020 16:36:23 -0500 Received: (qmail 20449 invoked by uid 1009); 5 Feb 2020 22:36:21 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25716. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.043023 secs); 05 Feb 2020 21:36:21 -0000 Received: from unknown (HELO localhost.localdomain) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with AES256-SHA encrypted SMTP; 5 Feb 2020 22:36:21 +0100 From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= To: guix-patches@gnu.org Subject: [PATCH] gnu: ripgrep: Install the manpage. Date: Wed, 5 Feb 2020 22:36:50 +0100 Message-Id: <20200205213650.12011-1-kuba@kadziolka.net> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 37.59.186.212 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/rust-apps.scm (ripgrep)[native-inputs]: Add ASCIIDOC to compile the manpage. (ripgrep)[arguments]: Add phase: 'install-manpage. Add #:modules argument to import (ice-9 match). --- gnu/packages/rust-apps.scm | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/gnu/packages/rust-apps.scm b/gnu/packages/rust-apps.scm index 90bd146442..b73efc08d9 100644 --- a/gnu/packages/rust-apps.scm +++ b/gnu/packages/rust-apps.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2019, 2020 John Soo ;;; Copyright © 2019, 2020 Efraim Flashner +;;; Copyright © 2020 Jakub Kądziołka ;;; ;;; This file is part of GNU Guix. ;;; @@ -24,6 +25,7 @@ #:use-module (guix packages) #:use-module (gnu packages compression) #:use-module (gnu packages crates-io) + #:use-module (gnu packages documentation) #:use-module (gnu packages pkg-config) #:use-module (gnu packages tls) #:use-module (gnu packages version-control)) @@ -58,7 +60,24 @@ (("rust-clap" ,rust-clap-2) ("rust-lazy-static" ,rust-lazy-static-1.3) ("rust-serde" ,rust-serde-1.0) - ("rust-serde-derive" ,rust-serde-derive-1.0)))) + ("rust-serde-derive" ,rust-serde-derive-1.0)) + #:modules ((ice-9 match) + (guix build cargo-build-system) + (guix build utils)) + #:phases + (modify-phases %standard-phases + (add-after 'build 'install-manpage + ;; NOTE: This is done before 'check so that there's only one output + ;; directory with the man page. + (lambda* (#:key outputs #:allow-other-keys) + (match (find-files "target" "^rg\\.1$") + ((manpage) + (install-file manpage (string-append + (assoc-ref outputs "out") + "/share/man/man1")))) + #t))))) + (native-inputs + `(("asciidoc" ,asciidoc))) (home-page "https://github.com/BurntSushi/ripgrep") (synopsis "Line-oriented search tool") (description -- 2.25.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 09 16:51:06 2020 Received: (at 39445) by debbugs.gnu.org; 9 Feb 2020 21:51:07 +0000 Received: from localhost ([127.0.0.1]:53334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0uTq-0008N1-Ms for submit@debbugs.gnu.org; Sun, 09 Feb 2020 16:51:06 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:51736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0uTn-0008Mb-Gk for 39445@debbugs.gnu.org; Sun, 09 Feb 2020 16:51:05 -0500 Received: (qmail 2817 invoked by uid 1009); 9 Feb 2020 22:51:00 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25718. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.019945 secs); 09 Feb 2020 21:51:00 -0000 Received: from unknown (HELO localhost.localdomain) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with AES256-SHA encrypted SMTP; 9 Feb 2020 22:51:00 +0100 From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= To: 39445@debbugs.gnu.org Subject: [PATCH v2 1/2] gnu: ripgrep: Install the manpage. Date: Sun, 9 Feb 2020 22:51:09 +0100 Message-Id: <20200209215110.6755-1-kuba@kadziolka.net> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Qmailux-2.08st: added fake Content-Type header Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39445 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/rust-apps.scm (ripgrep)[native-inputs]: Add ASCIIDOC to compile the manpage. (ripgrep)[arguments]: Add phase: 'install-manpage. Add #:modules argument to import (ice-9 match). --- This patch no longer applies after #39500, so I'm sending a new version to resolve the conflict. I have also added a second patch to the patchstack that enables the PCRE2 feature, as sending it separately would have some potential for generating merge conflicts. gnu/packages/rust-apps.scm | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/gnu/packages/rust-apps.scm b/gnu/packages/rust-apps.scm index d1d7d225a7..ddc9f6ed37 100644 --- a/gnu/packages/rust-apps.scm +++ b/gnu/packages/rust-apps.scm @@ -25,6 +25,7 @@ #:use-module (guix packages) #:use-module (gnu packages compression) #:use-module (gnu packages crates-io) + #:use-module (gnu packages documentation) #:use-module (gnu packages jemalloc) #:use-module (gnu packages pkg-config) #:use-module (gnu packages tls) @@ -226,7 +227,24 @@ provides defaults for 80% of the use cases.") ("rust-termcolor" ,rust-termcolor-1.0)) #:cargo-development-inputs (("rust-serde" ,rust-serde-1.0) - ("rust-serde-derive" ,rust-serde-derive-1.0)))) + ("rust-serde-derive" ,rust-serde-derive-1.0)) + #:modules ((ice-9 match) + (guix build cargo-build-system) + (guix build utils)) + #:phases + (modify-phases %standard-phases + (add-after 'build 'install-manpage + ;; NOTE: This is done before 'check so that there's only one output + ;; directory with the man page. + (lambda* (#:key outputs #:allow-other-keys) + (match (find-files "target" "^rg\\.1$") + ((manpage) + (install-file manpage (string-append + (assoc-ref outputs "out") + "/share/man/man1")))) + #t))))) + (native-inputs + `(("asciidoc" ,asciidoc))) (home-page "https://github.com/BurntSushi/ripgrep") (synopsis "Line-oriented search tool") (description -- 2.25.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 09 16:51:09 2020 Received: (at 39445) by debbugs.gnu.org; 9 Feb 2020 21:51:09 +0000 Received: from localhost ([127.0.0.1]:53336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0uTs-0008NG-Vc for submit@debbugs.gnu.org; Sun, 09 Feb 2020 16:51:09 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:51738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0uTn-0008Mf-Ga for 39445@debbugs.gnu.org; Sun, 09 Feb 2020 16:51:06 -0500 Received: (qmail 2826 invoked by uid 1009); 9 Feb 2020 22:51:01 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25718. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.019035 secs); 09 Feb 2020 21:51:01 -0000 Received: from unknown (HELO localhost.localdomain) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with AES256-SHA encrypted SMTP; 9 Feb 2020 22:51:00 +0100 From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= To: 39445@debbugs.gnu.org Subject: [PATCH v2 2/2] gnu: ripgrep: enable the 'pcre2' feature Date: Sun, 9 Feb 2020 22:51:10 +0100 Message-Id: <20200209215110.6755-2-kuba@kadziolka.net> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200209215110.6755-1-kuba@kadziolka.net> References: <20200209215110.6755-1-kuba@kadziolka.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Qmailux-2.08st: added fake Content-Type header Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39445 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/rust-apps.scm (ripgrep)[arguments]: Add #:cargo-build-flags to specify the feature. Replace the 'install phase to work around the cargo-build-system a bit. --- gnu/packages/rust-apps.scm | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/gnu/packages/rust-apps.scm b/gnu/packages/rust-apps.scm index ddc9f6ed37..26b5445d98 100644 --- a/gnu/packages/rust-apps.scm +++ b/gnu/packages/rust-apps.scm @@ -242,9 +242,21 @@ provides defaults for 80% of the use cases.") (install-file manpage (string-append (assoc-ref outputs "out") "/share/man/man1")))) - #t))))) + #t)) + (replace 'install + ;; Adapted from (guix build cargo-build-system). The flags need to + ;; be passed to `cargo install' too, as otherwise it will build + ;; another binary, without the features. + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (mkdir-p out) + (setenv "CARGO_TARGET_DIR" "./target") + (invoke "cargo" "install" "--path" "." "--root" out + "--features" "pcre2"))))) + #:cargo-build-flags '("--release" "--features" "pcre2"))) (native-inputs - `(("asciidoc" ,asciidoc))) + `(("asciidoc" ,asciidoc) + ,@(package-native-inputs rust-pcre2-sys-0.2))) (home-page "https://github.com/BurntSushi/ripgrep") (synopsis "Line-oriented search tool") (description -- 2.25.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 10 03:44:30 2020 Received: (at 39445) by debbugs.gnu.org; 10 Feb 2020 08:44:30 +0000 Received: from localhost ([127.0.0.1]:53646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j14gA-00016X-6j for submit@debbugs.gnu.org; Mon, 10 Feb 2020 03:44:30 -0500 Received: from flashner.co.il ([178.62.234.194]:56040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j14g8-00016L-Gx for 39445@debbugs.gnu.org; Mon, 10 Feb 2020 03:44:29 -0500 Received: from localhost (unknown [141.226.13.108]) by flashner.co.il (Postfix) with ESMTPSA id 96C904004F; Mon, 10 Feb 2020 08:44:22 +0000 (UTC) Date: Mon, 10 Feb 2020 10:43:51 +0200 From: Efraim Flashner To: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= Subject: Re: [bug#39445] [PATCH v2 2/2] gnu: ripgrep: enable the 'pcre2' feature Message-ID: <20200210084351.GA26092@E5400> References: <20200209215110.6755-1-kuba@kadziolka.net> <20200209215110.6755-2-kuba@kadziolka.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline In-Reply-To: <20200209215110.6755-2-kuba@kadziolka.net> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 39445 Cc: 39445@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Should the install phase also get the '--release' flag? On Sun, Feb 09, 2020 at 10:51:10PM +0100, Jakub K=C4=85dzio=C5=82ka wrote: > * gnu/packages/rust-apps.scm (ripgrep)[arguments]: Add > #:cargo-build-flags to specify the feature. Replace the 'install phase > to work around the cargo-build-system a bit. > --- > gnu/packages/rust-apps.scm | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) >=20 > diff --git a/gnu/packages/rust-apps.scm b/gnu/packages/rust-apps.scm > index ddc9f6ed37..26b5445d98 100644 > --- a/gnu/packages/rust-apps.scm > +++ b/gnu/packages/rust-apps.scm > @@ -242,9 +242,21 @@ provides defaults for 80% of the use cases.") > (install-file manpage (string-append > (assoc-ref outputs "out") > "/share/man/man1")))) > - #t))))) > + #t)) > + (replace 'install > + ;; Adapted from (guix build cargo-build-system). The flags ne= ed to > + ;; be passed to `cargo install' too, as otherwise it will bui= ld > + ;; another binary, without the features. > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (mkdir-p out) > + (setenv "CARGO_TARGET_DIR" "./target") > + (invoke "cargo" "install" "--path" "." "--root" out > + "--features" "pcre2"))))) > + #:cargo-build-flags '("--release" "--features" "pcre2"))) > (native-inputs > - `(("asciidoc" ,asciidoc))) > + `(("asciidoc" ,asciidoc) > + ,@(package-native-inputs rust-pcre2-sys-0.2))) > (home-page "https://github.com/BurntSushi/ripgrep") > (synopsis "Line-oriented search tool") > (description > --=20 > 2.25.0 >=20 >=20 >=20 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl5BF8QACgkQQarn3Mo9 g1F/RA/+KZSD3nZ8hrgyS2hX5DvG7AqqqTAyPmerYTToaDfcs1OdJGISa9rACacc quFSr3syoXh6SZxDWMlGJP/In/7XG1pA5xmFoVsS0f3Ua+sHYYEOi/GJTDZ3Nni/ XUi5+Fj4qE3Ca5jdUbY4ADE0BwEGw5hlzIiu+uYTr6Nxdt3CnWLqZsupBeGUUuXL xqz8lrmtXoV67kr05t/9CIEhIK0CW+bWlL2V1a4udEB6EWtt+3ochSlFFy6z5CAL bdbjcaRBn14jRgluBgQH6MF8jzR5wU7LGG8VIRKwnWPzUanIMhGUSSywmsyBotg8 zDSnE/WMvl1nwU+a3l5c96TKlXb3paJbLpG7rESoRF4AkQJy5eyDTJgu19urG+yr NFHxs9/jgfNrcai3iH4v0SSTDNz9macnmwPyAy717WPi72IVsDmbM8WVJmSbqgim qIl1T9j19JcKIIUJqlOr2yHnc5aUsDOuX2PU8W/8W6r+bSRRklkQPwXnI1QDnECN J4a2Y001fOj7Lu80CNRKGUb9dZIhykdJi029XXixaVjuWpDXhcwwJUXw/o8Ht/8i K+nbb2sqTyCzYVfRkvrR/hBGK7gCu5DWon5z292IkJ6YszFYpZxf5UMz2eI8e9Zo GP2xnIubZ1ESdu71g924DTcfl07xaxrXySOgMsugCzOnvHHDQL4= =JgnP -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 10 06:27:47 2020 Received: (at 39445) by debbugs.gnu.org; 10 Feb 2020 11:27:47 +0000 Received: from localhost ([127.0.0.1]:53749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j17EB-0000Xq-8Q for submit@debbugs.gnu.org; Mon, 10 Feb 2020 06:27:47 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:39356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j17E9-0000Xf-A6 for 39445@debbugs.gnu.org; Mon, 10 Feb 2020 06:27:45 -0500 Received: (qmail 11328 invoked by uid 1009); 10 Feb 2020 12:27:42 +0100 Received: from user-5-173-104-143.play-internet.pl (kuba@kadziolka.net@user-5-173-104-143.play-internet.pl) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25719. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(5.173.104.143):. Processed in 0.020997 secs); 10 Feb 2020 11:27:42 -0000 Received: from user-5-173-104-143.play-internet.pl (HELO gravity) (kuba@kadziolka.net@5.173.104.143) by pat.zlotemysli.pl with SMTP; 10 Feb 2020 12:27:42 +0100 Date: Mon, 10 Feb 2020 12:28:13 +0100 From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= To: Efraim Flashner Subject: Re: [bug#39445] [PATCH v2 2/2] gnu: ripgrep: enable the 'pcre2' feature Message-ID: <20200210112813.cgs4hbra2konsz5j@gravity> References: <20200209215110.6755-1-kuba@kadziolka.net> <20200209215110.6755-2-kuba@kadziolka.net> <20200210084351.GA26092@E5400> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tvqls5tcqdc6it26" Content-Disposition: inline In-Reply-To: <20200210084351.GA26092@E5400> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39445 Cc: 39445@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --tvqls5tcqdc6it26 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 10, 2020 at 10:43:51AM +0200, Efraim Flashner wrote: > Should the install phase also get the '--release' flag? It's a reasonable question to ask, but no. `cargo install' will always use a release build. Moreover, passing the --release flag to cargo install will lead to an unexpected argument error. Regards, Jakub K=C4=85dzio=C5=82ka --tvqls5tcqdc6it26 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl5BPkwACgkQ4xWnWEYT FWQRnRAA3y+DgIBuGAr5u+A0Wc8c8Ca7zZdDKFjKly1NH3sUD9VJiCddhQnajSLv Cx47k1AEGCoj5x/i3CU3qEhKKu3NAjv7Bk5L1VtQc97k32TIPcKcj828v3wm/2iQ wXhHHOWnKYqUZWfB2Liw2ITJkJGxLcmj8TPQ0Qcu8N1vyOiPDJybflSHURnGPvzy zcaZ0s876RwTxQur+rmsVExoNf03bit2sKNyinSq0HRo5HlXFYEn8P9UgGwDXMfG mzStaISyIy/RMNDu4hlw40Ifoan0ZUz8XEWJmHjukep9NCdw1S9CBuCXsrJqp0rJ jL3mdvlFxENtX0Yc+HD6ZPsOwHzMNwfB7aCpWkObdKYrEbujJObFbqI6Ykd2NMai tfLJeN4iS2468pYbPxAaquTauTzcueeWrDoSjpNEI/cdY8ERJ2bRWL8zXLQYzrKE 2db0ZdFNFeQsGM2y9B8lNVl8/IKm7aUZYRo6k/F1HAWdPcI2w9UbXefUwdRGeRl4 uTAeNYpBC3YQ8WwCO24ddfNa5WUzve91JYEY2UiyRdfYWQJQBfu98l6+1JdXW4uR /bL9gxKXpCrwWl3JhqSA1azQCqJrxWc/p55SnXTP0ec5fmd5G7DQQUCcgexuRG+D 5Ti37yuuqIJvPtvs20y4/ZaHBdMTgSRM9HeyZnnHwubDPmKSCUI= =Sm9T -----END PGP SIGNATURE----- --tvqls5tcqdc6it26-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 11 13:26:21 2020 Received: (at 39445-done) by debbugs.gnu.org; 11 Feb 2020 18:26:21 +0000 Received: from localhost ([127.0.0.1]:57522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1aEn-0000pd-D8 for submit@debbugs.gnu.org; Tue, 11 Feb 2020 13:26:21 -0500 Received: from flashner.co.il ([178.62.234.194]:47902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1aEl-0000p2-S0 for 39445-done@debbugs.gnu.org; Tue, 11 Feb 2020 13:26:20 -0500 Received: from localhost (unknown [141.226.13.108]) by flashner.co.il (Postfix) with ESMTPSA id C2E66402AA; Tue, 11 Feb 2020 18:26:13 +0000 (UTC) Date: Tue, 11 Feb 2020 20:25:42 +0200 From: Efraim Flashner To: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= Subject: Re: [bug#39445] [PATCH v2 2/2] gnu: ripgrep: enable the 'pcre2' feature Message-ID: <20200211182542.GD26092@E5400> References: <20200209215110.6755-1-kuba@kadziolka.net> <20200209215110.6755-2-kuba@kadziolka.net> <20200210084351.GA26092@E5400> <20200210112813.cgs4hbra2konsz5j@gravity> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IDYEmSnFhs3mNXr+" Content-Disposition: inline In-Reply-To: <20200210112813.cgs4hbra2konsz5j@gravity> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 39445-done Cc: 39445-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --IDYEmSnFhs3mNXr+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 10, 2020 at 12:28:13PM +0100, Jakub K=C4=85dzio=C5=82ka wrote: > On Mon, Feb 10, 2020 at 10:43:51AM +0200, Efraim Flashner wrote: > > Should the install phase also get the '--release' flag? >=20 > It's a reasonable question to ask, but no. `cargo install' will always > use a release build. Moreover, passing the --release flag to cargo > install will lead to an unexpected argument error. That's unfortunate. I was hoping to re-use the cargo-build-flags option. Might still be worth it, after adding logic to strip out the '--release' flag. Patches pushed. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --IDYEmSnFhs3mNXr+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl5C8aYACgkQQarn3Mo9 g1FSsw/9GDyLQF9j0KpE2NCw8Lv7eUjGgzdg033a4Z07zs0Fn1EbNOxCqAMzF+6q S0vkm99G8d6Fpbc/dycrKUPzB2PKoE0FVOYT+nORAGx0MlKX3FN9IdShGDwQaXyF Ne48SBzldgxvt9hvtFe5AbaZdml4TlNdQlsIuO9XPYafCfh3qcJveSHfXbbXn3N6 T6BM+klzLw9H9Kj7i/HIph0AUXgKkqeZHING6aDTr3BTVM1GvxCxSb2VVMGIZ/91 jpk1LFLehviKNK32WLT2XEn2sdI8zvUyf5ohc+dDNmxYi1RJy0FsuFx+XVlcRcnJ nP1AnJA1obbHH9gBQQo3GnU+Rukulj7yko1erPErXt3bi1pPcFuaJ/VpidceBCXO HEW00+lzQ3LeEXqf6Si252aZjKncTp8rFPWzd/x6luPYAA59d+xLbuZClocRcpBC 7zhK0zpSibogGw1dCZIT3mkwqODvlFRlVf5oyysd6FwaE3Im2359KfV3IxPRD6d1 b3Y4Xw7CP0d6NFV1EfQklpGCV0i79fyakJSp0WTfc9yP9F0BCRuPi+nkZN2SiHwv dDMh7ZMlJhX9qyqTUf3BbRh1XQxIUbXoh+WhiOLkKmkI3kGr8vKc23dZTrRmnasF G68DLbU7fLLmeOfuB3jheCxMNjfRC0yWlVy6kk6M635jia1zQSo= =L9c3 -----END PGP SIGNATURE----- --IDYEmSnFhs3mNXr+-- From unknown Wed Sep 10 09:28:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 11 Mar 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator