GNU bug report logs - #39436
27.0.60; Documentation error for package-menu-hide-package

Previous Next

Full log

Message #37 received at 39436 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Pieter van Oostrum <pieter-l <at> vanoostrum.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 39436 <at> debbugs.gnu.org
Subject: Re: bug#39436: 27.0.60; Documentaion error for
 package-menu-hide-package
Date: Sun, 09 Feb 2020 21:30:12 +0100

Pieter van Oostrum <pieter-l <at> vanoostrum.org> writes:

> And it changed revert-buffer to also load the package list, by setting
> 'revert-buffer-function' to the internal function 'package-menu--refresh'. But
> the menu entry "Redisplay buffer" was not removed, and it actually is wrong now,
> because it doesn't conditionally activate it on '(not
> package--downloads-in-progress)'.

Indeed.  Note that the condition here is probably a bit simplistic;
see Bug#39187.  I'm working on implementing the fix suggested there,
and will add a reminder to also change this menu entry.  IOW, we can
leave it as is in the context of this bug.

> So I think this is the one that should be removed (also because it
> does more than just redisplaying the buffer). I think that's the
> only change that is necessary.

Agreed.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.