From unknown Sun Sep 21 03:54:09 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#39428 <39428@debbugs.gnu.org> To: bug#39428 <39428@debbugs.gnu.org> Subject: Status: 28.0.50; cl--push-clause-loop-body: eval macro arg just once Reply-To: bug#39428 <39428@debbugs.gnu.org> Date: Sun, 21 Sep 2025 10:54:09 +0000 retitle 39428 28.0.50; cl--push-clause-loop-body: eval macro arg just once reassign 39428 emacs submitter 39428 Tino Calancha severity 39428 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 04 16:05:49 2020 Received: (at submit) by debbugs.gnu.org; 4 Feb 2020 21:05:49 +0000 Received: from localhost ([127.0.0.1]:44863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz5OG-00041i-Ss for submit@debbugs.gnu.org; Tue, 04 Feb 2020 16:05:49 -0500 Received: from lists.gnu.org ([209.51.188.17]:51794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz5OE-00041Z-U9 for submit@debbugs.gnu.org; Tue, 04 Feb 2020 16:05:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41183) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz5OD-0002Qv-RN for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 16:05:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, FREEMAIL_REPLY,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iz5OC-0002HX-H0 for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 16:05:45 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:33767) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iz5OC-0001yk-A1 for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 16:05:44 -0500 Received: by mail-wr1-x442.google.com with SMTP id u6so11638182wrt.0 for ; Tue, 04 Feb 2020 13:05:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=kVRkihzkYKU2yRFMKfZP+ExKIzBY+MYRS13MFZ9WrYU=; b=VYU2pMhE4iXHPBje4p7OgN+GRivfVTopbbchGvWdt47SMQogg0/mZqZi3dFYiGwxB6 d5bDiGo4OHQVD5tEoqQAWF4NSFuQHerszWmBBHD9xZtZN+GE/lrlG5LrmFfacJ5DO4HK PoiQGaQ8sNZu/TvZWoD2408exiUw8BqItO+we4WNqaYOVTH7oDpn4BLtB8Q/S0B0b8VX jLyv40R0QXJsLiKC+ILZdup0SekIuOEp5Zccxt9Gs7J1WohqAJcWc48xH5ea/Sl8exiF s+9oTf4hcJc0gysbDxJSG+oXwigilYqJM9D17kO6Gicg/ex9bDz1sWVL3OcvZkQf5Vie 14ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=kVRkihzkYKU2yRFMKfZP+ExKIzBY+MYRS13MFZ9WrYU=; b=lPqWXMiZOAdiFtyS71hlKGU0slskqrUcvJCr6T6kXctGKtvwiSlL0WfKBB0m+H0JdK Rj2a/yAgMkUh1i+zcDMP3a/P7Q73fV1kRMAboyRHesAc8D7jqubiOwS+YS+GOfx7jV/4 +TgN3N/xLgCjoYk1rnWapiRPddKhqZ2QFIgQnp+8CU3Ff4ma1TEM1hknwP1SqJrrZmzn 8TMOJbhn6l0Y4gJw7t9E9wGqzuunAFYjp5pBTWDbgCf2Jmsq1ip1pGvv0HvJCiTN8tpq M2Cu+cZf2juYf+0Uyb3oX2/p84gYRfQzuujvrkglfHCavDgKwSM+iWL4JOjCTnaPQtaX ECnA== X-Gm-Message-State: APjAAAV/P/itlgRbzF48OO05C2cFQDA5dX9nTXws+PgK2kQAD35+gvul N39BNSk3bMo3B0pykFKlfjujen9et/U= X-Google-Smtp-Source: APXvYqzVvltEUdkV7+3MaUA6CcLk162jScNrBvAJzDT1sz0CtzK3qLFDtBuSNWmqKcYrG1uYyUVYhQ== X-Received: by 2002:a5d:6646:: with SMTP id f6mr14486334wrw.276.1580850341208; Tue, 04 Feb 2020 13:05:41 -0800 (PST) Received: from calancha-pc.dy.bbexcite.jp ([31.7.242.222]) by smtp.gmail.com with ESMTPSA id g21sm5377560wmh.17.2020.02.04.13.05.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2020 13:05:40 -0800 (PST) From: Tino Calancha To: bug-gnu-emacs@gnu.org Subject: 28.0.50; cl--push-clause-loop-body: eval macro arg just once Date: Tue, 04 Feb 2020 22:05:30 +0100 Message-ID: <87mu9yhxlx.fsf@calancha-pc.dy.bbexcite.jp> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 X-Spam-Score: 3.3 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: X-Debbugs-Cc: Stefan Monnier , dick.r.chiang@gmail.com I think this little tweak has sense. WDYT? --88--- commit eb88afb89a8cfb760d89569e74c8ece1d1c446cb Author: Tino Calancha Date: Tue Feb 4 21:52:06 2020 +0100 Content analysis details: (3.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: bbexcite.jp] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 1.0 FREEMAIL_REPLY From and body contain different freemails 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) X-Debbugs-Cc: Stefan Monnier ,dick.r.chiang@gmail.com I think this little tweak has sense. WDYT? --8<-----------------------------cut here---------------start------------->8--- commit eb88afb89a8cfb760d89569e74c8ece1d1c446cb Author: Tino Calancha Date: Tue Feb 4 21:52:06 2020 +0100 Eval macro arg just once * lisp/emacs-lisp/cl-macs.el (cl--push-clause-loop-body): Use `macroexp-let2'. diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el index 9d0fd15bc3..4c2f58907d 100644 --- a/lisp/emacs-lisp/cl-macs.el +++ b/lisp/emacs-lisp/cl-macs.el @@ -1037,9 +1037,10 @@ cl-loop (defmacro cl--push-clause-loop-body (clause) "Apply CLAUSE to both `cl--loop-conditions' and `cl--loop-body'." - `(progn - (push ,clause cl--loop-conditions) - (push ,clause cl--loop-body))) + (macroexp-let2 nil sym clause + `(progn + (push ,sym cl--loop-conditions) + (push ,sym cl--loop-body)))) ;; Below is a complete spec for cl-loop, in several parts that correspond ;; to the syntax given in CLtL2. The specs do more than specify where --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 28.0.50 (build 21, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2020-02-04 built on calancha-pc.dy.bbexcite.jp Repository revision: e287da5a8154d83a97107b64915ccc17e3a086b8 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 04 16:15:34 2020 Received: (at 39428) by debbugs.gnu.org; 4 Feb 2020 21:15:34 +0000 Received: from localhost ([127.0.0.1]:44873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz5Xh-0004Fi-UN for submit@debbugs.gnu.org; Tue, 04 Feb 2020 16:15:34 -0500 Received: from mail-qk1-f173.google.com ([209.85.222.173]:37856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz5Xg-0004FV-Er for 39428@debbugs.gnu.org; Tue, 04 Feb 2020 16:15:33 -0500 Received: by mail-qk1-f173.google.com with SMTP id 21so19551719qky.4 for <39428@debbugs.gnu.org>; Tue, 04 Feb 2020 13:15:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iJwm+Cka8V58BMTdskoCMxDhe1HdedV7Nfn1nXozhww=; b=Gf3DUwxG1f1yRoYNu9ooW/fJpMkUDRnxAtoP1f9ya3kys5Ou4yMZuaBfPMRSzPpw17 rI9ZfSbJljhkciykR9SSFSf/gDEjnu1UOJmQraIGYX25ob4tkEOkCLzZfQraMEtZlMiz DpYKHjq0INm00ciJXpgQcn69mgTepKgSnis6IGi/cyuXC3oUdBvnqeQZViksKMJdkJwb FuMEC6P/vhytF4KjWXpv4QFl6i7hiMi9G5v8ARhZWa9c1OBEuFfjeu1egD6BvoGtOX8y 0f91p2c6Lu8F8D7edFYI9+05etHEuUfK3bVM1o93X6DT7oZ4Ex/Wmfg4BkCsjMKBH2II 5N5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=iJwm+Cka8V58BMTdskoCMxDhe1HdedV7Nfn1nXozhww=; b=ST7fEFgbyW9lc3TuuUqlLfyFeL92w3h36r2HOyZAeHTSFVuSpdvQU5TAf4UXTCaFic 29k3Wqm3ZgqkngMopA0lirLso0a2wAKZkCMLys0lhjIKPfc+YyZON2MyGEFsc+L4Ptch cR4kYEUltbe1P0Y/9QztbwCnWTloNzhiulCI/WHKHa4YZt+jIdyYMMXa/JMqFaZ+G5fX aSJlwx2xo/6OCP2jPgbPEe/3e7+w33LCgxJ++nbxTLbWp/YiCxltyFBPdbwLA1Igh5AV ur04RxTsGmPYNo46rIQJC/d8T5Zd6rpek664VrRl6dTMehZ6HqK5upFNlYuY5bfEmWZe GGHw== X-Gm-Message-State: APjAAAUby88SnHiMWGD7t1KGU6ZKh3x96MKA+qDGnLWdT93VSzlNRB8+ dr6g5yTO9bPvzNIEnmCzebA= X-Google-Smtp-Source: APXvYqz4qPbIvXgl5WLsQvxgYgessIkcfrJ8hEKE4zxZjzBGXpMfZttw5r4xUSCTlZ10DvioYcYIrA== X-Received: by 2002:a37:3c1:: with SMTP id 184mr30031844qkd.340.1580850926914; Tue, 04 Feb 2020 13:15:26 -0800 (PST) Received: from localhost (pool-100-33-98-8.nycmny.fios.verizon.net. [100.33.98.8]) by smtp.gmail.com with ESMTPSA id c45sm12939361qtd.43.2020.02.04.13.15.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Feb 2020 13:15:26 -0800 (PST) From: dick.r.chiang@gmail.com To: Tino Calancha Subject: Re: bug#39428: 28.0.50; cl--push-clause-loop-body: eval macro arg just once References: <87mu9yhxlx.fsf@calancha-pc.dy.bbexcite.jp> Date: Tue, 04 Feb 2020 16:15:25 -0500 In-Reply-To: <87mu9yhxlx.fsf@calancha-pc.dy.bbexcite.jp> (Tino Calancha's message of "Tue, 04 Feb 2020 22:05:30 +0100") Message-ID: <87k152836a.fsf@dick> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39428 Cc: 39428@debbugs.gnu.org, stefan monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) LGTM, thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 04 19:26:39 2020 Received: (at 39428) by debbugs.gnu.org; 5 Feb 2020 00:26:39 +0000 Received: from localhost ([127.0.0.1]:44953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz8Wd-0000Hl-Kr for submit@debbugs.gnu.org; Tue, 04 Feb 2020 19:26:39 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz8Wb-0000HZ-CL for 39428@debbugs.gnu.org; Tue, 04 Feb 2020 19:26:37 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C7B9380DC9; Tue, 4 Feb 2020 19:26:31 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D4AFF80D6C; Tue, 4 Feb 2020 19:26:29 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1580862389; bh=qcYjrzN9NV+4yjoGUF+3vMS62kFvUJnSyKpTglKFnlQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pfTfid/Nz/quTxqZ/Y5gtPQJJ778cP0zqzgBydsJ4OpasBrY3qiSy1ycpJQpkKHad /mjIzyB/4cnrc83Ib5tUsTsTtMDYyrMLABFaOiKjmb/9SOx0jb2mtQLiO+MFrFstqM afghiavHBmD05U1No+O6erqNpXfOnB/TyXW9OXkT72feSwNWH1SNGX9lIwJrKvw6wJ +ZMyT8V1rVkDdZ5u4Fc6Jb6quQ0rp9efD9FirZKBawebCJHSSxrAyXXyB4hOal2IGB RzYrFZsx1oTwxP9xpe8lTV2Z5HXSUcowtMaoZCU8/Swik3YkCoEhTgdHhd2Y0AiqiJ KAurSrLb2mJGg== Received: from pastel (unknown [216.154.34.88]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7F11512040F; Tue, 4 Feb 2020 19:26:29 -0500 (EST) From: Stefan Monnier To: Tino Calancha Subject: Re: bug#39428: 28.0.50; cl--push-clause-loop-body: eval macro arg just once Message-ID: References: <87mu9yhxlx.fsf@calancha-pc.dy.bbexcite.jp> Date: Tue, 04 Feb 2020 19:26:28 -0500 In-Reply-To: <87mu9yhxlx.fsf@calancha-pc.dy.bbexcite.jp> (Tino Calancha's message of "Tue, 04 Feb 2020 22:05:30 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39428 Cc: 39428@debbugs.gnu.org, dick.r.chiang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I think this little tweak has sense. WDYT? Yes, it looks good (tho I must say I don't really understand what cl--loop-conditions and cl--loop-body are for and even less why we'd want to push the same clause onto both lists). Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 05 13:03:54 2020 Received: (at 39428) by debbugs.gnu.org; 5 Feb 2020 18:03:54 +0000 Received: from localhost ([127.0.0.1]:46677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izP1m-0001wq-Bz for submit@debbugs.gnu.org; Wed, 05 Feb 2020 13:03:54 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:34832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izP1k-0001wd-J3 for 39428@debbugs.gnu.org; Wed, 05 Feb 2020 13:03:53 -0500 Received: by mail-wm1-f49.google.com with SMTP id b17so3961784wmb.0 for <39428@debbugs.gnu.org>; Wed, 05 Feb 2020 10:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=3+EwmMZBCihfABvD3vZDbuO5VsSK6iYBBwXKY2qW/QI=; b=Jr4PcZ9FfEX/A83TZnIlDXofRRatq2CmRMlLdtF744whu1IUd/9QR1fyezrAV0c6ll N8jTTmfpoyKZ1p4fmWjW7GgUQAjnKxQLF5w7Qxr6RFdOJLrHsNDRGLIdSRCvH1qXzuu/ PoxwdYVKhHcI0wKU3+kX5abiIdJmC1dyIUuWUC5kLetZIkNmyaoUVO9id7MLxQMyoSlp ICrG7gT2Qi+4dtuRcQYp0WrRega8CNsxMcVGlmnA9GwkyOs6+OIhFeHEX4uLHy2MCBbg LuYpxe4awWj7F9/wYqsJHRsu/b8cknupS1l5DGiEnf78HAd6+3NB2MdOiB3Ev/NL8OsM Y5ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=3+EwmMZBCihfABvD3vZDbuO5VsSK6iYBBwXKY2qW/QI=; b=doqQ8TUD5U+pTl75IRDOykV7L47y/ptlJhBhyNvTTKXNwOMTadPUyb/ar4PTqSfUeA gaYQqqOr+SpCxB/DMBj2XPS48XmPI6oj0SXAtWHVZgcU+SYcDbO0Ol1kZb9TFfAWT4O1 PbDmiE2T/X/xQKSxKn5iiHGrRBbbXX+QnhpzIIJgCGv5nhVJP3sHFNZleQijP6c5cJ62 yD9yXmZENXs8FpSsnrkaplJN+grHxXzRPDgBuod5FOPAwwRC0kUppF49cEGoHjRHdcVG 1y+qXsrlw7Atx3bJUX3LjsYRCx3swF17bB7wmPjqx58vh2ZmAoXgzbgeHKpwAnf7o+FG NmdA== X-Gm-Message-State: APjAAAU7zp7MC2M2LQldFMlMw5rFZmlpkqOVk1m4Zz0SgjYp3Ckm9oLF 33OWk5C6OBnz0P/on00xlow= X-Google-Smtp-Source: APXvYqwDUUoZazpoaGC8o+lCVZ6vFUmwFyOwS2LCvbotA5CY3nhGu+ydC/ZmfH902KWu7+EJB9RnBA== X-Received: by 2002:a1c:791a:: with SMTP id l26mr7103551wme.58.1580925826768; Wed, 05 Feb 2020 10:03:46 -0800 (PST) Received: from calancha-pc.dy.bbexcite.jp ([31.7.242.222]) by smtp.gmail.com with ESMTPSA id d16sm791443wrg.27.2020.02.05.10.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2020 10:03:45 -0800 (PST) From: Tino Calancha To: Stefan Monnier Subject: Re: bug#39428: 28.0.50; cl--push-clause-loop-body: eval macro arg just once References: <87mu9yhxlx.fsf@calancha-pc.dy.bbexcite.jp> Date: Wed, 05 Feb 2020 19:03:40 +0100 In-Reply-To: (Stefan Monnier's message of "Tue, 04 Feb 2020 19:26:28 -0500") Message-ID: <87ftfovrlv.fsf@calancha-pc.dy.bbexcite.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39428 Cc: 39428@debbugs.gnu.org, dick.r.chiang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > I must say I don't really understand what > cl--loop-conditions and cl--loop-body are for and even less why we'd > want to push the same clause onto both lists Those things came from bug#29799. I have not followed the latest changes in that report; the purpose seems to cover some edge cases. It has no impact on our test suite; furthermore, they have added new tests for those edge cases matching what clisp does. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 05 13:08:52 2020 Received: (at 39428-done) by debbugs.gnu.org; 5 Feb 2020 18:08:52 +0000 Received: from localhost ([127.0.0.1]:46688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izP6a-00024x-CF for submit@debbugs.gnu.org; Wed, 05 Feb 2020 13:08:52 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]:39398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izP6Y-00024k-Pb for 39428-done@debbugs.gnu.org; Wed, 05 Feb 2020 13:08:51 -0500 Received: by mail-wr1-f47.google.com with SMTP id y11so3907674wrt.6 for <39428-done@debbugs.gnu.org>; Wed, 05 Feb 2020 10:08:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=DexMQwQunOHr2qOubcTXIzBnbiDi/GihwOz+4kE/zFo=; b=doSg4WhwP8ubD3ARrWKYSzb8tB2Z/Dr0XyIhQtKqZDPEsvJ2L/Laqbanous5Po9win KGRWfVSdjbFp4NI1aRGaO4EbZmH88fy9MZij+HtpUNf5D09lonomw3IzIVOlK/aOhzEd lPEeY61Cu39SY2zf8B9s5b22cb9OD/N6O/Dk6mv5A5uOg9qLxT+nROCY9ku89JHvKPJY 3c7kPB/aZ3MUWshpTcc/rMYdgJ7DByrmg4to1szdSWMp82nymYHMlaFTIaueqvjbORdm izNaOnre0/M69UvI4bgcyB4uWNesBPfS+HAnjU3CG0IfAMHgc9gUTgN/djY8Ywl5VDEo JPBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=DexMQwQunOHr2qOubcTXIzBnbiDi/GihwOz+4kE/zFo=; b=VfgT1YF4E7eeAxIB5dsYncVcmAd2zVz6BhHPVR2/P9JZvcvV8D9eBMVkHNiLd5U+G8 yq//wnBDTjqg8FlKLrJc36YsA1WqcT3bmof5D7B7HEbdyAbHmiKVGqEcchOnGhI465ed wz75pT72fztSigDdto2XEjSuHBlpVgz4VtYWdeuMVqhFOSWMZWkcdxFYh3qDkfPMSjiz XCsYSFWHgSuC2HdrKBpCb/5jtuBAFndqNcjxvkEE7tcW6rjN169BqR1dcyRnWTFQX0ng DErE6b89YTSXXsCqHjTKkjU+bIhxZdU9U55weM6OnPSQmaqE7WKURbFhTsayqm5ZJ60s g6Sg== X-Gm-Message-State: APjAAAWWdECjrmMQ3VrIJpTvkBK5hAzRjBY2bb7hzSRgsvllrqXKsD8x fUNROHtb0Ga/YRIusA3IjdJMJtljFMI= X-Google-Smtp-Source: APXvYqwUEvypRFcQozuXkFQPjomr99YqqGscJWhNGhuqJ2vWQI6hmu4eMir3YXnpPAIO+nquJBtubQ== X-Received: by 2002:a05:6000:1251:: with SMTP id j17mr31694645wrx.210.1580926124779; Wed, 05 Feb 2020 10:08:44 -0800 (PST) Received: from calancha-pc.dy.bbexcite.jp ([31.7.242.222]) by smtp.gmail.com with ESMTPSA id r3sm760520wrn.34.2020.02.05.10.08.43 for <39428-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2020 10:08:43 -0800 (PST) From: Tino Calancha To: 39428-done@debbugs.gnu.org, Subject: Re: bug#39428: 28.0.50; cl--push-clause-loop-body: eval macro arg just once References: <87mu9yhxlx.fsf@calancha-pc.dy.bbexcite.jp> <87k152836a.fsf@dick> Date: Wed, 05 Feb 2020 19:08:42 +0100 In-Reply-To: <87k152836a.fsf@dick> (dick r. chiang's message of "Tue, 04 Feb 2020 16:15:25 -0500") Message-ID: <87d0asvrdh.fsf@calancha-pc.dy.bbexcite.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39428-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) dick.r.chiang@gmail.com writes: > LGTM, thanks. Pushed at master branch as commit 'Eval macro arg just once' (ebff24c0b8fa54854fe8445f2eba1d99fb76ecf2) From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 05 13:25:30 2020 Received: (at 39428) by debbugs.gnu.org; 5 Feb 2020 18:25:30 +0000 Received: from localhost ([127.0.0.1]:46703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izPMg-0002UG-77 for submit@debbugs.gnu.org; Wed, 05 Feb 2020 13:25:30 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]:45236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izPMe-0002U3-Pq for 39428@debbugs.gnu.org; Wed, 05 Feb 2020 13:25:29 -0500 Received: by mail-wr1-f47.google.com with SMTP id a6so3926916wrx.12 for <39428@debbugs.gnu.org>; Wed, 05 Feb 2020 10:25:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:date:mime-version; bh=BjC0QEIsDrScaAWIbF7XmjR/AarWhEsuJaWx5j12OuM=; b=B03Dhi+h+Xyb4Hia8ySfyEoBROY8wd1vZ5pikAS/y77nhZc5e1CPNtsnEBfFbxvHd2 dmvQRRvw0Yy+eCYRJ3Xl4UZJaTqPSlNnv1feNGTcBq6fRLL+BGWYx4r2hxgtjn7NzcUs MZLJ9lJzA8/TkUmJGXrA851B40q4r8pzDaOXgYJkKy9WGAv0rC8RX7V5zyWRQIwq4PWJ tDy57oNfjL4i3zPCMtq66aUToTpmU8kk9dJsa5xAf5KzcZWEBjHcfGJpXOP/J/OUpT8Y HKt7Uir+s3kEHXUFB2OWyq1zKOwHJg+oCXom5WmysQZ/gXHQ/lZxRXGB7OlrSYK9JSYB K5WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:date:mime-version; bh=BjC0QEIsDrScaAWIbF7XmjR/AarWhEsuJaWx5j12OuM=; b=to0ymHOY1fKBGGs6P5/NbQxOgvqy41Ywqhh32RgOB+MrN0YlXzSXgv3+Ajf6hOACU1 fxysjrKRKQyiiqVlNvEIkEtWi+9jS2foBAlCFug7pQT8EYLpx5uNpFOx5BzVnjNhI4ac hAwXXdtLL2xK1AtTStZHplxIOi3MoHhLAh5MYlt/eO1aDExBoG0crUFyl8iw+VgtzHtJ bYCvYgwyUosaGMfhRZ0q3F6AeiG6GQ511P1tCSQF6wwV5FYIlaXoRLT/G3QBdDgI6Nt0 2K13Vg2BMTZ8TAd1OH3iP1NAsKnWfbbdInDP/LfKxjnDon8Lsc+wPsp1WlrxdDQj00Ge BbQQ== X-Gm-Message-State: APjAAAUYBzrq6GcehdjD/RMV8jaC4H+rYD3MH3UtMCJtvvLU50bGP47c VE+a+WDxFTka8O33qrNvzLVY3dAxDIc= X-Google-Smtp-Source: APXvYqyDuHd+u4iUHvJuBk9Nf9OUyWrfCxMMJ3aa4FZpKdeDgCKM+vBgs9GznnHWQWUENj8sJm/RNQ== X-Received: by 2002:a5d:494b:: with SMTP id r11mr29269456wrs.184.1580927122597; Wed, 05 Feb 2020 10:25:22 -0800 (PST) Received: from calancha-pc.dy.bbexcite.jp ([31.7.242.222]) by smtp.gmail.com with ESMTPSA id f127sm514591wma.4.2020.02.05.10.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2020 10:25:21 -0800 (PST) Message-Id: <8736bonb77.fsf@calancha-pc.dy.bbexcite.jp> From: Tino Calancha To: eliz@gnu.org Subject: Re: bug#39428: 28.0.50; cl--push-clause-loop-body: eval macro arg just once Date: Wed, 05 Feb 2020 19:08:42 +0100 (5 minutes, 25 seconds ago) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39428 Cc: 39428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tino Calancha writes: > LGTM, thanks. >Pushed at master branch as commit 'Eval macro arg just once' >(ebff24c0b8fa54854fe8445f2eba1d99fb76ecf2) Eli, I have noticed that, even if I opened this report for emacs master, the code is also at emacs-27. Do we need to cherry pick this fix to emacs-27 now? Or should we wait after the release? IMO, it's not urgent, I mean, I have not a case where it's breaking something; it's simply more correct, because you are protected from unwanted side-effects. Message-ID: <874kw4nb7m.fsf@calancha-pc.dy.bbexcite.jp> From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 05 13:36:00 2020 Received: (at 39428) by debbugs.gnu.org; 5 Feb 2020 18:36:00 +0000 Received: from localhost ([127.0.0.1]:46708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izPWq-0002jM-83 for submit@debbugs.gnu.org; Wed, 05 Feb 2020 13:36:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izPWo-0002j9-2a for 39428@debbugs.gnu.org; Wed, 05 Feb 2020 13:35:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1izPWi-0003dw-Tq; Wed, 05 Feb 2020 13:35:52 -0500 Received: from [176.228.60.248] (port=4166 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1izPWi-0003QI-8M; Wed, 05 Feb 2020 13:35:52 -0500 Date: Wed, 05 Feb 2020 20:35:47 +0200 Message-Id: <83v9okg9vg.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <8736bonb77.fsf@calancha-pc.dy.bbexcite.jp> (message from Tino Calancha on Wed, 05 Feb 2020 19:08:42 +0100 (5 minutes, 25 seconds ago)) Subject: Re: bug#39428: 28.0.50; cl--push-clause-loop-body: eval macro arg just once References: <8736bonb77.fsf@calancha-pc.dy.bbexcite.jp> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39428 Cc: 39428@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Tino Calancha > Cc: 39428@debbugs.gnu.org > Date: Wed, 05 Feb 2020 19:08:42 +0100 (5 minutes, 25 seconds ago) > > >Pushed at master branch as commit 'Eval macro arg just once' > >(ebff24c0b8fa54854fe8445f2eba1d99fb76ecf2) > Eli, I have noticed that, even if I opened this report for emacs master, > the code is also at emacs-27. > Do we need to cherry pick this fix to emacs-27 now? I don't see a need, this doesn't seem to be serious enough to have in Emacs 27. > IMO, it's not urgent, I mean, I have not a case where it's > breaking something; it's simply more correct, because you are > protected from unwanted side-effects. Then it's definitely for master. Thanks. From unknown Sun Sep 21 03:54:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 05 Mar 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator