From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 04 04:44:30 2020 Received: (at submit) by debbugs.gnu.org; 4 Feb 2020 09:44:31 +0000 Received: from localhost ([127.0.0.1]:42605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyukw-0008Up-NV for submit@debbugs.gnu.org; Tue, 04 Feb 2020 04:44:30 -0500 Received: from lists.gnu.org ([209.51.188.17]:50070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyuks-0008Ug-Q1 for submit@debbugs.gnu.org; Tue, 04 Feb 2020 04:44:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50786) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyukr-00022P-DM for guix-patches@gnu.org; Tue, 04 Feb 2020 04:44:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iyukn-0003F1-PK for guix-patches@gnu.org; Tue, 04 Feb 2020 04:44:25 -0500 Received: from mout02.posteo.de ([185.67.36.66]:49231) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iyukn-0002vx-9Y for guix-patches@gnu.org; Tue, 04 Feb 2020 04:44:21 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id AA382240102 for ; Tue, 4 Feb 2020 10:44:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1580809458; bh=b0pkX40RXu1LSzU08WT5GFThF5wrF29OEs+wbuAa9s8=; h=From:To:Cc:Subject:Date:From; b=BkyF25B7QohB1pHg51O+xry3eMCw/MVz4Sx+vwXH0SyDn52VPVp5q35HavNDXbnGI r9/rOJhnKsl/8aH9fzrj2anGWj0SvLv/+ujKET85wGHL4eXXtJVlcI9AXWdPIkIuo2 CAoOjBL4Xi17Ll/gQ4bf/qdyu5JeKX80gSrfDLqv45FOPiH+NvV60nxH4ucDn0AASZ VfQuOEjiRb5xIJ6HbQhKYpBeSxT3a8YEnNebiJNNLpEEQY3Ynl1xx6bjtDzKRsS2l2 94Pkcny3aDouSfPcZfUfJP2otjjJ8RUU0kmzXk2JiD/eqV46CPQRKcjc3bkymzTAiF 0AKsCGu1wBnaA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 48Bfss5YTpz9rxg; Tue, 4 Feb 2020 10:44:17 +0100 (CET) From: Diego Nicola Barbato To: guix-patches@gnu.org Subject: [PATCH 0/2] gnu: emacs-telega: Build with emacs-wide-int on 32-bit systems. Date: Tue, 4 Feb 2020 10:43:51 +0100 Message-Id: <20200204094351.18671-1-dnbarbato@posteo.de> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.67.36.66 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit Cc: Diego Nicola Barbato X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Guix, Telega requires wide Emacs integers (62-bit), so it checks whether `most-positive-fixnum' is equal to 2305843009213693951. Due to a performance penalty [0] wide Emacs integers have to be explicitly enabled on 32-bit architectures. Because of this `emacs-telega' currently fails to build on armhf-linux and i686-linux. The following two patches fix this by first adding a variant of `emacs' with wide ints enabled and then using this `emacs-wide-int' instead of `emacs' to build `emacs-telega' on 32-bit systems. I am not completely happy with this solution, because wide ints are not required to build Telega but to run it: A user installing `emacs-telega' alongside "vanilla" `emacs' on a 32-bit machine will be greeted with cryptic parse errors when trying to run Telega. Would it be enough to mention that `emacs-telega' has to be installed alongside `emacs-wide-int' on 32-bit systems in the description? I have chosen this approach over building the regular Emacs package with the "--with-wide-ints" flag because I do not think the performance penalty is justified. What do others think? In the long run it should be possible to drop this workaround once Emacs 27, which introduces bignums, is released. With those Telega should work on 32-bit Emacs without wide ints. Regards, Diego [0]: Emacs' configure.ac file talks about a 10% to 30% slowdown of the Lisp interpreter and a larger memory footprint. Diego Nicola Barbato (2): gnu: Add emacs-wide-int. gnu: emacs-telega: Build with emacs-wide-int on 32-bit systems. gnu/packages/emacs-xyz.scm | 7 ++++++- gnu/packages/emacs.scm | 11 +++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) --=20 2.25.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 04 04:49:52 2020 Received: (at 39412) by debbugs.gnu.org; 4 Feb 2020 09:49:52 +0000 Received: from localhost ([127.0.0.1]:42610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyuq8-0000Bu-Bt for submit@debbugs.gnu.org; Tue, 04 Feb 2020 04:49:52 -0500 Received: from mout01.posteo.de ([185.67.36.65]:34733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyuq6-0000Bi-Ng for 39412@debbugs.gnu.org; Tue, 04 Feb 2020 04:49:51 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 9969B160062 for <39412@debbugs.gnu.org>; Tue, 4 Feb 2020 10:49:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1580809784; bh=RASmFRjIsgbPNjsG8tZGHAO9tc+5VMiW7nMMG52bXfQ=; h=From:To:Cc:Subject:Date:From; b=T8F3pBwQEGBTRqeNvUcOFfDQLaabOG8bw8drO0XfnrhMto0isgl9HDHXol+kr65wa SMkuTQ3IceFhr5vXHNqGZtAx1noEqjD2UdqligXxcsYV4uwScvn4OK2AgSFev+gtYb 4JFD0jNQ5a4v1qznAj/DL4yP4CrCSuCV3fcj5qra7o6ot+T/5Y38Ng25dgrId8lDWK X9P2d22fyACScB2Ii3p5eQSdsbhM/gXey4Ce+Jbxsx1Y/znvfHOu8qlBGq7/HD4Pv7 CXs2PwRL7KJv6MbflN0AA28OtotBz92D1DoGIpbIGTOsCdwedwzv+VdAoW1DIpCA11 J5juQwp0WiivA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 48Bg080ql7z6tm7; Tue, 4 Feb 2020 10:49:44 +0100 (CET) From: Diego Nicola Barbato To: 39412@debbugs.gnu.org Subject: [PATCH 1/2] gnu: Add emacs-wide-int. Date: Tue, 4 Feb 2020 10:49:35 +0100 Message-Id: <20200204094935.18850-1-dnbarbato@posteo.de> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200204094351.18671-1-dnbarbato@posteo.de> References: <20200204094351.18671-1-dnbarbato@posteo.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39412 Cc: Diego Nicola Barbato X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/emacs.scm (emacs-wide-int): New variable. --- gnu/packages/emacs.scm | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index b26c928e87..53123a6c82 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -380,6 +380,17 @@ editor (without an X toolkit)" ) ((#:configure-flags cf) `(cons "--with-x-toolkit=no" ,cf))))))) +(define-public emacs-wide-int + (package + (inherit emacs) + (name "emacs-wide-int") + (synopsis "The extensible, customizable, self-documenting text +editor (with wide ints)" ) + (arguments + (substitute-keyword-arguments (package-arguments emacs) + ((#:configure-flags flags) + `(cons "--with-wide-int" ,flags)))))) + (define-public guile-emacs (let ((commit "41120e0f595b16387eebfbf731fff70481de1b4b") (revision "0")) -- 2.25.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 04 04:50:11 2020 Received: (at 39412) by debbugs.gnu.org; 4 Feb 2020 09:50:12 +0000 Received: from localhost ([127.0.0.1]:42614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyuqR-0000D1-Jb for submit@debbugs.gnu.org; Tue, 04 Feb 2020 04:50:11 -0500 Received: from mout02.posteo.de ([185.67.36.66]:52645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyuqP-0000Ch-V8 for 39412@debbugs.gnu.org; Tue, 04 Feb 2020 04:50:10 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id C7AF7240100 for <39412@debbugs.gnu.org>; Tue, 4 Feb 2020 10:50:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1580809803; bh=C3oWgbbd5Fhfe0zPy944qWRlun3Irmauol011AALD3c=; h=From:To:Cc:Subject:Date:From; b=LMSlNyZIbWH3czh36VsnMSoEjqUmY0R9grP9fmnSlEx9KUC2cr+u8s7Ky0DfKkQ+l tttRRJ48X77PSBjsn8SFwtgU1f9uRjhd+l9pWWaeWIiEm5QGSlUPqbqnvU18Rd02uT Sa4sWL1BTbirwt2jKFtG8OoebN+jP9s9mFxAWZH52ndvGikXff2oIAs02N8Jo0rkEW gUOSSw0+P6pnlH19lgXgQg/W+w0wkfwLQ6gRhfm3L4k+6FmQ3gqeE0f2ut/2uyWYLu qCcfD9oL5LSOKuwlWFo7mlIFqwLdDg7C/VR3+tQY6BGfwP2uklA8HiQzPPETJTROCu 07E74MzRW/0AQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 48Bg0W2Bs2z9rxQ; Tue, 4 Feb 2020 10:50:03 +0100 (CET) From: Diego Nicola Barbato To: 39412@debbugs.gnu.org Subject: [PATCH 2/2] gnu: emacs-telega: Build with emacs-wide-int on 32-bit systems. Date: Tue, 4 Feb 2020 10:49:55 +0100 Message-Id: <20200204094955.18897-1-dnbarbato@posteo.de> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200204094351.18671-1-dnbarbato@posteo.de> References: <20200204094351.18671-1-dnbarbato@posteo.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39412 Cc: Diego Nicola Barbato X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Fixes . Reported by . * gnu/packages/emacs-xyz.scm (emacs-telega)[native-inputs]: Replace emacs with emacs-wide-int on 32-bit systems. This is needed because Telega requires 62-bit wide ints. --- gnu/packages/emacs-xyz.scm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 9936127a18..f4c58e94b2 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -20613,7 +20613,12 @@ fish-completion. It can be used in both Eshell and M-x shell.") (native-inputs `(("tdlib" ,tdlib) ("libtgvoip" ,libtgvoip) ; VoIP support. - ("emacs" ,emacs) + ;; Use Emacs with wide ints on 32-bit architectures. + ("emacs" ,(match (%current-system) + ((or "i686-linux" "armhf-linux") + emacs-wide-int) + (_ + emacs))) ("python" ,python))) (synopsis "GNU Emacs client for the Telegram messenger") (description -- 2.25.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 04 06:15:07 2020 Received: (at 39412) by debbugs.gnu.org; 4 Feb 2020 11:15:07 +0000 Received: from localhost ([127.0.0.1]:42670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iywAc-0002Az-VJ for submit@debbugs.gnu.org; Tue, 04 Feb 2020 06:15:07 -0500 Received: from flashner.co.il ([178.62.234.194]:35270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iywAY-0002AA-CX for 39412@debbugs.gnu.org; Tue, 04 Feb 2020 06:15:05 -0500 Received: from localhost (unknown [141.226.13.108]) by flashner.co.il (Postfix) with ESMTPSA id 85E05401AB; Tue, 4 Feb 2020 11:14:55 +0000 (UTC) Date: Tue, 4 Feb 2020 13:14:24 +0200 From: Efraim Flashner To: Diego Nicola Barbato Subject: Re: [bug#39412] [PATCH 0/2] gnu: emacs-telega: Build with emacs-wide-int on 32-bit systems. Message-ID: <20200204111424.GE19864@E5400> References: <20200204094351.18671-1-dnbarbato@posteo.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k3qmt+ucFURmlhDS" Content-Disposition: inline In-Reply-To: <20200204094351.18671-1-dnbarbato@posteo.de> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 39412 Cc: 39412@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --k3qmt+ucFURmlhDS Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I'll start by saying I'm not a user of emacs or of emacs-telega. On Tue, Feb 04, 2020 at 10:43:51AM +0100, Diego Nicola Barbato wrote: > Hi Guix, >=20 > Telega requires wide Emacs integers (62-bit), so it checks whether > `most-positive-fixnum' is equal to 2305843009213693951. Due to a > performance penalty [0] wide Emacs integers have to be explicitly > enabled on 32-bit architectures. Because of this `emacs-telega' > currently fails to build on armhf-linux and i686-linux. I assume it actually needs '--with-wide-ints' and that patching out the check wouldn't actually fix the problem. > The following two patches fix this by first adding a variant of > `emacs' with wide ints enabled and then using this `emacs-wide-int' > instead of `emacs' to build `emacs-telega' on 32-bit systems. >=20 > I am not completely happy with this solution, because wide ints are > not required to build Telega but to run it: A user installing > `emacs-telega' alongside "vanilla" `emacs' on a 32-bit machine will be > greeted with cryptic parse errors when trying to run Telega. Would it > be enough to mention that `emacs-telega' has to be installed alongside > `emacs-wide-int' on 32-bit systems in the description? I don't like this plan so much. It means relying on the users to read the description which is something I normally only do when I don't know what package I'm looking for. > I have chosen this approach over building the regular Emacs package > with the "--with-wide-ints" flag because I do not think the > performance penalty is justified. What do others think? 10-30% performance penalty across the board in emacs is pretty severe for one package. Otherwise that would've been my suggestion. > In the long run it should be possible to drop this workaround once > Emacs 27, which introduces bignums, is released. With those Telega > should work on 32-bit Emacs without wide ints. Do we know how long it may be before Emacs 27 is out? If it's not that long I wonder if it'd be better for it to be unbuildable on 32-bit systems than to make it installable but unusable without changing other installed packages. >=20 > Regards, >=20 > Diego >=20 > [0]: Emacs' configure.ac file talks about a 10% to 30% slowdown of the > Lisp interpreter and a larger memory footprint. Thank you for looking into this! --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --k3qmt+ucFURmlhDS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl45UhAACgkQQarn3Mo9 g1Hc3Q//VDYuVBcauWFGhE3j1IfyU3aD1F7YnCvHP8oX/y4Fw7HpRG+FWAotQB9i bhnXNTyWxe1sG42373TJOEes57EjBggyZtAZvg/utGZxPGvj45MsqSHxFg6jn8N4 +vAwp0yolX3tdpFDJKX8ZQI138sKtKCHka4J8sKWmKlGOP3UZ5POhKwcl05uWYq6 E7DDWHN5vwfqJUDusUsRsRFmHio9Gj6dtRPyIEDKzzK0rYHOhYJf344+/9CEbynp tFZd5Owmf/6mVEayqYUqX4+wKyP4rJesST4sbLqrb3SLOiWL/K9Y/Cu+MGTj+GUO gYqRtG0c+HT5OsZ8XM6mTGpUdQ0pMge3W7zjp7eywC5VfnMPK5+IR2vnUbJOvOt/ e18GxObK2TUXsrnvWw41NcI6uOiAqwZ0HiZHBaVaZM2el66X3BlPeOMgK/fuUy4H EgVS7Bh2vOe9Pc8R/CkLMTjCNklIffeHDed/issf3qd7ZS75bJjBM/9LnprnIrsr pthz5jo2ipvoXRYqXIrpFBM5sgWouznfG5ChS08/PRYV5QqoIJC6Fmdywz3yKU1h 94zKIebkzYUQXtwqo2VYq7cafDRr+kvuVuIXBJ7Of6WcusY2YGE1CndR5cWXt77n 4mJZ85MeSRcnCo2FnQd0Qq8xzbs74mqShass0bmXiq4rdn4IVk8= =6q3B -----END PGP SIGNATURE----- --k3qmt+ucFURmlhDS-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 26 09:16:04 2020 Received: (at 39412) by debbugs.gnu.org; 26 Mar 2020 13:16:04 +0000 Received: from localhost ([127.0.0.1]:58228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHSMc-0003Ap-B6 for submit@debbugs.gnu.org; Thu, 26 Mar 2020 09:16:04 -0400 Received: from mout02.posteo.de ([185.67.36.66]:48431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHSMX-0003AD-11 for 39412@debbugs.gnu.org; Thu, 26 Mar 2020 09:16:00 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 9E4682400FF for <39412@debbugs.gnu.org>; Thu, 26 Mar 2020 14:15:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1585228550; bh=4BYDYugY/VHd2BEOSH/xGwWd+GaP9FikPwzeCqFUlwI=; h=From:To:Cc:Subject:Date:From; b=EXt2X84N/rm2L7SfbBfwWoxS9f8aVxovvUS6ueXolyQ2lNp68FZ1iO6oObEVjyIio n28mPiOEW4dnBEe+xMJjAjIk9RgDpMPSYkyHfKqTFBsD1GbRFnFHiet7q3/OgnNRqg vimte1Hu0x0aFhACZMIFEceG6Z1SLK6ShgvB7meoBy3MjXCvbQ+trQokWjsnBW//13 ilJ6MHglPJ6RAGXCcXdj+ead63GL/q9uGsc3FABk7i2oFT47a7Tvx1isLStmVVCQtF Sn/u70XrpeO/VOn8AnQWG3uJbeSBWVtqLDngyNI4ybrsHiyelnBm3vHSTpkFOiFB1H fGbaVv1Af8l1Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 48p58P1PMqz9rxG; Thu, 26 Mar 2020 14:15:49 +0100 (CET) From: Diego Nicola Barbato To: Efraim Flashner Subject: Re: [bug#39412] [PATCH 0/2] gnu: emacs-telega: Build with emacs-wide-int on 32-bit systems. References: <20200204094351.18671-1-dnbarbato@posteo.de> <20200204111424.GE19864@E5400> Date: Thu, 26 Mar 2020 14:15:48 +0100 In-Reply-To: <20200204111424.GE19864@E5400> (Efraim Flashner's message of "Tue, 4 Feb 2020 13:14:24 +0200") Message-ID: <87eetfcl4r.fsf@GlaDOS.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39412 Cc: 39412@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Efraim, Sorry for the long delay. Efraim Flashner writes: > I'll start by saying I'm not a user of emacs or of emacs-telega. > > On Tue, Feb 04, 2020 at 10:43:51AM +0100, Diego Nicola Barbato wrote: >> Hi Guix, >> >> Telega requires wide Emacs integers (62-bit), so it checks whether >> `most-positive-fixnum' is equal to 2305843009213693951. Due to a >> performance penalty [0] wide Emacs integers have to be explicitly >> enabled on 32-bit architectures. Because of this `emacs-telega' >> currently fails to build on armhf-linux and i686-linux. > > I assume it actually needs '--with-wide-ints' and that patching out the > check wouldn't actually fix the problem. Yes, that would lead to the same cryptic errors (i.e. assertion failures) I mentioned below when running it (although it would build successfully) on 32-bit systems. >> The following two patches fix this by first adding a variant of >> `emacs' with wide ints enabled and then using this `emacs-wide-int' >> instead of `emacs' to build `emacs-telega' on 32-bit systems. >> >> I am not completely happy with this solution, because wide ints are >> not required to build Telega but to run it: A user installing >> `emacs-telega' alongside "vanilla" `emacs' on a 32-bit machine will be >> greeted with cryptic parse errors when trying to run Telega. Would it >> be enough to mention that `emacs-telega' has to be installed alongside >> `emacs-wide-int' on 32-bit systems in the description? > > I don't like this plan so much. It means relying on the users to read > the description which is something I normally only do when I don't know > what package I'm looking for. > >> I have chosen this approach over building the regular Emacs package >> with the "--with-wide-ints" flag because I do not think the >> performance penalty is justified. What do others think? > > 10-30% performance penalty across the board in emacs is pretty severe for > one package. Otherwise that would've been my suggestion. > >> In the long run it should be possible to drop this workaround once >> Emacs 27, which introduces bignums, is released. With those Telega >> should work on 32-bit Emacs without wide ints. > > Do we know how long it may be before Emacs 27 is out? If it's not that The release cycle for Emacs 27 was started in late December [1] and a pretest has been released [2], but I don't know how long it's going to be until 27.1. > long I wonder if it'd be better for it to be unbuildable on 32-bit > systems than to make it installable but unusable without changing other > installed packages. IMO it's ok for it to require changing other installed packages during a transitional period (e.g. guix repl currently doesn't work with `guile-readline' and requires that the guile3.0 variant be installed instead due to the transition in progress from Guile 2 to Guile 3). I do believe that the failure mode of Telega running with `emacs' instead of `emacs-wide-int' on a 32-bit system is problematic because it doesn't make it clear what's wrong and how to fix it. I have tried to address this in v2 of my patch series by patching Telega to run `telega-test-env' (the failing test) on startup (i.e. `M-x telega'). That way it fails immediately with the following error message: Emacs with wide ints (--with-wide-int) is required This should hopefully lead users on the right track. If v2 is still considered inadequate I'm fine with dropping the patches and waiting for Emacs 27 instead (the failing test would still have to be tweaked to make it aware of bignums). > Thank you for looking into this! Thanks for your feedback! Diego >> [0]: Emacs' configure.ac file talks about a 10% to 30% slowdown of the >> Lisp interpreter and a larger memory footprint. [1]: https://lists.gnu.org/archive/html/emacs-devel/2019-12/msg00635.html [2]: https://lists.gnu.org/archive/html/emacs-devel/2020-03/msg00045.html From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 26 09:17:48 2020 Received: (at 39412) by debbugs.gnu.org; 26 Mar 2020 13:17:48 +0000 Received: from localhost ([127.0.0.1]:58232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHSOK-0003Ds-AG for submit@debbugs.gnu.org; Thu, 26 Mar 2020 09:17:48 -0400 Received: from mout02.posteo.de ([185.67.36.66]:59447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHSOJ-0003Dg-Dr for 39412@debbugs.gnu.org; Thu, 26 Mar 2020 09:17:47 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 8A85C240106 for <39412@debbugs.gnu.org>; Thu, 26 Mar 2020 14:17:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1585228661; bh=BscrwrP8huAh6QsQ9McPjRSOS2rHYdsu49l5+mj6ZFU=; h=From:To:Cc:Subject:Date:From; b=kqObCFumRLeWRW+s+jGqIa4M/Cfbzr+pJz7UxvSDjPCCVhJmX7TuL5qZ+3tK2EeeC 5ejkO4Jk3DJAu10Go2IV09eGwlqJJghbvtk6uItOYpjNCAcHyXk0qM2DNN/p2PwibP HrAHRMsSdgpJM3/oCSJnzSuUrzs0bENkW8NbxG7Xp4XvO/KsQddkDuiCyKlrHC24Z7 MGHFdSoWVl6EfSwzuL7OV6X04F3H8snqlMvJsLDveinoG9YwwU0oEhTgfvV5B4kcqK ymz9RGCsWvtzcEyqPVgzZc+D4yBnaVi6qQl0tUhoJ/F4vz38j0qi1NtM0t/iA5/k4w 1NM+EovZc/ZBg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 48p5BY0bqbz9rxX; Thu, 26 Mar 2020 14:17:41 +0100 (CET) From: Diego Nicola Barbato To: 39412@debbugs.gnu.org Subject: [PATCH v2 1/3] gnu: Add emacs-wide-int. Date: Thu, 26 Mar 2020 14:17:20 +0100 Message-Id: <20200326131720.26591-1-dnbarbato@posteo.de> X-Mailer: git-send-email 2.26.0 In-Reply-To: <87eetfcl4r.fsf@GlaDOS.home> References: <87eetfcl4r.fsf@GlaDOS.home> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39412 Cc: Diego Nicola Barbato X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/emacs.scm (emacs-wide-int): New variable. --- gnu/packages/emacs.scm | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index de19998a41..b52849c578 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -398,6 +398,17 @@ editor (without an X toolkit)" ) ((#:configure-flags cf) `(cons "--with-x-toolkit=no" ,cf))))))) +(define-public emacs-wide-int + (package + (inherit emacs) + (name "emacs-wide-int") + (synopsis "The extensible, customizable, self-documenting text +editor (with wide ints)" ) + (arguments + (substitute-keyword-arguments (package-arguments emacs) + ((#:configure-flags flags) + `(cons "--with-wide-int" ,flags)))))) + (define-public guile-emacs (let ((commit "41120e0f595b16387eebfbf731fff70481de1b4b") (revision "0")) -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 26 09:18:11 2020 Received: (at 39412) by debbugs.gnu.org; 26 Mar 2020 13:18:11 +0000 Received: from localhost ([127.0.0.1]:58236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHSOh-0003F0-IV for submit@debbugs.gnu.org; Thu, 26 Mar 2020 09:18:11 -0400 Received: from mout01.posteo.de ([185.67.36.65]:40439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHSOg-0003El-AH for 39412@debbugs.gnu.org; Thu, 26 Mar 2020 09:18:10 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 335BF160068 for <39412@debbugs.gnu.org>; Thu, 26 Mar 2020 14:18:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1585228684; bh=VZ8lj8yF+q7VvLS0O/M8bgyYNyU1hvVWZL2X6wGzhJA=; h=From:To:Cc:Subject:Date:From; b=HUmCEImAzhTtZLoGp46gk5laXrE1Tg0ii1VB/2dmJNJ/1ErcSlJE2xnzFF68Z/1kg WwHmBoJdMv+WzIlSnqyWZcl/Du59sJy1swJcgjecA7nGeOg1QdeOIPMF8vmDopXzz1 BhwcraJXNynCnChwEOR/Rk5KRZZUGu9Mp2Gej8QRfmAvn8t/uR32ExEev5vBlCySsU QrVUpBvaoNF62+kdOYUaFmmx2zLpAY1GVN22Ga+ieaV06CYnpo3pSP7RBSmQkAtO+6 NNk4xVeOMlqDwIf+BFZlE+z36AuXuuxgKyKJuwPJiLzITizZnSnR6Yu9O9/CSHahzN Mu95cUlGSUpcw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 48p5Bz2csjz6tmR; Thu, 26 Mar 2020 14:18:03 +0100 (CET) From: Diego Nicola Barbato To: 39412@debbugs.gnu.org Subject: [PATCH v2 2/3] gnu: emacs-telega: Build with emacs-wide-int on 32-bit systems. Date: Thu, 26 Mar 2020 14:17:52 +0100 Message-Id: <20200326131752.26638-1-dnbarbato@posteo.de> X-Mailer: git-send-email 2.26.0 In-Reply-To: <87eetfcl4r.fsf@GlaDOS.home> References: <87eetfcl4r.fsf@GlaDOS.home> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39412 Cc: Diego Nicola Barbato X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Fixes . Reported by . * gnu/packages/emacs-xyz.scm (emacs-telega)[native-inputs]: Replace emacs with emacs-wide-int on 32-bit systems. This is needed because Telega requires 62-bit wide ints. --- gnu/packages/emacs-xyz.scm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 7b67cc37ae..401dbdec2c 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -20671,7 +20671,12 @@ fish-completion. It can be used in both Eshell and M-x shell.") (native-inputs `(("tdlib" ,tdlib) ("libtgvoip" ,libtgvoip) ; VoIP support. - ("emacs" ,emacs) + ;; Use Emacs with wide ints on 32-bit architectures. + ("emacs" ,(match (%current-system) + ((or "i686-linux" "armhf-linux") + emacs-wide-int) + (_ + emacs))) ("python" ,python))) (synopsis "GNU Emacs client for the Telegram messenger") (description -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 26 09:18:35 2020 Received: (at 39412) by debbugs.gnu.org; 26 Mar 2020 13:18:35 +0000 Received: from localhost ([127.0.0.1]:58239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHSP4-0003Fi-Qz for submit@debbugs.gnu.org; Thu, 26 Mar 2020 09:18:35 -0400 Received: from mout01.posteo.de ([185.67.36.65]:60045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHSOz-0003FR-Tg for 39412@debbugs.gnu.org; Thu, 26 Mar 2020 09:18:33 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 575E8160061 for <39412@debbugs.gnu.org>; Thu, 26 Mar 2020 14:18:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1585228704; bh=3cumqt6rtvZA6PiRIjahZ/6Exu6ekzRHpe7pLIz5Zkw=; h=From:To:Cc:Subject:Date:From; b=ILvuj6vxBuITDiB4LH99Cn6nQGSC2xpPTIv1iE96fT3JYgatrRTh5djNJ4X2e7HeL R8odVbSwkcCjCGMKDBKtFkkKVlb0WWr3crymXLq62R2O1zYjsuS4EFdGac0wa0IfPi ox0l1Ce/hn71DYeaApu//sfTwT/zOrEY3dOY3MFV61ply9aB6oHTkwei0hZw2PY8Ez 78ekfkEFVYtzIClwyTS/HRcLt/DeYjrZ+vQH/9iiE5puh9hhKZGkt4xqndK5elRwDz Mpy4OVCEUfXOCtohzYSkYhY2riXMue7AfC4b9sqfLIAZxUbdJlPGLnrppoBDuGjz+Y xSzvlbgwV+Fbw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 48p5CM4fNMz6tmR; Thu, 26 Mar 2020 14:18:22 +0100 (CET) From: Diego Nicola Barbato To: 39412@debbugs.gnu.org Subject: [PATCH v2 3/3] gnu: emacs-telega: Test Emacs environment on startup. Date: Thu, 26 Mar 2020 14:18:16 +0100 Message-Id: <20200326131816.26686-1-dnbarbato@posteo.de> X-Mailer: git-send-email 2.26.0 In-Reply-To: <87eetfcl4r.fsf@GlaDOS.home> References: <87eetfcl4r.fsf@GlaDOS.home> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39412 Cc: Diego Nicola Barbato X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Print a more helpful error message when someone attempts to run Telega on an incompatible Emacs (e.g a 32-bit Emacs without wide ints). * gnu/packages/patches/telega-test-env.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/emacs-xyz.scm (emacs-telega): Use it. --- gnu/local.mk | 1 + gnu/packages/emacs-xyz.scm | 2 ++ gnu/packages/patches/telega-test-env.patch | 14 ++++++++++++++ 3 files changed, 17 insertions(+) create mode 100644 gnu/packages/patches/telega-test-env.patch diff --git a/gnu/local.mk b/gnu/local.mk index 7cce60b7c0..eb6998cb65 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1448,6 +1448,7 @@ dist_patch_DATA = \ %D%/packages/patches/tcsh-fix-autotest.patch \ %D%/packages/patches/tcsh-fix-out-of-bounds-read.patch \ %D%/packages/patches/teensy-loader-cli-help.patch \ + %D%/packages/patches/telega-test-env.patch \ %D%/packages/patches/texinfo-5-perl-compat.patch \ %D%/packages/patches/texlive-bin-CVE-2018-17407.patch \ %D%/packages/patches/texlive-bin-luatex-poppler-compat.patch \ diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 401dbdec2c..23a988625d 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -20580,6 +20580,8 @@ fish-completion. It can be used in both Eshell and M-x shell.") (sha256 (base32 "0mv6i80958d9crzspzik5xh5g8326115bvg2frgv0dp9p6rm86m3")) + (patches + (search-patches "telega-test-env.patch")) (file-name (git-file-name name version)))) (build-system gnu-build-system) (arguments diff --git a/gnu/packages/patches/telega-test-env.patch b/gnu/packages/patches/telega-test-env.patch new file mode 100644 index 0000000000..7b2600d13b --- /dev/null +++ b/gnu/packages/patches/telega-test-env.patch @@ -0,0 +1,14 @@ +Test Emacs environment on startup. + +Patch by Diego N. Barbato + +--- a/telega.el 2020-02-07 17:07:18.549970090 +0100 ++++ b/telega.el 2020-02-07 17:10:08.383499765 +0100 +@@ -82,6 +82,7 @@ + "Start telegramming. + If prefix ARG is given, then will not pop to telega root buffer." + (interactive "P") ++ (telega-test-env) + (telega--create-hier) + + (unless (telega-server-live-p) -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 28 10:04:40 2020 Received: (at 39412) by debbugs.gnu.org; 28 Apr 2020 14:04:40 +0000 Received: from localhost ([127.0.0.1]:40976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTQqm-0001xQ-8M for submit@debbugs.gnu.org; Tue, 28 Apr 2020 10:04:40 -0400 Received: from mout02.posteo.de ([185.67.36.66]:42393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTQqh-0001x7-0u for 39412@debbugs.gnu.org; Tue, 28 Apr 2020 10:04:39 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 83395240102 for <39412@debbugs.gnu.org>; Tue, 28 Apr 2020 16:04:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1588082668; bh=ZPZQaaQ9dGHlaBznLbB7jZrZS3DyYOCohGbAlIrbJOg=; h=From:To:Cc:Subject:Date:From; b=c+UtaxKPGiqmcyjJ/M6QMvNJ8yv60BbIyTAiQ4MCwEo8vG3jcyc0+D+XNE1etMv4J 1T5lcHVfRUFhHSQzDt/UzYExhe1XbjpP+0o5WaLvQuFLUMCHalcrzmLvgh+/R/tELz LQoLgeFcv3NC5ODo5INXBN20C7tbYT7MKZ9AncS3WYziTLz1Ni+djXZk1b4lrG/eIH maAyQrtq25iVJdd0iI51U24digQmuGFvt7cVCzdhd99FHgZ9tOjwipgsrFIU2lZiEO uYOWJnuLO4wkVYvJJWqdJe8ByttUP+XQgtgQWLDogpaRLitCJFRl8A+XL+f+vylCRY 5Hl0FemkVlhxw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49BNgH42q1z6tmW; Tue, 28 Apr 2020 16:04:27 +0200 (CEST) From: Diego Nicola Barbato To: Efraim Flashner Subject: Re: [bug#39412] [PATCH 0/2] gnu: emacs-telega: Build with emacs-wide-int on 32-bit systems. References: <20200204094351.18671-1-dnbarbato@posteo.de> <20200204111424.GE19864@E5400> <87eetfcl4r.fsf@GlaDOS.home> Date: Tue, 28 Apr 2020 16:04:27 +0200 In-Reply-To: <87eetfcl4r.fsf@GlaDOS.home> (Diego Nicola Barbato's message of "Thu, 26 Mar 2020 14:15:48 +0100") Message-ID: <87pnbrhfkk.fsf@GlaDOS.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39412 Cc: 39412@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hi, Diego Nicola Barbato writes: [...] >> long I wonder if it'd be better for it to be unbuildable on 32-bit >> systems than to make it installable but unusable without changing other >> installed packages. > > IMO it's ok for it to require changing other installed packages during a > transitional period (e.g. guix repl currently doesn't work with > `guile-readline' and requires that the guile3.0 variant be installed > instead due to the transition in progress from Guile 2 to Guile 3). I > do believe that the failure mode of Telega running with `emacs' instead > of `emacs-wide-int' on a 32-bit system is problematic because it doesn't > make it clear what's wrong and how to fix it. I have tried to address > this in v2 of my patch series by patching Telega to run > `telega-test-env' (the failing test) on startup (i.e. `M-x telega'). > That way it fails immediately with the following error message: > > Emacs with wide ints (--with-wide-int) is required > > This should hopefully lead users on the right track. I've rebased the patches on master and modified the last one such that `telega-test-env' doesn't display a message when it succeeds. [...] Regards, Diego --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=v3-0001-gnu-Add-emacs-wide-int.patch >From 0197316358bc496f1d6868f3e41be7121ed8fa5f Mon Sep 17 00:00:00 2001 From: Diego Nicola Barbato Date: Sun, 29 Dec 2019 00:41:48 +0100 Subject: [PATCH v3 1/3] gnu: Add emacs-wide-int. * gnu/packages/emacs.scm (emacs-wide-int): New variable. --- gnu/packages/emacs.scm | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 3d0368be4e..ab7cc20d10 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -401,6 +401,17 @@ editor (without an X toolkit)" ) ((#:configure-flags cf) `(cons "--with-x-toolkit=no" ,cf))))))) +(define-public emacs-wide-int + (package + (inherit emacs) + (name "emacs-wide-int") + (synopsis "The extensible, customizable, self-documenting text +editor (with wide ints)" ) + (arguments + (substitute-keyword-arguments (package-arguments emacs) + ((#:configure-flags flags) + `(cons "--with-wide-int" ,flags)))))) + (define-public guile-emacs (let ((commit "41120e0f595b16387eebfbf731fff70481de1b4b") (revision "0")) -- 2.26.0 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=v3-0002-gnu-emacs-telega-Build-with-emacs-wide-int-on-32-.patch >From 1b86cf0846233b19b4905537d566f9ea40f76dbd Mon Sep 17 00:00:00 2001 From: Diego Nicola Barbato Date: Sun, 29 Dec 2019 01:03:38 +0100 Subject: [PATCH v3 2/3] gnu: emacs-telega: Build with emacs-wide-int on 32-bit systems. Fixes . Reported by . * gnu/packages/emacs-xyz.scm (emacs-telega)[native-inputs]: Replace emacs with emacs-wide-int on 32-bit systems. This is needed because Telega requires 62-bit wide ints. --- gnu/packages/emacs-xyz.scm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 0ae3f72fb7..e5bd414d75 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -21419,7 +21419,12 @@ fish-completion. It can be used in both Eshell and M-x shell.") (native-inputs `(("tdlib" ,tdlib) ("libtgvoip" ,libtgvoip) ; VoIP support. - ("emacs" ,emacs) + ;; Use Emacs with wide ints on 32-bit architectures. + ("emacs" ,(match (%current-system) + ((or "i686-linux" "armhf-linux") + emacs-wide-int) + (_ + emacs))) ("python" ,python))) (synopsis "GNU Emacs client for the Telegram messenger") (description -- 2.26.0 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=v3-0003-gnu-emacs-telega-Test-Emacs-environment-on-startu.patch >From 6f6a35fd07559aa484a59c4b6267e01db41921a3 Mon Sep 17 00:00:00 2001 From: Diego Nicola Barbato Date: Fri, 7 Feb 2020 17:59:31 +0100 Subject: [PATCH v3 3/3] gnu: emacs-telega: Test Emacs environment on startup. Print a more helpful error message when someone attempts to run Telega on an incompatible Emacs (e.g a 32-bit Emacs without wide ints). * gnu/packages/patches/telega-test-env.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/emacs-xyz.scm (emacs-telega): Use it. --- gnu/local.mk | 1 + gnu/packages/emacs-xyz.scm | 2 ++ gnu/packages/patches/telega-test-env.patch | 14 ++++++++++++++ 3 files changed, 17 insertions(+) create mode 100644 gnu/packages/patches/telega-test-env.patch diff --git a/gnu/local.mk b/gnu/local.mk index 9f212434a9..5787c675dd 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1470,6 +1470,7 @@ dist_patch_DATA = \ %D%/packages/patches/tcsh-fix-autotest.patch \ %D%/packages/patches/tcsh-fix-out-of-bounds-read.patch \ %D%/packages/patches/teensy-loader-cli-help.patch \ + %D%/packages/patches/telega-test-env.patch \ %D%/packages/patches/texinfo-5-perl-compat.patch \ %D%/packages/patches/texlive-bin-CVE-2018-17407.patch \ %D%/packages/patches/texlive-bin-luatex-poppler-compat.patch \ diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index e5bd414d75..01758bbbc5 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -21328,6 +21328,8 @@ fish-completion. It can be used in both Eshell and M-x shell.") (sha256 (base32 "0mv6i80958d9crzspzik5xh5g8326115bvg2frgv0dp9p6rm86m3")) + (patches + (search-patches "telega-test-env.patch")) (file-name (git-file-name name version)))) (build-system gnu-build-system) (arguments diff --git a/gnu/packages/patches/telega-test-env.patch b/gnu/packages/patches/telega-test-env.patch new file mode 100644 index 0000000000..75fe2e12fc --- /dev/null +++ b/gnu/packages/patches/telega-test-env.patch @@ -0,0 +1,14 @@ +Test Emacs environment on startup. + +Patch by Diego N. Barbato + +--- a/telega.el 2020-02-07 17:07:18.549970090 +0100 ++++ b/telega.el 2020-02-07 17:10:08.383499765 +0100 +@@ -82,6 +82,7 @@ + "Start telegramming. + If prefix ARG is given, then will not pop to telega root buffer." + (interactive "P") ++ (telega-test-env t) + (telega--create-hier) + + (unless (telega-server-live-p) -- 2.26.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 28 13:47:13 2020 Received: (at 39412-done) by debbugs.gnu.org; 28 Apr 2020 17:47:13 +0000 Received: from localhost ([127.0.0.1]:41384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTUJu-0000pl-D0 for submit@debbugs.gnu.org; Tue, 28 Apr 2020 13:47:13 -0400 Received: from flashner.co.il ([178.62.234.194]:52744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTUJr-0000jO-S2 for 39412-done@debbugs.gnu.org; Tue, 28 Apr 2020 13:46:57 -0400 Received: from localhost (unknown [31.210.177.209]) by flashner.co.il (Postfix) with ESMTPSA id AE85B40063; Tue, 28 Apr 2020 17:46:49 +0000 (UTC) Date: Tue, 28 Apr 2020 20:46:17 +0300 From: Efraim Flashner To: Diego Nicola Barbato Subject: Re: [bug#39412] [PATCH 0/2] gnu: emacs-telega: Build with emacs-wide-int on 32-bit systems. Message-ID: <20200428174617.GV5243@E5400> References: <20200204094351.18671-1-dnbarbato@posteo.de> <20200204111424.GE19864@E5400> <87eetfcl4r.fsf@GlaDOS.home> <87pnbrhfkk.fsf@GlaDOS.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ahZICQ7iXVM/oLYH" Content-Disposition: inline In-Reply-To: <87pnbrhfkk.fsf@GlaDOS.home> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 39412-done Cc: 39412-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --ahZICQ7iXVM/oLYH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Looks good. patch pushed! --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --ahZICQ7iXVM/oLYH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl6oa+gACgkQQarn3Mo9 g1Hv5BAAlm57/8cKSuE1LSpQ0u3HA/5nSxnZ7MDNxUi/Yk7xOFAsA9cjORWkY6F1 OXyRL66bmcKcNCvACWB/dxmgkZdh53cjTqo+SM1+vmg0WiEGjRzjMhQxjNC6G5IN 3wXUv9o4XlrXtzHpxyAXLRbguItNd6C3UJLftPpgHxZ/VlTayQqGviomoVim/IDH OKGMhA9WY8IjR34WD0DZhV5x9aGinMuZ5Pnl/RGm/K5VqSPMvxusIXPrq5N1hMKv epoXmnQXJnEh6505exSpXYhg5ZSni8v2Pqt3rIlAjdosd13PEAzTqNR7VS3/O6e9 8wgaCZfqjNDxxOFtrzAx+m/9AAfpJ9LAQkEWL/+D+n4hAYfqrnwyXc2NYUZHJaLx kHCis+Y/mJmV01orY5GPJAv181kt1pSWVsTQv7T9djShUPPfzlGpCWzrcv2G07az ZsCUI9/uihPCkP7AZ123Lc51JjvTmapFH05YsNgLvRWuvZxM6kkvwPsTPm/3ai86 tJFTzMWSd8IFY1Qpe6pVUW/uZXsuo+w6jKVz5n0eI+yAWLKCMZcdhQbtSxJVdVKH +S68I8uQkwieQRm2rvG/X/pls198uS5NUPNi041t9fbcyzj2LJT7Ky0Uwhv+BCLF sITJKYFQlXBqwDc8EKrsK2OG6TWHtvgvLcjwmFTIi6vbgMFJc8w= =tgf/ -----END PGP SIGNATURE----- --ahZICQ7iXVM/oLYH-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 28 16:28:01 2020 Received: (at 39412) by debbugs.gnu.org; 28 Apr 2020 20:28:01 +0000 Received: from localhost ([127.0.0.1]:41709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTWpl-0003MK-Ii for submit@debbugs.gnu.org; Tue, 28 Apr 2020 16:28:01 -0400 Received: from mout01.posteo.de ([185.67.36.65]:54111) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTWpj-0003M6-TC for 39412@debbugs.gnu.org; Tue, 28 Apr 2020 16:28:00 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id AE3AA16005C for <39412@debbugs.gnu.org>; Tue, 28 Apr 2020 22:27:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1588105673; bh=sPQuOnaUtV5YTKtXJ7umkt2msWYW+2CN+JTpdPun7pc=; h=From:To:Cc:Subject:Date:From; b=ODxAQ4vGErXBKmvd5t2o7PiQlRZzqVLhiuc/UxTkbxTPTzylbAs76OldRIasqcXAd P+ISIiGfvc00DCtl4QFYoRYFuOdq9onz7ebJKcWhLHxRnYrx3TUsbcACP9jGEhwD5W ltQ5a3v7/o4a4g6V7K5FURVpxgFsUgUbgSIRuhJZz955qgj2Q+mTOvDVcUcF5sOQGK QSUIOx+eqz8FHK1ZBpDOp3DcV/wvmFcEB1OxUz+fo1GpWpQyx4HlsGuVV4/3f/ksn0 pZOqeA81DvE4NI5/N6zpXwQ1Loc9YMi3bJZW46UgB6ScfVOH+xZIlf0ollIEXxHBwD b4U76kaqZ+SLA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49BY9h6V3wz6tmr; Tue, 28 Apr 2020 22:27:52 +0200 (CEST) From: Diego Nicola Barbato To: Efraim Flashner Subject: Re: [bug#39412] [PATCH 0/2] gnu: emacs-telega: Build with emacs-wide-int on 32-bit systems. References: <20200204094351.18671-1-dnbarbato@posteo.de> <20200204111424.GE19864@E5400> <87eetfcl4r.fsf@GlaDOS.home> <87pnbrhfkk.fsf@GlaDOS.home> <20200428174617.GV5243@E5400> Date: Tue, 28 Apr 2020 22:27:52 +0200 In-Reply-To: <20200428174617.GV5243@E5400> (Efraim Flashner's message of "Tue, 28 Apr 2020 20:46:17 +0300") Message-ID: <87h7x3gxtj.fsf@GlaDOS.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39412 Cc: 39412@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Efraim Flashner writes: > Looks good. patch pushed! Thanks! I went ahead and closed https://debbugs.gnu.org/39406. From unknown Fri Jun 20 07:19:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 27 May 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator