GNU bug report logs - #39398
26.3; `python-shell-buffer-substring` does not respect region

Previous Next

Package: emacs;

Reported by: Gaby Launay <gaby.launay <at> protonmail.com>

Date: Sun, 2 Feb 2020 21:14:01 UTC

Severity: normal

Tags: fixed

Found in version 26.3

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Gaby Launay <gaby.launay <at> protonmail.com>, 39398 <at> debbugs.gnu.org
Subject: bug#39398: 26.3; `python-shell-buffer-substring` does not respect region
Date: Wed, 28 Oct 2020 09:34:48 +0100
Glenn Morris <rgm <at> gnu.org> writes:

> This causes the tests that were added for https://debbugs.gnu.org/21086
> to fail.

This should now be fixed.

It's debatable, I guess, whether the old or the new `C-c C-r' behaviour
makes sense.  I think the command should do what it says: Send the
region to the python process...  but that means that the region should
be valid.  For instance:

if 1:
    print foo()

Sending "print foo()" is not valid; you need the entire line (because of
the True wrapping).  But that means that it's impossible to send
something later on the line, like just "foo()" (which is valid).

So we could revert the new patch and go back to the "send the entire
line" behaviour, but then we should actually document it at least.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 4 years and 258 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.