GNU bug report logs - #39384
[PATCH] gnu: Add emacs-rg.

Previous Next

Package: guix-patches;

Reported by: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>

Date: Sat, 1 Feb 2020 20:29:02 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

Full log


Message #11 received at 39384 <at> debbugs.gnu.org (full text, mbox):

From: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 39384 <at> debbugs.gnu.org
Subject: Re: [bug#39384] [PATCH] gnu: Add emacs-rg.
Date: Sun, 02 Feb 2020 08:21:52 -0600
[Message part 1 (text/plain, inline)]
Thank you for the fast feedback!

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
> Nitpick: I think the trend is to align `base32' with the string.

> You may want to lint your package. In particular, the synopsis 
> should be
> akin to "Search tool based ..."

> The description must start with a full sentence, e.g., "rg.el" 
> is an
> Emacs search package...

> Texinfo requires two spaces after the full stop.

> Ditto. Besides, the quote after "users" looks suspicious. You 
> should use
> a regular quote.

A patch file is attached that addresses all of the above feedback. 
The output of `guix lint emacs-rg` is now clean on my system; 
thank you for making me aware of that utility.

The only part of the package I'm uncertain about is declaring 
ripgrep as a propagated dependency.  ripgrep is not needed for 
this Emacs package to be able to byte-compile successfully, but 
`rg` does not need to be on PATH for the package to be useful at 
all.  So while I imagine the majority of the uses-cases would want 
to have ripgrep installed locally, it's definitely plausible that 
one could only ever want to use emacs-rg via TRAMP in which case 
pulling in ripgrep would be completely unnecessary.

Please let me know what you think.

--
Joseph LaFreniere
[0001-gnu-Add-emacs-rg.patch (text/x-patch, attachment)]

This bug report was last modified 5 years and 142 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.