GNU bug report logs - #39380
26.3: Opening files in vc-dir-mode with differing root and working dir fails

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 39380 <at> debbugs.gnu.org, Wolfgang.Scherer <at> gmx.de
Subject: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails
Date: Fri, 07 Feb 2020 11:53:32 +0200

> Cc: Eli Zaretskii <eliz <at> gnu.org>
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Date: Thu, 6 Feb 2020 16:38:54 +0300
> 
> >> Good catch, thank you. Could you try this patch?
> >>
> > Works fine. Directory listing in vc-dir-mode is truncated at sub-directory. Files are processed correctly.
> 
> Very good.
> 
> Eli, I'd like to get it into emacs-27. OK?

I'll have to ask you to walk me through the change and explain how it
solves the original issue.

I tried to figure that out myself, but it's too hard: the patch has no
log message, the function being changed has no doc string which could
describe its contract, and the Mercurial documentation I've read seems
to contradict what you are doing (e.g., it says "re:" should be
immediately followed by a regexp).  Sorry, I cannot make up my mind
whether this is a safe change without understanding it better.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.