From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 31 19:13:48 2020 Received: (at submit) by debbugs.gnu.org; 1 Feb 2020 00:13:48 +0000 Received: from localhost ([127.0.0.1]:38228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixgPz-0001Wf-P6 for submit@debbugs.gnu.org; Fri, 31 Jan 2020 19:13:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:59277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixgPy-0001WX-B2 for submit@debbugs.gnu.org; Fri, 31 Jan 2020 19:13:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37917) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixgPx-0008Aq-2s for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 19:13:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_40,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,SPOOFED_FREEMAIL autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixgPv-0002iL-Vi for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 19:13:44 -0500 Received: from mout.gmx.net ([212.227.17.20]:40479) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ixgPv-0002br-JD for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 19:13:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1580516021; bh=Nh6HVHbGZDtmQKOLorchQPkeieUSPBPQIhJF0LUexYc=; h=X-UI-Sender-Class:To:From:Subject:Date; b=EXG1NUYP2J68u8ODcB2Ebmo2Ntr1AZFBZlW44Ek3wrPMKiRH57oJnC62mntDVORLB Bj9/QNFUKbCbV/KmzwS9sr1mvyUTpzQ9j6tcpPPGRismFAbmhVK6fFNb1OUPg583aJ 3UoNl2el+p7HRqLncWVFgsxNHMK0zgGpK6pCEjt0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N1wll-1jhzbR3sD3-012Dec for ; Sat, 01 Feb 2020 01:13:40 +0100 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id 190A319431B6 for ; Sat, 1 Feb 2020 01:13:39 +0100 (CET) To: Emacs Bugs From: Wolfgang Scherer Subject: 26.3: Opening files in vc-dir-mode with differing root and working dir fails Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> Date: Sat, 1 Feb 2020 01:13:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 Content-Language: de-DE X-Provags-ID: V03:K1:gBpAbUXV7DX6HA5JK+ZfzpqQnu6KYQ0ASN4TD7rTgrkhM8lSX+o eSS9P5MEhsLXdeIkKmBMcXnw7nDPa5pSXmMVgAqwTMZTcq1qqib5QHrT62wwPLpEytfJYPu UMl31+870QpTQ9xOCXN6QpNPbwtgd9VD70v7LvLu7HbMY5GTL+ps1Vw9MRn2Tlw3Ux2ka2T wQhb8Q+anzUaFcbOzSqtQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:qt1XN3z5O/8=:byT/siyrYM/xRVp4DuWFq2 w3MR7Kus2z1lN2oAXhf3uTSNUi9UVuaO6WM9v7atRKUsK/bvWY6lhCtEtEKWGGMDka6NWhyvv I0DOUAOp1a9k08irVa1b+qHCfs7dAroGCW57JjChF+Ri7LbXUDXTDkH+t/n1wGJ6igKzmcuk+ C4bLdCQEh1h88l+64Lb5paQIOoN6yRrYTOHJCCCKk+licRteDswgQYnJtcKwF3BJXTTwLGqhG G3ZbiB9IRX7De7HRGQvRblpP63vTqv1RuKhOOfwsI8lmKpoAO90qgYKkDUlDYB6IXq6dzhc3q p+fHJvliQ2rjXRLoCe7mo4J2bpig7mzr09WK+DNA/FX6Xal/AXHJ33bVIyl3Bkf7gTJ/0AjXa +uVKBGQeLo3EisqKEYS0z1GaeY1aTD4qPWOZ8K1DMRa4gM8eTMHwN23l5fu8wO1r6rEyy7+AN ZVgNBqZsiSpq8xJhrQYQKOhVVetD2/hCU84pSN3SL4w+LbDAMOZ7A26mTaDrrZQIQJclONjGN imWicDNTcGhVJQxgeg/jNB2oRWqpc6DnzTU9337d+tBLa9v2Hh44wU5pESjYPZEj/8ttQ1oqr eDHsC1nJyzRSdm9I+qiQyUIU8Za3nT9W32LkcDyw0YvdmWynqWKogKsU1H3q6HLcqFJBK6yGG Agsf8jv4vMU3UTEHuLqmPbVNaBJEPbNcmeABb7REx48z3993RlSlDeQNOgbPcoES1on9IdV9M JtJB1cIY1Q2gvkwA1COksN1CvNhCVnUk9+ktW2z3H84oKWW/HkAwlqBR1Tgih5WDOMW/FfqJz Do3tUSZFfxSCfSujNT+soTHAI9raIva8z0TmlH0XKpgWTMslH85zEAymWJta9ROw5pxURcIe4 5cYANEWxIJBYC7tMcqfS+8KXc6LjeONb7kNZuWg45/ApFlyp/u0O0UwXALky6E4GzlXMsP6nd 7gyXpVbnzQshnBdojwMM4nuNnWAkV9ahMXuZ5VkETzw2pZcTrAT6X+RAFuTz+Auv6loMpZeeo EIcVriZhaHhDj0/MROcELjsDoMQ6xcMJYFzli42VOrYt0mvZyl7h3/DHRrc6q7ko4b1e1rg2f FTKnfSi9JVbOkQjtEHUgZt3yAZWVgaju2a6teahmThOo5QLfOl/Tq3vMflC6gVLBTaCuMRHBj TGblOJigP/IgWmv0c+0oiIyT+UdNVNDg++Z7GUiY3o41nB6GJslNSvq4pVW8L/5QLWNqjs3YF iLYzP8ANet6BjP0l/ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.20 X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Here is another per-tree/per-directory bug, I just found: 1. Prepare a Mercurial repository `check-hgs` with sub directories `sub1`    and `sub2` and the files `sub1/a`, `sub2/x`,    .. code-block:: sh Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (wolfgang.scherer[at]gmx.de) 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=wolfgang.scherer%40gmx.de;ip=209.51.188.17;r=debbugs.gnu.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) SGVyZSBpcyBhbm90aGVyIHBlci10cmVlL3Blci1kaXJlY3RvcnkgYnVnLCBJIGp1c3QgZm91bmQ6 DQoNCjEuIFByZXBhcmUgYSBNZXJjdXJpYWwgcmVwb3NpdG9yeSBgY2hlY2staGdzYCB3aXRoIHN1 YiBkaXJlY3RvcmllcyBgc3ViMWANCsKgwqAgYW5kIGBzdWIyYCBhbmQgdGhlIGZpbGVzIGBzdWIx L2FgLCBgc3ViMi94YCwNCg0KwqDCoCAuLiBjb2RlLWJsb2NrOjogc2gNCg0KwqDCoMKgwqDCoCBt a2RpciAtcCBjaGVjay1oZ3Mvc3ViMSBjaGVjay1oZ3Mvc3ViMg0KwqDCoMKgwqDCoCB0b3VjaCBj aGVjay1oZ3Mvc3ViMS9hIGNoZWNrLWhncy9zdWIyL3gNCsKgwqDCoMKgwqAgY2QgY2hlY2staGdz ICYmIGhnIGluaXQNCg0KMi4gRmluZCBmaWxlIGBjaGVjay1oZ3Mvc3ViMS9hYC4NCg0KMy4gUHJl c3MgYEMteCB2IGQgUkVUYCwgd2hpY2ggd2lsbCBzaG93IGEgIldvcmtpbmcgZGlyIiBkaWZmZXJl bnQgZnJvbSAiUm9vdCI6DQoNCsKgwqAgLi4gY29kZS1ibG9jazo6IHRleHQNCg0KwqDCoMKgwqDC oCBXb3JraW5nIGRpcjogY2hlY2staGdzL3N1YjEvDQrCoMKgwqDCoMKgIFJvb3TCoMKgwqDCoMKg wqAgOiBjaGVjay1oZ3MNCg0KwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCAuLw0KwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCBzdWIxLw0KwqDCoMKgwqDCoCB1bnJlZ2lzdGVyZWTCoMKgwqDCoMKgwqDC oMKgIHN1YjEvYQ0KwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBzdWIyLw0KwqDCoMKgwqDCoCB1bnJlZ2lzdGVyZWTCoMKgwqDCoMKgwqDCoMKgIHN1 YjIveA0KDQo0LiBHbyB0byBsaW5lDQoNCsKgwqAgInVucmVnaXN0ZXJlZMKgwqDCoMKgwqDCoMKg wqAgc3ViMi94Ig0KDQrCoMKgIGFuZCBwcmVzcyBgZmAuDQoNCjUuIFByZXNzIGBDLXggZGAuDQoN CsKgwqAgVGhlIGRlZmF1bHQgZGlyZWN0b3J5IGlzICJjaGVjay1oZ3Mvc3ViMS9zdWIyLyIsIHdo aWNoIGlzIHdyb25nLiBJdA0KwqDCoCBzaG91bGQgYmUgImNoZWNrLWhncy9zdWIyLyIuDQoNClRo ZSBwcm9ibGVtIHJlc3VsdHMgZnJvbSB0aGUgY2FsbCB0byBgZXhwYW5kLWZpbGUtbmFtZWAgaW4N CmB2Yy1kaXItY3VycmVudC1maWxlYCwgd2hpY2ggdXNlcyB0aGUgZGVmYXVsdCBkaXJlY3Rvcnks IGJ1dA0KYHZjLWRpci1maWxlaW5mby0+bmFtZWAgZGVsaXZlcnMgYSBmaWxlbmFtZSByZWxhdGl2 ZSB0byB0aGUgcm9vdA0KZGlyZWN0b3J5Lg0KDQouLiBjb2RlLWJsb2NrOjogZWxpc3ANCg0KwqDC oCAoZGVmdW4gdmMtZGlyLWN1cnJlbnQtZmlsZSAoKQ0KwqDCoMKgwqAgKGxldCAoKG5vZGUgKGV3 b2MtbG9jYXRlIHZjLWV3b2MpKSkNCsKgwqDCoMKgwqDCoCAodW5sZXNzIG5vZGUNCsKgwqDCoCDC oChlcnJvciAiTm8gZmlsZSBhdmFpbGFibGUiKSkNCsKgwqDCoMKgwqDCoCAoZXhwYW5kLWZpbGUt bmFtZSAodmMtZGlyLWZpbGVpbmZvLT5uYW1lIChld29jLWRhdGEgbm9kZSkpKSkpDQoNCg0KSG93 ZXZlciwgbW9kaWZ5aW5nIGB2Yy1kaXItY3VycmVudC1maWxlYCBkb2VzIG5vdCBzb2x2ZSB0aGUg cHJvYmxlbSwNCnNpbmNlIGFsbCBvdGhlciBpbnZvY2F0aW9ucyBvZiBgdmMtZGlyLWZpbGVpbmZv LT5uYW1lYCB1bHRpbWF0ZWx5DQpzdWZmZXIgZnJvbSB0aGUgc2FtZSBkZWZpY2llbmN5Lg0KDQpJ dCBpcyBJTUhPIGJldHRlciB0byByZW1vdmUgdGhlIGh5YnJpZCBzdGF0ZSBvZiBgdmMtZGlyLW1v ZGVgLCB3aGVyZQ0KdGhlIGRlZmF1bHQgZGlyZWN0b3J5IGlzIGRpZmZlcmVudCBmcm9tIHRoZSBy b290IGRpcmVjdG9yeS4NCsKTDQo= From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 02:20:48 2020 Received: (at 39380) by debbugs.gnu.org; 1 Feb 2020 07:20:48 +0000 Received: from localhost ([127.0.0.1]:38303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixn5E-0003LR-G9 for submit@debbugs.gnu.org; Sat, 01 Feb 2020 02:20:48 -0500 Received: from mail-lj1-f172.google.com ([209.85.208.172]:33264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixn5D-0003LD-4N for 39380@debbugs.gnu.org; Sat, 01 Feb 2020 02:20:47 -0500 Received: by mail-lj1-f172.google.com with SMTP id y6so9472038lji.0 for <39380@debbugs.gnu.org>; Fri, 31 Jan 2020 23:20:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=y0AASh92ZkNp90NttpvfO9AEHIhooTP1lq64lYRfxWI=; b=fd86YC9fdfgO+iQFlctQ22rq/NRiNtjesifsuQTEWBu9Bgr6l7OUrTy+jW6NBJ44aK 8DkKlIHeGQK3Evez7MZJtlhAe+Rzxc+xzGleECR6GU9M1WawDihoZboExZPsp2Bl1ppR tBv1hCRTpcrfuT+WRC3JYnb+OElwUCELITkXkD6ix5Yn9JbAHS/AdpQ7cNO/sQC0LMgS /q0ky6rz/kw7BXT2sdZ2+1eS42zITBpvfT72pSMcCetDg+SALnMjyZ5bhFsAk9PIVqwH omOdUwgoM8GjFDDB7hsb+a+gYqQoUDfFoxWbTGnYEMWktARzEqfF41XTxGqGVTyPRGdm XmDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y0AASh92ZkNp90NttpvfO9AEHIhooTP1lq64lYRfxWI=; b=ViIzAag3qUn/H0iE4YZWR8Rea/OGYFO6mUitv3amQzzEmv891Cfif3fGJIEM79LD/4 d89ht8/zAMoQJ2N1FHQnl8Uxtt6jtlDLEoaUfn6/G2OPfkNTCD9Z9dBLGmTiFbMAOqOt LG6kvgAplhYruqDekUdAcX24zwmAXkTaY1/WBNOosgzj2NosF5I30AQAclkEbUdELaU/ D6aeQcpGJ7NTnmOpMtp6fZSG3GSN3lmoAZ732P0O1yVh58vxkZ/M+7Ih/hAKXOv2hrcp G/QX7wPM6e0Go9DZD1uCiLFePOamsEsvRoFut1PvNAyB/aD33gfQmn9sNdw5OKGRFd4i YfaA== X-Gm-Message-State: APjAAAUVXbxkAaxcaVRIXWRVYohyGSJ/2BCElu0ZjsAdDHJemaBRqKLk cDDSMO4SG6y9K/XM6o2KPKttdqODFG8= X-Google-Smtp-Source: APXvYqwkkX4tbv+jA6xdV7HqhplNmUumMwT+3lODFCnORo/yXrX9MHthc9W9gvVvI3omPLlxG5pjeg== X-Received: by 2002:a2e:b0c4:: with SMTP id g4mr8222543ljl.83.1580541640903; Fri, 31 Jan 2020 23:20:40 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id d26sm5686397lfa.44.2020.01.31.23.20.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Jan 2020 23:20:40 -0800 (PST) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails To: Wolfgang Scherer , 39380@debbugs.gnu.org References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> From: Dmitry Gutov Message-ID: Date: Sat, 1 Feb 2020 10:20:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 01.02.2020 3:13, Wolfgang Scherer wrote: > 3. Press `C-x v d RET`, which will show a "Working dir" different from "Root": > >    .. code-block:: text > >       Working dir: check-hgs/sub1/ > [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.172 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.172 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 39380 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 01.02.2020 3:13, Wolfgang Scherer wrote: > 3. Press `C-x v d RET`, which will show a "Working dir" different from "Root": > >    .. code-block:: text > >       Working dir: check-hgs/sub1/ >       Root       : check-hgs > >                            ./ >                            sub1/ >       unregistered         sub1/a >                            sub2/ >       unregistered         sub2/x Maybe this should be fixed in vc-hg-status-files by not showing "outside" files and using proper relative names. Compare how VC-Dir works with Git: when you open it in a subdirectory, it only shows changed files in that directory, and with proper relative names. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 02:20:54 2020 Received: (at 39380) by debbugs.gnu.org; 1 Feb 2020 07:20:54 +0000 Received: from localhost ([127.0.0.1]:38306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixn5K-0003Lj-N4 for submit@debbugs.gnu.org; Sat, 01 Feb 2020 02:20:54 -0500 Received: from mail-lj1-f182.google.com ([209.85.208.182]:42149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixn5I-0003LK-Su for 39380@debbugs.gnu.org; Sat, 01 Feb 2020 02:20:53 -0500 Received: by mail-lj1-f182.google.com with SMTP id d10so9417010ljl.9 for <39380@debbugs.gnu.org>; Fri, 31 Jan 2020 23:20:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=E5UIrCoVwKOocd0NJk1Tdwop7qqGF1lVseLetP2pUa0=; b=QfRouGPd/aRUKzBqjGXJQg7zu7y4tV/wkZcDrZgZIHL6m2qyT1a5FFDCLEP4dQ08b0 cffpImg05b0tzvMbcwFTNyR0ymr6GyvjFBXldHBVqmzKcJNz1Du7sFAPzNHEeBXB6d3U fpIj7oWY1FuKx2jTpfwJ64wWHlR4RKjd0SB6FIe1IaU1JnDhl0yRr21yd1j+/MQzJ5C9 cQrxz2TaiP0lzWhXZLeuZ0W0yk/lg0F9UT7cDcEKpS2cefVFowxXSTq+JTgpeSiYQWFD P/RcQ+WDRYAEEF8FGDcXWlGar9/TTjnc/JX11392FJcBdhkI4xhJgpBEgAwtD8qIOYHx 1+JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E5UIrCoVwKOocd0NJk1Tdwop7qqGF1lVseLetP2pUa0=; b=D0Ncb+jBq5LW5RLob2bPkWcDp0DGSkEkbSRg6qJ44rczN2UUlso8ogkTZhFR9o+YAb JqHy97jqgUOySPRLbQY8GwKuvCsvIPp1S53T8HgZe3g+I7VFAIgwBDvO8N3YMHjwSdO9 5wcPmCP9Z3XaseGp5C6awLdh9NmZADJQYCeSR4LibXKyvVhTG0XPWL2k9Wn21PfI1oHB ZT0X1+t6iYYxYBu1hTx++6iQRrSUJ97CdQa2i2UXWxSKJB+7/kpuYUE3HcCQFzagQpQr dVsl/pfhfnr4j8LNFcNIVDHxhPeGL1HUkJLxUpamDr9nbVIWTK5jnR5Q+NzVVBzCJSJt U0yg== X-Gm-Message-State: APjAAAWNgJCYRMpAWm3P79LI/2Ck7C2uy7GcRMnFC8Qi+IVTQ9gmQxXS jpOxAiju67PwHaGzeLYPM+GBnMGZkhs= X-Google-Smtp-Source: APXvYqzmNBMQzujKnp2448sOi1nTeC2zu4v8MXVJtMbbA/AG1IS2tk48D7ATbuAcIn7G3Azs5ultDA== X-Received: by 2002:a2e:9955:: with SMTP id r21mr7871214ljj.283.1580541646960; Fri, 31 Jan 2020 23:20:46 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id d24sm5835048lja.82.2020.01.31.23.20.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Jan 2020 23:20:46 -0800 (PST) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails To: Wolfgang Scherer , 39380@debbugs.gnu.org References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> From: Dmitry Gutov Message-ID: Date: Sat, 1 Feb 2020 10:20:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 01.02.2020 3:13, Wolfgang Scherer wrote: > It is IMHO better to remove the hybrid state of `vc-dir-mode`, where > the default directory is different from the root directory If you mean to always open VC-Dir in repository roots, I'm not sure we can do that. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.182 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.182 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 39380 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 01.02.2020 3:13, Wolfgang Scherer wrote: > It is IMHO better to remove the hybrid state of `vc-dir-mode`, where > the default directory is different from the root directory If you mean to always open VC-Dir in repository roots, I'm not sure we can do that. We had a discussion about that at one point (purely for reasons of usability), and turns out some people routinely open VC-Dir in subdirectories. To focus on a subset of a project, or whatever. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 02 17:35:51 2020 Received: (at 39380) by debbugs.gnu.org; 2 Feb 2020 22:35:51 +0000 Received: from localhost ([127.0.0.1]:40695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyNqJ-0006rW-D1 for submit@debbugs.gnu.org; Sun, 02 Feb 2020 17:35:51 -0500 Received: from mout.gmx.net ([212.227.17.20]:48291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyNqI-0006rK-97 for 39380@debbugs.gnu.org; Sun, 02 Feb 2020 17:35:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1580682944; bh=I83FaawZL4WuO30BVYgmfxYbJ0gPwWrDKjGHJa6eLRI=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=I9Pwon1W0Ajc4JZmnBoM25h5RgBwDzdEksiHuSHms16IUEVPye5L2boGLbafMUrpg ghjOcf+LBOpJ8jFI/5ao6O5Es8qKsVxfFMkmOEze9JLLLm1InCWbrLyFfJ9iIQZtB6 gvsilZcDTk5M0VOn0Y2LW6KeM+ACfdWsUBhkk5p8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4hzj-1jeYMC3YUp-011iFS; Sun, 02 Feb 2020 23:35:43 +0100 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id 9132F1943155; Sun, 2 Feb 2020 23:35:42 +0100 (CET) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails To: Dmitry Gutov , 39380@debbugs.gnu.org References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> From: Wolfgang Scherer Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> Date: Sun, 2 Feb 2020 23:35:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 Content-Language: de-DE X-Provags-ID: V03:K1:zjcmz1b2Y0nMoP0/SGjM8YHlVnCpUu1aBdSydPvntBu5TmeKgNP dTIHayk4xAcXtrtBi73YBSpvxwDkBTCR64IPB4FRH8pK/A/pbHR9mM53EKjL3xioUsXaEdY XgXD3imK/blf8Kd1PXRcmMhox8plTpERVKQns2zY7ipIDHgcGETCq9NhYmJyNV2qM6Q+yik 6XuKaE0AUhmxJsJp6sH5A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:NK2HLnOVMpY=:sj3jG5oT0tN+dsDWU2kK0+ 9qbp/Xy7VO7tP8oQ8tD757u3UfmvhGPvYInXkTQ6qUk/ezt4g4/xvkGT4XXQCTjCQm+N0o0Z3 mrLEUw0XFYbr7dWYTTndOLKvK6gFDMCntQfx4PEzXZZkerj3ossBVH7H2c23X9qMXZ88YWYs9 poZmtHLKmLGSs0j6xdSamS4O9E/rRjpp+T8YkCEm6QoU+QGXi4BCvFdnfijU4WpTNfssAjtPx MLiWZF1jbRJSxxDI1fOJv0OUJ1ESSvGl64wQb31BFvwd6lkZGt+0hQp6WDz7Ai67/r6EeOEbu Xw7UK8U6U89uth2WVnNDHarYlP8ggXU0LHVcpWySL3qS+/p7uKeMmjfZ/TKSPmPOZiW0qjg4T RVvavUUyyvaFMekwPYdoiTFZIeV3hkVL3U19EdKin4FrZ94MFSIeJRFln6BQpCy1B4PlPZACV 2COEuVyEIydgWY+sbpoYuw1u005tsPLCeArsn/YMx8R1Cv0FUcQ9QPGUFU+Mbo2ZBaVQ/ZAby de9WtPtt30x3amcYKCMhqoyCRzUs9K0+V6Ddoke3vJ+8rKYkzZfb9lAMwJZOWJbepw5S7jzXU At5WiqtlBaMw64RrK+PFRnHU3rWgmHV6A0JMNvffmpaoEigD8GJPBcCH/k49S79zs/PmhP85i xrvLJ4c6AuieW5SJJ7FIedvtsBNvqp0zY9k+/Um+TJakMTg0OWQ/8gTCUHFuI9WMvPqCV8SHn e8/szf38rNkZnLpP0PWKY3agJQbvDjhGPwgBLYZ/z4om6Tx88suogdhyZ1mHMgzpjEk/NOosJ 0TJDlCZZJGD/TweeHM9jUyNq+EBZDJZAXDtEXoAQPypDgrJx8FqnGlYnVVIJo4e8N5CX8cfTD aTOg4MobRvseHb2j60gxyLjbItW8HGwcK7V3Xv3mzh6KmkTbmkvVhtzWARZBWJeQ2RIeS90iC sRTeh8Vg8541npqLecgyNb8d3X0mdkgF7TX9rG6/ImnfagSqhYdj1dv+0p4qAM/f1rz7iKIqe 28mUuaC6uN2VZxwXZhAwSc0/RZsAHw+bE0lUrytGP4ro7GD0eb/fz/WnjrhHVKKJWEztF+rGc XeT3SGUC5fVSlZKK4X0qJ+aIaN3DRRjJ8R8Z6ENFGWoMYGMgfIbPMHqQnp0H/LYlSjucOm4Hn NfON5n5BxxQkI5jfZPoY2QfLhN2C4n2BobdXjS5MdIg/DeikFqFxlXs6mkX471o/HB6scqh1X hcFOl0bu3heEgVagR X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39380 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) DQpBbSAwMS4wMi4yMCB1bSAwODoyMCBzY2hyaWViIERtaXRyeSBHdXRvdjoNCj4gT24gMDEuMDIu MjAyMCAzOjEzLCBXb2xmZ2FuZyBTY2hlcmVyIHdyb3RlOg0KPj4gMy4gUHJlc3MgYEMteCB2IGQg UkVUYCwgd2hpY2ggd2lsbCBzaG93IGEgIldvcmtpbmcgZGlyIiBkaWZmZXJlbnQgZnJvbSAiUm9v dCI6DQo+Pg0KPj4gwqDCoMKgIC4uIGNvZGUtYmxvY2s6OiB0ZXh0DQo+Pg0KPj4gwqDCoMKgwqDC oMKgIFdvcmtpbmcgZGlyOiBjaGVjay1oZ3Mvc3ViMS8NCj4+IMKgwqDCoMKgwqDCoCBSb290wqDC oMKgwqDCoMKgIDogY2hlY2staGdzDQo+Pg0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC4vDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3ViMS8NCj4+IMKgwqDCoMKgwqDCoCB1 bnJlZ2lzdGVyZWTCoMKgwqDCoMKgwqDCoMKgIHN1YjEvYQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN1YjIvDQo+PiDCoMKgwqDCoMKg wqAgdW5yZWdpc3RlcmVkwqDCoMKgwqDCoMKgwqDCoCBzdWIyL3gNCj4NCj4gTWF5YmUgdGhpcyBz aG91bGQgYmUgZml4ZWQgaW4gdmMtaGctc3RhdHVzLWZpbGVzIGJ5IG5vdCBzaG93aW5nICJvdXRz aWRlIiBmaWxlcyBhbmQgdXNpbmcgcHJvcGVyIHJlbGF0aXZlIG5hbWVzLg0KPg0KPiBDb21wYXJl IGhvdyBWQy1EaXIgd29ya3Mgd2l0aCBHaXQ6IHdoZW4geW91IG9wZW4gaXQgaW4gYSBzdWJkaXJl Y3RvcnksIGl0IG9ubHkgc2hvd3MgY2hhbmdlZCBmaWxlcyBpbiB0aGF0IGRpcmVjdG9yeSwgYW5k IHdpdGggcHJvcGVyIHJlbGF0aXZlIG5hbWVzLg0KDQpUaGUgYmVoYXZpb3Igc2hvdWxkIGJlIGNv bnNpc3RlbnQuIEluIEVtYWNzIDI0LzI1IHZjLWRpci1tb2RlIGZvciBNZXJjdXJpYWwgYmVoYXZl ZCBleGFjdGx5IGxpa2UgR2l0LiBTaW5jZSB0aGUgYmVoYXZpb3IgZm9yIE1lcmN1cmlhbCBjaGFu Z2VkIHNvbWUgdGltZSBhZnRlciBFbWFjcyAyNCwgSSBqdXN0IGFzc3VtZWQgKHByb2JhYmx5IGJl Y2F1c2Ugb2YgbXkgYmlhcyB0b3dhcmRzIGBkdmNgKSB0aGF0IHRoZSBuZXcgYmVoYXZpb3Igd2Fz IGludGVuZGVkLg0KDQpJIHJlYWxseSBoYXZlIG5vIHByZWZlcmVuY2UgaG93IHRoZSBmYXVsdHkg YmVoYXZpb3IgaXMgZml4ZWQsIHNpbmNlIEkgaGF2ZSBsb25nIHNpbmNlIGRlZmluZWQgc29tZSBh ZHZpY2UgYmVmb3JlIGB2Yy1kaXItcHJlcGFyZS1zdGF0dXMtYnVmZmVyYC4gSSBoYXZlIGFsc28g bm90IGNoZWNrZWQgdGhlIGRvY3VtZW50YXRpb24gdG8gZmluZCBvdXQgd2hhdCB0aGUgaW50ZW5k ZWQgYmVoYXZpb3IgaXMuDQoNCg== From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 03 08:11:18 2020 Received: (at 39380) by debbugs.gnu.org; 3 Feb 2020 13:11:18 +0000 Received: from localhost ([127.0.0.1]:40968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iybVW-0004hf-HJ for submit@debbugs.gnu.org; Mon, 03 Feb 2020 08:11:18 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:35795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iybVU-0004hQ-C0 for 39380@debbugs.gnu.org; Mon, 03 Feb 2020 08:11:16 -0500 Received: by mail-lj1-f193.google.com with SMTP id q8so14571586ljb.2 for <39380@debbugs.gnu.org>; Mon, 03 Feb 2020 05:11:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0Thun8N6gbmowaWvzTusILjfAKmj51Y+2oOZQDIx4Rg=; b=sZPxMatuAWQSPWpYcu9WpoD0Hkro677UFjO2ITWHAojHbnhF6g/zupulFhwx/+1d7Q 3W7FIh+poO1cIRRsF24cMas6UCB8CUv7UXzSrPY/e4TkU1N9gdgu1wn2sOLXY2OgGlEl qQCRYV++qJMKWg6x6y0N0Ai9A0H1njohJNIMM01WJ6XXtWws5jg/RrS4OKpOLa4E1T3U wN+LJiox4E6Bm0xGD3h5tsT2PvUVV3tbx7agoXD6QLaBWeM9fHkNhLKtwnIMAdoVyyoe CkY83HTYt7BN+Dxm8ecno4e23kUkjKlOQeNFbZSZV77ftCLhJI5PfK3oY9Us4ISqJCpy dmtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0Thun8N6gbmowaWvzTusILjfAKmj51Y+2oOZQDIx4Rg=; b=q77i9sBKlVZY3YpRjiVyfqjA8oAI1oZrS51fJS7phwykzO1Ni/MjLztgXl3rIyXK3a 1RR2hlheLrP2b+iVDkVAABGsYofl26Fd/nzgHnRNJXOJQLcbOHvbQym6DmXB328bK2w1 4akxJKRbEpPi2w41dxS7AyZEHnQ1u1As8lct38Ae80vBJWQSokMb4OC1TfZYIQWIolxm R4eHCqw9FAiguwxclHi/7wqltflWG3y0fbMoZTeqxw8tpeGb46n3S1LGmkWWAugyVis+ zNvrfX9Zcsn2BTOfm6eYDjMz4NWnp19UFnNPUDswd7L3sfi8z/BB84/C62gZFXm60Cpp Jc2Q== X-Gm-Message-State: APjAAAVgyFXei5XSr+iA00hu2uZO2pnd1ndxieXIqKySoX7XZnoYG+ph XyVFf1/d7kvtjL6qCLLxALvOJJLRZD4= X-Google-Smtp-Source: APXvYqzK74OGG+KnQu16vIc7xVPFMe3BKaDnjiX2s/nnpzfN3LXUiSw3I3VSoDY3nEvdgJ3UHCA1hA== X-Received: by 2002:a2e:b5d5:: with SMTP id g21mr14062198ljn.89.1580735470241; Mon, 03 Feb 2020 05:11:10 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id f8sm8843621lfc.22.2020.02.03.05.11.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Feb 2020 05:11:09 -0800 (PST) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails To: Wolfgang Scherer , 39380@debbugs.gnu.org References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> From: Dmitry Gutov Message-ID: <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> Date: Mon, 3 Feb 2020 16:11:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 03.02.2020 1:35, Wolfgang Scherer wrote: > > Am 01.02.20 um 08:20 schrieb Dmitry Gutov: >> On 01.02.2020 3:13, Wolfgang Scherer wrote: >>> 3. Press `C-x v d RET`, which will show a "Working dir" di [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.193 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.193 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 39380 Cc: Daniel Colascione X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 03.02.2020 1:35, Wolfgang Scherer wrote: > > Am 01.02.20 um 08:20 schrieb Dmitry Gutov: >> On 01.02.2020 3:13, Wolfgang Scherer wrote: >>> 3. Press `C-x v d RET`, which will show a "Working dir" different from "Root": >>> >>>     .. code-block:: text >>> >>>        Working dir: check-hgs/sub1/ >>>        Root       : check-hgs >>> >>>                             ./ >>>                             sub1/ >>>        unregistered         sub1/a >>>                             sub2/ >>>        unregistered         sub2/x >> >> Maybe this should be fixed in vc-hg-status-files by not showing "outside" files and using proper relative names. >> >> Compare how VC-Dir works with Git: when you open it in a subdirectory, it only shows changed files in that directory, and with proper relative names. > > The behavior should be consistent. Right. > In Emacs 24/25 vc-dir-mode for Mercurial behaved exactly like Git. Since the behavior for Mercurial changed some time after Emacs 24, I just assumed (probably because of my bias towards `dvc`) that the new behavior was intended. In 25 or 26 Daniel added a Lisp-based faster implementation for some commands (de76a167dc09dc695a5acebabb7ab354a6bf556e) since apparently Hg itself was too slow. So this bug must have arrived with that implementation. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 04 11:04:26 2020 Received: (at 39380) by debbugs.gnu.org; 4 Feb 2020 16:04:26 +0000 Received: from localhost ([127.0.0.1]:44607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz0gc-0003M5-Kq for submit@debbugs.gnu.org; Tue, 04 Feb 2020 11:04:26 -0500 Received: from mout.gmx.net ([212.227.17.22]:37273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz0ga-0003Lp-B8 for 39380@debbugs.gnu.org; Tue, 04 Feb 2020 11:04:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1580832252; bh=VND5UM2IPxGHk1LkcDWFtLxX7YsVlKlYcERDJrOvdrw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=iFICBTVT4bp1T5iNpxFpwejLCL47w+laIT+Co95ri2MJW7Pwyy+FZij1FvF+Ky2sV EBTp6YdnE3DJlBBH+YGZsAZuI0NogRg4daHuvlGY47YS6ASOtSmxRszrxc5W8YtsS2 yyglgHTLDRvWdmOcVu5ed9pJylU8LBFqcrgzDuts= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MxlzC-1jkmCw1hTq-00zH0B; Tue, 04 Feb 2020 17:04:12 +0100 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id E8FAA19431C5; Tue, 4 Feb 2020 17:04:10 +0100 (CET) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails To: Dmitry Gutov , 39380@debbugs.gnu.org References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> From: Wolfgang Scherer Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> Date: Tue, 4 Feb 2020 17:04:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: de-DE X-Provags-ID: V03:K1:tuwTRoPCMJBxJp9OdhtqGeFsJDeN89hcfKDkphyhZ6hc6HCtOdG i+VY6XjjUgMu13GmZbGi16deLEuu2VZNbhEjdkPMOucuwXLId0YeSWibn7TDin4JSMzfSYt q5tD1ZliXLCV9PHOtWN0l1MD+tGeQ002C+/3ECKW0AeN1vlW8Ul2RdPQEkYSH0vaXLC8cMI DF+wrFSgf53LlOeWGnGYA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:rIUYNyNxzTY=:DcLUuNuXFMpcTdLMu9hPXL CwhQOTLe8EAfP/rZcolkKHZgL/e/vqGGIhWk10BH4IMEkbJe507PJJogkHeY2/3kNjRRM8Hgq 4v67/a69aHd0XA1Eji1+udmTUliow8cxPzOcVq0YB9ep2Lshb2+uEgzM5OXVbKlWnX1kV+x0J TRi+vjTQVaz9CiP5iqDzqjbSNfiqSJkRcjj/DoZ/2ZqotnT5ljAhbn3+RMJkjSL12scO6kv51 t3PNDNh30QQCTkeuebR/jrpftIwlITioKwMqly6Oo1snNIH0OsBo7PrYEddNiVhu4UH7PL8F4 2Y+m3hSB2Sgjc0p73/Y57jmdjmhDycYBdgAohFpbuqSjKKUewApQL7hsr8Q1HRy4H3f47Wl1q XD7FLL0gUyYL4WZf/18i+fTNAPqv0ik3YSQ6xy59tdhD7/IuoORuzoBNjYcN36Dyvubru1YNl uZVvY87k7Lco8u+yZxdDjTSIgX836IatXUVuFKO9qO8d9HSYoSCal81vUYGFY4HagLu6o/jiR 0rpWIOPpvGc3K2/jDLSZGVf8Gi2Zzx5hZYQhRx1TP1EzVcU7JCLQzdu6yMApiGqYybwp80v3e kvCCTs1oPducET7HkUMpV4xNFabkRY122+kQLK/ocKt3ZLUuNRPAoUo0ebkv3l6yugFNjueag bukeQ+GF/ZbtqqPB276PVKF+3YKRu8mZ9uFraM3sY4yxS52foj2LOC5gr8bsbG4R+hozbv6NZ 0aYSHHZRwbbq9Zqu4LGmGQHh4etp60UJwBzlroikcdWaMlFoe64EfvJangndEOfx3a+Jy0vP9 81mw7CrquNuUITXNyxWQtaYT3N8f+ehN18M2pik5yxXkcCdzPQ5x2u9NguXz3t0RTu/T6dp0/ YkaWUwAZsBo18H5zUAYB+33AfioIgv9mNYM7nD9uNEQNIRYv/qz4ovEiBbYe6uf3SeTzh5a7P WW/zgMdeJqvTebxluU1Bk9wTjApS4TMK5QuPH+4wxKZv0PyYvjQ9orEmtkQuBBrLUM+mM1Suf ib5kVba/aGdjpWq07siFvwAo18Be2l/XTQZm3WLYSqMIx4OqTZAl2zilqnnpW1WRWaF0vHm+l ZHLYEcc+C61m7hVf3+93vYNNED0DPqiBiA84mLHhCIaizoleL49wgOTfRurHHogedLwhsKQT9 YtILLNPYYoeLoF6iAdRk+Y7zvdPUkE0I13mTszs3waPm33sp7lBXxFs4/g3PXWd4oJonrxHfD uNsnoRIbann4ihdfv X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39380 Cc: Daniel Colascione X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Am 03.02.20 um 14:11 schrieb Dmitry Gutov: > On 03.02.2020 1:35, Wolfgang Scherer wrote: >> >> Am 01.02.20 um 08:20 schrieb Dmitry Gutov: >>> On 01.02.2020 3:13, Wolfgang Scherer wrote: >>>> 3. Press `C-x v d RET`, which will show a "Working dir" different fro= m "Root": >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 .. code-block:: text >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Working dir: check-hgs/sub= 1/ >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Root=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 : check-hgs >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 ./ >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 sub1/ >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unregistered=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sub1/a >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 sub2/ >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unregistered=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sub2/x >>> >>> Maybe this should be fixed in vc-hg-status-files by not showing "outsi= de" files and using proper relative names. >>> >>> Compare how VC-Dir works with Git: when you open it in a subdirectory,= it only shows changed files in that directory, and with proper relative n= ames. >> >> The behavior should be consistent. > > Right. > >> In Emacs 24/25 vc-dir-mode for Mercurial behaved exactly like Git. Sinc= e the behavior for Mercurial changed some time after Emacs 24, I just assu= med (probably because of my bias towards `dvc`) that the new behavior was = intended. > > In 25 or 26 Daniel added a Lisp-based faster implementation for some com= mands (de76a167dc09dc695a5acebabb7ab354a6bf556e) since apparently Hg itsel= f was too slow. > > So this bug must have arrived with that implementation. Reverting de76a167dc09dc695a5acebabb7ab354a6bf556e does not change anythin= g for me. I had to revert 06083cf41c473404d246de9b91a0116f38c5485f to restore the co= rrect behavior: Author: Dmitry Gutov Date:=C2=A0=C2=A0 Sat Jan 30 06:55:32 2016 +0300 =C2=A0=C2=A0=C2=A0 Don't pass DIR to 'hg status' =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 * lisp/vc/vc-hg.el (vc-hg-dir-status-files): =C2=A0=C2=A0=C2=A0 Don't pass DIR to 'hg status' (bug#22481). From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 05 10:56:12 2020 Received: (at 39380) by debbugs.gnu.org; 5 Feb 2020 15:56:12 +0000 Received: from localhost ([127.0.0.1]:46634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izN2C-0007Q6-1E for submit@debbugs.gnu.org; Wed, 05 Feb 2020 10:56:12 -0500 Received: from mail-lf1-f51.google.com ([209.85.167.51]:42750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izN2A-0007Po-4v for 39380@debbugs.gnu.org; Wed, 05 Feb 2020 10:56:11 -0500 Received: by mail-lf1-f51.google.com with SMTP id y19so1834178lfl.9 for <39380@debbugs.gnu.org>; Wed, 05 Feb 2020 07:56:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IICbPLkzo8MaWndOBew5rwV1mmT4EFse6Pod5CcwaLM=; b=RGzGNFPc5et1DrhK/C44tx7LQVsq6hDyjLk3cTL6MKvKSUV+A6C63s1SICKqSPy7ez njsvjSoRYbN6GT4t2+95fqLNDidYkvLQhL97PazRZknfZe/JuBV5yUrPwfaYuV5z7QOS uhPueZAMVh1M/hfD6Xfi36PwqhhJw3pnJVDYTn8uoFnBCqW8yXpxVc5yhtv5uIEtOzvi 3EWj28V9RoEGXYaCsYDVUQDNZi6YKsSJWV/7pBhAj3auenruo6bE7rX2OWwPQiwSJF9U vY04aXlREvdPrgPA8fFo+jiCZVZK+2eONJ9AwaFADPAhvs5n7VCkFlUpDRf2b2LdTuh1 eI3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IICbPLkzo8MaWndOBew5rwV1mmT4EFse6Pod5CcwaLM=; b=DG6eLcGVo+6NOJDY5BVel3WNXRP9pjMRhZaaY+8nRBIvvh7a0A4N8aL+ymmyuJztqh YkLNrqBzZ/CZjIzt4vhmJen8Ftn9LvvkUBOwyP66I5b8Ma2X4bK7+Z+wk6+8itox8g8f 1uu8SH22HTE//axjryjKjvw1h8PO3O4Lfyuh1lblq1SUf/ZyEthIR10vuGv9Ao0oq5cF 0IWBlfIzuR5T0sQ7CY1TbpjB4dsv1kMLo02yoow8p1x6X3lHG6a53KNZQhIG5OQEVes0 NRuueV0R6udlHtTkBx4UgVGUbCPJIkZ8WMTZJREnEran8izICk32uzmBt9//MEkfXvQ/ joYw== X-Gm-Message-State: APjAAAUCbzrKLZhaWoOR54hSk26LIXAi0rB3b3pv0yPVkCXlzhuuQ0h3 UcCIZkSXvMT0iCV2dbDhdcMIYPjOQRw= X-Google-Smtp-Source: APXvYqyvL+1gucUYyLm47//eHnaODp+OqHmlf1Kj+XFE+d7ZLvPc5ZUNOl6p4j2k6eHqrzlJVuicIQ== X-Received: by 2002:ac2:5922:: with SMTP id v2mr18031692lfi.106.1580918163476; Wed, 05 Feb 2020 07:56:03 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id n206sm12224916lfd.50.2020.02.05.07.56.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Feb 2020 07:56:02 -0800 (PST) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails To: Wolfgang Scherer , 39380@debbugs.gnu.org References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> From: Dmitry Gutov Message-ID: Date: Wed, 5 Feb 2020 18:56:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 04.02.2020 19:04, Wolfgang Scherer wrote: > Reverting de76a167dc09dc695a5acebabb7ab354a6bf556e does not change anything for me. > > I had to revert 06083cf41c473404d246de9b91a0116f38c5485f to resto [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: yandex.ru] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.51 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.51 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 39380 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 04.02.2020 19:04, Wolfgang Scherer wrote: > Reverting de76a167dc09dc695a5acebabb7ab354a6bf556e does not change anything for me. > > I had to revert 06083cf41c473404d246de9b91a0116f38c5485f to restore the correct behavior: > > Author: Dmitry Gutov > Date:   Sat Jan 30 06:55:32 2016 +0300 > >     Don't pass DIR to 'hg status' > >     * lisp/vc/vc-hg.el (vc-hg-dir-status-files): >     Don't pass DIR to 'hg status' (bug#22481). Good catch, thank you. Could you try this patch? diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el index c9a2cb412e..a91e1f5ad6 100644 --- a/lisp/vc/vc-hg.el +++ b/lisp/vc/vc-hg.el @@ -1352,14 +1352,14 @@ vc-hg-after-dir-status ;; Follows vc-exec-after. (declare-function vc-set-async-update "vc-dispatcher" (process-buffer)) -(defun vc-hg-dir-status-files (_dir files update-function) +(defun vc-hg-dir-status-files (dir files update-function) ;; XXX: We can't pass DIR directly to 'hg status' because that ;; returns all ignored files if FILES is non-nil (bug#22481). - ;; If honoring DIR ever becomes important, try using '-I DIR/'. - (vc-hg-command (current-buffer) 'async files - "status" - (concat "-mardu" (if files "i")) - "-C") + (let ((default-directory dir)) + (vc-hg-command (current-buffer) 'async files + "status" "re:" "-I" "." + (concat "-mardu" (if files "i")) + "-C")) (vc-run-delayed (vc-hg-after-dir-status update-function))) From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 06 08:25:34 2020 Received: (at 39380) by debbugs.gnu.org; 6 Feb 2020 13:25:34 +0000 Received: from localhost ([127.0.0.1]:47121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izh9y-00089m-Dc for submit@debbugs.gnu.org; Thu, 06 Feb 2020 08:25:34 -0500 Received: from mout.gmx.net ([212.227.15.19]:59525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izh9w-00089U-A7 for 39380@debbugs.gnu.org; Thu, 06 Feb 2020 08:25:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1580995526; bh=ASdwRmt7RxUqk705mJYNryfAsthbdzelGKZogCAyat8=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=HAGofPTChCxGgHJm6Arg60sUAqmT0aa9HTIfvHoh2Bwj1dp53DbnWcFWx6vIx2UTs kHYBVrn3XeTrBe9as7ZEumiFydUI9c+VNujsY/18pWaSwShbr5HA8ZHhMjztsyV3ih /LkaHMrD1P2XQcYK6HpNFIJCmMQ06dyHUO1F63lU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MNt0M-1jAkpi1L4K-00OJCK; Thu, 06 Feb 2020 14:25:26 +0100 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id A93F419431C9; Thu, 6 Feb 2020 14:25:25 +0100 (CET) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails To: Dmitry Gutov , 39380@debbugs.gnu.org References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> From: Wolfgang Scherer Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: <25183dd6-10b3-c3c4-0910-262c70434161@gmx.de> Date: Thu, 6 Feb 2020 14:25:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: de-DE X-Provags-ID: V03:K1:0OJCKCegSpvaYorZjWF1zfZtko+/BXPQIFp92y9PCpK8ic1N1tJ rVUGNb2R9C9VsHHTB/jGYN/Zt1tk94U4+iNmztXmdq2qck45Cc3Mo9FojhDuVrVoybSzSg1 TMyxe+P2RVTLyd5zE1U0y85iCmmIo/QqjKScJdCcWY+zTa3WoWMvj4pgQjUxXcDdjb20Tau XUy6cn3xByoZMonkTul5A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:mFpMiXBTGm8=:pIu8Z0IMxlmbxtRaz58HkG WECCm16uUv4lk+SSGXe1g08hXf2ofC43+h/KLrpQo9ZiyVXBktPiuJ6JqpglySr0uhKrMBv9S CvqWS32SA9qQfMS70nKRA5g0amBxt/xYn8NUokuxEv7XlvwisaHz5YAMmKcahRaGrjof7gOSM qCxC38PLxF7OdVPGGaawz18H1X+QCVm793LEZesBEIeVjLw6VfGcHcwz9fBtvaF5+NZKbsni8 Psoa4E/Ee6GAyHMI3bAeMBM8rdGaOA7fS5t+TKmLPj9Jil+Gw/PxezGucOU54j8mYrnQgLQfK WEuEiIhYw2GTxPxl6hC5DomesZveW7SY+OBUSKE9Ui0AvdAAK8E98fVYPx9PUVpcD5zOEtexg HudPpThhdBG2eR2422liXIY+FgObWXmKpQRnUkMB/Cw4flxy0PLBNktBZTGmDlvv0o0LIUyrx rPB/fi9nixzXnEJL0BvQNxhkIMsEN08SYubwUEk0vFsY4wJeawbG2J4xaxCqOlJWeDqrR43Uf a5zAHndYPb6caqrR2V53597B9dYcLBvNlFJ7IKqe0gHld2jpkZHopBCPGSK53Y+5ZYxLRKLqr LBxLAnwJsvpC+NHduPn57pKCsmp+2YFqTfuHE62gXqJmfRvz5n9IpFcau86NWKKCEfd0NPr/W v2y0b2SiVaZVQtGY2S1mCWMnKvCaiWMQ9QkL2Xy8mMGLyz9ym7V70q/egi/5Yq7RgAZTICsSu 7A54ck9a/SwCxPJ91MLUPvhk+KzbEwqK0yzf6pJjfG0npqgkJTSVsP1PEWEcswBpwLHVw5Y8S pi5cI42EJRD564Noy4AtL7SLDsBO4Trrt52vWhakn+RrsiAir+zGDKi5br+OpRA/Grf/rqv93 MjSliXeqQCAGpt/3eDY+tz5yRx5O7/lBDDf23JYxlxiMKh7w8Oldeg5Gz9mI92X0rHijrDOCu r+r2PvMKYgtSx0fkrJK3I0Xs+Gp91H64+KNZBspC015lijLlT1Z4D7DCLK1LZG+WFxyT/78Nj iOhPpTeFPua9doKXxAPiOq+jj4DlyPwgV0ajj+nZ/cNI1sgx1aFgTKlSe/hR58m1r8Uiozf7k obVTZ5etifAyASMzHMTWQQ8qgT/8QwlHm5oiYF0vTtXk7+mnVnabBVMN+rSlC4CFghWx8VVSL oT9I2KUJTcOjwV7QfyAiw15f0EAwalJs2teM14X7ANQPBNAwMCFJdumrb24A9KzNJTV4aJXHP ffekHcV0jRXWBo5ig X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39380 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Am 05.02.20 um 16:56 schrieb Dmitry Gutov: > On 04.02.2020 19:04, Wolfgang Scherer wrote: >> Reverting de76a167dc09dc695a5acebabb7ab354a6bf556e does not change anything for me. >> >> I had to revert 06083cf41c473404d246de9b91a0116f38c5485f to restore the correct behavior: >> > Good catch, thank you. Could you try this patch? > Works fine. Directory listing in vc-dir-mode is truncated at sub-directory. Files are processed correctly. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 06 08:39:07 2020 Received: (at 39380) by debbugs.gnu.org; 6 Feb 2020 13:39:07 +0000 Received: from localhost ([127.0.0.1]:47126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izhN4-0008TT-QG for submit@debbugs.gnu.org; Thu, 06 Feb 2020 08:39:06 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:45624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izhN2-0008Sy-4A for 39380@debbugs.gnu.org; Thu, 06 Feb 2020 08:39:04 -0500 Received: by mail-lj1-f193.google.com with SMTP id f25so6112317ljg.12 for <39380@debbugs.gnu.org>; Thu, 06 Feb 2020 05:39:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3yncM6oHR3WT495loF06kV6nGG1zfxnPZuyvJqdVI7c=; b=SFMKIB4vB/yKk9FU++YCBc8XgsF8iM/IAQKJMk+7rx3uKjIQ3axbUx5/P1k3eUSs3h igVuHFQLcuh3bPc6G861X20w6BCc1lzUKhuOCQkZubVuGIatoScP5EVLSAKzlfP7rZ6v YDK0T92Nzdlfn3oYbu9YW/3IoDgg+0RkUo6HCN6IfaOFpMtice3bQ1/yvEjIs2MVvZUt QyYeycqsRyEbwm5lj8y1QOmxQw5P0t4YXPqqsukw8BjBFXZRIPUVjyJ27KML7idMWLeN GGsHnY0FMgqK7p7w+MY0m0Z/th9ol97i0JZ33g61YCO085PNNWLa8DdWdL8tmqt60IsN Xzmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3yncM6oHR3WT495loF06kV6nGG1zfxnPZuyvJqdVI7c=; b=oHUr4OujiZoQ4sH8eh3RL4eITkEFi/BQDVo074ePt4cMP6MdyaO3IwPkYnpoxtN3DC RAyRqr2IHBF27qsID/R9kvQwGNoeVzpIqhsqFcwLZB6AGpARpLmYaLN5BOrgqu3Je5MF aJiz7U4S+LC1MUurrhk0khr9/Js17NkB7gVspab0Ur3ClgutyZMbApJZLPLgXcC1MSt6 cXfjRFOjx/zdKJzShxCzgIbsCL1+lhCqf0372SgXp8ATaJIVIQtHLRCVLlIUwqF+Hi2q ggo8VjU5O4RehdTsVweYmz9pwW85hvPm2kMtqqOVKX3T+CoTLQtWjjrpg4aE51x13RF9 N1Qg== X-Gm-Message-State: APjAAAVSKVa3lrgk+0kzrgWBd8/ApugN4LUjVMDK14KlCKpZYYmVGncE vY6sRXDgp/dqj8QosB98fVk= X-Google-Smtp-Source: APXvYqwl+90MhrmpgQ1buuIzs6WkvQ2FFcHISfcoonl9OLkUzZAu3WtEcOPbrMWI3ryFRRYvJkpGVg== X-Received: by 2002:a2e:8490:: with SMTP id b16mr2130634ljh.282.1580996338066; Thu, 06 Feb 2020 05:38:58 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id u9sm1419923ljk.33.2020.02.06.05.38.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Feb 2020 05:38:57 -0800 (PST) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails To: Wolfgang Scherer , 39380@debbugs.gnu.org References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> <25183dd6-10b3-c3c4-0910-262c70434161@gmx.de> From: Dmitry Gutov Message-ID: <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> Date: Thu, 6 Feb 2020 16:38:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <25183dd6-10b3-c3c4-0910-262c70434161@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 06.02.2020 16:25, Wolfgang Scherer wrote: > > Am 05.02.20 um 16:56 schrieb Dmitry Gutov: >> On 04.02.2020 19:04, Wolfgang Scherer wrote: >>> Reverting de76a167dc09dc695a5acebabb7ab354a6bf556e does [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.193 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.193 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 39380 Cc: Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 06.02.2020 16:25, Wolfgang Scherer wrote: > > Am 05.02.20 um 16:56 schrieb Dmitry Gutov: >> On 04.02.2020 19:04, Wolfgang Scherer wrote: >>> Reverting de76a167dc09dc695a5acebabb7ab354a6bf556e does not change anything for me. >>> >>> I had to revert 06083cf41c473404d246de9b91a0116f38c5485f to restore the correct behavior: >>> >> Good catch, thank you. Could you try this patch? >> > Works fine. Directory listing in vc-dir-mode is truncated at sub-directory. Files are processed correctly. Very good. Eli, I'd like to get it into emacs-27. OK? From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 07 04:54:00 2020 Received: (at 39380) by debbugs.gnu.org; 7 Feb 2020 09:54:00 +0000 Received: from localhost ([127.0.0.1]:48903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j00Km-0001zH-8u for submit@debbugs.gnu.org; Fri, 07 Feb 2020 04:54:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j00Kk-0001yv-Qe for 39380@debbugs.gnu.org; Fri, 07 Feb 2020 04:53:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j00Kf-00052m-37; Fri, 07 Feb 2020 04:53:53 -0500 Received: from [176.228.60.248] (port=3909 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j00Ke-00017B-CW; Fri, 07 Feb 2020 04:53:52 -0500 Date: Fri, 07 Feb 2020 11:53:32 +0200 Message-Id: <834kw2g1ur.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> (message from Dmitry Gutov on Thu, 6 Feb 2020 16:38:54 +0300) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> <25183dd6-10b3-c3c4-0910-262c70434161@gmx.de> <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39380 Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Cc: Eli Zaretskii > From: Dmitry Gutov > Date: Thu, 6 Feb 2020 16:38:54 +0300 > > >> Good catch, thank you. Could you try this patch? > >> > > Works fine. Directory listing in vc-dir-mode is truncated at sub-directory. Files are processed correctly. > > Very good. > > Eli, I'd like to get it into emacs-27. OK? I'll have to ask you to walk me through the change and explain how it solves the original issue. I tried to figure that out myself, but it's too hard: the patch has no log message, the function being changed has no doc string which could describe its contract, and the Mercurial documentation I've read seems to contradict what you are doing (e.g., it says "re:" should be immediately followed by a regexp). Sorry, I cannot make up my mind whether this is a safe change without understanding it better. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 07 06:03:31 2020 Received: (at 39380) by debbugs.gnu.org; 7 Feb 2020 11:03:31 +0000 Received: from localhost ([127.0.0.1]:48931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j01Q3-0004Zv-1s for submit@debbugs.gnu.org; Fri, 07 Feb 2020 06:03:31 -0500 Received: from mail-lf1-f44.google.com ([209.85.167.44]:38743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j01Q1-0004Zb-Ge for 39380@debbugs.gnu.org; Fri, 07 Feb 2020 06:03:29 -0500 Received: by mail-lf1-f44.google.com with SMTP id r14so1251818lfm.5 for <39380@debbugs.gnu.org>; Fri, 07 Feb 2020 03:03:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=w4wtz17QMaxUqtJOGDLny8jKxg/2AMjMEr9fOAVnUrM=; b=hliomobI5JcfRVijasWJHRYumvFqDu715wMIQmmr36betJcGpz6jMzHYloP6/AXqNP UG9mKdVv7/VK4aFgGgVENlTvwRyZTVBobp4WnjarLJB+M3tkbuhyW1kKMxljDyQEnez7 pZM14bX02w10zZlEo7TpnUslcxpoVXKhbcV/rU10sSD3Q21PRkVXhhCmrKJraagrIL9d mMCXOJLzKw+bIyQe9LaEWG8sV3DqbyBsZr4FxIV1l2C9MkJMUfGo83veXB9Ox/ZYBMXQ uV2cGyyNtW8s26ERVp491y/7uZzVcCdeEggLFY6OuQrHeTEnsFIfjnXJi62wlzQBX2Y9 20SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w4wtz17QMaxUqtJOGDLny8jKxg/2AMjMEr9fOAVnUrM=; b=Cuw/SAeV9PuzVoRRdQGD4TDoHmNJ9qfis6X+5UVLSDTsFLD6TPGzSLxbfZoUU6bP5W ii2KCjsBeZf97D+XrH3+fwNRRHlTDmjX9umXOsLq0SeiKFqTpGVbeccNjlDCxaVv+Flb m7sv5eaioyyQjbshaF30UdPx6YmUdgINhL5RruSPOWzCG7upyYXjr5cHpAne3/zOLNf5 p+W7F5Q2iEZ6c25rM8WR29FyVjsvUm/O+8Eqn0NiU4BbG2KZmZpWEO4j/sn8AfOGjaxn poQgVYUkfbBvhzzN4seLszKurLplNCJKP5AyENuDQlinppD9C7ZmYt0Dswd+6n6cJUf4 wRfQ== X-Gm-Message-State: APjAAAVvuM2cCxq1FID917lNDXFA3o5DEZeqHb4j6mZYse09VlMoxxCi a9vxYKF15d1ey9sHwAoxmvE= X-Google-Smtp-Source: APXvYqwo2AFaWZrFFwHe7tnrBMaSLbcyhw223v9f6Gh2o5RH/ybYYVetpyYt8RpjsGGxJiWvjxpcew== X-Received: by 2002:ac2:58fa:: with SMTP id v26mr4235333lfo.84.1581073403506; Fri, 07 Feb 2020 03:03:23 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id q24sm898692lfm.78.2020.02.07.03.03.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Feb 2020 03:03:22 -0800 (PST) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails To: Eli Zaretskii References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> <25183dd6-10b3-c3c4-0910-262c70434161@gmx.de> <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> <834kw2g1ur.fsf@gnu.org> From: Dmitry Gutov Message-ID: <38ea415e-9993-806c-3006-85e6e435fbd5@yandex.ru> Date: Fri, 7 Feb 2020 14:03:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <834kw2g1ur.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 07.02.2020 12:53, Eli Zaretskii wrote: > I'll have to ask you to walk me through the change and explain how it > solves the original issue. There are two changes: 1. Having the returned file names relative to the working dir instead of the repository root. For that, we change 'hg status' to 'hg status re:'. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: stackoverflow.com] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.44 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.44 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 39380 Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 07.02.2020 12:53, Eli Zaretskii wrote: > I'll have to ask you to walk me through the change and explain how it > solves the original issue. There are two changes: 1. Having the returned file names relative to the working dir instead of the repository root. For that, we change 'hg status' to 'hg status re:'. 2. Only including the files inside the working dir in the output. That happens by adding '-I .' to the arguments. Otherwise, Mercurial adds, in the presented scenario, an entry like '../sub2/x', which is extraneous. > the Mercurial documentation I've read seems > to contradict what you are doing (e.g., it says "re:" should be > immediately followed by a regexp). You can search the manual for "hg status re:". I agree it's a bit unclear (it also mentions "hg help patterns" for some reason), but here's an SO answer that got me this far: https://stackoverflow.com/a/46743585/615245 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 07 09:01:52 2020 Received: (at 39380) by debbugs.gnu.org; 7 Feb 2020 14:01:52 +0000 Received: from localhost ([127.0.0.1]:49022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j04Cd-0004Mq-Qz for submit@debbugs.gnu.org; Fri, 07 Feb 2020 09:01:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j04Cc-0004Mb-IX for 39380@debbugs.gnu.org; Fri, 07 Feb 2020 09:01:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j04CV-0008NA-Ea; Fri, 07 Feb 2020 09:01:45 -0500 Received: from [176.228.60.248] (port=3018 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j04CS-0003Db-0x; Fri, 07 Feb 2020 09:01:42 -0500 Date: Fri, 07 Feb 2020 16:00:52 +0200 Message-Id: <83v9oiebu3.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <38ea415e-9993-806c-3006-85e6e435fbd5@yandex.ru> (message from Dmitry Gutov on Fri, 7 Feb 2020 14:03:21 +0300) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> <25183dd6-10b3-c3c4-0910-262c70434161@gmx.de> <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> <834kw2g1ur.fsf@gnu.org> <38ea415e-9993-806c-3006-85e6e435fbd5@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39380 Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de > From: Dmitry Gutov > Date: Fri, 7 Feb 2020 14:03:21 +0300 > > On 07.02.2020 12:53, Eli Zaretskii wrote: > > I'll have to ask you to walk me through the change and explain how it > > solves the original issue. > > There are two changes: > > 1. Having the returned file names relative to the working dir instead of > the repository root. For that, we change 'hg status' to 'hg status re:'. Why do we want the file names to be relative? If default-directory of the buffer is set correctly, that shouldn't be necessary, and if the file names are absolute, then the default-directory doesn't even matter much. > 2. Only including the files inside the working dir in the output. That > happens by adding '-I .' to the arguments. Otherwise, Mercurial adds, in > the presented scenario, an entry like '../sub2/x', which is extraneous. This change should be in NEWS, IMO. > > the Mercurial documentation I've read seems > > to contradict what you are doing (e.g., it says "re:" should be > > immediately followed by a regexp). > > You can search the manual for "hg status re:". Which only finds a single example, where this notation is not explained at all (and which I already saw). > I agree it's a bit unclear (it also mentions "hg help patterns" for some > reason), but here's an SO answer that got me this far: > https://stackoverflow.com/a/46743585/615245 Isn't it disturbing that we are using a feature that doesn't seem to be documented? But to get to the issue at hand: you are saying that "C-x v d" in a subdirectory of the root of a Mercurial repository became broken in Emacs 25.1? Also, is DIR guaranteed to be the directory where FILES live? From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 07 20:20:36 2020 Received: (at 39380) by debbugs.gnu.org; 8 Feb 2020 01:20:36 +0000 Received: from localhost ([127.0.0.1]:50502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0EnU-0008LI-4b for submit@debbugs.gnu.org; Fri, 07 Feb 2020 20:20:36 -0500 Received: from mail-lj1-f180.google.com ([209.85.208.180]:45292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0EnS-0008L6-1N for 39380@debbugs.gnu.org; Fri, 07 Feb 2020 20:20:34 -0500 Received: by mail-lj1-f180.google.com with SMTP id f25so1200236ljg.12 for <39380@debbugs.gnu.org>; Fri, 07 Feb 2020 17:20:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WOHn+rIkEBxfKC4Q/Brk1IonDpehMREEWbGH9D8yo/k=; b=mP1wjbWldwgo3H2f+LPrOeD15NtyGl8JClwD/984NNbvqPqePahWDl3EhDyeBgdGch 8uqHW7E3ml1OoPIAcfmXDjdhw/Ozv4HPGRlE/291vFnT3TpM4liYDQdHXKhKoNrSDkkh zfUDy2BvOJuAe6RBA8lG+6ey0DMI+HAZlNyGUo3vQ+c46YIs5+fJv6g8oGCv4APe2Sw0 5AkyUs9DTwE7+iRan9Ws342Ig7BVniQSD45Ju9tnleItzwzZtUMM26CceT/V7m0By8Ih fDQGnOEaN+CTy92qtmFVC7+2707gUvHFTfQ7aONmPdlCcY6CRcVQwEA5NeeZXZdfUmJo k4mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WOHn+rIkEBxfKC4Q/Brk1IonDpehMREEWbGH9D8yo/k=; b=Ar0LAlRoGp3FnSZiS4whUcadC++jl1C+ewBXIQQ5CVskQ4f5y6lbx/u48ZdsGXJQ1I 8PN9/O79ouLRNxRQLuVNSEoFscrwrIvXlwPte5SSSOQamxH365RMQvJJwh6HvlDD6/fG 1DpFT/kjv/rOOl0mTSlby6yVUMA7MpJv2T2VqI8X6ag9hCzVVb0/e6sLfEMscz7FzsJA 6mlXF4k9qXknFZasiMvOtCO4xsptTqdI0+9JhueF12RevjwE55/OZvd38fBF1hxLy2JM /Hkkr7OQN4R+BgVB5vsHjyLiSpwnK5hzc9bYK9Q4VX2potgrhsn/fN+YIdMCd0vqvCz2 qXQw== X-Gm-Message-State: APjAAAWpLd7uOzj5DI54fRadPfqkrB18Pt7Lu7v++Z/tEfcscUCu3wru Qm+C9k02VDhOXlWb9ITt+bc= X-Google-Smtp-Source: APXvYqyh4NoSfOq8cABZvfqCmBKythh1zNth/9yvAp4NHUJxSBCL5KaiOb2xQ2VYFLWhADH9PkirMw== X-Received: by 2002:a2e:99da:: with SMTP id l26mr1117315ljj.272.1581124828020; Fri, 07 Feb 2020 17:20:28 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id t1sm2094714lji.98.2020.02.07.17.20.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Feb 2020 17:20:26 -0800 (PST) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails To: Eli Zaretskii References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> <25183dd6-10b3-c3c4-0910-262c70434161@gmx.de> <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> <834kw2g1ur.fsf@gnu.org> <38ea415e-9993-806c-3006-85e6e435fbd5@yandex.ru> <83v9oiebu3.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Sat, 8 Feb 2020 04:20:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83v9oiebu3.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 3.0 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 07.02.2020 17:00, Eli Zaretskii wrote: >> Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de >> From: Dmitry Gutov >> Date: Fri, 7 Feb 2020 14:03:21 +0300 >> >> On 07.02.2020 12:53, Eli Zaretskii [...] Content analysis details: (3.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: stackoverflow.com] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) -0.0 SPF_PASS SPF: sender matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.180 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 1.0 FREEMAIL_REPLY From and body contain different freemails X-Debbugs-Envelope-To: 39380 Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 07.02.2020 17:00, Eli Zaretskii wrote: >> Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de >> From: Dmitry Gutov >> Date: Fri, 7 Feb 2020 14:03:21 +0300 >> >> On 07.02.2020 12:53, Eli Zaretskii wrote: >>> I'll have to ask you to walk me through the change and explain how it >>> solves the original issue. >> >> There are two changes: >> >> 1. Having the returned file names relative to the working dir instead of >> the repository root. For that, we change 'hg status' to 'hg status re:'. > > Why do we want the file names to be relative? If default-directory of > the buffer is set correctly, that shouldn't be necessary, and if the > file names are absolute, then the default-directory doesn't even > matter much. They are already relative, but against the repository root. And people want to open vc-dir buffers in any directory, not just in repository roots. We could force the file names to be absolute, and then pipe them through file-relative-name, but that's just extra work. >> 2. Only including the files inside the working dir in the output. That >> happens by adding '-I .' to the arguments. Otherwise, Mercurial adds, in >> the presented scenario, an entry like '../sub2/x', which is extraneous. > > This change should be in NEWS, IMO. It's a bugfix for an older, unintended change. It's not a new behavior. >>> the Mercurial documentation I've read seems >>> to contradict what you are doing (e.g., it says "re:" should be >>> immediately followed by a regexp). >> >> You can search the manual for "hg status re:". > > Which only finds a single example, where this notation is not > explained at all (and which I already saw). Not my fault. >> I agree it's a bit unclear (it also mentions "hg help patterns" for some >> reason), but here's an SO answer that got me this far: >> https://stackoverflow.com/a/46743585/615245 > > Isn't it disturbing that we are using a feature that doesn't seem to > be documented? It's been there for enough years, and it's the best choice I've found so far. > But to get to the issue at hand: you are saying that "C-x v d" in a > subdirectory of the root of a Mercurial repository became broken in > Emacs 25.1? > > Also, is DIR guaranteed to be the directory where FILES live? Yes, see the description of dir-status-files in the top commentary in vc.el. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 03:04:51 2020 Received: (at 39380) by debbugs.gnu.org; 8 Feb 2020 08:04:51 +0000 Received: from localhost ([127.0.0.1]:50576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0L6h-0001Ik-AQ for submit@debbugs.gnu.org; Sat, 08 Feb 2020 03:04:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0L6e-0001IU-GQ for 39380@debbugs.gnu.org; Sat, 08 Feb 2020 03:04:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j0L6Z-0006PL-12; Sat, 08 Feb 2020 03:04:43 -0500 Received: from [176.228.60.248] (port=1577 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j0L6Y-0005Z6-Dq; Sat, 08 Feb 2020 03:04:42 -0500 Date: Sat, 08 Feb 2020 10:04:23 +0200 Message-Id: <83k14xec8o.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Sat, 8 Feb 2020 04:20:26 +0300) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> <25183dd6-10b3-c3c4-0910-262c70434161@gmx.de> <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> <834kw2g1ur.fsf@gnu.org> <38ea415e-9993-806c-3006-85e6e435fbd5@yandex.ru> <83v9oiebu3.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39380 Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de > From: Dmitry Gutov > Date: Sat, 8 Feb 2020 04:20:26 +0300 > > On 07.02.2020 17:00, Eli Zaretskii wrote: > >> Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de > >> From: Dmitry Gutov > >> Date: Fri, 7 Feb 2020 14:03:21 +0300 > >> > >> On 07.02.2020 12:53, Eli Zaretskii wrote: > >>> I'll have to ask you to walk me through the change and explain how it > >>> solves the original issue. > >> > >> There are two changes: > >> > >> 1. Having the returned file names relative to the working dir instead of > >> the repository root. For that, we change 'hg status' to 'hg status re:'. > > > > Why do we want the file names to be relative? If default-directory of > > the buffer is set correctly, that shouldn't be necessary, and if the > > file names are absolute, then the default-directory doesn't even > > matter much. > > They are already relative, but against the repository root. > > And people want to open vc-dir buffers in any directory, not just in > repository roots. If I say "hg status" in a subdirectory, I by default get file names relative to the root. Wouldn't Mercurial users be surprised that Emacs produces a different display? (I understand that there's a recent tendency to make it easier to produce relative file names, and there's even a config option to make that the default, but I'm asking whether we should force this behavior on users even if their preference is not to.) > We could force the file names to be absolute, and then pipe them through > file-relative-name, but that's just extra work. I'm more bothered by the user-facing changes in this respect than by algorithmic details. Would it work to set the default-directory of the buffer to the repository's root instead? would that solve the original problem? If setting the default-directory could be a solution, I'd prefer doing that on the release branch, so that user-facing behavior is unchanged. We could then make changes on master to offer a defcustom that is parallel to the commands.status.relative config setting, and if that's set to prefer relative names, use your modified code. WDYT? > > This change should be in NEWS, IMO. > > It's a bugfix for an older, unintended change. It's not a new behavior. It changes how files are presented to the user, so I think it has user-visible effects that should be mentioned in NEWS. > > Also, is DIR guaranteed to be the directory where FILES live? > > Yes, see the description of dir-status-files in the top commentary in vc.el. Thanks. What about this question: > you are saying that "C-x v d" in a subdirectory of the root of a > Mercurial repository became broken in Emacs 25.1? From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 04:36:56 2020 Received: (at 39380) by debbugs.gnu.org; 8 Feb 2020 09:36:56 +0000 Received: from localhost ([127.0.0.1]:50619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0MXn-0003Vt-QS for submit@debbugs.gnu.org; Sat, 08 Feb 2020 04:36:56 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:39309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0MXm-0003Vh-3K for 39380@debbugs.gnu.org; Sat, 08 Feb 2020 04:36:54 -0500 Received: by mail-lj1-f195.google.com with SMTP id o15so1869596ljg.6 for <39380@debbugs.gnu.org>; Sat, 08 Feb 2020 01:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Aya3ADhM1v9LTCrDs+baHGxdvIo1j4aI4vHLfTKcTVY=; b=BkJQGXSaytDw6xOk2Fca68NytIpinat8QMYLWg5E1/etTYX7+RHM0t1TKEJr9Yx5G4 atsmFh1A6aywUbuJjq+CzrPl6gQ2DbqR0LtpRuTtIXOr418cgCWEUqu9blqS9chU8/Wk sxz4wp+GgVOWHLOylqBymOx6aaRhmoj1T2nav0d6fimy1gsXv9Xmj58Jp5IEKxUiXRCY DyjeduWauLFY4iv1VbqXczErDpMs6hza0IfJzWRGEPJn4M/3c0z7Z42ygA3LDv+5Cl8a Gt0mi2l6xOmuafhCvstL9DE39RBkeddUM7taH/uZ+oWrozgVfWIQhtoJp1RjL86Lh+uK QWcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Aya3ADhM1v9LTCrDs+baHGxdvIo1j4aI4vHLfTKcTVY=; b=Tf0jzWz7VO4EpjtBhV2Xz3xG9SjOUJNC0ZNKXHSCRTrL4TZdXA4IvRQYbM2P7J5Q9+ 5Ndnw/0B4TAydgMNXLlwU9GNcJUlw5mLUEOyYSJJAoPKLDWpx/3dD9L0SBbNaE7hCy0e ANXyw3mzQFO6wBRiUDgwsnKd032i94r2bKVXWGxHjTCF2pE9ho2x2NSgKy2jsTwS52i1 hyTTH4fsL3a/B4Uh7z2E0e3qhuKZkT55aoGl3wsvUTc77mHMw2bEMRYzJALHrFDF3zfo JFNLBhuluJYGsCf7qgYKQmXeb1vgThLLSgV6+10lAJbgZfm7oIc//FTtNT1uYgXuR2Iq 2a9A== X-Gm-Message-State: APjAAAXUDDgIACxo77HQ+hfPywnYfF5rCe+u9sdzUZzjNt4SMjvtcAW3 Dhw3v7lm0AoNLHDwQdjJ/kE= X-Google-Smtp-Source: APXvYqzIXSAEyIp0hQdiaCY+CX6uIQfxF7rz5J5y0ZZvzSPui7nroggMFopmQg85qxOJGkdukDluAA== X-Received: by 2002:a2e:918c:: with SMTP id f12mr2099893ljg.66.1581154607996; Sat, 08 Feb 2020 01:36:47 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id t10sm2707681lji.61.2020.02.08.01.36.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Feb 2020 01:36:47 -0800 (PST) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails To: Eli Zaretskii References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> <25183dd6-10b3-c3c4-0910-262c70434161@gmx.de> <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> <834kw2g1ur.fsf@gnu.org> <38ea415e-9993-806c-3006-85e6e435fbd5@yandex.ru> <83v9oiebu3.fsf@gnu.org> <83k14xec8o.fsf@gnu.org> From: Dmitry Gutov Message-ID: <092bcdf9-c866-9eb0-b249-60381d445731@yandex.ru> Date: Sat, 8 Feb 2020 12:36:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83k14xec8o.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 08.02.2020 11:04, Eli Zaretskii wrote: >> And people want to open vc-dir buffers in any directory, not just in >> repository roots. > > If I say "hg status" in a subdirectory, I by default get file names > relative to the root. Wouldn't Me [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) -0.0 SPF_PASS SPF: sender matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.195 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.195 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 39380 Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 08.02.2020 11:04, Eli Zaretskii wrote: >> And people want to open vc-dir buffers in any directory, not just in >> repository roots. > > If I say "hg status" in a subdirectory, I by default get file names > relative to the root. Wouldn't Mercurial users be surprised that > Emacs produces a different display? (I understand that there's a > recent tendency to make it easier to produce relative file names, and > there's even a config option to make that the default, but I'm asking > whether we should force this behavior on users even if their > preference is not to.) VC is intended to provide a unified interface across backends, even if it's at times different from the "native" behaviors. Anyway, it's very easy to get the names against the root anyway: just open VC-Dir there. And it's the default input: M-x vc-dir RET. >> We could force the file names to be absolute, and then pipe them through >> file-relative-name, but that's just extra work. > > I'm more bothered by the user-facing changes in this respect than by > algorithmic details. Would it work to set the default-directory of > the buffer to the repository's root instead? would that solve the > original problem? Again, it's a bugfix. VC-Dir expects this, other backends work like this, and vc-hg worked like this until Emacs 24 or 25. And the present behavior makes VC-Dir have broken behavior. There are only two possible reasons the buggy behavior wasn't noticed: a) Hg users are a minority among our users, b) most people open VC-Dir in repository root anyway. IOW, the difference wasn't triggered/seen. >>> This change should be in NEWS, IMO. >> >> It's a bugfix for an older, unintended change. It's not a new behavior. > > It changes how files are presented to the user, so I think it has > user-visible effects that should be mentioned in NEWS. I don't mind adding some NEWS entry, but, like said above, the users likely didn't see the change. > What about this question: > >> you are saying that "C-x v d" in a subdirectory of the root of a >> Mercurial repository became broken in Emacs 25.1? Yes. :-( From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 05:11:45 2020 Received: (at 39380) by debbugs.gnu.org; 8 Feb 2020 10:11:45 +0000 Received: from localhost ([127.0.0.1]:50660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0N5V-0004M2-81 for submit@debbugs.gnu.org; Sat, 08 Feb 2020 05:11:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0N5T-0004Lq-1R for 39380@debbugs.gnu.org; Sat, 08 Feb 2020 05:11:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j0N5N-0007lZ-FZ; Sat, 08 Feb 2020 05:11:37 -0500 Received: from [176.228.60.248] (port=1467 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j0N5M-0007qp-Ve; Sat, 08 Feb 2020 05:11:37 -0500 Date: Sat, 08 Feb 2020 12:11:18 +0200 Message-Id: <837e0xe6d5.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <092bcdf9-c866-9eb0-b249-60381d445731@yandex.ru> (message from Dmitry Gutov on Sat, 8 Feb 2020 12:36:46 +0300) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> <25183dd6-10b3-c3c4-0910-262c70434161@gmx.de> <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> <834kw2g1ur.fsf@gnu.org> <38ea415e-9993-806c-3006-85e6e435fbd5@yandex.ru> <83v9oiebu3.fsf@gnu.org> <83k14xec8o.fsf@gnu.org> <092bcdf9-c866-9eb0-b249-60381d445731@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39380 Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de > From: Dmitry Gutov > Date: Sat, 8 Feb 2020 12:36:46 +0300 > > > If I say "hg status" in a subdirectory, I by default get file names > > relative to the root. Wouldn't Mercurial users be surprised that > > Emacs produces a different display? (I understand that there's a > > recent tendency to make it easier to produce relative file names, and > > there's even a config option to make that the default, but I'm asking > > whether we should force this behavior on users even if their > > preference is not to.) > > VC is intended to provide a unified interface across backends, even if > it's at times different from the "native" behaviors. > > Anyway, it's very easy to get the names against the root anyway: just > open VC-Dir there. And it's the default input: M-x vc-dir RET. OK. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 11 17:36:25 2020 Received: (at 39380-done) by debbugs.gnu.org; 11 Feb 2020 22:36:25 +0000 Received: from localhost ([127.0.0.1]:57691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1e8n-0002PQ-Bi for submit@debbugs.gnu.org; Tue, 11 Feb 2020 17:36:25 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:38837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1e8l-0002P8-3L for 39380-done@debbugs.gnu.org; Tue, 11 Feb 2020 17:36:23 -0500 Received: by mail-wm1-f67.google.com with SMTP id a9so5739686wmj.3 for <39380-done@debbugs.gnu.org>; Tue, 11 Feb 2020 14:36:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YV8QPsK6jCRr/Foq8fTc5pvFBkO71SwTrRDJB2cWIxc=; b=TtP5Wb/MhhFlFtm+ZNcfdnzd/gqDJXwoH1QwrpY2tE4iXNY9fsRFS+hoWNjo5z4igZ leO1MwfdLN7pyYp8zKmDIMinGK/HTyfelRdnDAtK4KiQWRsg1/vT3FNrdKeTbDbJ6eru X0+fGX3WiO+ghcyexBq2hirgUrSKd5nxjUN0vc9H6yO/XbY+GrZe08zKs6nVq9QKNtU8 AzAEg/Bq/BXWW8TbfC5wh4AXCa5WpibfHE/LR4X1+pdlPpYViV+psO0KR8VA4XvKgqGn 3Q0VRRiqRIyd8ClDfuRfYOgu6ESrhpxznzns+rpsNjf7Xv2aH/CCr9f0kkClv4eFQToD u07A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YV8QPsK6jCRr/Foq8fTc5pvFBkO71SwTrRDJB2cWIxc=; b=P2yHqfUR0pqkoK1vmtameMEeiIj9eXJnGFQlRcXrdcG0RCio65nCO0jz4fc0x3Ogkf 3JQ0zJkKmn88bK3vkq4G+Bk13CnC2Xjf4XXCf/KbcQlDCRrDdHsZW3oeUFOnFQV2R0d2 JMZp6LupI82CFjsW5p8NcgHrMRIsrkk9JKfPqUoyYH4OTJBN3bCmqBZ9RkvSxLlQHCse ePBUFUkNgU2OjgMGr294kcW15e7tqra3DK1iEGmxaMVIqMnQVCXuNnOkenqoijLvfMGR S8n6hlgOEUtyuA7BEEBL0qe/NDCQfJTV9FrpGk0EHq9mckGaaZLxNQ3hxQFPbQlblS1W Lwhw== X-Gm-Message-State: APjAAAXpEWiR5HHQpMkA1lnXFfvn4J8WqZlUIYTmEOJ6owZviy1TRcaH YtchVpMtB7SMrkbX7I0L5HRaxB6ZHFs= X-Google-Smtp-Source: APXvYqxaDW+ib0zXvHOEZEvuya9DvME2zI3Y4B9/jRcqHOgLAjhz/4wOIVZkK5sIlLNjkhkt7CK/Ig== X-Received: by 2002:a1c:e246:: with SMTP id z67mr8648714wmg.52.1581460577440; Tue, 11 Feb 2020 14:36:17 -0800 (PST) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id l8sm5690606wmj.2.2020.02.11.14.36.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Feb 2020 14:36:16 -0800 (PST) Subject: Re: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails To: Eli Zaretskii References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> <25183dd6-10b3-c3c4-0910-262c70434161@gmx.de> <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> <834kw2g1ur.fsf@gnu.org> <38ea415e-9993-806c-3006-85e6e435fbd5@yandex.ru> <83v9oiebu3.fsf@gnu.org> <83k14xec8o.fsf@gnu.org> <092bcdf9-c866-9eb0-b249-60381d445731@yandex.ru> <837e0xe6d5.fsf@gnu.org> From: Dmitry Gutov Message-ID: <1d6bc78f-fddd-8b9e-cf3a-296b87a422f7@yandex.ru> Date: Wed, 12 Feb 2020 00:36:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <837e0xe6d5.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Version: 27.1 On 08.02.2020 12:11, Eli Zaretskii wrote: >> Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de >> From: Dmitry Gutov >> Date: Sat, 8 Feb 2020 12:36:46 +0300 >> >>> If I say "hg status" in a subdire [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.67 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.67 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 1.0 FREEMAIL_REPLY From and body contain different freemails X-Debbugs-Envelope-To: 39380-done Cc: 39380-done@debbugs.gnu.org, Wolfgang.Scherer@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Version: 27.1 On 08.02.2020 12:11, Eli Zaretskii wrote: >> Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de >> From: Dmitry Gutov >> Date: Sat, 8 Feb 2020 12:36:46 +0300 >> >>> If I say "hg status" in a subdirectory, I by default get file names >>> relative to the root. Wouldn't Mercurial users be surprised that >>> Emacs produces a different display? (I understand that there's a >>> recent tendency to make it easier to produce relative file names, and >>> there's even a config option to make that the default, but I'm asking >>> whether we should force this behavior on users even if their >>> preference is not to.) >> >> VC is intended to provide a unified interface across backends, even if >> it's at times different from the "native" behaviors. >> >> Anyway, it's very easy to get the names against the root anyway: just >> open VC-Dir there. And it's the default input: M-x vc-dir RET. > > OK. Taking this as the approval of the patch, pushed. Using "re:" adds a bit of a performance overhead, but it's probably not really noticeable on small-to-medium projects (and on a big one it was ~100ms where without it dir-status-files takes ~1s). From unknown Sat Jun 14 19:35:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 11 Mar 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator