GNU bug report logs - #39373
27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding

Previous Next

Full log

Message #29 received at 39373 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mattias Engdegård <mattiase <at> acm.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 39373 <at> debbugs.gnu.org
Subject: Re: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with
 lexical-binding
Date: Sat, 01 Feb 2020 21:28:14 +0200

> From: Mattias Engdegård <mattiase <at> acm.org>
> Date: Sat, 1 Feb 2020 20:24:56 +0100
> Cc: 39373 <at> debbugs.gnu.org
> 
> It all seems rather fragile to me, and I'd rather add a note about not using add-to-list for lexical variables to its doc string and the manual, and fix all the calls listed above.

I tend to agree.  Stefan, any comments?

> Two patches attached: a doc update, and a replacement of add-to-list in the cases listed above.

LGTM, on both counts, but let's hear from Stefan (and others, if
someone has an opinion).

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.