From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2020 17:41:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 39373@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158049242127168 (code B ref -1); Fri, 31 Jan 2020 17:41:03 +0000 Received: (at submit) by debbugs.gnu.org; 31 Jan 2020 17:40:21 +0000 Received: from localhost ([127.0.0.1]:38027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixaHF-000748-KN for submit@debbugs.gnu.org; Fri, 31 Jan 2020 12:40:21 -0500 Received: from lists.gnu.org ([209.51.188.17]:55449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixaHD-000740-KD for submit@debbugs.gnu.org; Fri, 31 Jan 2020 12:40:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39366) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixaHC-0001hU-9d for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 12:40:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50,KHOP_HELO_FCRDNS, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixaHB-0005PF-5N for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 12:40:18 -0500 Received: from mail1441c50.megamailservers.eu ([91.136.14.41]:44958 helo=mail264c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ixaHA-0005FH-MM for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 12:40:17 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1580490484; bh=j9dVjvq/qwFNchNmsHbiqfYRTS4Ygcr6rLO/yAN1VDE=; h=From:Subject:Date:To:From; b=q1mUVlYVI169KcHd/A/eoiXxyRswuEQ0qKJje7NlTAZmAvaCeO4kmW9QylLb41XcA bdN0I3T8TVxpA4hIv01Da6TXobKS9J5MPA3rQ8suGTcl9TBq5MhJ01f/D7eXoc6l6P JeJ05+/ealb7wsqKTWDkSBehncQa0maPmV96qgGk= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-6f4fe655.032-75-73746f71.bbcust.telenor.se [85.230.79.111]) (authenticated bits=0) by mail264c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 00VH81El005851 for ; Fri, 31 Jan 2020 17:08:03 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_C00920C9-4DFC-491E-ABCE-040BE57CED9C" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Message-Id: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> Date: Fri, 31 Jan 2020 18:08:01 +0100 X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020E.5E345EF4.000D, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=ar3M9hRV c=1 sm=1 tr=0 a=fHaj9vQUQVKQ4sUldAaXuQ==:117 a=fHaj9vQUQVKQ4sUldAaXuQ==:17 a=M51BFTxLslgA:10 a=_iGz7pHDUnD4zqnyQnUA:9 a=CjuIK1q_8ugA:10 a=1z7mGcGWJNLIE_uD8nEA:9 a=B2y7HmGcmWMA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.14.41 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_C00920C9-4DFC-491E-ABCE-040BE57CED9C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 'mode-local-print-bindings' in mode-local.el seems to be broken since = the file was converted to lexical binding. Straightforward patch attached -- acceptable for emacs-27? (It's a = regression from Emacs 26.) --Apple-Mail=_C00920C9-4DFC-491E-ABCE-040BE57CED9C Content-Disposition: attachment; filename=0001-Fix-describe-mode-local-bindings-lexical-binding-dam.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-describe-mode-local-bindings-lexical-binding-dam.patch" Content-Transfer-Encoding: quoted-printable =46rom=20ded807b01792e966a4ce4905cc3ed2483c52294a=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Fri,=2031=20Jan=202020=2017:37:17=20+0100=0A= Subject:=20[PATCH]=20Fix=20describe-mode-local-bindings=20= lexical-binding=20damage=0A=0A*=20lisp/cedet/mode-local.el=20= (mode-local-print-bindings):=0ARepair=20code=20that=20relied=20on=20= dynamic=20binding.=0A---=0A=20lisp/cedet/mode-local.el=20|=2013=20= +++++--------=0A=201=20file=20changed,=205=20insertions(+),=208=20= deletions(-)=0A=0Adiff=20--git=20a/lisp/cedet/mode-local.el=20= b/lisp/cedet/mode-local.el=0Aindex=20a6e143cfcd..70ed62f4fb=20100644=0A= ---=20a/lisp/cedet/mode-local.el=0A+++=20b/lisp/cedet/mode-local.el=0A@@=20= -819,14=20+819,11=20@@=20mode-local-print-bindings=0A=20=20=20=20=20=20=20= =20=20)=0A=20=20=20=20=20;;=20Order=20symbols=20by=20type=0A=20=20=20=20=20= (mapatoms=0A-=20=20=20=20=20#'(lambda=20(s)=0A-=20=20=20=20=20=20=20=20=20= (add-to-list=20(cond=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20((get=20s=20'mode-variable-flag)=0A-=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(if=20(get=20s=20= 'constant-flag)=20'mc=20'mv))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20((get=20s=20'override-flag)=0A-=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(if=20(get=20s=20= 'constant-flag)=20'fo=20'ov))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20('us))=0A-=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20s))=0A+=20=20=20=20=20(lambda=20(s)=20= (push=20s=20(cond=20((get=20s=20'mode-variable-flag)=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(if=20(get=20s=20'constant-flag)=20mc=20mv))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= ((get=20s=20'override-flag)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(if=20(get=20s=20= 'constant-flag)=20fo=20ov))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(t=20us))))=0A=20=20=20= =20=20=20table)=0A=20=20=20=20=20;;=20Print=20symbols=20by=20type=0A=20=20= =20=20=20(when=20us=0A--=20=0A2.21.1=20(Apple=20Git-122.3)=0A=0A= --Apple-Mail=_C00920C9-4DFC-491E-ABCE-040BE57CED9C-- From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2020 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.158049889512248 (code B ref 39373); Fri, 31 Jan 2020 19:29:02 +0000 Received: (at 39373) by debbugs.gnu.org; 31 Jan 2020 19:28:15 +0000 Received: from localhost ([127.0.0.1]:38105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixbxe-0003BU-Uv for submit@debbugs.gnu.org; Fri, 31 Jan 2020 14:28:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixbxe-0003BI-3a for 39373@debbugs.gnu.org; Fri, 31 Jan 2020 14:28:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixbxY-0008Ow-Rq; Fri, 31 Jan 2020 14:28:08 -0500 Received: from [176.228.60.248] (port=4734 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixbxY-0007vi-5X; Fri, 31 Jan 2020 14:28:08 -0500 Date: Fri, 31 Jan 2020 21:27:48 +0200 Message-Id: <83lfpnjuiz.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Fri, 31 Jan 2020 18:08:01 +0100) References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Mattias Engdegård > Date: Fri, 31 Jan 2020 18:08:01 +0100 > > Straightforward patch attached -- acceptable for emacs-27? If you find an easier way of fixing it, yes. From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2020 19:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.158049949613183 (code B ref 39373); Fri, 31 Jan 2020 19:39:01 +0000 Received: (at 39373) by debbugs.gnu.org; 31 Jan 2020 19:38:16 +0000 Received: from localhost ([127.0.0.1]:38114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixc7L-0003QY-TU for submit@debbugs.gnu.org; Fri, 31 Jan 2020 14:38:16 -0500 Received: from mail200c50.megamailservers.eu ([91.136.10.210]:39106 helo=mail193c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixc7J-0003QP-DW for 39373@debbugs.gnu.org; Fri, 31 Jan 2020 14:38:14 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1580499491; bh=baZkEUMhOgxf6po7d9FSFSghMqi3AuZ/AFX7UkIqBfw=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=VCguVTieQXjsKJWFriF3PHakQiq+3am+50T7GzTh/HLmSE0RIZ8jl7sznJ77AGN5Y omBbe2oV2G+73+kXs8FaEtOY10gMpoMqK42e6/vDNIh8lNJ8So0pyFUlZAzpRbPLPF /bEyYEJ51SzRd8skR/L2eOvYhtBng5U+GN9uKCSc= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-6f4fe655.032-75-73746f71.bbcust.telenor.se [85.230.79.111]) (authenticated bits=0) by mail193c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 00VJc9cg020888; Fri, 31 Jan 2020 19:38:11 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <83lfpnjuiz.fsf@gnu.org> Date: Fri, 31 Jan 2020 20:38:08 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020A.5E348223.0029, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=SamJicZu c=1 sm=1 tr=0 a=fHaj9vQUQVKQ4sUldAaXuQ==:117 a=fHaj9vQUQVKQ4sUldAaXuQ==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=A4sP0x89I38mjJJ8kEcA:9 a=CjuIK1q_8ugA:10 a=ncZ9vwaUYPMA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 31 jan. 2020 kl. 20.27 skrev Eli Zaretskii : > If you find an easier way of fixing it, yes. Sorry if I'm misunderstanding you, but the patch just replaces = 'add-to-list' with 'push' -- is that not easy enough? From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2020 20:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.158050233417682 (code B ref 39373); Fri, 31 Jan 2020 20:26:01 +0000 Received: (at 39373) by debbugs.gnu.org; 31 Jan 2020 20:25:34 +0000 Received: from localhost ([127.0.0.1]:38154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixcr8-0004b7-4T for submit@debbugs.gnu.org; Fri, 31 Jan 2020 15:25:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixcr6-0004as-07 for 39373@debbugs.gnu.org; Fri, 31 Jan 2020 15:25:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixcr0-0003la-R3; Fri, 31 Jan 2020 15:25:26 -0500 Received: from [176.228.60.248] (port=4234 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixcqz-0001G0-HX; Fri, 31 Jan 2020 15:25:26 -0500 Date: Fri, 31 Jan 2020 22:25:06 +0200 Message-Id: <83imkrjrvh.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Fri, 31 Jan 2020 20:38:08 +0100) References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Mattias Engdegård > Date: Fri, 31 Jan 2020 20:38:08 +0100 > Cc: 39373@debbugs.gnu.org > > 31 jan. 2020 kl. 20.27 skrev Eli Zaretskii : > > > If you find an easier way of fixing it, yes. > > Sorry if I'm misunderstanding you, but the patch just replaces 'add-to-list' with 'push' -- is that not easy enough? That's not the "usual" way of fixing problems with lexical-binding, and it isn't immediately clear to me why that fixes the problem. From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2020 20:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.158050392020028 (code B ref 39373); Fri, 31 Jan 2020 20:52:02 +0000 Received: (at 39373) by debbugs.gnu.org; 31 Jan 2020 20:52:00 +0000 Received: from localhost ([127.0.0.1]:38163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixdGi-0005Cy-IJ for submit@debbugs.gnu.org; Fri, 31 Jan 2020 15:52:00 -0500 Received: from mail1452c50.megamailservers.eu ([91.136.14.52]:48884 helo=mail266c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixdGf-0005Ci-Ky for 39373@debbugs.gnu.org; Fri, 31 Jan 2020 15:51:58 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1580503910; bh=lLIiawQkyOfDQ44mDYjtG4+mx8tw54ABAfeIt57hgkU=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=epA63VZIsTiobJc3K5ksiVFjYt3wZ7xbSlsdEilXxF09/cO54H0NzgucUEno919SA 79H5463xR1zcctdYYJ+KM4em1JNi3k3vyzCeyNR9WVASGz0lMu56jfQ4E8+rComFf5 snBbrdcvnAUzKJbSLV5wOf136Vdbl0AH+AVFsXS4= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-6f4fe655.032-75-73746f71.bbcust.telenor.se [85.230.79.111]) (authenticated bits=0) by mail266c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 00VKpmNp000978; Fri, 31 Jan 2020 20:51:50 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <83imkrjrvh.fsf@gnu.org> Date: Fri, 31 Jan 2020 21:51:48 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020A.5E349366.0034, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=PNJxBsiC c=1 sm=1 tr=0 a=fHaj9vQUQVKQ4sUldAaXuQ==:117 a=fHaj9vQUQVKQ4sUldAaXuQ==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=GumZ9bsJRw_c3x8tsY0A:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 31 jan. 2020 kl. 21.25 skrev Eli Zaretskii : > That's not the "usual" way of fixing problems with lexical-binding, > and it isn't immediately clear to me why that fixes the problem. 'add-to-list' doesn't work on lexical variables because it's a plain function taking the variable symbol as argument. 'push' works on lexical variables since it is a macro that expands to direct varia [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.3 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 31 jan. 2020 kl. 21.25 skrev Eli Zaretskii : > That's not the "usual" way of fixing problems with lexical-binding, > and it isn't immediately clear to me why that fixes the problem. 'add-to-list' doesn't work on lexical variables because it's a plain = function taking the variable symbol as argument. 'push' works on lexical = variables since it is a macro that expands to direct variable reference = and setq. I should perhaps have included this in the commit message. Happily, Emacs provides generalised variable support for 'if' and = 'cons', so that they can be used as target for 'push'. We could sink the pushes to the leaves of the condition tree, if you = prefer: (cond ((get s 'mode-variable-flag) (if (get s 'constant-flag) (push s mc) (push s mv))) ((get s 'override-flag) (if (get s 'constant-flag) (push s fo) (push s ov))) (t (push s us))) Not as elegant or concise, but does not rely on if and cond as GVs in = push. From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Feb 2020 07:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.158054332515444 (code B ref 39373); Sat, 01 Feb 2020 07:49:02 +0000 Received: (at 39373) by debbugs.gnu.org; 1 Feb 2020 07:48:45 +0000 Received: from localhost ([127.0.0.1]:38312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixnWG-000412-W6 for submit@debbugs.gnu.org; Sat, 01 Feb 2020 02:48:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixnWF-00040q-0X for 39373@debbugs.gnu.org; Sat, 01 Feb 2020 02:48:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixnW9-00006H-Ni; Sat, 01 Feb 2020 02:48:37 -0500 Received: from [176.228.60.248] (port=1826 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixnW9-0002FN-5z; Sat, 01 Feb 2020 02:48:37 -0500 Date: Sat, 01 Feb 2020 09:48:19 +0200 Message-Id: <83eevekat8.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Fri, 31 Jan 2020 21:51:48 +0100) References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Mattias Engdegård > Date: Fri, 31 Jan 2020 21:51:48 +0100 > Cc: 39373@debbugs.gnu.org > > 'add-to-list' doesn't work on lexical variables because it's a plain > function taking the variable symbol as argument. 'push' works on > lexical variables since it is a macro that expands to direct > variable reference and setq. If that's the case, then why don't we say that loud and clear in the ELisp manual? (The doc string of add-to-list has some vague recommendation, not sure if it really talks about this aspect, but that's definitely not enough for such a serious issue.) And doesn't it mean we should audit all the gazillion uses of add-to-list in our sources, and do that urgently? > I should perhaps have included this in the commit message. That would have definitely helped, thanks. > We could sink the pushes to the leaves of the condition tree, if you prefer: No, your original patch is fine, but please let's update the docs ASAP. Thanks. From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Feb 2020 15:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.15805724153788 (code B ref 39373); Sat, 01 Feb 2020 15:54:01 +0000 Received: (at 39373) by debbugs.gnu.org; 1 Feb 2020 15:53:35 +0000 Received: from localhost ([127.0.0.1]:39318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixv5T-0000z1-CJ for submit@debbugs.gnu.org; Sat, 01 Feb 2020 10:53:35 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:58550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixv5Q-0000yl-Lo for 39373@debbugs.gnu.org; Sat, 01 Feb 2020 10:53:34 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 011FqZo8127069; Sat, 1 Feb 2020 15:53:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=5pAzaBGENolvA6BA3yUzeKontLNIvD6yNCzVozNNsSU=; b=Wlg63GVmscHxjbKIqiVg0WJ5NVol/uYPe4GvpVZVJD85U1wZ4M8UT7a+a389MW5cWHl9 i0EJpKuq9kddcNIi5VHtYqTnHnqIPD/4anu7evLCeULkxZwyniiwCKfJLH0mFo35GPCV w1AOPlx4u6eoo/VOjCm2MJh+39FFUwY90VSftsTqWVppCmPnPFBHswGnE7pSHHc0q9XU WNmAz+Wr3ZeZ98fI26GMnUNo091aS1hPxAjXsB1gzGWkWlASe4FO/3hJWLI0Pthvs6t+ haZV0vxhkmRVxcpgHyX4ayulNttIlGL4x/a7N7U0DjriZEhPt4iNlFn4X5UE8kO3C7vL rg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2xw19q1m3e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 01 Feb 2020 15:53:23 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 011FoFkE157417; Sat, 1 Feb 2020 15:53:23 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2xvxfgtnt0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 01 Feb 2020 15:53:22 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 011FrJgJ011784; Sat, 1 Feb 2020 15:53:20 GMT MIME-Version: 1.0 Message-ID: <21024bbe-3e10-4d63-8d25-5e689ca459ff@default> Date: Sat, 1 Feb 2020 07:53:18 -0800 (PST) From: Drew Adams References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> <83eevekat8.fsf@gnu.org> In-Reply-To: <83eevekat8.fsf@gnu.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4954.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9518 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=885 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2002010116 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9518 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=933 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2002010116 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > 'add-to-list' doesn't work on lexical variables because it's a plain > > function taking the variable symbol as argument. 'push' works on > > lexical variables since it is a macro that expands to direct > > variable reference and setq. >=20 > If that's the case, then why don't we say that loud and clear in the > ELisp manual? (The doc string of add-to-list has some vague > recommendation, not sure if it really talks about this aspect, but > that's definitely not enough for such a serious issue.) >=20 > And doesn't it mean we should audit all the gazillion uses of > add-to-list in our sources, and do that urgently? +1. `add-to-list' uses `symbol-value'. Everything that uses `symbol-value' is in the same boat. From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Feb 2020 19:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.158058510424179 (code B ref 39373); Sat, 01 Feb 2020 19:26:01 +0000 Received: (at 39373) by debbugs.gnu.org; 1 Feb 2020 19:25:04 +0000 Received: from localhost ([127.0.0.1]:39346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixyO8-0006Hv-6C for submit@debbugs.gnu.org; Sat, 01 Feb 2020 14:25:04 -0500 Received: from mail173c50.megamailservers.eu ([91.136.10.183]:35012 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixyO5-0006HR-Ik for 39373@debbugs.gnu.org; Sat, 01 Feb 2020 14:25:02 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1580585099; bh=49B34+XMXbRHP0WQ2tXnWbEIioAdEm5Eqr3BSaFXCV8=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=K8X0onBZ7TQsDmQz5hlGk/x4jmbC52IARVD9sQZkqwFfK9FN7qDDxX+dijWdTkPI4 lULGJ9rm2w51/MbmnxP1DScYglcyMtYM017tc9lKxdxM/h3GHQydj1WEZdA57DNwAX cHaqwGLD9btB8I5qHgDBB6Tj/bBe5t+1NKWl9wWw= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-6f4fe655.032-75-73746f71.bbcust.telenor.se [85.230.79.111]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 011JOuaO023646; Sat, 1 Feb 2020 19:24:58 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_8AFC5F9C-7065-4C63-B719-A12C7B284675" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Date: Sat, 1 Feb 2020 20:24:56 +0100 In-Reply-To: <83eevekat8.fsf@gnu.org> References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> <83eevekat8.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0212.5E35D08B.0014, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Hc1qsRM8 c=1 sm=1 tr=0 a=fHaj9vQUQVKQ4sUldAaXuQ==:117 a=fHaj9vQUQVKQ4sUldAaXuQ==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=6OtYOO8Av_4Lg4D20V4A:9 a=CjuIK1q_8ugA:10 a=HvU0dG_389u4s91MisEA:9 a=B2y7HmGcmWMA:10 a=mP4ZM0_zIS7DOXXc2F0A:9 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_8AFC5F9C-7065-4C63-B719-A12C7B284675 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 1 feb. 2020 kl. 08.48 skrev Eli Zaretskii : > If that's the case, then why don't we say that loud and clear in the > ELisp manual? (The doc string of add-to-list has some vague > recommendation, not sure if it really talks about this aspect, but > that's definitely not enough for such a serious issue.) >=20 > And doesn't it mean we should audit all the gazillion uses of > add-to-list in our sources, and do that urgently? Yes, I agree, but it's not quite as simple as I thought at first. A = mechanised scan of the source for uses of add-to-list on lexical = variables revealed a handful: lisp/cedet/mode-local.el:823:23: add-to-list to lexical variable mc lisp/net/tramp-cache.el:376:45: add-to-list to lexical variable = properties lisp/net/tramp-cache.el:430:25: add-to-list to lexical variable result lisp/net/zeroconf.el:259:40: add-to-list to lexical variable result lisp/net/zeroconf.el:267:40: add-to-list to lexical variable result lisp/net/zeroconf.el:281:23: add-to-list to lexical variable result lisp/org/org.el:18685:49: add-to-list to lexical variable load-uncore lisp/autoinsert.el:174:47: add-to-list to lexical variable modes lisp/whitespace.el:1687:33: add-to-list to lexical variable style test/lisp/emacs-lisp/map-tests.el:230:30: add-to-list to lexical = variable result However, add-to-list has a compiler macro which tries to make it work = even for lexical variables, and it mostly does -- specifically, when the = LIST-VAR parameter is on the form (quote VARIABLE), which is the case in = all the above cases except the one i mode-local.el. The macro (which apparently works in non-compiled code as well) attempts = to warn about lexical variables but somehow this warning doesn't always = trigger. I haven't researched this further. It all seems rather fragile to me, and I'd rather add a note about not = using add-to-list for lexical variables to its doc string and the = manual, and fix all the calls listed above. However, this last point is = not strictly necessary for correctness. Two patches attached: a doc update, and a replacement of add-to-list in = the cases listed above. --Apple-Mail=_8AFC5F9C-7065-4C63-B719-A12C7B284675 Content-Disposition: attachment; filename=0001-Clarify-add-to-list-documentation-bug-39373.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Clarify-add-to-list-documentation-bug-39373.patch" Content-Transfer-Encoding: quoted-printable =46rom=20e7535d23b0855307a93ea6e8fa7cf7fb5910ac56=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sat,=201=20Feb=202020=2020:11:11=20+0100=0A= Subject:=20[PATCH=201/2]=20Clarify=20add-to-list=20documentation=20= (bug#39373)=0A=0AWhile=20add-to-list=20often=20works=20with=20lexical=20= variables,=20this=20is=20a=20hack=0Athat=20isn't=20always=20effective;=20= better=20tell=20the=20user=20not=20to=20try.=0A=0A*=20= doc/lispref/lists.texi=20(List=20Variables):=20Add=20a=20note=20about=20= lexical=0Avariables=20to=20the=20add-to-list=20description.=20=20Fix=20= the=20equivalent=20code.=0A*=20lisp/subr.el=20(add-to-list):=20Amend=20= doc=20string.=0A---=0A=20doc/lispref/lists.texi=20|=208=20++++++--=0A=20= lisp/subr.el=20=20=20=20=20=20=20=20=20=20=20|=201=20+=0A=202=20files=20= changed,=207=20insertions(+),=202=20deletions(-)=0A=0Adiff=20--git=20= a/doc/lispref/lists.texi=20b/doc/lispref/lists.texi=0Aindex=20= 5ef21d0671..ce0d9a3c92=20100644=0A---=20a/doc/lispref/lists.texi=0A+++=20= b/doc/lispref/lists.texi=0A@@=20-777,6=20+777,9=20@@=20List=20Variables=0A= =20The=20argument=20@var{symbol}=20is=20not=20implicitly=20quoted;=20= @code{add-to-list}=0A=20is=20an=20ordinary=20function,=20like=20= @code{set}=20and=20unlike=20@code{setq}.=20=20Quote=0A=20the=20argument=20= yourself=20if=20that=20is=20what=20you=20want.=0A+=0A+Do=20not=20use=20= this=20function=20when=20@var{symbol}=20refers=20to=20a=20lexical=0A= +variable.=0A=20@end=20defun=0A=20=0A=20Here's=20a=20scenario=20showing=20= how=20to=20use=20@code{add-to-list}:=0A@@=20-799,8=20+802,9=20@@=20List=20= Variables=0A=20@var{value})}=20is=20this:=0A=20=0A=20@example=0A-(or=20= (member=20@var{value}=20@var{var})=0A-=20=20=20=20(setq=20@var{var}=20= (cons=20@var{value}=20@var{var})))=0A+(if=20(member=20@var{value}=20= @var{var})=0A+=20=20=20=20@var{var}=0A+=20=20(setq=20@var{var}=20(cons=20= @var{value}=20@var{var})))=0A=20@end=20example=0A=20=0A=20@defun=20= add-to-ordered-list=20symbol=20element=20&optional=20order=0Adiff=20= --git=20a/lisp/subr.el=20b/lisp/subr.el=0Aindex=20a4fdc6bdfe..05fb82321e=20= 100644=0A---=20a/lisp/subr.el=0A+++=20b/lisp/subr.el=0A@@=20-1845,6=20= +1845,7=20@@=20add-to-list=0A=20If=20ELEMENT=20is=20added,=20it=20is=20= added=20at=20the=20beginning=20of=20the=20list,=0A=20unless=20the=20= optional=20argument=20APPEND=20is=20non-nil,=20in=20which=20case=0A=20= ELEMENT=20is=20added=20at=20the=20end.=0A+LIST-VAR=20should=20not=20= refer=20to=20a=20lexical=20variable.=0A=20=0A=20The=20return=20value=20= is=20the=20new=20value=20of=20LIST-VAR.=0A=20=0A--=20=0A2.21.1=20(Apple=20= Git-122.3)=0A=0A= --Apple-Mail=_8AFC5F9C-7065-4C63-B719-A12C7B284675 Content-Disposition: attachment; filename=0002-Replace-add-to-list-to-lexical-variable-with-push-bu.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0002-Replace-add-to-list-to-lexical-variable-with-push-bu.patch" Content-Transfer-Encoding: quoted-printable =46rom=204501670056beed4c8e709674b3b80dc2a1160c0b=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sat,=201=20Feb=202020=2018:07:32=20+0100=0A= Subject:=20[PATCH=202/2]=20Replace=20add-to-list=20to=20lexical=20= variable=20with=20push=0A=20(bug#39373)=0A=0ASince=20'add-to-list',=20= being=20a=20plain=20function,=20cannot=20access=20lexical=0Avariables,=20= such=20use=20must=20be=20rewritten=20for=20correctness.=0A=0A*=20= lisp/autoinsert.el=20(auto-insert-alist):=0A*=20lisp/cedet/mode-local.el=20= (mode-local-print-bindings):=0A*=20lisp/net/tramp-cache.el=20= (tramp-flush-connection-properties)=0A(tramp-list-connections):=0A*=20= lisp/net/zeroconf.el=20(zeroconf-list-service-names)=0A= (zeroconf-list-service-types,=20zeroconf-list-services):=0A*=20= lisp/org/org.el=20(org-reload):=0A*=20lisp/whitespace.el=20= (whitespace-report-region):=0A*=20test/lisp/emacs-lisp/map-tests.el=20= (test-map-do):=0AReplace=20add-to-list=20with=20push.=0A---=0A=20= lisp/autoinsert.el=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20|=20=20= 2=20+-=0A=20lisp/cedet/mode-local.el=20=20=20=20=20=20=20=20=20=20|=2014=20= ++++++--------=0A=20lisp/net/tramp-cache.el=20=20=20=20=20=20=20=20=20=20= =20|=20=204=20++--=0A=20lisp/net/zeroconf.el=20=20=20=20=20=20=20=20=20=20= =20=20=20=20|=2012=20++++++------=0A=20lisp/org/org.el=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20|=20=205=20+++--=0A=20= lisp/whitespace.el=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20|=20=20= 2=20+-=0A=20test/lisp/emacs-lisp/map-tests.el=20|=20=202=20+-=0A=207=20= files=20changed,=2020=20insertions(+),=2021=20deletions(-)=0A=0Adiff=20= --git=20a/lisp/autoinsert.el=20b/lisp/autoinsert.el=0Aindex=20= 9bc3aad278..25961d4108=20100644=0A---=20a/lisp/autoinsert.el=0A+++=20= b/lisp/autoinsert.el=0A@@=20-171,7=20+171,7=20@@=20auto-insert-alist=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(mapatoms=20(lambda=20= (mode)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20(let=20((name=20(symbol-name=20mode)))=0A=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(when=20(string-match=20"-mode$"=20name)=0A-=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(add-to-list=20'modes=20name)))))=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (push=20name=20modes)))))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(sort=20modes=20'string<)))=0A=20=20=20=20=20=20= (completing-read=20"Local=20variables=20for=20mode:=20"=20v1=20nil=20t)=0A= =20=20=20=20=20=20"=20.=20(("=0Adiff=20--git=20= a/lisp/cedet/mode-local.el=20b/lisp/cedet/mode-local.el=0Aindex=20= a6e143cfcd..a1aea30c20=20100644=0A---=20a/lisp/cedet/mode-local.el=0A+++=20= b/lisp/cedet/mode-local.el=0A@@=20-819,14=20+819,12=20@@=20= mode-local-print-bindings=0A=20=20=20=20=20=20=20=20=20)=0A=20=20=20=20=20= ;;=20Order=20symbols=20by=20type=0A=20=20=20=20=20(mapatoms=0A-=20=20=20=20= =20#'(lambda=20(s)=0A-=20=20=20=20=20=20=20=20=20(add-to-list=20(cond=0A= -=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= ((get=20s=20'mode-variable-flag)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(if=20(get=20s=20'constant-flag)=20'mc=20= 'mv))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20((get=20s=20'override-flag)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(if=20(get=20s=20'constant-flag)=20'fo=20= 'ov))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20('us))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20s))=0A+=20=20=20=20=20(lambda=20(s)=20(push=20s=20(cond=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= ((get=20s=20'mode-variable-flag)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(if=20(get=20s=20= 'constant-flag)=20mc=20mv))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20((get=20s=20'override-flag)=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (if=20(get=20s=20'constant-flag)=20fo=20ov))=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(t=20us))))=0A=20=20=20= =20=20=20table)=0A=20=20=20=20=20;;=20Print=20symbols=20by=20type=0A=20=20= =20=20=20(when=20us=0Adiff=20--git=20a/lisp/net/tramp-cache.el=20= b/lisp/net/tramp-cache.el=0Aindex=20b81a1a23d5..62e25fa1f0=20100644=0A= ---=20a/lisp/net/tramp-cache.el=0A+++=20b/lisp/net/tramp-cache.el=0A@@=20= -373,7=20+373,7=20@@=20tramp-flush-connection-properties=0A=20=20=20=20= (let=20((hash=20(gethash=20key=20tramp-cache-data))=0A=20=09=20= properties)=0A=20=20=20=20=20=20(when=20(hash-table-p=20hash)=0A-=20=20=20= =20=20=20=20(maphash=20(lambda=20(x=20_y)=20(add-to-list=20'properties=20= x=20'append))=20hash))=0A+=20=20=20=20=20=20=20(maphash=20(lambda=20(x=20= _y)=20(push=20x=20properties))=20hash))=0A=20=20=20=20=20=20properties))=0A= =20=20=20(setq=20tramp-cache-data-changed=20t)=0A=20=20=20(remhash=20key=20= tramp-cache-data))=0A@@=20-427,7=20+427,7=20@@=20tramp-list-connections=0A= =20=09=20(when=20(and=20(tramp-file-name-p=20key)=0A=20=09=09=20=20=20=20= (null=20(tramp-file-name-localname=20key))=0A=20=09=09=20=20=20=20= (tramp-connection-property-p=20key=20"process-buffer"))=0A-=09=20=20=20= (add-to-list=20'result=20key)))=0A+=09=20=20=20(push=20key=20result)))=0A= =20=20=20=20=20=20=20=20tramp-cache-data)=0A=20=20=20=20=20=20=20= result))=0A=20=0Adiff=20--git=20a/lisp/net/zeroconf.el=20= b/lisp/net/zeroconf.el=0Aindex=20b8becd712f..cb3c0f2a7e=20100644=0A---=20= a/lisp/net/zeroconf.el=0A+++=20b/lisp/net/zeroconf.el=0A@@=20-256,17=20= +256,17=20@@=20zeroconf-list-service-names=0A=20=20=20"Return=20all=20= discovered=20Avahi=20service=20names=20as=20list."=0A=20=20=20(let=20= (result)=0A=20=20=20=20=20(maphash=0A-=20=20=20=20=20(lambda=20(_key=20= value)=20(add-to-list=20'result=20(zeroconf-service-name=20value)))=0A+=20= =20=20=20=20(lambda=20(_key=20value)=20(push=20(zeroconf-service-name=20= value)=20result))=0A=20=20=20=20=20=20zeroconf-services-hash)=0A-=20=20=20= =20result))=0A+=20=20=20=20(delete-dups=20result)))=0A=20=0A=20(defun=20= zeroconf-list-service-types=20()=0A=20=20=20"Return=20all=20discovered=20= Avahi=20service=20types=20as=20list."=0A=20=20=20(let=20(result)=0A=20=20= =20=20=20(maphash=0A-=20=20=20=20=20(lambda=20(_key=20value)=20= (add-to-list=20'result=20(zeroconf-service-type=20value)))=0A+=20=20=20=20= =20(lambda=20(_key=20value)=20(push=20(zeroconf-service-type=20value)=20= result))=0A=20=20=20=20=20=20zeroconf-services-hash)=0A-=20=20=20=20= result))=0A+=20=20=20=20(delete-dups=20result)))=0A=20=0A=20(defun=20= zeroconf-list-services=20(type)=0A=20=20=20"Return=20all=20discovered=20= Avahi=20services=20for=20a=20given=20service=20type=20TYPE.=0A@@=20= -278,9=20+278,9=20@@=20zeroconf-list-services=0A=20=20=20=20=20(maphash=0A= =20=20=20=20=20=20(lambda=20(_key=20value)=0A=20=20=20=20=20=20=20=20= (when=20(equal=20type=20(zeroconf-service-type=20value))=0A-=09=20= (add-to-list=20'result=20value)))=0A+=09=20(push=20value=20result)))=0A=20= =20=20=20=20=20zeroconf-services-hash)=0A-=20=20=20=20result))=0A+=20=20=20= =20(delete-dups=20result)))=0A=20=0A=20(defvar=20= zeroconf-service-added-hooks-hash=20(make-hash-table=20:test=20'equal)=0A= =20=20=20"Hash=20table=20of=20hooks=20for=20newly=20added=20services.=0A= diff=20--git=20a/lisp/org/org.el=20b/lisp/org/org.el=0Aindex=20= 5c8b02b9d1..568f5b9b87=20100644=0A---=20a/lisp/org/org.el=0A+++=20= b/lisp/org/org.el=0A@@=20-18682,13=20+18682,14=20@@=20org-reload=0A=20=09= =09=09=20=20=20=20=20=20(and=20(string=3D=20org-dir=20contrib-dir)=0A=20=09= =09=09=09=20=20=20(org-load-noerror-mustsuffix=20(concat=20contrib-dir=20= f)))=0A=20=09=09=09=20=20=20=20=20=20(and=20(org-load-noerror-mustsuffix=20= (concat=20(org-find-library-dir=20f)=20f))=0A-=09=09=09=09=20=20=20= (add-to-list=20'load-uncore=20f=20'append)=0A+=09=09=09=09=20=20=20(push=20= f=20load-uncore)=0A=20=09=09=09=09=20=20=20't)=0A=20=09=09=09=20=20=20=20= =20=20f))=0A=20=09=09=09lfeat)))=0A=20=20=20=20=20(when=20load-uncore=0A=20= =20=20=20=20=20=20(message=20"The=20following=20feature%s=20found=20in=20= load-path,=20please=20check=20if=20that's=20correct:\n%s"=0A-=09=20=20=20= =20=20=20=20(if=20(>=20(length=20load-uncore)=201)=20"s=20were"=20"=20= was")=20load-uncore))=0A+=09=20=20=20=20=20=20=20(if=20(>=20(length=20= load-uncore)=201)=20"s=20were"=20"=20was")=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(reverse=20load-uncore)))=0A=20=20=20=20=20(if=20= load-misses=0A=20=09(message=20"Some=20error=20occurred=20while=20= reloading=20Org=20feature%s\n%s\nPlease=20check=20*Messages*!\n%s"=0A=20=09= =09=20(if=20(>=20(length=20load-misses)=201)=20"s"=20"")=20load-misses=20= (org-version=20nil=20'full))=0Adiff=20--git=20a/lisp/whitespace.el=20= b/lisp/whitespace.el=0Aindex=20111b175263..db7c023324=20100644=0A---=20= a/lisp/whitespace.el=0A+++=20b/lisp/whitespace.el=0A@@=20-1684,7=20= +1684,7=20@@=20whitespace-report-region=0A=20=20=20=20=20=20=20=20=20=20=20= =20=20(mapcar=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20#'(lambda=20= (option)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20= force=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (add-to-list=20'style=20(car=20option)))=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(push=20(car=20option)=20style))=0A=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(goto-char=20rstart)=0A=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(let=20((regexp=0A=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(cond=0A= diff=20--git=20a/test/lisp/emacs-lisp/map-tests.el=20= b/test/lisp/emacs-lisp/map-tests.el=0Aindex=2006fd55faad..c52bb83fa3=20= 100644=0A---=20a/test/lisp/emacs-lisp/map-tests.el=0A+++=20= b/test/lisp/emacs-lisp/map-tests.el=0A@@=20-227,7=20+227,7=20@@=20= test-map-do=0A=20=20=20(with-maps-do=20map=0A=20=20=20=20=20(let=20= ((result=20nil))=0A=20=20=20=20=20=20=20(map-do=20(lambda=20(k=20v)=0A-=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(add-to-list=20'result=20= (list=20(int-to-string=20k)=20v)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(push=20(list=20(int-to-string=20k)=20v)=20result))=0A=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20map)=0A=20=20=20=20=20=20=20(should=20= (equal=20result=20'(("2"=205)=20("1"=204)=20("0"=203)))))))=0A=20=0A--=20= =0A2.21.1=20(Apple=20Git-122.3)=0A=0A= --Apple-Mail=_8AFC5F9C-7065-4C63-B719-A12C7B284675-- From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Feb 2020 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Stefan Monnier Cc: 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.158058532024517 (code B ref 39373); Sat, 01 Feb 2020 19:29:02 +0000 Received: (at 39373) by debbugs.gnu.org; 1 Feb 2020 19:28:40 +0000 Received: from localhost ([127.0.0.1]:39352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixyRb-0006NN-QQ for submit@debbugs.gnu.org; Sat, 01 Feb 2020 14:28:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixyRa-0006N9-56 for 39373@debbugs.gnu.org; Sat, 01 Feb 2020 14:28:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixyRU-0005FX-Pt; Sat, 01 Feb 2020 14:28:32 -0500 Received: from [176.228.60.248] (port=2102 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixyRS-0003bK-Ni; Sat, 01 Feb 2020 14:28:32 -0500 Date: Sat, 01 Feb 2020 21:28:14 +0200 Message-Id: <83mua2hzu9.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sat, 1 Feb 2020 20:24:56 +0100) References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> <83eevekat8.fsf@gnu.org> <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Mattias Engdegård > Date: Sat, 1 Feb 2020 20:24:56 +0100 > Cc: 39373@debbugs.gnu.org > > It all seems rather fragile to me, and I'd rather add a note about not using add-to-list for lexical variables to its doc string and the manual, and fix all the calls listed above. I tend to agree. Stefan, any comments? > Two patches attached: a doc update, and a replacement of add-to-list in the cases listed above. LGTM, on both counts, but let's hear from Stefan (and others, if someone has an opinion). Thanks. From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Feb 2020 20:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.158058812028703 (code B ref 39373); Sat, 01 Feb 2020 20:16:01 +0000 Received: (at 39373) by debbugs.gnu.org; 1 Feb 2020 20:15:20 +0000 Received: from localhost ([127.0.0.1]:39371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixzAm-0007St-Ip for submit@debbugs.gnu.org; Sat, 01 Feb 2020 15:15:20 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixzAk-0007Sg-96 for 39373@debbugs.gnu.org; Sat, 01 Feb 2020 15:15:18 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C7A968083B; Sat, 1 Feb 2020 15:15:12 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9FAF480EC2; Sat, 1 Feb 2020 15:15:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1580588110; bh=k31t9PraXCGIgqHo8Px/y/DU2d67EzBF/AGyYxgfIy8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bCkNpTfyWm6VBXKMDsw+eFN2i5kvpYCAzlKihjbVcuIuiAcHU0Przswji4soziSlV pEk5f+Ab+gzUFzXrVGG/vei2j8zl/ObdaGvWUKrBXri68tfel+yYd9vhJ8FPw30pK0 lusUkuDsGq5g6qt69Ra8qGxLR91ytgEaTlTRcZ7poPV4UAbUx0MXw0VsjnbNXg6Qch AQI8WmkhFFtukmyQINQ8MVVs6rDeIdbF84XQtqT8JbtS2EiC6fFzl37lySDV2pdJ48 xJ8GlNeFyiNVDydlLJhiKR2U2WdhIdh3WtmvLKIyswCS2dvizhbfoNmMn60gcrw5Hg b61cpSMKgr9LQ== Received: from pastel (unknown [216.154.34.88]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 893C91204E7; Sat, 1 Feb 2020 15:15:09 -0500 (EST) From: Stefan Monnier Message-ID: References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> <83eevekat8.fsf@gnu.org> <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> Date: Sat, 01 Feb 2020 15:15:08 -0500 In-Reply-To: <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Sat, 1 Feb 2020 20:24:56 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> If that's the case, then why don't we say that loud and clear in the ELisp manual? >> (The doc string of add-to-list has some vague >> recommendation, not sure if it really talks about this aspect, but >> that's definitely not enough for such a serious issue.) Good idea. >> And doesn't it mean we should audit all the gazillion uses of >> add-to-list in our sources, and do that urgently? In dynamically-scoped files, it's OK. But yes, we should audit them and change those that need changing for lexical scoping. I added a compiler macro as a crutch to handle the most command problems, but it's just an ugly hack which can make things worse by hiding the problem. > The compiler-macro (which apparently works in non-compiled code as well) Compiler macros work when the code passes through `macroexpand-all`, so it works when the code is compiled as well as when it's `load`ed (thanks to "eager" macroexpansion), but not when it's passed directly to `eval`. > attempts to warn about lexical variables but somehow this warning > doesn't always trigger. I haven't researched this further. The message is supposed not to trigger when it's applied to dynamically scoped var, but it's probably not 100% reliable. > It all seems rather fragile to me, and I'd rather add a note about not using > add-to-list for lexical variables to its doc string and the manual, and fix > all the calls listed above. Yes, this compiler-macro isn't supposed to replace educating the programmers (in the manual) and fixing the actual problems. BTW, this problem doesn't affect only `add-to-list`. Other culprits include `add-hook`, `run-hooks`, `set`, and `symbol-value`. > Two patches attached: a doc update, and a replacement of add-to-list in the cases listed above. LGTM, Stefan From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Feb 2020 21:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: Eli Zaretskii , 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.15805933114412 (code B ref 39373); Sat, 01 Feb 2020 21:42:01 +0000 Received: (at 39373) by debbugs.gnu.org; 1 Feb 2020 21:41:51 +0000 Received: from localhost ([127.0.0.1]:39396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iy0WU-000196-Q7 for submit@debbugs.gnu.org; Sat, 01 Feb 2020 16:41:51 -0500 Received: from mail1445c50.megamailservers.eu ([91.136.14.45]:57940 helo=mail265c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iy0WS-00018s-Ii for 39373@debbugs.gnu.org; Sat, 01 Feb 2020 16:41:49 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1580593301; bh=YdN7edUSqFU1Yo1WVj1sIVo+4y/jghkd6/pgskPj/DY=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=hs0+h0LgjvA/NnZ7MQ4PCiTTi19Q7qHqZHII5TRcVttmrmIEGDHc0E+pZzmgVWcnx UTcx7bEyxu/z/VDwsWdoT6yd56DJ7sr2IyxbCuXTcVMha7XAgUqv+v9V9BSUPwjNET nRP65/AsCZ4s4oGyUdnkQJUklpktteQRvRVIJ1oM= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-6f4fe655.032-75-73746f71.bbcust.telenor.se [85.230.79.111]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 011Lfb1F014723; Sat, 1 Feb 2020 21:41:39 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: Date: Sat, 1 Feb 2020 22:40:16 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> <83eevekat8.fsf@gnu.org> <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0209.5E35F095.0002, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=YIzhNiOx c=1 sm=1 tr=0 a=fHaj9vQUQVKQ4sUldAaXuQ==:117 a=fHaj9vQUQVKQ4sUldAaXuQ==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=iRZporoAAAAA:8 a=Y5VFf0hPGQ8sVX9UeX4A:9 a=CjuIK1q_8ugA:10 a=NOBgFS-JBQ2l-kSd6-zu:22 X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 1 feb. 2020 kl. 21.15 skrev Stefan Monnier : > Compiler macros work when the code passes through `macroexpand-all`, so > it works when the code is compiled as well as when it's `load`ed (thanks > to "eager" macroexpansion), but not when it's pas [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: umontreal.ca] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.3 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 1 feb. 2020 kl. 21.15 skrev Stefan Monnier : > Compiler macros work when the code passes through `macroexpand-all`, = so > it works when the code is compiled as well as when it's `load`ed = (thanks > to "eager" macroexpansion), but not when it's passed directly to = `eval`. Understood, thank you. (Obviously they aren't expanded when the function = is called indirectly, but I didn't find anyone doing that with = add-to-list.) > The message is supposed not to trigger when it's applied to = dynamically > scoped var, but it's probably not 100% reliable. It appears that the warning triggers (as a hard error, actually) when = add-to-list is called directly from a function, but not if it only = occurs inside a lambda. All the cases found were inside lambdas (or they = would have been fixed long ago). > BTW, this problem doesn't affect only `add-to-list`. Other culprits > include `add-hook`, `run-hooks`, `set`, and `symbol-value`. Right. I see that some of them are detected by the compiler (in = byte-compile-form), but add-to-list is commented out. The set of functions is a bit open-ended; there is also = add-to-ordered-list, add-to-history, etc. Not sure how much text needs = to be added for all these. There is a general note about lexical = variables and symbol values in the manual, in the section about lexical = binding. > LGTM, Thanks, pushed to emacs-27. From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Feb 2020 03:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: monnier@iro.umontreal.ca, 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.15806143104246 (code B ref 39373); Sun, 02 Feb 2020 03:32:01 +0000 Received: (at 39373) by debbugs.gnu.org; 2 Feb 2020 03:31:50 +0000 Received: from localhost ([127.0.0.1]:39487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iy5zC-00016Q-Ad for submit@debbugs.gnu.org; Sat, 01 Feb 2020 22:31:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iy5zA-00016A-3E for 39373@debbugs.gnu.org; Sat, 01 Feb 2020 22:31:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iy5z4-0006Wt-R9; Sat, 01 Feb 2020 22:31:42 -0500 Received: from [176.228.60.248] (port=3794 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iy5z3-0005pE-QY; Sat, 01 Feb 2020 22:31:42 -0500 Date: Sun, 02 Feb 2020 05:31:25 +0200 Message-Id: <83lfplis1e.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sat, 1 Feb 2020 22:40:16 +0100) References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> <83eevekat8.fsf@gnu.org> <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Mattias Engdegård > Date: Sat, 1 Feb 2020 22:40:16 +0100 > Cc: Eli Zaretskii , 39373@debbugs.gnu.org > > > BTW, this problem doesn't affect only `add-to-list`. Other culprits > > include `add-hook`, `run-hooks`, `set`, and `symbol-value`. > > Right. I see that some of them are detected by the compiler (in byte-compile-form), but add-to-list is commented out. > > The set of functions is a bit open-ended; there is also add-to-ordered-list, add-to-history, etc. Not sure how much text needs to be added for all these. There is a general note about lexical variables and symbol values in the manual, in the section about lexical binding. I'd prefer to have a short note in the description of each one of them. Thanks. From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Feb 2020 11:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: monnier@iro.umontreal.ca, 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.158064472920033 (code B ref 39373); Sun, 02 Feb 2020 11:59:01 +0000 Received: (at 39373) by debbugs.gnu.org; 2 Feb 2020 11:58:49 +0000 Received: from localhost ([127.0.0.1]:39562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyDto-0005D2-Kw for submit@debbugs.gnu.org; Sun, 02 Feb 2020 06:58:48 -0500 Received: from mail235c50.megamailservers.eu ([91.136.10.245]:38768 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyDtm-0005Cs-7S for 39373@debbugs.gnu.org; Sun, 02 Feb 2020 06:58:47 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1580644724; bh=Giy57EVBJUM8yTo2pMl+h55yZ+YsyqOQKQVtOrRTrxk=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=k8uc3WK7T20R9/waLQyjnlDuhmOfV0ru2bkzxQDEZDhEInGMa/eenQMsBnhVMvhA3 ruGjqlWYIlGbFMCXE+ZTSmQxXvDM1FfAp7Reb0A46CZsA6oLHerOEBAHHzj+4pX/K+ jnpKKNmJRe7FsfJlAZ6ox7tPZxH0/LJtOrsB6BR8= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-6f4fe655.032-75-73746f71.bbcust.telenor.se [85.230.79.111]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 012BwenH019342; Sun, 2 Feb 2020 11:58:42 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <83lfplis1e.fsf@gnu.org> Date: Sun, 2 Feb 2020 12:58:40 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <45DBB63C-62BC-483F-BF01-FEE39F2ED9F5@acm.org> References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> <83eevekat8.fsf@gnu.org> <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> <83lfplis1e.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020F.5E36B974.0012, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Hc1qsRM8 c=1 sm=1 tr=0 a=fHaj9vQUQVKQ4sUldAaXuQ==:117 a=fHaj9vQUQVKQ4sUldAaXuQ==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=2bfLTL3LXZmemzyx0l0A:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 2 feb. 2020 kl. 04.31 skrev Eli Zaretskii : > I'd prefer to have a short note in the description of each one of > them. Right -- I added a note to 'add-to-ordered-list' and 'add-to-history', since their arguments were described as variables. Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.3 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 2 feb. 2020 kl. 04.31 skrev Eli Zaretskii : > I'd prefer to have a short note in the description of each one of > them. Right -- I added a note to 'add-to-ordered-list' and 'add-to-history', = since their arguments were described as variables. For 'set' and 'symbol-value', the argument is described as a symbol, = which I'd say makes a slight difference here, since lexical variables = are mentioned in the description of the relationship between variables = and symbols, and also explicitly in the documentation of 'set' in the = manual. The hook functions mostly talk about symbols and hooks, not variables, = and I think the risk of them being used on lexvars is slight. Good enough? From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Feb 2020 13:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.15806517397447 (code B ref 39373); Sun, 02 Feb 2020 13:56:01 +0000 Received: (at 39373) by debbugs.gnu.org; 2 Feb 2020 13:55:39 +0000 Received: from localhost ([127.0.0.1]:39631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyFit-0001w3-Au for submit@debbugs.gnu.org; Sun, 02 Feb 2020 08:55:39 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyFir-0001vo-Ov for 39373@debbugs.gnu.org; Sun, 02 Feb 2020 08:55:38 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5B3C680D5A; Sun, 2 Feb 2020 08:55:32 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3D16780EC2; Sun, 2 Feb 2020 08:55:26 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1580651726; bh=1+trLVPFP4bGIAPNQe0/z8ObGhpQiwCcfsyjeakvQ5c=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RqswGKH7CxD0FYdg9sY0y56rj5kHSFaI0AynXH14ROOsBpCWYnNAnm2G7uLrMBjps 6FSZhIPAHp6o3nF0IR+MJbGwawmBpOlJ4vRZ0FtdYJitTGaiPZAa/fQI22pt3XnGIn ndKCLZNiS93nh+c/QlqiAsFOgTKEh7qctUeX1tSzcrfg7lRzL7hyYWOJ3ICEacMYm6 fdNW0tsebvO97onlWqAS3VpaOwqdSBIxKk5tcEf2qgcKDtgaKskoUw4ZCdAfnUoMSD zDNrXXfoSMGmUtivCAhnvenpR2PzndxjuiwaLonKf4T6p+lSG64Y9oV4CNdrwBzye9 Z2EcrzIwy5hvw== Received: from pastel (unknown [216.154.34.88]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id ED320120B03; Sun, 2 Feb 2020 08:55:25 -0500 (EST) From: Stefan Monnier Message-ID: References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> <83eevekat8.fsf@gnu.org> <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> <83lfplis1e.fsf@gnu.org> <45DBB63C-62BC-483F-BF01-FEE39F2ED9F5@acm.org> Date: Sun, 02 Feb 2020 08:55:24 -0500 In-Reply-To: <45DBB63C-62BC-483F-BF01-FEE39F2ED9F5@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Sun, 2 Feb 2020 12:58:40 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > The hook functions mostly talk about symbols and hooks, not variables, and > I think the risk of them being used on lexvars is slight. I also expected so, but I've already changed a handful of `(run-hooks 'foo)` to `(mapcar #'funcall foo)`. The problem is a bit different, tho: it's *also* wrong to use it on dynamically-scoped let-bound vars (tho it mostly works), so the doc should not focus on lexical vars but on the difference between vars and hooks. Stefan From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Feb 2020 14:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: Eli Zaretskii , 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.15806528849520 (code B ref 39373); Sun, 02 Feb 2020 14:15:01 +0000 Received: (at 39373) by debbugs.gnu.org; 2 Feb 2020 14:14:44 +0000 Received: from localhost ([127.0.0.1]:39661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyG1M-0002TT-4I for submit@debbugs.gnu.org; Sun, 02 Feb 2020 09:14:44 -0500 Received: from mail154c50.megamailservers.eu ([91.136.10.164]:50430 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyG1J-0002TH-UG for 39373@debbugs.gnu.org; Sun, 02 Feb 2020 09:14:42 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1580652879; bh=5ZvGKfLTvpbcP/aiGBL1dqYlDsGgJkSOb9mgFFrDWlI=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=HY/NHeCrw+03sxIR/RSE/t8tNn2TIUhxljMvrpCoqqhNWm9KZGcdH3+GYuE3+GFIh 06oRyuZClIRysugPWniFtRi7+OHASOQVRuSn2BdvKqMdeSUniRF6j/bBJJbrDXD+j+ yMd761bdsP3Il4BRIcyOvf8MfCdcOfbXEMkjfTr8= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-6f4fe655.032-75-73746f71.bbcust.telenor.se [85.230.79.111]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 012EEaHd031396; Sun, 2 Feb 2020 14:14:38 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: Date: Sun, 2 Feb 2020 15:14:35 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <82110A68-1F5C-4B0B-AB0E-67B710B33C1A@acm.org> References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> <83eevekat8.fsf@gnu.org> <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> <83lfplis1e.fsf@gnu.org> <45DBB63C-62BC-483F-BF01-FEE39F2ED9F5@acm.org> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0204.5E36D94F.000F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=N4FX6F1B c=1 sm=1 tr=0 a=fHaj9vQUQVKQ4sUldAaXuQ==:117 a=fHaj9vQUQVKQ4sUldAaXuQ==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=iRZporoAAAAA:8 a=QCCKKS5cLIbEMXgvm94A:9 a=CjuIK1q_8ugA:10 a=NOBgFS-JBQ2l-kSd6-zu:22 X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 2 feb. 2020 kl. 14.55 skrev Stefan Monnier : > I also expected so, but I've already changed a handful of > `(run-hooks 'foo)` to `(mapcar #'funcall foo)`. The problem is a bit > different, tho: it's *also* wrong to use it on dynamically-scoped l [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: megamailservers.eu] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 2 feb. 2020 kl. 14.55 skrev Stefan Monnier : > I also expected so, but I've already changed a handful of > `(run-hooks 'foo)` to `(mapcar #'funcall foo)`. The problem is a bit > different, tho: it's *also* wrong to use it on dynamically-scoped = let-bound > vars (tho it mostly works), so the doc should not focus on lexical > vars but on the difference between vars and hooks. Very well, in that case you are probably better placed to provide the = nuanced modifications necessary, if any. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 09 07:37:48 2020 Received: (at control) by debbugs.gnu.org; 9 Aug 2020 11:37:48 +0000 Received: from localhost ([127.0.0.1]:60142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4je8-0003OC-CC for submit@debbugs.gnu.org; Sun, 09 Aug 2020 07:37:48 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4je6-0003Nx-5h for control@debbugs.gnu.org; Sun, 09 Aug 2020 07:37:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AMO4SY4jRYjoszRul88TsYXd1vzZ3obqv/DVsB4ynI4=; b=dAjrCgStvUvHUGaARw/nalDcLc 4XzLHVC4ustEkCX3Jc5ewDi6vRjnZ3lvdl2zZNcqRRsqi8i4zQw2YIy9pTRQvFpPe0+xjBq/ioMbx rJNBNb/vWPmS/1qowwSdOSuRxfVFpXHaGSPhF7Dc5XGNk6z27jagMI2pDIX97BDa6G9g=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4jdy-0001Hs-1X for control@debbugs.gnu.org; Sun, 09 Aug 2020 13:37:40 +0200 Date: Sun, 09 Aug 2020 13:37:36 +0200 Message-Id: <87pn80t5hb.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #39373 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 39373 - patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 39373 - patch quit From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Aug 2020 11:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , Stefan Monnier , 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.159697316413212 (code B ref 39373); Sun, 09 Aug 2020 11:40:02 +0000 Received: (at 39373) by debbugs.gnu.org; 9 Aug 2020 11:39:24 +0000 Received: from localhost ([127.0.0.1]:60147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4jff-0003R2-LN for submit@debbugs.gnu.org; Sun, 09 Aug 2020 07:39:23 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4jfd-0003Qp-Bx for 39373@debbugs.gnu.org; Sun, 09 Aug 2020 07:39:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rFx/VhhBPEDfHAEQgXtH5ZgJhuYJZ6UFKDb1Nlfm6Io=; b=L2RBHO0OUUeCFFb6dTGu8++Bjl aMD2bCO+ZYb4Q2J1es4j1+/0rQk8EfKHtEYgrgD57/W25Q9jvugTKLwDXCVV6lFZs6PJcn3vAO4oA JC1qcUe/mrPEfwvQTcCtBhYm6fXRKy5/QnExWRX3TavXNIWsHRHC625pIh3HHxlTr+3Y=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4jfU-0001JT-4t; Sun, 09 Aug 2020 13:39:14 +0200 From: Lars Ingebrigtsen References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> <83eevekat8.fsf@gnu.org> <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> <83lfplis1e.fsf@gnu.org> <45DBB63C-62BC-483F-BF01-FEE39F2ED9F5@acm.org> <82110A68-1F5C-4B0B-AB0E-67B710B33C1A@acm.org> Date: Sun, 09 Aug 2020 13:39:10 +0200 In-Reply-To: <82110A68-1F5C-4B0B-AB0E-67B710B33C1A@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Sun, 2 Feb 2020 15:14:35 +0100") Message-ID: <87lfiot5ep.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= writes: > 2 feb. 2020 kl. 14.55 skrev Stefan Monnier : > >> I also expected so, but I've already changed a handful of >> `(run-hooks 'foo)` to `(mapcar #'funcall foo)`. The problem i [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd writes: > 2 feb. 2020 kl. 14.55 skrev Stefan Monnier : > >> I also expected so, but I've already changed a handful of >> `(run-hooks 'foo)` to `(mapcar #'funcall foo)`. The problem is a bit >> different, tho: it's *also* wrong to use it on dynamically-scoped let-bo= und >> vars (tho it mostly works), so the doc should not focus on lexical >> vars but on the difference between vars and hooks. > > Very well, in that case you are probably better placed to provide the > nuanced modifications necessary, if any. If I'm reading this thread right, the specific problem in this bug report was fixed (and the documentation of add-to-list updated), but the more general problem of going through all the instances of add-to-list (and friends) in lexical files hasn't been done? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Aug 2020 13:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Eli Zaretskii , Stefan Monnier , 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.15969797069591 (code B ref 39373); Sun, 09 Aug 2020 13:29:01 +0000 Received: (at 39373) by debbugs.gnu.org; 9 Aug 2020 13:28:26 +0000 Received: from localhost ([127.0.0.1]:60362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4lNC-0002Ud-8R for submit@debbugs.gnu.org; Sun, 09 Aug 2020 09:28:26 -0400 Received: from mail1477c50.megamailservers.eu ([91.136.14.77]:42706 helo=mail118c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4lN9-0002UM-45 for 39373@debbugs.gnu.org; Sun, 09 Aug 2020 09:28:24 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1596979695; bh=iJMLWBTK/0L9jy958UCi+EMEsZVnGeZX4vsPdyK3vMU=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=FI76gisC/09nzlR0L0S+Oocmsd9jLa8eOaEN8o7VbPOiZ4ABbKddToQt9xkigYA7Y hpxsGKrUNs+3WclylxcX/TQfSvycOU3EAowrGzt7EKBxlEDGfSh9cNtUE/3Nj2rvbi MOlWN41P0Nq1XX7wBX1aNCTsjuOeV+KU2Uw75dCQ= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 079DSCo1003825; Sun, 9 Aug 2020 13:28:13 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <87lfiot5ep.fsf@gnus.org> Date: Sun, 9 Aug 2020 15:28:11 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <18CECA70-D003-4993-A47E-152A9E1AED1C@acm.org> References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> <83eevekat8.fsf@gnu.org> <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> <83lfplis1e.fsf@gnu.org> <45DBB63C-62BC-483F-BF01-FEE39F2ED9F5@acm.org> <82110A68-1F5C-4B0B-AB0E-67B710B33C1A@acm.org> <87lfiot5ep.fsf@gnus.org> X-Mailer: Apple Mail (2.3445.104.15) X-CTCH-RefID: str=0001.0A782F28.5F2FF9EF.003D, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=KaGsTjQD c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=e4A6e26Ii9wK_hJ4pGAA:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 9 aug. 2020 kl. 13.39 skrev Lars Ingebrigtsen : > If I'm reading this thread right, the specific problem in this bug > report was fixed (and the documentation of add-to-list updated), but = the > more general problem of going through all the instances of add-to-list > (and friends) in lexical files hasn't been done? No, I believe add-to-list calls have been updated and I would be happy = to mark the bug as done. Stefan alluded to some improvement possibilities in the hook function = documentation (re the difference between variables and hooks). From unknown Sun Jun 15 08:59:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Aug 2020 19:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , Stefan Monnier , 39373@debbugs.gnu.org Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.159700216523885 (code B ref 39373); Sun, 09 Aug 2020 19:43:01 +0000 Received: (at 39373) by debbugs.gnu.org; 9 Aug 2020 19:42:45 +0000 Received: from localhost ([127.0.0.1]:33515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4rDR-0006DA-2U for submit@debbugs.gnu.org; Sun, 09 Aug 2020 15:42:45 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4rDP-0006Cq-KG for 39373@debbugs.gnu.org; Sun, 09 Aug 2020 15:42:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ezziSFWfub4q7UEMl2rcYu7TaUs82+HPhWQr8YkDLtc=; b=Y8wSYQmcpZPIuJKVc8wtIUQtzU 6Dp4b3MrZi7BDHad8iv1EjArw29yOVX67c2sKlDA7zE2WZhGgPIh3wrOxhMyasSLln4Pr0yfLyP1B jkkL0dFI7p2B6AMBlTwKXPm1tIuWjm78zW2ITJ7qia2GG6HGXCicrFdculfoS/q4rdaM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4rDG-0002ww-Dn; Sun, 09 Aug 2020 21:42:37 +0200 From: Lars Ingebrigtsen References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> <83eevekat8.fsf@gnu.org> <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> <83lfplis1e.fsf@gnu.org> <45DBB63C-62BC-483F-BF01-FEE39F2ED9F5@acm.org> <82110A68-1F5C-4B0B-AB0E-67B710B33C1A@acm.org> <87lfiot5ep.fsf@gnus.org> <18CECA70-D003-4993-A47E-152A9E1AED1C@acm.org> Date: Sun, 09 Aug 2020 21:42:33 +0200 In-Reply-To: <18CECA70-D003-4993-A47E-152A9E1AED1C@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Sun, 9 Aug 2020 15:28:11 +0200") Message-ID: <87wo27a9na.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= writes: > 9 aug. 2020 kl. 13.39 skrev Lars Ingebrigtsen : > >> If I'm reading this thread right, the specific problem in this bug >> report was fixed (and the documentation of add-to-list upda [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd writes: > 9 aug. 2020 kl. 13.39 skrev Lars Ingebrigtsen : > >> If I'm reading this thread right, the specific problem in this bug >> report was fixed (and the documentation of add-to-list updated), but the >> more general problem of going through all the instances of add-to-list >> (and friends) in lexical files hasn't been done? > > No, I believe add-to-list calls have been updated and I would be happy > to mark the bug as done. > Stefan alluded to some improvement possibilities in the hook function > documentation (re the difference between variables and hooks). OK; then I'll just close this bug report, and if a new bug report about those improvements can be opened (if that helps to track any work to be done in this area). --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 09 15:42:54 2020 Received: (at control) by debbugs.gnu.org; 9 Aug 2020 19:42:54 +0000 Received: from localhost ([127.0.0.1]:33518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4rDa-0006Da-A3 for submit@debbugs.gnu.org; Sun, 09 Aug 2020 15:42:54 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4rDZ-0006DK-3v for control@debbugs.gnu.org; Sun, 09 Aug 2020 15:42:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BiXQep8qSUR1TMOZRLuEobSCfVMc8nF1uEXNMnfUSVQ=; b=QjTxs1bDZhp4OpoZeCO0QTZCFr PJvNnJngZg0xlFNZbRG/6Y5N4a3fHAc0adpWVl/aAUEIi5GOXTna4Oy//4kZ341NaScCxcSXf4BNc wGICf59kp4xf7iSMjmbQaojDBPEBkhlr+38JNxo838klxrGJSzzB5MK3MshCYzcuMdQQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4rDQ-0002x8-VP for control@debbugs.gnu.org; Sun, 09 Aug 2020 21:42:47 +0200 Date: Sun, 09 Aug 2020 21:42:43 +0200 Message-Id: <87v9hra9n0.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #39373 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 39373 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 39373 quit