GNU bug report logs - #39366
guix offload sometimes can use ~/.ssh/config, sometimes not

Previous Next

Full log

Message #17 received at 39366 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 39366 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: bug#39366: guix offload sometimes can use ~/.ssh/config,
 sometimes not
Date: Mon, 03 Jan 2022 18:24:30 +0100

Hi,

On Mon, 03 Jan 2022 at 17:58, Ludovic Courtès <ludo <at> gnu.org> wrote:

>>> We could instruct ‘guix offload’ to always ignore ~/.ssh/config, but
>>> that wouldn’t be great because using it can be useful.
>>
>> Well, I am in favor of POLA.
>
> Yeah, actually that would be in line with
> bd8345777f5a48ee61656248655ebac71a09e926.
>
> How about this:
>
> diff --git a/guix/scripts/offload.scm b/guix/scripts/offload.scm
> index 9ddf458c13..925325ef5f 100644
> --- a/guix/scripts/offload.scm
> +++ b/guix/scripts/offload.scm
> @@ -231,6 +231,9 @@ (define* (open-ssh-session machine #:optional max-silent-time)
>                                 ;; stateless instead.
>                                 #:knownhosts "/dev/null"
>  
> +                               ;; Likewise for ~/.ssh/config.
> +                               #:config "/dev/null"
> +
>                                 ;; We need lightweight compression when
>                                 ;; exchanging full archives.
>                                 #:compression

I am not enough familiar with this part of code but it sounds reasonable
since it is indeed aligned with the mentioned commit
bd8345777f5a48ee61656248655ebac71a09e926. :-)


Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.