Subject: Re: bug#39364: [PATCH] rmdir: fix clobbered errno

From: Pádraig Brady <[email-masked]>
Date: Fri, 7 Feb 2020 13:58:33 +0000

On 06/02/2020 18:04, Bernhard Voelker wrote:
> On 2020-02-04 20:21, Pádraig Brady wrote:
>> pushed. marking done
> 
> Hi Padraig,
> 
> I just noticed that 'is_empty_dir' from 'src/system.h' is also used
> in 'src/remove.c', so - without having looked there yet - it could
> be that the patch changed something in rm(1) as well (good or bad).
> Did you check?

Yes the existing is_empty_dir() interface didn't change.
We just added more info (errno) in the non empty case,
that is not inspected by remove.c (which is fine for its uses).

thanks for checking,
Pádraig