From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 30 08:55:17 2020 Received: (at submit) by debbugs.gnu.org; 30 Jan 2020 13:55:17 +0000 Received: from localhost ([127.0.0.1]:35064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixAHs-0004ri-QC for submit@debbugs.gnu.org; Thu, 30 Jan 2020 08:55:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:53261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixAHq-0004ra-ET for submit@debbugs.gnu.org; Thu, 30 Jan 2020 08:55:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54120) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixAHo-0005wl-1g for bug-coreutils@gnu.org; Thu, 30 Jan 2020 08:55:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.0 required=5.0 tests=BAYES_50,PDS_BTC_ID, PDS_BTC_MSGID,RCVD_IN_DNSWL_NONE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixAHk-0006YQ-P9 for bug-coreutils@gnu.org; Thu, 30 Jan 2020 08:55:10 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:50655 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ixAHk-0006Xr-DJ for bug-coreutils@gnu.org; Thu, 30 Jan 2020 08:55:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580392507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mCpDenraPKyGqKyTKj4UQBHHU2gjbP/sBSPxMFQWWIE=; b=JSR8DltZsBIGZLpyRVf2rx4uU41ORqmbbcsNkaVtGce8cvvfw1qxEvtfex74xNrb79jRyG 2p2CZGhjPhWxmLV0kCod+FgZeTn1HvaZOgFkIn5e8VSMn1vV8huna/GV2auHtUQrwWpS88 n4l6WXx+fEkM99uYrdginzFVbD+aiOQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-xbkLM4AbP821vFduGPvyZg-1; Thu, 30 Jan 2020 08:53:57 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 52B59800E21 for ; Thu, 30 Jan 2020 13:53:56 +0000 (UTC) Received: from nbkamil.localnet (unknown [10.43.7.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id A845A77921 for ; Thu, 30 Jan 2020 13:53:55 +0000 (UTC) From: Kamil Dudka To: bug-coreutils@gnu.org Subject: tests/cp/proc-short-read.sh fails in modern build environment Date: Thu, 30 Jan 2020 14:53:54 +0100 Message-ID: <5565935.lOV4Wx5bFT@nbkamil> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: xbkLM4AbP821vFduGPvyZg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tests/cp/proc-short-read.sh expects that a pair of subsequent reads from /proc/kallsyms will always return the same content. This does not seem to be a safe assumption any more. The test has started t [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: proc-short-read.sh] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=kdudka%40redhat.com; ip=209.51.188.17; r=debbugs.gnu.org] 0.5 PDS_BTC_ID FP reduced Bitcoin ID 0.7 PDS_BTC_MSGID Bitcoin ID with T_MSGID_NOFQDN2 X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) tests/cp/proc-short-read.sh expects that a pair of subsequent reads from /proc/kallsyms will always return the same content. This does not seem to be a safe assumption any more. The test has started to fail in our build environment. I am not sure how to fix the test. We could probably make it use another file from /proc but most of them are much smaller than kallsyms and/or suffer from the same problem. Output of the failing test follows. Kamil FAIL: tests/cp/proc-short-read ============================== ++ initial_cwd_=/builddir/build/BUILD/coreutils-8.31/separate +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /builddir/build/BUILD/coreutils-8.31/separate gt-proc-short-read.sh.XXXX +++ case $# in +++ destdir_=/builddir/build/BUILD/coreutils-8.31/separate +++ template_=gt-proc-short-read.sh.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ destdir_slash_=/builddir/build/BUILD/coreutils-8.31/separate/ +++ case $template_ in ++++ unset TMPDIR +++ d=/builddir/build/BUILD/coreutils-8.31/separate/gt-proc-short-read.sh.lINR +++ case $d in +++ : +++ test -d /builddir/build/BUILD/coreutils-8.31/separate/gt-proc-short-read.sh.lINR ++++ ls -dgo /builddir/build/BUILD/coreutils-8.31/separate/gt-proc-short-read.sh.lINR +++ perms='drwx------. 2 4096 Jan 29 12:04 /builddir/build/BUILD/coreutils-8.31/separate/gt-proc-short-read.sh.lINR' +++ case $perms in +++ : +++ echo /builddir/build/BUILD/coreutils-8.31/separate/gt-proc-short-read.sh.lINR +++ return ++ test_dir_=/builddir/build/BUILD/coreutils-8.31/separate/gt-proc-short-read.sh.lINR ++ cd /builddir/build/BUILD/coreutils-8.31/separate/gt-proc-short-read.sh.lINR ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ./src + test 1 '!=' 0 + path_dir_=./src + case $path_dir_ in + abs_path_dir_=/builddir/build/BUILD/coreutils-8.31/separate/./src + case $abs_path_dir_ in + PATH=/builddir/build/BUILD/coreutils-8.31/separate/./src:/builddir/build/BUILD/coreutils-8.31/separate/src:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin + create_exe_shims_ /builddir/build/BUILD/coreutils-8.31/separate/./src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ cp + require_built_ cp + skip_=no + for i in "$@" + case " $built_programs " in + test no = yes + test yes = yes + local i + for i in $* + env cp --version cp (GNU coreutils) 8.31 Copyright (C) 2019 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Torbjorn Granlund, David MacKenzie, and Jim Meyering. + kall=/proc/kallsyms + test -r /proc/kallsyms + cp /proc/kallsyms 1 + cat /proc/kallsyms + compare 1 2 + compare_dev_null_ 1 2 + test 2 = 2 + test x1 = x/dev/null + test x2 = x/dev/null + return 2 + case $? in + compare_ 1 2 + diff -u 1 2 --- 1 2020-01-29 12:04:36.923963121 +0000 +++ 2 2020-01-29 12:04:37.026963484 +0000 @@ -114819,81 +114819,132 @@ 0000000000000000 t nfs_file_direct_read.cold [nfs] 0000000000000000 t nfs_file_direct_write.cold [nfs] 0000000000000000 r .LC0 [nfs] -0000000000000000 r .LC2 [nfs] -0000000000000000 r __ksymtab_nfs_pgio_current_mirror [nfs] -0000000000000000 r __kstrtab_nfs_pgio_current_mirror [nfs] -0000000000000000 r __ksymtab_nfs_pgheader_init [nfs] -0000000000000000 r __kstrtab_nfs_pgheader_init [nfs] -0000000000000000 r __ksymtab_nfs_async_iocounter_wait [nfs] -0000000000000000 r __kstrtab_nfs_async_iocounter_wait [nfs] -0000000000000000 r __ksymtab_nfs_release_request [nfs] -0000000000000000 r __kstrtab_nfs_release_request [nfs] -0000000000000000 r __ksymtab_nfs_wait_on_request [nfs] -0000000000000000 r __kstrtab_nfs_wait_on_request [nfs] -0000000000000000 r __ksymtab_nfs_generic_pg_test [nfs] -0000000000000000 r __kstrtab_nfs_generic_pg_test [nfs] -0000000000000000 r __ksymtab_nfs_pgio_header_alloc [nfs] -0000000000000000 r __kstrtab_nfs_pgio_header_alloc [nfs] -0000000000000000 r __ksymtab_nfs_pgio_header_free [nfs] -0000000000000000 r __kstrtab_nfs_pgio_header_free [nfs] -0000000000000000 r __ksymtab_nfs_initiate_pgio [nfs] -0000000000000000 r __kstrtab_nfs_initiate_pgio [nfs] -0000000000000000 r __ksymtab_nfs_generic_pgio [nfs] -0000000000000000 r __kstrtab_nfs_generic_pgio [nfs] -0000000000000000 r __ksymtab_nfs_pageio_resend [nfs] -0000000000000000 r __kstrtab_nfs_pageio_resend [nfs] -0000000000000000 t nfs_pgio_release [nfs] -0000000000000000 t nfs_initiate_pgio.cold [nfs] -0000000000000000 t nfs_pgio_prepare [nfs] -0000000000000000 t kmalloc_array [nfs] -0000000000000000 t nfs_pageio_error_cleanup.part.0 [nfs] -0000000000000000 t nfs_pageio_doio [nfs] -0000000000000000 t __nfs_create_request.part.0 [nfs] -0000000000000000 b nfs_page_cachep [nfs] -0000000000000000 r nfs_pgio_common_ops [nfs] -0000000000000000 t nfs_generic_pg_pgios [nfs] -0000000000000000 t nfs_create_subreq [nfs] -0000000000000000 t nfs_pgio_result [nfs] -0000000000000000 t nfs_pgio_result.cold [nfs] -0000000000000000 r __func__.77615 [nfs] -0000000000000000 t __nfs_pageio_add_request [nfs] -0000000000000000 t nfs_do_recoalesce [nfs] -0000000000000000 t nfs_unlock_request.cold [nfs] -0000000000000000 t nfs_page_group_destroy [nfs] -0000000000000000 r .LC2 [nfs] -0000000000000000 r .LC3 [nfs] -0000000000000000 r .LC5 [nfs] -0000000000000000 r __ksymtab_nfs_pageio_init_read [nfs] -0000000000000000 r __kstrtab_nfs_pageio_init_read [nfs] -0000000000000000 r __ksymtab_nfs_pageio_reset_read_mds [nfs] -0000000000000000 r __kstrtab_nfs_pageio_reset_read_mds [nfs] -0000000000000000 r nfs_rw_read_ops [nfs] -0000000000000000 t nfs_initiate_read [nfs] -0000000000000000 t nfs_readhdr_free [nfs] -0000000000000000 b nfs_rdata_cachep [nfs] -0000000000000000 t nfs_readhdr_alloc [nfs] -0000000000000000 t nfs_readpage_release [nfs] -0000000000000000 t nfs_readpage_release.cold [nfs] -0000000000000000 t nfs_readpage_done [nfs] -0000000000000000 t nfs_readpage_result [nfs] -0000000000000000 t nfs_page_group_set_uptodate [nfs] -0000000000000000 t nfs_async_read_error [nfs] -0000000000000000 t nfs_return_empty_page [nfs] -0000000000000000 t nfs_read_completion [nfs] -0000000000000000 t readpage_async_filler [nfs] -0000000000000000 r nfs_async_read_completion_ops [nfs] -0000000000000000 t nfs_readpage.cold [nfs] -0000000000000000 t nfs_readpages.cold [nfs] -0000000000000000 r .LC0 [nfs] -0000000000000000 r .LC4 [nfs] -0000000000000000 r .LC5 [nfs] -0000000000000000 t nfs_symlink_filler [nfs] -0000000000000000 t nfs_get_link [nfs] -0000000000000000 r .LC1 [nfs] -0000000000000000 r .LC3 [nfs] -0000000000000000 t nfs_unlink_prepare [nfs] -0000000000000000 t nfs_rename_prepare [nfs] -0000000000000000 t nfs_do_call_unlink [nfs] +0000000000000000 r __func__.87038 [nfs] +0000000000000000 t __nfs_revalidate_inode.cold [nfs] +0000000000000000 t nfs_revalidate_mapping.cold [nfs] +0000000000000000 d nfs_net_ops [nfs] +0000000000000000 t exit_nfs_fs [nfs] +0000000000000000 r __param_enable_ino64 [nfs] +0000000000000000 r __param_str_enable_ino64 [nfs] +0000000000000000 r .LC15 [nfs] +0000000000000000 r __ksymtab_nfs_fs_type [nfs] +0000000000000000 r __kstrtab_nfs_fs_type [nfs] +0000000000000000 r __ksymtab_nfs_sops [nfs] +0000000000000000 r __kstrtab_nfs_sops [nfs] +0000000000000000 r __ksymtab_nfs4_fs_type [nfs] +0000000000000000 r __kstrtab_nfs4_fs_type [nfs] +0000000000000000 r __ksymtab_nfs_sb_active [nfs] +0000000000000000 r __kstrtab_nfs_sb_active [nfs] +0000000000000000 r __ksymtab_nfs_sb_deactive [nfs] +0000000000000000 r __kstrtab_nfs_sb_deactive [nfs] +0000000000000000 r __ksymtab_nfs_statfs [nfs] +0000000000000000 r __kstrtab_nfs_statfs [nfs] +0000000000000000 r __ksymtab_nfs_show_options [nfs] +0000000000000000 r __kstrtab_nfs_show_options [nfs] +0000000000000000 r __ksymtab_nfs_show_devname [nfs] +0000000000000000 r __kstrtab_nfs_show_devname [nfs] +0000000000000000 r __ksymtab_nfs_show_path [nfs] +0000000000000000 r __kstrtab_nfs_show_path [nfs] +0000000000000000 r __ksymtab_nfs_show_stats [nfs] +0000000000000000 r __kstrtab_nfs_show_stats [nfs] +0000000000000000 r __ksymtab_nfs_umount_begin [nfs] +0000000000000000 r __kstrtab_nfs_umount_begin [nfs] +0000000000000000 r __ksymtab_nfs_auth_info_match [nfs] +0000000000000000 r __kstrtab_nfs_auth_info_match [nfs] +0000000000000000 r __ksymtab_nfs_try_mount [nfs] +0000000000000000 r __kstrtab_nfs_try_mount [nfs] +0000000000000000 r __ksymtab_nfs_remount [nfs] +0000000000000000 r __kstrtab_nfs_remount [nfs] +0000000000000000 r __ksymtab_nfs_fill_super [nfs] +0000000000000000 r __kstrtab_nfs_fill_super [nfs] +0000000000000000 r __ksymtab_nfs_set_sb_security [nfs] +0000000000000000 r __kstrtab_nfs_set_sb_security [nfs] +0000000000000000 r __ksymtab_nfs_clone_sb_security [nfs] +0000000000000000 r __kstrtab_nfs_clone_sb_security [nfs] +0000000000000000 r __ksymtab_nfs_fs_mount_common [nfs] +0000000000000000 r __kstrtab_nfs_fs_mount_common [nfs] +0000000000000000 r __ksymtab_nfs_fs_mount [nfs] +0000000000000000 r __kstrtab_nfs_fs_mount [nfs] +0000000000000000 r __ksymtab_nfs_kill_super [nfs] +0000000000000000 r __kstrtab_nfs_kill_super [nfs] +0000000000000000 r __ksymtab_nfs_callback_nr_threads [nfs] +0000000000000000 r __kstrtab_nfs_callback_nr_threads [nfs] +0000000000000000 r __ksymtab_nfs_callback_set_tcpport [nfs] +0000000000000000 r __kstrtab_nfs_callback_set_tcpport [nfs] +0000000000000000 r __ksymtab_nfs_idmap_cache_timeout [nfs] +0000000000000000 r __kstrtab_nfs_idmap_cache_timeout [nfs] +0000000000000000 r __ksymtab_nfs4_disable_idmapping [nfs] +0000000000000000 r __kstrtab_nfs4_disable_idmapping [nfs] +0000000000000000 r __ksymtab_max_session_slots [nfs] +0000000000000000 r __kstrtab_max_session_slots [nfs] +0000000000000000 r __ksymtab_max_session_cb_slots [nfs] +0000000000000000 r __kstrtab_max_session_cb_slots [nfs] +0000000000000000 r __ksymtab_send_implementation_id [nfs] +0000000000000000 r __kstrtab_send_implementation_id [nfs] +0000000000000000 r __ksymtab_nfs4_client_id_uniquifier [nfs] +0000000000000000 r __kstrtab_nfs4_client_id_uniquifier [nfs] +0000000000000000 r __ksymtab_recover_lost_locks [nfs] +0000000000000000 r __kstrtab_recover_lost_locks [nfs] +0000000000000000 t nfs_initialise_sb [nfs] +0000000000000000 t nfs_clone_super [nfs] +0000000000000000 t nfs_statfs.cold [nfs] +0000000000000000 r __func__.79706 [nfs] +0000000000000000 t nfs_show_mount_options [nfs] +0000000000000000 r nfs_info.79771 [nfs] +0000000000000000 r sec_flavours.79718 [nfs] +0000000000000000 t nfs_parse_security_flavors [nfs] +0000000000000000 r nfs_secflavor_tokens [nfs] +0000000000000000 r CSWTCH.283 [nfs] +0000000000000000 t nfs_parse_security_flavors.cold [nfs] +0000000000000000 t nfs_get_option_ul [nfs] +0000000000000000 t param_set_portnr [nfs] +0000000000000000 t nfs_parse_mount_options [nfs] +0000000000000000 r nfs_mount_option_tokens [nfs] +0000000000000000 r nfs_xprt_protocol_tokens [nfs] +0000000000000000 d nfs_lookupcache_tokens [nfs] +0000000000000000 d nfs_local_lock_tokens [nfs] +0000000000000000 d nfs_vers_tokens [nfs] +0000000000000000 t nfs_parse_mount_options.cold [nfs] +0000000000000000 t nfs_set_super [nfs] +0000000000000000 t nfs_compare_super [nfs] +0000000000000000 t nfs_xdev_mount [nfs] +0000000000000000 t nfs_xdev_mount.cold [nfs] +0000000000000000 t nfs_verify_server_address [nfs] +0000000000000000 t nfs_verify_server_address.cold [nfs] +0000000000000000 t nfs_free_parsed_mount_data.part.0 [nfs] +0000000000000000 t nfs_request_mount.constprop.0 [nfs] +0000000000000000 t nfs_request_mount.constprop.0.cold [nfs] +0000000000000000 t nfs_try_mount.cold [nfs] +0000000000000000 t nfs_alloc_parsed_mount_data [nfs] +0000000000000000 t nfs_fs_mount.cold [nfs] +0000000000000000 d acl_shrinker [nfs] +0000000000000000 r __param_recover_lost_locks [nfs] +0000000000000000 r __param_str_recover_lost_locks [nfs] +0000000000000000 r __param_send_implementation_id [nfs] +0000000000000000 r __param_str_send_implementation_id [nfs] +0000000000000000 r __param_max_session_cb_slots [nfs] +0000000000000000 r __param_str_max_session_cb_slots [nfs] +0000000000000000 r __param_max_session_slots [nfs] +0000000000000000 r __param_str_max_session_slots [nfs] +0000000000000000 r __param_nfs4_unique_id [nfs] +0000000000000000 r __param_str_nfs4_unique_id [nfs] +0000000000000000 r __param_string_nfs4_unique_id [nfs] +0000000000000000 r __param_nfs4_disable_idmapping [nfs] +0000000000000000 r __param_str_nfs4_disable_idmapping [nfs] +0000000000000000 r __param_nfs_idmap_cache_timeout [nfs] +0000000000000000 r __param_str_nfs_idmap_cache_timeout [nfs] +0000000000000000 r __param_callback_nr_threads [nfs] +0000000000000000 r __param_str_callback_nr_threads [nfs] +0000000000000000 r __param_callback_tcpport [nfs] +0000000000000000 r __param_str_callback_tcpport [nfs] +0000000000000000 r param_ops_portnr [nfs] +0000000000000000 r .LC120 [nfs] +0000000000000000 r __ksymtab_nfs_dreq_bytes_left [nfs] +0000000000000000 r __kstrtab_nfs_dreq_bytes_left [nfs] +0000000000000000 t nfs_direct_count_bytes [nfs] +0000000000000000 t nfs_direct_pgio_init [nfs] +0000000000000000 t nfs_direct_set_hdr_verf [nfs] +0000000000000000 t nfs_direct_wait [nfs] 0000000000000000 r nfs_unlink_ops [nfs] 0000000000000000 t nfs_async_unlink_done [nfs] 0000000000000000 t nfs_async_rename_done [nfs] + fail=1 + md5sum /proc/kallsyms + md5sum 2 + sed 's/ .*//' 3 + sed 's/ .*//' 4 + compare sum.proc sum.2 + compare_dev_null_ sum.proc sum.2 + test 2 = 2 + test xsum.proc = x/dev/null + test xsum.2 = x/dev/null + return 2 + case $? in + compare_ sum.proc sum.2 + diff -u sum.proc sum.2 --- sum.proc 2020-01-29 12:04:37.172963999 +0000 +++ sum.2 2020-01-29 12:04:37.175964009 +0000 @@ -1 +1 @@ -226cd09830f68c56edda0b9272be66e4 +37d7e78173b2a31d5f27cc66aa52e72a + fail=1 + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + : + test '' = yes + cd /builddir/build/BUILD/coreutils-8.31/separate + chmod -R u+rwx /builddir/build/BUILD/coreutils-8.31/separate/gt-proc-short-read.sh.lINR + rm -rf /builddir/build/BUILD/coreutils-8.31/separate/gt-proc-short-read.sh.lINR + exit 1 FAIL tests/cp/proc-short-read.sh (exit status: 1) From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 03 19:45:21 2020 Received: (at 39357) by debbugs.gnu.org; 4 Feb 2020 00:45:21 +0000 Received: from localhost ([127.0.0.1]:42331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iymL6-0006Y7-Vx for submit@debbugs.gnu.org; Mon, 03 Feb 2020 19:45:20 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:39199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iymL4-0006Xp-AR for 39357@debbugs.gnu.org; Mon, 03 Feb 2020 19:45:15 -0500 Received: by mail-wr1-f66.google.com with SMTP id y11so20743639wrt.6 for <39357@debbugs.gnu.org>; Mon, 03 Feb 2020 16:45:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=nQpyYnlwek6mXT3ySGxAGKqkleRwrc+FWzrlW7Bhpc8=; b=jKX8f3Jkdd5vMoFdg6kHXG/xcmGsvTxgGMf3pdVHv/kQXvL0gY7RjjgLzZiVWhVFs+ qqdYEP3quyNKrNB8+JC4uHosMrnPaWuF2Wefo/GNuVQ8AyEKgfUMdCvsgC19MWNnoJ9f GuYbA8AFEWMroYxsbKJKDpo4LyE+4bnMdfW515ZXkrPUUCf+Rzl4Xn4c1UFZVPO5m6w4 IsPmrTz46ujTe0YqatVuR3sgbzFNqIP2llF9Oh5LE3bNaCD1AQ9ZdPjmAKDSfLZYjK6w J0fy+M22Hvy3X/uCvCcvAmbMZqvStFOFBCXqunM1QPvEFWsw0QrSxwWH9pLS0jxelvtO 0Kdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=nQpyYnlwek6mXT3ySGxAGKqkleRwrc+FWzrlW7Bhpc8=; b=i7iQv3Ose/YJZirdH/z2BXrQRHuD/tA68p8oxQXsh2T9DgICF6OXCZso9JA3F7OQXt vShN65DQSIigujV1iYuMbGINPq+uNTtWLEZ/sEW4dhAY+bRN434rzorpqwYnd8lI822K IoAdm8HHjc1My/E/IEJglHqP+LuaVe/8Je8NpJ1YA38T01HAOQ7J3BiO/dg2SIHNWqJk mFrAjvhbDDzEkk43c/0vBKwYcIK8suMxGuNAYlqcGr41Z+2YYbR2hwWVMJS3zLRbh3ed n3nB5U70e3lSFOCa26gSYa4l8zsHWyX1vPp1/iEpbFK0DyMDbkEjrB+8ojB5V1x+c0EG +AvA== X-Gm-Message-State: APjAAAUyA0F/xAZRdeFClacQ6W44gD7mg2h3t577NAun+NoQNLPidsZB FCtn540FP3PHc1dHHe0tJwm+hisAnqU= X-Google-Smtp-Source: APXvYqyzl6Ide2sKaujzIlkvPiumKvD0SCtQk4a9XubndK/P4ZZi44n03MQtWXuyJ3yuElvr4VtGhg== X-Received: by 2002:a5d:63c7:: with SMTP id c7mr20038086wrw.158.1580777108178; Mon, 03 Feb 2020 16:45:08 -0800 (PST) Received: from localhost.localdomain (86-42-14-227-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.42.14.227]) by smtp.googlemail.com with ESMTPSA id x132sm2139730wmg.0.2020.02.03.16.45.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Feb 2020 16:45:07 -0800 (PST) Subject: Re: bug#39357: tests/cp/proc-short-read.sh fails in modern build environment To: Kamil Dudka , 39357@debbugs.gnu.org References: <5565935.lOV4Wx5bFT@nbkamil> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: Date: Tue, 4 Feb 2020 00:45:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Thunderbird/73.0 MIME-Version: 1.0 In-Reply-To: <5565935.lOV4Wx5bFT@nbkamil> Content-Type: multipart/mixed; boundary="------------22000CBFA4D5503744F8BCCA" Content-Language: en-US X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 39357 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------22000CBFA4D5503744F8BCCA Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 30/01/2020 13:53, Kamil Dudka wrote: > tests/cp/proc-short-read.sh expects that a pair of subsequent reads from > /proc/kallsyms will always return the same content. This does not seem to > be a safe assumption any more. The test has started to fail in our build > environment. I am not sure how to fix the test. We could probably make > it use another file from /proc but most of them are much smaller than > kallsyms and/or suffer from the same problem. Output of the failing test > follows. > > Kamil > > > FAIL: tests/cp/proc-short-read > ============================== > + compare_ 1 2 > + diff -u 1 2 > --- 1 2020-01-29 12:04:36.923963121 +0000 > +++ 2 2020-01-29 12:04:37.026963484 +0000 > @@ -114819,81 +114819,132 @@ > 0000000000000000 t nfs_file_direct_read.cold [nfs] > 0000000000000000 t nfs_file_direct_write.cold [nfs] > 0000000000000000 r .LC0 [nfs] > -0000000000000000 r .LC2 [nfs] > -0000000000000000 r __ksymtab_nfs_pgio_current_mirror [nfs] > -0000000000000000 r __kstrtab_nfs_pgio_current_mirror [nfs] > +0000000000000000 r __func__.87038 [nfs] > +0000000000000000 t __nfs_revalidate_inode.cold [nfs] > +0000000000000000 t nfs_revalidate_mapping.cold [nfs] > +0000000000000000 d nfs_net_ops [nfs] > +0000000000000000 t exit_nfs_fs [nfs] > +0000000000000000 r __param_enable_ino64 [nfs] > +0000000000000000 r __param_str_enable_ino64 [nfs] > +0000000000000000 r .LC15 [nfs] > +0000000000000000 r __ksymtab_nfs_fs_type [nfs] > +0000000000000000 r __kstrtab_nfs_fs_type [nfs] > + fail=1 > + md5sum /proc/kallsyms > + md5sum 2 > + sed 's/ .*//' 3 > + sed 's/ .*//' 4 > + compare sum.proc sum.2 > + compare_dev_null_ sum.proc sum.2 > + test 2 = 2 > + test xsum.proc = x/dev/null > + test xsum.2 = x/dev/null > + return 2 > + case $? in > + compare_ sum.proc sum.2 > + diff -u sum.proc sum.2 > --- sum.proc 2020-01-29 12:04:37.172963999 +0000 > +++ sum.2 2020-01-29 12:04:37.175964009 +0000 > @@ -1 +1 @@ > -226cd09830f68c56edda0b9272be66e4 > +37d7e78173b2a31d5f27cc66aa52e72a > + fail=1 Interesting. The attached changes to /proc/cpuinfo which is a bit more awkward, but should be a valid test most of the time, and is also the file for which the original bug report was against. cheers, Pádraig --------------22000CBFA4D5503744F8BCCA Content-Type: text/x-patch; charset=UTF-8; name="proc-kallsyms.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="proc-kallsyms.patch" >From 309dcf79f097fc547edbd82cd6601d111277c4f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Tue, 4 Feb 2020 00:37:23 +0000 Subject: [PATCH] tests: avoid false failure due to varying /proc/kallsyms * tests/cp/proc-short-read.sh: Switch to using /proc/cpuinfo, rather than /proc/kallsyms which was seen to vary in some cases. Fixes https://bugs.gnu.org/39357 --- tests/cp/proc-short-read.sh | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/tests/cp/proc-short-read.sh b/tests/cp/proc-short-read.sh index 6c58881de..dcc8b30d5 100755 --- a/tests/cp/proc-short-read.sh +++ b/tests/cp/proc-short-read.sh @@ -19,22 +19,18 @@ . "${srcdir=.}/tests/init.sh"; path_prepend_ ./src print_ver_ cp -kall=/proc/kallsyms +proc_large=/proc/cpuinfo # usually > 4KiB -test -r $kall || skip_ "your system lacks $kall" +test -r $proc_large || skip_ "your system lacks $proc_large" -# Before coreutils-7.3, cp would copy less than 4KiB of this 1MB+ file. -cp $kall 1 || fail=1 -cat $kall > 2 || fail=1 -compare 1 2 || fail=1 +# Before coreutils-7.3, cp would copy less than 4KiB of this file. +cp $proc_large 1 || fail=1 +cat $proc_large > 2 || fail=1 -# Also check md5sum, just for good measure. -md5sum $kall > 3 || fail=1 -md5sum 2 > 4 || fail=1 +# adjust varying parts +sed '/MHz/d; /bogomips/d;' 1 > proc.cp || framework_failure_ +sed '/MHz/d; /bogomips/d;' 2 > proc.cat || framework_failure_ -# Remove each file name before comparing checksums. -sed 's/ .*//' 3 > sum.proc || fail=1 -sed 's/ .*//' 4 > sum.2 || fail=1 -compare sum.proc sum.2 || fail=1 +compare proc.cp proc.cat || fail=1 Exit $fail -- 2.24.1 --------------22000CBFA4D5503744F8BCCA-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 04 05:34:17 2020 Received: (at submit) by debbugs.gnu.org; 4 Feb 2020 10:34:17 +0000 Received: from localhost ([127.0.0.1]:42642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyvX7-0001FF-92 for submit@debbugs.gnu.org; Tue, 04 Feb 2020 05:34:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:43542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyvX4-0001F6-MY for submit@debbugs.gnu.org; Tue, 04 Feb 2020 05:34:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58147) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyvX2-0001VE-Tr for bug-coreutils@gnu.org; Tue, 04 Feb 2020 05:34:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.3 required=5.0 tests=BAYES_50,PDS_BTC_ID, PDS_BTC_MSGID,RCVD_IN_DNSWL_NONE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iyvX1-0007E9-2e for bug-coreutils@gnu.org; Tue, 04 Feb 2020 05:34:12 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:53973 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iyvX0-0007B6-NV for bug-coreutils@gnu.org; Tue, 04 Feb 2020 05:34:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580812449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tF5pkb1x9XHMCtifeQVSlt2uQJEc1TPUTj85mm24rXs=; b=LvNfMXYQH8TB4MbQ9UQr6beyoZA13NA2TvQrHQg9g36K56fNy2roy1fwbJIZLJ40mhG61T IfnRx0uA6Qk9Hp4ggYacLIISFnThnI4yGV+ad3Q4CuCwD7Mv9ZUSMrbeSx0dqMaXPC4s1Z OkoCvcJi4JG6DCdfyd6AKwCIcHmifJc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-365-dtSqVY6tNsie_j55GgcIrg-1; Tue, 04 Feb 2020 05:34:04 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0272F8C4A1C; Tue, 4 Feb 2020 10:34:03 +0000 (UTC) Received: from nbkamil.localnet (unknown [10.43.7.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id 26ED410018FF; Tue, 4 Feb 2020 10:34:01 +0000 (UTC) From: Kamil Dudka To: =?ISO-8859-1?Q?P=E1draig?= Brady Subject: Re: bug#39357: tests/cp/proc-short-read.sh fails in modern build environment Date: Tue, 04 Feb 2020 11:34:00 +0100 Message-ID: <4549007.GXAFRqVoOG@nbkamil> In-Reply-To: References: <5565935.lOV4Wx5bFT@nbkamil> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: dtSqVY6tNsie_j55GgcIrg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Tuesday, February 4, 2020 1:45:06 AM CET P�draig Brady wrote: > On 30/01/2020 13:53, Kamil Dudka wrote: > > tests/cp/proc-short-read.sh expects that a pair of subsequent reads from > > /proc/kallsy [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: proc-short-read.sh] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=kdudka%40redhat.com;ip=209.51.188.17;r=debbugs.gnu.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 PDS_BTC_ID FP reduced Bitcoin ID 1.0 PDS_BTC_MSGID Bitcoin ID with T_MSGID_NOFQDN2 X-Debbugs-Envelope-To: submit Cc: 39357@debbugs.gnu.org, bug-coreutils@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On Tuesday, February 4, 2020 1:45:06 AM CET P=E1draig Brady wrote: > On 30/01/2020 13:53, Kamil Dudka wrote: > > tests/cp/proc-short-read.sh expects that a pair of subsequent reads fro= m > > /proc/kallsyms will always return the same content. This does not seem= to > > be a safe assumption any more. The test has started to fail in our bui= ld > > environment. I am not sure how to fix the test. We could probably mak= e > > it use another file from /proc but most of them are much smaller than > > kallsyms and/or suffer from the same problem. Output of the failing te= st > > follows. > >=20 > > Kamil > >=20 > >=20 > > FAIL: tests/cp/proc-short-read > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > >=20 > > + compare_ 1 2 > > + diff -u 1 2 > > --- 1=092020-01-29 12:04:36.923963121 +0000 > > +++ 2=092020-01-29 12:04:37.026963484 +0000 > > @@ -114819,81 +114819,132 @@ > >=20 > > 0000000000000000 t nfs_file_direct_read.cold=09[nfs] > > 0000000000000000 t nfs_file_direct_write.cold=09[nfs] > > 0000000000000000 r .LC0=09[nfs] > >=20 > > -0000000000000000 r .LC2=09[nfs] > > -0000000000000000 r __ksymtab_nfs_pgio_current_mirror=09[nfs] > > -0000000000000000 r __kstrtab_nfs_pgio_current_mirror=09[nfs] > >=20 > > +0000000000000000 r __func__.87038=09[nfs] > > +0000000000000000 t __nfs_revalidate_inode.cold=09[nfs] > > +0000000000000000 t nfs_revalidate_mapping.cold=09[nfs] > > +0000000000000000 d nfs_net_ops=09[nfs] > > +0000000000000000 t exit_nfs_fs=09[nfs] > > +0000000000000000 r __param_enable_ino64=09[nfs] > > +0000000000000000 r __param_str_enable_ino64=09[nfs] > > +0000000000000000 r .LC15=09[nfs] > > +0000000000000000 r __ksymtab_nfs_fs_type=09[nfs] > > +0000000000000000 r __kstrtab_nfs_fs_type=09[nfs] > >=20 > > + fail=3D1 > > + md5sum /proc/kallsyms > > + md5sum 2 > > + sed 's/ .*//' 3 > > + sed 's/ .*//' 4 > > + compare sum.proc sum.2 > > + compare_dev_null_ sum.proc sum.2 > > + test 2 =3D 2 > > + test xsum.proc =3D x/dev/null > > + test xsum.2 =3D x/dev/null > > + return 2 > > + case $? in > > + compare_ sum.proc sum.2 > > + diff -u sum.proc sum.2 > > --- sum.proc=092020-01-29 12:04:37.172963999 +0000 > > +++ sum.2=092020-01-29 12:04:37.175964009 +0000 > > @@ -1 +1 @@ > > -226cd09830f68c56edda0b9272be66e4 > > +37d7e78173b2a31d5f27cc66aa52e72a > > + fail=3D1 >=20 > Interesting. > The attached changes to /proc/cpuinfo > which is a bit more awkward, but should be a valid test most of the time, > and is also the file for which the original bug report was against. >=20 > cheers, > P=E1draig Neither the content of /proc/cpuinfo is guaranteed to be immutable because= =20 CPUs can go online/offline at run time. Anyway, the proposed patch has passed my quick test. So I think it is an improvement over status quo.=20 Thanks! Kamil From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 04 14:23:15 2020 Received: (at submit) by debbugs.gnu.org; 4 Feb 2020 19:23:15 +0000 Received: from localhost ([127.0.0.1]:44788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz3n0-00082V-QJ for submit@debbugs.gnu.org; Tue, 04 Feb 2020 14:23:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:53051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz3mz-00082O-FD for submit@debbugs.gnu.org; Tue, 04 Feb 2020 14:23:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50350) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz3my-0004iL-9U for bug-coreutils@gnu.org; Tue, 04 Feb 2020 14:23:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_50,BITCOIN_SPAM_02, FREEMAIL_FROM,PDS_BTC_ID,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iz3mx-0003VU-7K for bug-coreutils@gnu.org; Tue, 04 Feb 2020 14:23:12 -0500 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:52579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iz3mx-0003Mj-0I for bug-coreutils@gnu.org; Tue, 04 Feb 2020 14:23:11 -0500 Received: by mail-wm1-x344.google.com with SMTP id p9so4592803wmc.2 for ; Tue, 04 Feb 2020 11:23:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Xg+01NFT5ysphigXyZymVansWw7F1X0BhI/duXlPLkA=; b=r/phxa2pe3dnpqpSyhXrWeszmL7KIvq2l8XvnNUMhIckUO9HnExxF/Aqp5/hcuFxWs 8KBU/IXOjxi0d+CFbnZJp5StRCkg6ILbhX9H+bti/Dr/F8j2JYEpYKIO9vQlnZp/8e0O WQ7zS7XevjDXk45PVNj03f3ekzIm8Z04b0lBDDLXwzAbazKMkOsXwS5hC3kcBF9L/HrA OMGbrqJ/j2QhaS3QuhZzhQk7ovtZbKecWYmJb9+se9yxxbO+u9Tphjkf1Cg0VenDD5jl 2Eg7mgptlQbPVGyiLea/+U0WEiib0QSdccz3dkl+qmdBXp5DWFIlqzzXoHhAGzDpYIr+ xezg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Xg+01NFT5ysphigXyZymVansWw7F1X0BhI/duXlPLkA=; b=OYKWce/pXHpjUZjcBiHO3z9zCC8V7c2XyZo4OvKKv8PhWMbnzmz7SMkPrFNrOIPqFx 4NLa7fg52yKnFu7wBjibubJbdLBiSv3nOE+h7snlcjwHifBs15D/o4UoTvGk5h2qdDeT 7TTwyTLZ7TeIMNmvxNH8VrJ5rGmIl2vVeR6kjjxlhlOR0bGJ25Uvljg/BZLwXN26bIWv bW1DsHRRwDU8EyEAjLvpNxaz4axvHi+Pbr6651/Om+epzzOgHh57qDx4PdE0reJlLnWV MLp2yQ1PAAJqFHEFAiBbXSB+PUtYJ4iOsWWdlhSqqIlUh1gLZdF0wxcfRaabiehDhfnh qYQQ== X-Gm-Message-State: APjAAAXYYZdNd7ycG+rcX50yNXGT+bbqzohH5EdXVI6hkU1/kijwkZdn 5Pc5Sx0XK0Wfms5HpqXqtQw= X-Google-Smtp-Source: APXvYqz6fxFudmdUoFtEaQXUE/5pPF6Ur9uc9etrH8uSHuOvO4fxKua7o3BMsc/OGUrPcpUpueSf6A== X-Received: by 2002:a1c:7406:: with SMTP id p6mr602981wmc.82.1580844189720; Tue, 04 Feb 2020 11:23:09 -0800 (PST) Received: from localhost.localdomain (86-42-14-227-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.42.14.227]) by smtp.googlemail.com with ESMTPSA id y7sm4650039wmd.1.2020.02.04.11.23.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Feb 2020 11:23:09 -0800 (PST) Subject: Re: bug#39357: tests/cp/proc-short-read.sh fails in modern build environment To: Kamil Dudka References: <5565935.lOV4Wx5bFT@nbkamil> <4549007.GXAFRqVoOG@nbkamil> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: Date: Tue, 4 Feb 2020 19:23:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Thunderbird/73.0 MIME-Version: 1.0 In-Reply-To: <4549007.GXAFRqVoOG@nbkamil> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 04/02/2020 10:34, Kamil Dudka wrote: > On Tuesday, February 4, 2020 1:45:06 AM CET Pádraig Brady wrote: >> On 30/01/2020 13:53, Kamil Dudka wrote: >>> tests/cp/proc-short-read.sh expects that a pa [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: proc-short-read.sh] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pixelbeat[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 0.5 PDS_BTC_ID FP reduced Bitcoin ID 0.0 BITCOIN_SPAM_02 BitCoin spam pattern 02 X-Debbugs-Envelope-To: submit Cc: 39357-done@debbugs.gnu.org, bug-coreutils@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) On 04/02/2020 10:34, Kamil Dudka wrote: > On Tuesday, February 4, 2020 1:45:06 AM CET Pádraig Brady wrote: >> On 30/01/2020 13:53, Kamil Dudka wrote: >>> tests/cp/proc-short-read.sh expects that a pair of subsequent reads from >>> /proc/kallsyms will always return the same content. This does not seem to >>> be a safe assumption any more. The test has started to fail in our build >>> environment. I am not sure how to fix the test. We could probably make >>> it use another file from /proc but most of them are much smaller than >>> kallsyms and/or suffer from the same problem. Output of the failing test >>> follows. >>> >>> Kamil >>> >>> >>> FAIL: tests/cp/proc-short-read >>> ============================== >>> >>> + compare_ 1 2 >>> + diff -u 1 2 >>> --- 1 2020-01-29 12:04:36.923963121 +0000 >>> +++ 2 2020-01-29 12:04:37.026963484 +0000 >>> @@ -114819,81 +114819,132 @@ >>> >>> 0000000000000000 t nfs_file_direct_read.cold [nfs] >>> 0000000000000000 t nfs_file_direct_write.cold [nfs] >>> 0000000000000000 r .LC0 [nfs] >>> >>> -0000000000000000 r .LC2 [nfs] >>> -0000000000000000 r __ksymtab_nfs_pgio_current_mirror [nfs] >>> -0000000000000000 r __kstrtab_nfs_pgio_current_mirror [nfs] >>> >>> +0000000000000000 r __func__.87038 [nfs] >>> +0000000000000000 t __nfs_revalidate_inode.cold [nfs] >>> +0000000000000000 t nfs_revalidate_mapping.cold [nfs] >>> +0000000000000000 d nfs_net_ops [nfs] >>> +0000000000000000 t exit_nfs_fs [nfs] >>> +0000000000000000 r __param_enable_ino64 [nfs] >>> +0000000000000000 r __param_str_enable_ino64 [nfs] >>> +0000000000000000 r .LC15 [nfs] >>> +0000000000000000 r __ksymtab_nfs_fs_type [nfs] >>> +0000000000000000 r __kstrtab_nfs_fs_type [nfs] >>> >>> + fail=1 >>> + md5sum /proc/kallsyms >>> + md5sum 2 >>> + sed 's/ .*//' 3 >>> + sed 's/ .*//' 4 >>> + compare sum.proc sum.2 >>> + compare_dev_null_ sum.proc sum.2 >>> + test 2 = 2 >>> + test xsum.proc = x/dev/null >>> + test xsum.2 = x/dev/null >>> + return 2 >>> + case $? in >>> + compare_ sum.proc sum.2 >>> + diff -u sum.proc sum.2 >>> --- sum.proc 2020-01-29 12:04:37.172963999 +0000 >>> +++ sum.2 2020-01-29 12:04:37.175964009 +0000 >>> @@ -1 +1 @@ >>> -226cd09830f68c56edda0b9272be66e4 >>> +37d7e78173b2a31d5f27cc66aa52e72a >>> + fail=1 >> >> Interesting. >> The attached changes to /proc/cpuinfo >> which is a bit more awkward, but should be a valid test most of the time, >> and is also the file for which the original bug report was against. >> >> cheers, >> Pádraig > > Neither the content of /proc/cpuinfo is guaranteed to be immutable because > CPUs can go online/offline at run time. Anyway, the proposed patch has > passed my quick test. So I think it is an improvement over status quo. pushed. marking done cheers, Pádraog From unknown Tue Aug 19 23:13:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Mar 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator