GNU bug report logs - #39354
enhancement request: hideshow should handle derived modes

Previous Next

Full log

Message #8 received at 39354 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tobias Zawada <i_inbox <at> tn-home.de>
Cc: 39354 <at> debbugs.gnu.org
Subject: Re: bug#39354: enhancement request: hideshow should handle derived
 modes
Date: Fri, 21 Aug 2020 14:42:48 +0200

Tobias Zawada <i_inbox <at> tn-home.de> writes:

> hideshow.el should handle derived modes.
> See discussion on emacs.SE about hideshow in sage-shell-mode (link: https://emacs.stackexchange.com/questions/55129/hs-minor-mode-and-sage-shell-mode-derived-from-python-mode#comment86297_55129).
>
> I propose following change on `hs-grok-mode-type` (perma-link:
> https://github.com/jwiegley/emacs-release/blob/adfd5933358fdf6715423dee8169eb3cd7d982db/lisp/progmodes/hideshow.el#L666):

[...]

> -      (let* ((lookup (assoc major-mode hs-special-modes-alist))
> +      (let* ((lookup (cl-assoc-if (lambda (mode)
> +				    (derived-mode-p major-mode mode))
> +				  hs-special-modes-alist))

Makes sense to me, so I've applied your patch to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.