From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 30 04:24:43 2020 Received: (at submit) by debbugs.gnu.org; 30 Jan 2020 09:24:43 +0000 Received: from localhost ([127.0.0.1]:34923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ix643-0004qo-Cd for submit@debbugs.gnu.org; Thu, 30 Jan 2020 04:24:43 -0500 Received: from lists.gnu.org ([209.51.188.17]:57591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ix641-0004qh-UG for submit@debbugs.gnu.org; Thu, 30 Jan 2020 04:24:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46304) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ix640-0008Rf-My for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 04:24:41 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ix63y-0003u3-BB for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 04:24:40 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:38257) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ix63y-0003pm-1V for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 04:24:38 -0500 Received: from oxbaltgw37.schlund.de ([172.19.246.45]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MGygv-1ijbns2RFr-00E8aj for ; Thu, 30 Jan 2020 10:24:35 +0100 Date: Thu, 30 Jan 2020 10:24:35 +0100 (CET) From: Tobias Zawada To: bug-gnu-emacs@gnu.org Message-ID: <1405743405.6348.1580376275497@email.ionos.de> Subject: enhancement request: hideshow should handle derived modes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.1-Rev25 X-Originating-Client: open-xchange-appsuite X-Provags-ID: V03:K1:g3iBx1h/VH6EaggQwUIbPleh2kDLaQZ9nzsduXWLMqsHxSX7Bxz X97niuQDUHXxeQWOru1gekadEpsdW1FhVSQhmCXfrAwD6fa3QfiHiZj38x0KXAk+8i8QuKy 3KuL/fd3P4FRJHTdVecAT9WvANOLFMXeb85XUsLY017ippi6X9Auo7hhsetVlcM42hxPJLF KkG+daVWoT70R0VTls66g== X-UI-Out-Filterresults: notjunk:1;V03:K0:AgsBX2vc1gM=:K6PyiaHp40C9cfPqdzvd6n eQuQTjfdvkadz316xU9jHj7DkJpyj5EO40WO1pJsvYV4Qjc2sJkeje3dqItGW4fZqlytmPYwX UjjLwvFxy5jhKBZG2BzB1NIUXd9DVEkMt0SaotieG3ogInZhzKXsHuDeyoWXlITqat1T+Tpnc RyJRrBJekkTJ8DlN20Rkm2j5G7JtZpxJP2AVeLIVcZmk8QNAdWucadtI7tIX776orJBRaBVZx HoZxy4UTCy4HBkyvGtSO6/XOQtwKqXhrDeGR8s0hAOfLkxHE072b40RH8xS08fWKbawPC1MRz 8xvsVHE2P6UQc1zugY8G34MyB3YLo/GokwfzPx9eANvtk2Lxa/WJqjzaWN8k9ZFZPKTr9kLR0 OFGtMchBZ3k4GQ+pYkRZh5+qlE8mQUs5xu3pGpVdr+LmDCS9teWaNj/4eBEt+232tP3WwNu+i bY07/FefSxs2aKxyqavxvuCRchF36+aFBHbL2yfWBJEiuHcEHA49boaNTX88BVp1AgB4MF9k7 0ahdNeu5OKjJkjLzzqM5UeKit+J5Jpoq/rOy7nPh0WUfVx3Y0PBUXglzqFYbRQkI8dw6kg2/c /tUuYOTJOu6bqY9GU2enJ4kfzRKbERfFQDf14mjFJxH1aeGqgSLxdebFNC9LeIZ6KptfHC1SY FcdXwUQlZU7qpUxoKghgWCtUMwx2A78GYCmAB9Q9wjlyg8leCYoHa09BqfMsNtNpAWXGY/MHp y4kU5LZ7+MNOzzGdnXJylt39N5usGsvGrv0nIHvcy4eu4uRPuewTTYH64RMbrl4qJbQOHq+BW EBw7+rOIUMY3Iq+8u1bHXDHUU7P5f3UaB6TAWwxayGJDsH5xBlSAMeJ5clf5WA8H+LqtolK X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.72.192.74 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, hideshow.el should handle derived modes. See discussion on emacs.SE about hideshow in sage-shell-mode (link: https://emacs.stackexchange.com/questions/55129/hs-minor-mode-and-sage-shell-mode-derived-from-python-mode#comment86297_55129). I propose following change on `hs-grok-mode-type` (perma-link: https://github.com/jwiegley/emacs-release/blob/adfd5933358fdf6715423dee8169eb3cd7d982db/lisp/progmodes/hideshow.el#L666): @@ -7,7 +7,9 @@ (if (and (boundp 'comment-start) (boundp 'comment-end) comment-start comment-end) - (let* ((lookup (assoc major-mode hs-special-modes-alist)) + (let* ((lookup (cl-assoc-if (lambda (mode) + (derived-mode-p major-mode mode)) + hs-special-modes-alist)) (start-elem (or (nth 1 lookup) "\\s("))) (if (listp start-elem) ;; handle (START-REGEXP MDATA-SELECT) The new version of `hs-grok-mode-type` in full would be: (defun hs-grok-mode-type () "Set up hideshow variables for new buffers. If `hs-special-modes-alist' has information associated with the current buffer's major mode, use that. Otherwise, guess start, end and `comment-start' regexps; `forward-sexp' function; and adjust-block-beginning function." (if (and (boundp 'comment-start) (boundp 'comment-end) comment-start comment-end) (let* ((lookup (cl-assoc-if (lambda (mode) (derived-mode-p major-mode mode)) hs-special-modes-alist)) (start-elem (or (nth 1 lookup) "\\s("))) (if (listp start-elem) ;; handle (START-REGEXP MDATA-SELECT) (setq hs-block-start-regexp (car start-elem) hs-block-start-mdata-select (cadr start-elem)) ;; backwards compatibility: handle simple START-REGEXP (setq hs-block-start-regexp start-elem hs-block-start-mdata-select 0)) (setq hs-block-end-regexp (or (nth 2 lookup) "\\s)") hs-c-start-regexp (or (nth 3 lookup) (let ((c-start-regexp (regexp-quote comment-start))) (if (string-match " +$" c-start-regexp) (substring c-start-regexp 0 (1- (match-end 0))) c-start-regexp))) hs-forward-sexp-func (or (nth 4 lookup) 'forward-sexp) hs-adjust-block-beginning (nth 5 lookup))) (setq hs-minor-mode nil) (error "%s Mode doesn't support Hideshow Minor Mode" (format-mode-line mode-name)))) Best regards, Tobias Zawada From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 21 08:43:05 2020 Received: (at 39354) by debbugs.gnu.org; 21 Aug 2020 12:43:05 +0000 Received: from localhost ([127.0.0.1]:45336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k96Nq-00084L-3h for submit@debbugs.gnu.org; Fri, 21 Aug 2020 08:43:05 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k96Nn-00083w-Q6 for 39354@debbugs.gnu.org; Fri, 21 Aug 2020 08:43:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Lt1o4MAI/JT0jVPFlpj/m+J+3qqsu5htwwg7sv8k0p4=; b=our+XsNHFV48GBLeYWrYW/N1LR n7XCFHYoJZKorPJj05De/Ib0uKkXBLZjcE2rZq8/ylsG3y2xyjDwhenZ294vKzs3YvjgHLjRQNxfv s6eO03Xgad/mtEL6RH7/n+MTyH//2LP5VM7NAWVYvxMheXvwLaTn9jt8nJUxcurqM0ok=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k96Nd-0003kJ-Pv; Fri, 21 Aug 2020 14:42:53 +0200 From: Lars Ingebrigtsen To: Tobias Zawada Subject: Re: bug#39354: enhancement request: hideshow should handle derived modes References: <1405743405.6348.1580376275497@email.ionos.de> X-Now-Playing: The Raincoats's _The Raincoats_: "Black and White" Date: Fri, 21 Aug 2020 14:42:48 +0200 In-Reply-To: <1405743405.6348.1580376275497@email.ionos.de> (Tobias Zawada's message of "Thu, 30 Jan 2020 10:24:35 +0100 (CET)") Message-ID: <87pn7k5fw7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Tobias Zawada writes: > hideshow.el should handle derived modes. > See discussion on emacs.SE about hideshow in sage-shell-mode (link: https://emacs.stackexchange.com/questions/55129/hs-minor-mode-and-sage-shell-mode-deriv [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39354 Cc: 39354@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tobias Zawada writes: > hideshow.el should handle derived modes. > See discussion on emacs.SE about hideshow in sage-shell-mode (link: https://emacs.stackexchange.com/questions/55129/hs-minor-mode-and-sage-shell-mode-derived-from-python-mode#comment86297_55129). > > I propose following change on `hs-grok-mode-type` (perma-link: > https://github.com/jwiegley/emacs-release/blob/adfd5933358fdf6715423dee8169eb3cd7d982db/lisp/progmodes/hideshow.el#L666): [...] > - (let* ((lookup (assoc major-mode hs-special-modes-alist)) > + (let* ((lookup (cl-assoc-if (lambda (mode) > + (derived-mode-p major-mode mode)) > + hs-special-modes-alist)) Makes sense to me, so I've applied your patch to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 21 08:43:11 2020 Received: (at control) by debbugs.gnu.org; 21 Aug 2020 12:43:11 +0000 Received: from localhost ([127.0.0.1]:45339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k96Ny-000850-Qx for submit@debbugs.gnu.org; Fri, 21 Aug 2020 08:43:11 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k96Nw-00084Z-NO for control@debbugs.gnu.org; Fri, 21 Aug 2020 08:43:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zPoawKz4DJZbpg88BKYn0bJCulj0hXgXF5JjEsmXoR8=; b=CNUu/ewyENReaI3T8IqGu8ZanK dXbvKBEwimSlOplAcvnVn0nHdc1OovhylrED+sORhksedPi2L8hXlcNCEDW4GhtyyyRRf/dd5G0r3 Layr04Ji9HooCjhEql9KsgWgklGFAQS07I+jKz8n6TS4NRtc87PLXGbR3hQRguhoN8ZM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k96No-0003kV-Vt for control@debbugs.gnu.org; Fri, 21 Aug 2020 14:43:03 +0200 Date: Fri, 21 Aug 2020 14:42:59 +0200 Message-Id: <87o8n45fvw.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #39354 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 39354 + patch tags 39354 fixed close 39354 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 39354 + patch tags 39354 fixed close 39354 28.1 quit From unknown Mon Aug 18 04:47:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 19 Sep 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator