From unknown Wed Jun 18 23:18:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#39353 <39353@debbugs.gnu.org> To: bug#39353 <39353@debbugs.gnu.org> Subject: Status: [PATCH] Use current-prefix-arg instead of prefix-arg Reply-To: bug#39353 <39353@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:18:27 +0000 retitle 39353 [PATCH] Use current-prefix-arg instead of prefix-arg reassign 39353 emacs submitter 39353 Kyle Hubert severity 39353 normal tag 39353 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 30 03:59:24 2020 Received: (at submit) by debbugs.gnu.org; 30 Jan 2020 08:59:24 +0000 Received: from localhost ([127.0.0.1]:34897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ix5fY-0004F3-AX for submit@debbugs.gnu.org; Thu, 30 Jan 2020 03:59:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:57185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ix0bp-00033X-TE for submit@debbugs.gnu.org; Wed, 29 Jan 2020 22:35:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40990) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ix0bn-0006Ro-Nu for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 22:35:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ix0bl-0000h5-OM for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 22:35:11 -0500 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]:40994) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ix0bl-0000aF-Ba for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 22:35:09 -0500 Received: by mail-qt1-x842.google.com with SMTP id l19so1350860qtq.8 for ; Wed, 29 Jan 2020 19:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SY3EP/PMOJK0+y7/FTU1N0/BojBPvcDkVb5Yy57EDpU=; b=MiI355bk5EPGJHQAEmr9w2SamLV9xfgBXGsicdxMhdwxlAsjYuuXAoFzFlvzLeYZCU GNO+fTMQIlLSujXN/m1hoxHFV96C6YfrkpdeRx/YdcaoXZHpvXRnS1/XvAygeIcxDrmZ JTkm3rjqu3JDfGbWWsx+AvrfjVtnzMEZ+bR4H/aaK4c55/w//vHsKP/nYa49791Ofj2g 0zP3vnDYpBmGaoJOJGirGniQ97mVFtoB9DVD4+ZgFZbs8NdUP5dOymNznJcBFPx1EkmN 67ejAV4X0kt9u0CIq7I0sbNHsPEaOC3eRf94kmW+lwXo6tYOqAWH+nwRX7gKfHQ5Dddz HpCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SY3EP/PMOJK0+y7/FTU1N0/BojBPvcDkVb5Yy57EDpU=; b=bL72HDpQ80SsZbIG8Y3Cg+hcj52G2zBofbclHVbe4biPMAxwk8dLVrfmbSS5cFK67X L6Dmzm0pilyhHNLBRylIRigZhidFFgKofwCkzzqrM1W6DFfU1+N3DIhj9n2mn6Xm1ZMJ TDUrB6M/R0W18yaYzxvFKmV5FQcfI1MTZjVjk+lM7eNZ85KQVTU/9XbK3UfT02tTKEuS X9yLzIL6OLNltLF+B9kKBPEqCVnitW7gqVxkzQ19cBZW7XhYfjpcSEUrEoSu5rxjhmfC BEKUSL3++RAXYzH1/9xA8lMNob2fR1RF0rsisBdQgfwNTn+Axrg6K+sGiP5LGU+6CI5m kX7w== X-Gm-Message-State: APjAAAVhFJcVHENHWGTcJDcml0T/oo2FUU4jtFYL8QMUghfy2YyoiTeN FjHnlRW0YH2moW8zjEgKKvFyv7X0 X-Google-Smtp-Source: APXvYqx68WmkmzdN2uBhFHrCXYcVy+JroJ1Mf/9JcBagJYL+WGKnF63mntd1CGzzSep/kg8KN0hiTQ== X-Received: by 2002:ac8:6b58:: with SMTP id x24mr2706505qts.311.1580355307961; Wed, 29 Jan 2020 19:35:07 -0800 (PST) Received: from localhost.localdomain (pool-100-2-226-56.nycmny.fios.verizon.net. [100.2.226.56]) by smtp.gmail.com with ESMTPSA id y194sm2106707qkb.113.2020.01.29.19.35.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jan 2020 19:35:07 -0800 (PST) From: Kyle Hubert To: bug-gnu-emacs@gnu.org Subject: [PATCH] Use current-prefix-arg instead of prefix-arg Date: Wed, 29 Jan 2020 22:35:04 -0500 Message-Id: <20200130033504.64697-1-khubert@gmail.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::842 X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Forwarding arguments through to children function invocations should be handled by current-prefix-arg. This was first uncovered when ediff used full window width scrolling in ediff-scroll-horizontally [...] Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (khubert[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 30 Jan 2020 03:59:23 -0500 Cc: Kyle Hubert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Forwarding arguments through to children function invocations should be handled by current-prefix-arg. This was first uncovered when ediff used full window width scrolling in ediff-scroll-horizontally, when the call to scroll-left or scroll-right should have been half-window size. Through further grepping, there was another usage in simple.el. Note, execute-extended-command was visually inspected that it was in interactive mode. --- lisp/simple.el | 2 +- lisp/vc/ediff-util.el | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index 2ec3da680f..53afa7b138 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -1888,7 +1888,7 @@ invoking, give a prefix argument to `execute-extended-command'." ;; `function' and not `execute-extended-command'. The difference is ;; visible in cases such as M-x RET and then C-x z (bug#11506). (setq real-this-command function) - (let ((prefix-arg prefixarg)) + (let ((current-prefix-arg prefixarg)) (command-execute function 'record)) ;; If enabled, show which key runs this command. ;; But first wait, and skip the message if there is input. diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el index a8af9ba37a..5f8a4a86b1 100644 --- a/lisp/vc/ediff-util.el +++ b/lisp/vc/ediff-util.el @@ -1540,10 +1540,10 @@ the width of the A/B/C windows." ;; hscrolling. (if (= last-command-event ?<) (lambda (arg) - (let ((prefix-arg arg)) + (let ((current-prefix-arg arg)) (call-interactively #'scroll-left))) (lambda (arg) - (let ((prefix-arg arg)) + (let ((current-prefix-arg arg)) (call-interactively #'scroll-right)))) ;; calculate argument to scroll-left/right ;; if there is an explicit argument -- 2.25.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 30 07:23:02 2020 Received: (at submit) by debbugs.gnu.org; 30 Jan 2020 12:23:03 +0000 Received: from localhost ([127.0.0.1]:35027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ix8qc-0000iy-Fh for submit@debbugs.gnu.org; Thu, 30 Jan 2020 07:23:02 -0500 Received: from lists.gnu.org ([209.51.188.17]:46933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ix0uD-0003Vo-Pq for submit@debbugs.gnu.org; Wed, 29 Jan 2020 22:54:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44109) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ix0uC-0001Sf-86 for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 22:54:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ix0uA-0007MA-Vi for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 22:54:12 -0500 Received: from mail-vk1-xa41.google.com ([2607:f8b0:4864:20::a41]:45236) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ix0uA-0007L4-Cs for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 22:54:10 -0500 Received: by mail-vk1-xa41.google.com with SMTP id g7so634294vkl.12 for ; Wed, 29 Jan 2020 19:54:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=vRRIEBOfTecduYR9wOUwXV1kMJJv6EDg1mErmDL7REA=; b=gYFv1xaaEP3JnJVTRfJf+fopQwYlPYhepeoK8rOHKG8IwXWqRQHGTas8lTyneOPhjZ 8IbP1KG2N45+MTbFHmA0rfinqNSZbMIL9qpdfLqK2FNYaNYbMy6tE4fQaWwRzwL1tLSH DssuuL2NWlfbVMOY+X1brVfDxb5faEnVgc9t4NKldI6H3I1QqDLelMt/bD+KL/IoN9le Z+gXoD4tYHY5RZsLlYN9XqyeIaXiejYF6R+mO6mkL7QkLPdPVQ3/qufQl1PIJMSVwcVQ VJTdKF4flNhvsxMJpcb8x03B9JKQakaklI5S+j7bP4k+28xJ+hGftXOT4F5F3EZHv4GQ 7OnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=vRRIEBOfTecduYR9wOUwXV1kMJJv6EDg1mErmDL7REA=; b=pLxmQNJoIQNa136sQ/AUe7DnamwyPv+f9/pRwNl2ht2OYJOncyXUeAvBrIFi28GqSq gGiIoIxgDbSKYfszCg20+MTnD2K40QEtaO+iK8gXlTql1HU3ta/issTVDpPLZ9jb6SXF Lh6On08cgkPoA5T3llLVmIRgHiowRN3n/dU3VuXNZL6HqAMmknPNxJwq/qaVwo2VjeWM tHITG17AtUYrMPP8MXoMFHBuBbsfaLyt4ldtZmJpF0lyGmm4bHD1GjReNlNLV2+ucu99 28B6/dRMINRas4/uWuA7Qv2wKLK9FBmfkYpLS/BT2oMFRPYoqibYzxlj5viDVOnCkuCD 1gnw== X-Gm-Message-State: APjAAAWoxlbTzzkLTXmuG55QItSPfAMy3UtHSncCShOCFi7Te4dKrklT 9nuOzH1bIidz1AKKsuKIr9OM7fOU4PIbXl43uZfFAiZS X-Google-Smtp-Source: APXvYqy1NK9wbpgbzPI7rKdiLTrenHYcGPfPKi7rsYuasQzdowYSCWsYJK1MdvI9456OVzrFo+NwM1QBkdkw4b3VOMo= X-Received: by 2002:a1f:4193:: with SMTP id o141mr1651892vka.19.1580356449231; Wed, 29 Jan 2020 19:54:09 -0800 (PST) MIME-Version: 1.0 References: <20200130033504.64697-1-khubert@gmail.com> In-Reply-To: <20200130033504.64697-1-khubert@gmail.com> From: Kyle Hubert Date: Wed, 29 Jan 2020 22:53:58 -0500 Message-ID: Subject: Re: [PATCH] Use current-prefix-arg instead of prefix-arg To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000c66635059d53689e" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::a41 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 30 Jan 2020 07:23:00 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000c66635059d53689e Content-Type: text/plain; charset="UTF-8" I have a hard time testing the change to simple.el, as I don't understand execute-extended-command. Can anyone help here? I'm worried since it isn't using (interactive "P") that this is incorrect. I admit I'm deeper in the guts of emacs than typical. Thanks, -Kyle On Wed, Jan 29, 2020 at 10:35 PM Kyle Hubert wrote: > Forwarding arguments through to children function invocations should > be handled by current-prefix-arg. This was first uncovered when ediff > used full window width scrolling in ediff-scroll-horizontally, when > the call to scroll-left or scroll-right should have been half-window > size. Through further grepping, there was another usage in > simple.el. Note, execute-extended-command was visually inspected that > it was in interactive mode. > > --- > lisp/simple.el | 2 +- > lisp/vc/ediff-util.el | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lisp/simple.el b/lisp/simple.el > index 2ec3da680f..53afa7b138 100644 > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -1888,7 +1888,7 @@ invoking, give a prefix argument to > `execute-extended-command'." > ;; `function' and not `execute-extended-command'. The difference is > ;; visible in cases such as M-x RET and then C-x z (bug#11506). > (setq real-this-command function) > - (let ((prefix-arg prefixarg)) > + (let ((current-prefix-arg prefixarg)) > (command-execute function 'record)) > ;; If enabled, show which key runs this command. > ;; But first wait, and skip the message if there is input. > diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el > index a8af9ba37a..5f8a4a86b1 100644 > --- a/lisp/vc/ediff-util.el > +++ b/lisp/vc/ediff-util.el > @@ -1540,10 +1540,10 @@ the width of the A/B/C windows." > ;; hscrolling. > (if (= last-command-event ?<) > (lambda (arg) > - (let ((prefix-arg arg)) > + (let ((current-prefix-arg arg)) > (call-interactively #'scroll-left))) > (lambda (arg) > - (let ((prefix-arg arg)) > + (let ((current-prefix-arg arg)) > (call-interactively #'scroll-right)))) > ;; calculate argument to scroll-left/right > ;; if there is an explicit argument > -- > 2.25.0 > > --000000000000c66635059d53689e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I have a hard time testing the change to = simple.el, as I don't understand execute-extended-command. Can anyone h= elp here? I'm worried since it isn't using (interactive "P&quo= t;) that this is incorrect. I admit I'm deeper in the guts of emacs tha= n typical.

Thanks,
-Kyle

<= /div>
O= n Wed, Jan 29, 2020 at 10:35 PM Kyle Hubert <khubert@gmail.com> wrote:
Forwarding arguments through to children functio= n invocations should
be handled by current-prefix-arg. This was first uncovered when ediff
used full window width scrolling in ediff-scroll-horizontally, when
the call to scroll-left or scroll-right should have been half-window
size. Through further grepping, there was another usage in
simple.el. Note, execute-extended-command was visually inspected that
it was in interactive mode.

---
=C2=A0lisp/simple.el=C2=A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-
=C2=A0lisp/vc/ediff-util.el | 4 ++--
=C2=A02 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/simple.el b/lisp/simple.el
index 2ec3da680f..53afa7b138 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -1888,7 +1888,7 @@ invoking, give a prefix argument to `execute-extended= -command'."
=C2=A0 =C2=A0 =C2=A0;; `function' and not `execute-extended-command'= ;.=C2=A0 The difference is
=C2=A0 =C2=A0 =C2=A0;; visible in cases such as M-x <cmd> RET and the= n C-x z (bug#11506).
=C2=A0 =C2=A0 =C2=A0(setq real-this-command function)
-=C2=A0 =C2=A0 (let ((prefix-arg prefixarg))
+=C2=A0 =C2=A0 (let ((current-prefix-arg prefixarg))
=C2=A0 =C2=A0 =C2=A0 =C2=A0(command-execute function 'record))
=C2=A0 =C2=A0 =C2=A0;; If enabled, show which key runs this command.
=C2=A0 =C2=A0 =C2=A0;; But first wait, and skip the message if there is inp= ut.
diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el
index a8af9ba37a..5f8a4a86b1 100644
--- a/lisp/vc/ediff-util.el
+++ b/lisp/vc/ediff-util.el
@@ -1540,10 +1540,10 @@ the width of the A/B/C windows."
=C2=A0 =C2=A0 ;; hscrolling.
=C2=A0 =C2=A0 (if (=3D last-command-event ?<)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambda (arg)
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((prefix-arg arg))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((current-prefix-arg arg))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(call-interactively #'scroll-l= eft)))
=C2=A0 =C2=A0 =C2=A0 (lambda (arg)
-=C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((prefix-arg arg))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((current-prefix-arg arg))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(call-interactively #'scroll-right)))= )
=C2=A0 =C2=A0 ;; calculate argument to scroll-left/right
=C2=A0 =C2=A0 ;; if there is an explicit argument
--
2.25.0

--000000000000c66635059d53689e-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 30 08:12:41 2020 Received: (at 39353) by debbugs.gnu.org; 30 Jan 2020 13:12:41 +0000 Received: from localhost ([127.0.0.1]:35039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ix9ce-0003rj-T8 for submit@debbugs.gnu.org; Thu, 30 Jan 2020 08:12:41 -0500 Received: from mail-qv1-f67.google.com ([209.85.219.67]:40668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ix9cd-0003rX-8L for 39353@debbugs.gnu.org; Thu, 30 Jan 2020 08:12:40 -0500 Received: by mail-qv1-f67.google.com with SMTP id dp13so1428589qvb.7 for <39353@debbugs.gnu.org>; Thu, 30 Jan 2020 05:12:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=09CsNyoEC93kqfre62xoJ8QdBOBzAfjQ/m388gljFYk=; b=OlVWStx8xYVC/t5a6gPzRqus6GDitEE+nLA/JN/Mlfw5B7522mDij1aBKD1/sMfuTb BDVqTMviAQ9JD5HKbZLieOYTecZrVYwiYkpjooyZoO5UdJ/rxU+/ufvpKZisnIfbh4oQ G8xizrcSVqube7Y/5VD698ByZtUpa4VYTmJYXyIg5J+JXBG7/xHYsHWHfOLaEmzlsfoY AAoeZV7h+QAKa0NSLCZnN1m6GbUR7Z32QXWd5a1Mc2HYHYzLL5cwFZWPQ0tgJb+Jt2OC +ZEa+Bv1hqJ8H17XKFcgTF1rpe/Yzkwhjt2uAW8OAwm8Cd2nDI9YDuEdbjGQ1t9EfyWa Flvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=09CsNyoEC93kqfre62xoJ8QdBOBzAfjQ/m388gljFYk=; b=j65GDXB87qbDHFsWQwwWA1MQgc+uMS0RL1Yuq5n8OaYUVxPWXxbAy4688tAdzIn135 RQqX9uSfxiRVpBHWHnIVoI69ZwsDNkjnQEW6spZks/E8fghbvP+S+LEicLcU3nSyJsOQ 0iSUMKxXXgu3MA3xO+0P4nm8wcmzG5mCinfuP/p9QXtgZ3hwYtff5m26pU9vJ2SprqUK sCgcseJpnGNxYn9dUIYioBNkba1Q0CE5/Xn0s/esgRJcdRnMiAO3IxCQqe9WEP20ITgc xuR/07UOLL2RdjwF23sNEhXgl62ErG3nFYKEjQS3XnxyzKQUUS6keMNq1naYlz0tsYBH 6uKg== X-Gm-Message-State: APjAAAUmErZ6YPLBMsB1SvtkvvGjXyXhGofMSM0R1dhM/SH++Aey7/Uw bnpDU4cGSJj24h5M3RWAmS4jaSlT X-Google-Smtp-Source: APXvYqzHAj2thF/6DQpxzCAiUqXA7btozv+/JHGAqQ1XNtwuhHqscnhp7Dtblr9U6mM9YL17GmeUIg== X-Received: by 2002:ad4:4aaa:: with SMTP id i10mr4471731qvx.27.1580389953595; Thu, 30 Jan 2020 05:12:33 -0800 (PST) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id r10sm2654226qkm.23.2020.01.30.05.12.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Jan 2020 05:12:33 -0800 (PST) From: Noam Postavsky To: Kyle Hubert Subject: Re: bug#39353: [PATCH] Use current-prefix-arg instead of prefix-arg References: <20200130033504.64697-1-khubert@gmail.com> Date: Thu, 30 Jan 2020 08:12:27 -0500 In-Reply-To: (Kyle Hubert's message of "Wed, 29 Jan 2020 22:53:58 -0500") Message-ID: <87r1zhay10.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39353 Cc: 39353@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Kyle Hubert writes: > I have a hard time testing the change to simple.el, as I don't understand > execute-extended-command. Can anyone help here? I'm worried since it isn't > using (interactive "P") that this is incorrect. I admit I'm deeper in the > guts of emacs than typical. The simple.el let-binding is around command-execute, not execute-extended-command. command-execute does specifically read prefix-arg, so I think that part of your patch should be dropped (I haven't looked in detail at the ediff part, but it sounds right). >> --- a/lisp/simple.el >> +++ b/lisp/simple.el >> @@ -1888,7 +1888,7 @@ invoking, give a prefix argument to >> `execute-extended-command'." >> ;; `function' and not `execute-extended-command'. The difference is >> ;; visible in cases such as M-x RET and then C-x z (bug#11506). >> (setq real-this-command function) >> - (let ((prefix-arg prefixarg)) >> + (let ((current-prefix-arg prefixarg)) >> (command-execute function 'record)) From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 30 11:35:21 2020 Received: (at 39353) by debbugs.gnu.org; 30 Jan 2020 16:35:21 +0000 Received: from localhost ([127.0.0.1]:36187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixCmm-0002VD-OD for submit@debbugs.gnu.org; Thu, 30 Jan 2020 11:35:20 -0500 Received: from mail-vs1-f44.google.com ([209.85.217.44]:39149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixCmk-0002V0-8d for 39353@debbugs.gnu.org; Thu, 30 Jan 2020 11:35:19 -0500 Received: by mail-vs1-f44.google.com with SMTP id p14so2454808vsq.6 for <39353@debbugs.gnu.org>; Thu, 30 Jan 2020 08:35:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cx7Rvrh9WlN/RhgL6mDx99TpmCHuV2mEIN31ntt95IE=; b=NkT1v71waHFx9gJwz+MX022jvs3zlJxxDLJGaioOhvuO2XxZcn0YXOWMK7+dbaiWln PPtxT1qb7OetDugt6BCz5129g0TAtYjJiZZTuWm0zGLVBxHu/qDZbJVKrdsSlat2xFOp cUMXguYZb5m5FA+59O1QVItiYGcUBw1Tx0es0bRlaSj+jyocSheJFZEnPsWwDQUHadn9 VEbY7/t6foxSUPzcW/CbofhsWFGORHVn0znd1XbIk9Whi4wvl0zUrKavo1uAYa6JmY3p +UBoa4uNAwGVKur+IxRs+FLVHZiISASRHcT6KDdiLBF4eCJdCZ8N82p14uAeO6cwT1XA FMFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cx7Rvrh9WlN/RhgL6mDx99TpmCHuV2mEIN31ntt95IE=; b=TTZR84uX5jZIEMlvMogx6xZmDQ7+PSnX2Q49FT44Uq4iwE75kqt17T0d3GehsM2lFC LaHToA8RuaNWPwWi+AqMiArWy2hnrpP6wDanVTU4PHtCY/5iVWAI99RGdafe+G6iHvDP dK1WlpAhQW97mLW3J1X+xDqhes2pyUZj7ddPDTlVil87v0y+ZnrYx1K+oALmJb9DbvpN MRqKiFz+QBd0DVUYCGoNlgAw2BGWCl2kdZkh/wySB11hehAHaIkWARmxkZ/6fi22dSQG 0lehfM8q+TceR2RiW19jY4+pXnlc+l2kB8YclZz+0UMZPTgNe6e14P/rAx3/YYot7+qG lGmw== X-Gm-Message-State: APjAAAVf3lFY7MTL9rFaOOZnd73oybBbnR6blC4R3NMn2d2zspHlGpj0 vq4uhwPaQlCCCqldpCzGHYBsGKTqfarBYm0pG5c= X-Google-Smtp-Source: APXvYqzNtY1EQHnU4le9k+PMbbqDuUGuS6jCaQLDYVU+uv6B17etMRIDUy84mh3vNrX5J0W2o2+9fiAaA4hrLoNRhV4= X-Received: by 2002:a67:fb85:: with SMTP id n5mr3526326vsr.50.1580402112486; Thu, 30 Jan 2020 08:35:12 -0800 (PST) MIME-Version: 1.0 References: <20200130033504.64697-1-khubert@gmail.com> <87r1zhay10.fsf@gmail.com> In-Reply-To: <87r1zhay10.fsf@gmail.com> From: Kyle Hubert Date: Thu, 30 Jan 2020 11:35:01 -0500 Message-ID: Subject: Re: bug#39353: [PATCH] Use current-prefix-arg instead of prefix-arg To: Noam Postavsky Content-Type: multipart/alternative; boundary="0000000000008462c0059d5e0a79" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39353 Cc: 39353@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000008462c0059d5e0a79 Content-Type: text/plain; charset="UTF-8" Thank you for the review. I had a feeling that execute-extended-command's calling of prefix-arg was the correct usage for command-execute. If I drop that from the PATCH, do I repost to this bug ID email? I'm unfamiliar with the project. -Kyle On Thu, Jan 30, 2020 at 8:12 AM Noam Postavsky wrote: > Kyle Hubert writes: > > > I have a hard time testing the change to simple.el, as I don't understand > > execute-extended-command. Can anyone help here? I'm worried since it > isn't > > using (interactive "P") that this is incorrect. I admit I'm deeper in the > > guts of emacs than typical. > > The simple.el let-binding is around command-execute, not > execute-extended-command. command-execute does specifically read > prefix-arg, so I think that part of your patch should be dropped (I > haven't looked in detail at the ediff part, but it sounds right). > > >> --- a/lisp/simple.el > >> +++ b/lisp/simple.el > >> @@ -1888,7 +1888,7 @@ invoking, give a prefix argument to > >> `execute-extended-command'." > >> ;; `function' and not `execute-extended-command'. The difference > is > >> ;; visible in cases such as M-x RET and then C-x z > (bug#11506). > >> (setq real-this-command function) > >> - (let ((prefix-arg prefixarg)) > >> + (let ((current-prefix-arg prefixarg)) > >> (command-execute function 'record)) > --0000000000008462c0059d5e0a79 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you for the review. I had a fe= eling that
execute-extended-command's calling of prefix-arg was the = correct
usage for command-execute. If I drop that from the PATCH, do Irepost to this bug ID email? I'm unfamiliar with the project.

-Kyle

On Thu, Jan 30, 2020 at 8:12 AM Noam Posta= vsky <npostavs@gmail.com> w= rote:
Kyle Huber= t <khubert@gmail.= com> writes:

> I have a hard time testing the change to simple.el, as I don't und= erstand
> execute-extended-command. Can anyone help here? I'm worried since = it isn't
> using (interactive "P") that this is incorrect. I admit I= 9;m deeper in the
> guts of emacs than typical.

The simple.el let-binding is around command-execute, not
execute-extended-command.=C2=A0 command-execute does specifically read
prefix-arg, so I think that part of your patch should be dropped (I
haven't looked in detail at the ediff part, but it sounds right).

>> --- a/lisp/simple.el
>> +++ b/lisp/simple.el
>> @@ -1888,7 +1888,7 @@ invoking, give a prefix argument to
>> `execute-extended-command'."
>>=C2=A0 =C2=A0 =C2=A0 ;; `function' and not `execute-extended-co= mmand'.=C2=A0 The difference is
>>=C2=A0 =C2=A0 =C2=A0 ;; visible in cases such as M-x <cmd> RE= T and then C-x z (bug#11506).
>>=C2=A0 =C2=A0 =C2=A0 (setq real-this-command function)
>> -=C2=A0 =C2=A0 (let ((prefix-arg prefixarg))
>> +=C2=A0 =C2=A0 (let ((current-prefix-arg prefixarg))
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (command-execute function 'record))=
--0000000000008462c0059d5e0a79-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 30 13:39:48 2020 Received: (at 39353) by debbugs.gnu.org; 30 Jan 2020 18:39:49 +0000 Received: from localhost ([127.0.0.1]:36244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixEjE-0005Qj-OE for submit@debbugs.gnu.org; Thu, 30 Jan 2020 13:39:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixEjD-0005QY-Gj for 39353@debbugs.gnu.org; Thu, 30 Jan 2020 13:39:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45198) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixEj8-00024E-Bs; Thu, 30 Jan 2020 13:39:42 -0500 Received: from [176.228.60.248] (port=1266 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixEj7-0004Of-GU; Thu, 30 Jan 2020 13:39:42 -0500 Date: Thu, 30 Jan 2020 20:39:33 +0200 Message-Id: <838slon5zu.fsf@gnu.org> From: Eli Zaretskii To: Kyle Hubert In-reply-to: (message from Kyle Hubert on Thu, 30 Jan 2020 11:35:01 -0500) Subject: Re: bug#39353: [PATCH] Use current-prefix-arg instead of prefix-arg References: <20200130033504.64697-1-khubert@gmail.com> <87r1zhay10.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39353 Cc: 39353@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Kyle Hubert > Date: Thu, 30 Jan 2020 11:35:01 -0500 > Cc: 39353@debbugs.gnu.org > > If I drop that from the PATCH, do I repost to this bug ID email? Yes, please. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 31 09:30:01 2020 Received: (at 39353) by debbugs.gnu.org; 31 Jan 2020 14:30:01 +0000 Received: from localhost ([127.0.0.1]:36786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixXJ3-00027V-9b for submit@debbugs.gnu.org; Fri, 31 Jan 2020 09:30:01 -0500 Received: from mail-qt1-f169.google.com ([209.85.160.169]:41525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixXJ1-00027C-SR for 39353@debbugs.gnu.org; Fri, 31 Jan 2020 09:30:00 -0500 Received: by mail-qt1-f169.google.com with SMTP id l19so5495033qtq.8 for <39353@debbugs.gnu.org>; Fri, 31 Jan 2020 06:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Hzr1X9ibrW49DChT5IoMZDrG5ETVTyuhivc3uAlqDOY=; b=DpKxnfh2rDvBKpFGXdVIXROrSTsQc9S6gORs9cfHiyFEbOL7dFjvN9CN3Kq8+/nYtx PHTtvCsfhXLElbT5k/Al8UdKL+q05quI0wFYeG9mjbazg013D3pjwgoleVs4BUGz3yf/ oynn2WD2n3tJB6h0nfmJetKhIU8WTnoHRrQQgTRi2MGAN25tN4j9Ql84Gk3a/GMRPnsi tNsf542O6iZMkYYIeyCLQ/SW4t7BtPxTWY/P9gt/+w9l5XEIYwmAGYipwemSi1hxVO20 5cjUqeMVRzSdafrFZg1TmafptOx1+TnndncjIfJ+3fl+T0kp7yPbjJDCyEPNfhGD29ZP ezUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Hzr1X9ibrW49DChT5IoMZDrG5ETVTyuhivc3uAlqDOY=; b=BeRIKKfvOc54F5cX8gnlA1qLBhm/ZE7ZxzfKpmQPYWJioZcSySfJY9nzARo5FcLcKK 1Fg+gqmGtoySOxy4m5YxEPb7VrX3BKu6X0vSE8YgFRd62F25w0H05JafwsjK5s1Q0QmO 0SEeyLx8Xxg0cPBoO8/2tDiHIhgQoItOtiB61K4FjEk200XQBG1CCZLZVE5i2YfFtC2c N8/yu7/aWPZWN8Zrv3GPIZdYO5LMDcouopMc/wn9oXXTOFXMTy3dK53B2gIHS6uhoNVM wthopfBAwJSAteOpjXOWuRzxWlRD59I/p5NlPIrSDfzMSM1HYs7yzjsGg+JJ5GaEmJRq mNTA== X-Gm-Message-State: APjAAAXBIM9LJLZ7DUSnZrIJranX2pNMn2CBOrh/nfS4Rl/URTETRm0s FcqimoyXJN89uQuBYrAeoonwmW3O X-Google-Smtp-Source: APXvYqzsNR3WudVCiLTOqZqvysYqnHXeoa8kHWFixO+NUkiqnu9Mgcn9JangSmdRGmC94qt3ZmvAgg== X-Received: by 2002:ac8:4890:: with SMTP id i16mr10385942qtq.211.1580480993999; Fri, 31 Jan 2020 06:29:53 -0800 (PST) Received: from dean.sm.tld (simulmedia03.s.subnet.rcn.com. [208.59.126.98]) by smtp.gmail.com with ESMTPSA id d22sm4953079qtp.37.2020.01.31.06.29.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Jan 2020 06:29:53 -0800 (PST) From: Kyle Hubert To: 39353@debbugs.gnu.org Subject: [PATCH] Ediff fix for ediff-scroll-horizontally Date: Fri, 31 Jan 2020 09:29:43 -0500 Message-Id: <20200131142943.70625-1-khubert@gmail.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39353 Cc: Kyle Hubert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) When ediff-scroll-horizontally interactively calls scroll-left and scroll-right, current-prefix-arg should be used. This allows for the case that when no args or '-' are passed to ediff-scroll-horizontally, it will determine the default amount (half the window width or half-again, respectively). --- lisp/vc/ediff-util.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el index a8af9ba37a..5f8a4a86b1 100644 --- a/lisp/vc/ediff-util.el +++ b/lisp/vc/ediff-util.el @@ -1540,10 +1540,10 @@ the width of the A/B/C windows." ;; hscrolling. (if (= last-command-event ?<) (lambda (arg) - (let ((prefix-arg arg)) + (let ((current-prefix-arg arg)) (call-interactively #'scroll-left))) (lambda (arg) - (let ((prefix-arg arg)) + (let ((current-prefix-arg arg)) (call-interactively #'scroll-right)))) ;; calculate argument to scroll-left/right ;; if there is an explicit argument -- 2.25.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 05:02:26 2020 Received: (at 39353-done) by debbugs.gnu.org; 8 Feb 2020 10:02:26 +0000 Received: from localhost ([127.0.0.1]:50643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0MwU-00048R-49 for submit@debbugs.gnu.org; Sat, 08 Feb 2020 05:02:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0MwS-00048F-SF for 39353-done@debbugs.gnu.org; Sat, 08 Feb 2020 05:02:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j0MwN-00011C-NB; Sat, 08 Feb 2020 05:02:19 -0500 Received: from [176.228.60.248] (port=4878 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j0MwM-0004KM-DT; Sat, 08 Feb 2020 05:02:19 -0500 Date: Sat, 08 Feb 2020 12:01:59 +0200 Message-Id: <83blq9e6so.fsf@gnu.org> From: Eli Zaretskii To: Kyle Hubert In-reply-to: <20200131142943.70625-1-khubert@gmail.com> (message from Kyle Hubert on Fri, 31 Jan 2020 09:29:43 -0500) Subject: Re: bug#39353: [PATCH] Ediff fix for ediff-scroll-horizontally References: <20200130033504.64697-1-khubert@gmail.com> <20200131142943.70625-1-khubert@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39353-done Cc: 39353-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Kyle Hubert > Date: Fri, 31 Jan 2020 09:29:43 -0500 > Cc: Kyle Hubert > > When ediff-scroll-horizontally interactively calls scroll-left and > scroll-right, current-prefix-arg should be used. This allows for the > case that when no args or '-' are passed to ediff-scroll-horizontally, > it will determine the default amount (half the window width or > half-again, respectively). > --- > lisp/vc/ediff-util.el | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, pushed to the master branch. From unknown Wed Jun 18 23:18:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 07 Mar 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator