GNU bug report logs - #39351
One failed self test on CentOS 5

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39351 in the body.
You can then email your comments to 39351 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jeffrey Walton <noloader <at> gmail.com>
To: bug-sed <at> gnu.org
Subject: One failed self test on CentOS 5
Date: Wed, 29 Jan 2020 20:21:23 -0500

Hi Everyone,

I'm working on CentOS 5, x86_64. I'm building Sed 4.8 from the release
tarball. I'm catching one self-test failure:

    $ cat sed-4.8/gnulib-tests/test-suite.log
    ==============================================
       GNU sed 4.8: gnulib-tests/test-suite.log
    ==============================================

    # TOTAL: 178
    # PASS:  149
    # SKIP:  28
    # XFAIL: 0
    # FAIL:  1
    # XPASS: 0
    # ERROR: 0
    ...

    FAIL: test-strverscmp
    =====================
    test-strverscmp.c:52: assertion 'strverscmp (a, c) < 0' failed
    FAIL test-strverscmp (exit status: 134)

And:

    $ cat -n sed-4.8/gnulib-tests/test-strverscmp.c
    ...
    45      /* From glibc bug 9913.  */
    46      {
    47        static char const a[] = "B0075022800016.gbp.corp.com";
    48        static char const b[] = "B007502280067.gbp.corp.com";
    49        static char const c[] = "B007502357019.GBP.CORP.COM";
    50        ASSERT (strverscmp (a, b) < 0);
    51        ASSERT (strverscmp (b, c) < 0);
    52        ASSERT (strverscmp (a, c) < 0);
    53        ASSERT (strverscmp (b, a) > 0);
    54        ASSERT (strverscmp (c, b) > 0);
    55        ASSERT (strverscmp (c, a) > 0);
    56      }

Jeff

Message #8 received at 39351 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: noloader <at> gmail.com, 39351 <at> debbugs.gnu.org
Subject: Re: bug#39351: One failed self test on CentOS 5
Date: Thu, 30 Jan 2020 00:25:11 -0700

close 39351
stop

Hello,

Thanks for the report.

On 2020-01-29 6:21 p.m., Jeffrey Walton wrote:
> I'm working on CentOS 5, x86_64. I'm building Sed 4.8 from the release
> tarball. I'm catching one self-test failure:

CentOS 5 was end-of-life'd in 2017 - so fixing bugs for it isn't
a high priority ( 
https://en.wikipedia.org/wiki/CentOS#End-of-support_schedule ).

However,

>      $ cat sed-4.8/gnulib-tests/test-suite.log
[...]
>      FAIL: test-strverscmp
>      =====================
>      test-strverscmp.c:52: assertion 'strverscmp (a, c) < 0' failed
>      FAIL test-strverscmp (exit status: 134)

This is a test failure in gnulib - a component library used by sed.

sed uses the strverscmp() function only in one rarely used GNU extension
(the "v" command) and it is extremely unlikely to affect any real-world
scenarios of using sed.

GNU sed itself did not fail any tests on your system, and it is OK to
use it.

As such, I'm closing this bug report, but discussion can continue
by replying to this thread.

regards,
 - assaf

Message #13 received at 39351 <at> debbugs.gnu.org (full text, mbox):

From: Jeffrey Walton <noloader <at> gmail.com>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: 39351 <at> debbugs.gnu.org
Subject: Re: bug#39351: One failed self test on CentOS 5
Date: Thu, 30 Jan 2020 03:55:23 -0500

On Thu, Jan 30, 2020 at 2:25 AM Assaf Gordon <assafgordon <at> gmail.com> wrote:
>
> close 39351
> stop
>
> Hello,
>
> Thanks for the report.
>
> On 2020-01-29 6:21 p.m., Jeffrey Walton wrote:
> > I'm working on CentOS 5, x86_64. I'm building Sed 4.8 from the release
> > tarball. I'm catching one self-test failure:
>
> CentOS 5 was end-of-life'd in 2017 - so fixing bugs for it isn't
> a high priority (
> https://en.wikipedia.org/wiki/CentOS#End-of-support_schedule ).
>
> However,
>
> >      $ cat sed-4.8/gnulib-tests/test-suite.log
> [...]
> >      FAIL: test-strverscmp
> >      =====================
> >      test-strverscmp.c:52: assertion 'strverscmp (a, c) < 0' failed
> >      FAIL test-strverscmp (exit status: 134)
>
> This is a test failure in gnulib - a component library used by sed.
>
> sed uses the strverscmp() function only in one rarely used GNU extension
> (the "v" command) and it is extremely unlikely to affect any real-world
> scenarios of using sed.
>
> GNU sed itself did not fail any tests on your system, and it is OK to
> use it.
>
> As such, I'm closing this bug report, but discussion can continue
> by replying to this thread.

Thanks Assaf.

Can you confirm Sed is using the latest Gnulib as of Sed's release
date? I.e., https://www.gnu.org/software/gnulib/manual/html_node/Simple-update.html
.

I want to ensure I am not chasing something that's already been fixed.

Jeff

Message #16 received at 39351 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: noloader <at> gmail.com
Cc: 39351 <at> debbugs.gnu.org
Subject: Re: bug#39351: One failed self test on CentOS 5
Date: Thu, 30 Jan 2020 02:10:24 -0700

On 2020-01-30 1:55 a.m., Jeffrey Walton wrote:
> On Thu, Jan 30, 2020 at 2:25 AM Assaf Gordon <assafgordon <at> gmail.com> wrote:
>> On 2020-01-29 6:21 p.m., Jeffrey Walton wrote:
>>>       FAIL: test-strverscmp
>>>       =====================
>>>       test-strverscmp.c:52: assertion 'strverscmp (a, c) < 0' failed
>>
>> sed uses the strverscmp() function only in one rarely used GNU extension
>> (the "v" command) and it is extremely unlikely to affect any real-world
>> scenarios of using sed.
>>
>> GNU sed itself did not fail any tests on your system, and it is OK to
>> use it.
>>
> 
> Can you confirm Sed is using the latest Gnulib as of Sed's release
> date? I.e., https://www.gnu.org/software/gnulib/manual/html_node/Simple-update.html
> .
> 
> I want to ensure I am not chasing something that's already been fixed.

In sed's commit log you can see sed 4.8 was released on 14-Jan-2020,
and the last gnulib updated was on 11-Jan-2020 :
https://git.savannah.gnu.org/cgit/sed.git/log/

sed's gnulib was updated to commit
https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=6b9d15b8bcb3c009374ccb21dc2c2be2333133d 
.

So it is up-to-date, and there have been no "strverscmp" related
changes since then.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.