GNU bug report logs -
#39345
28.0.50; rcirc-authenticate-before-join due to case sensitive mismatch
Previous Next
Reported by: Jake Nelson <jake.nelson <at> gmail.com>
Date: Wed, 29 Jan 2020 14:53:01 UTC
Severity: normal
Tags: fixed
Found in version 28.0.50
Fixed in version 28.1
Done: Noam Postavsky <npostavs <at> gmail.com>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
1. join irc.freenode.net with a lowercase nick "examplenick"
2. authenticate to nickserv
3. nickserv echos back "-NickServ- You are now identified for
"Examplenick" capitalizing the nickname.
4. rcirc-authenticate-before-join does not trigger, so no channels are
auto-joined.
The existing check is case sensitive. The patch below fixes the issue
for me on freenode.
diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index 5722582ab6..b516c8d0a6 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -2624,12 +2624,12 @@ rcirc-check-auth-status
(when (or
(and ;; nickserv
(string= sender "NickServ")
- (string= target rcirc-nick)
- (member message
+ (string= (downcase target) (downcase rcirc-nick))
+ (member (downcase message)
(list
- (format "You are now identified for
\C-b%s\C-b." rcirc-nick)
- (format "You are successfully identified as
\C-b%s\C-b." rcirc-nick)
- "Password accepted - you are now recognized."
+ (downcase (format "You are now identified
for \C-b%s\C-b." rcirc-nick))
+ (downcase (format "You are successfully
identified as \C-b%s\C-b." rcirc-nick))
+ (downcase "Password accepted - you are now
recognized.")
)))
(and ;; quakenet
(string= sender "Q")
This bug report was last modified 5 years and 72 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.