GNU bug report logs - #39336
[PATCH] gnu: Add emacs-gnus-harvest.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39336 in the body.
You can then email your comments to 39336 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Amin Bandali <mab <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Amin Bandali <mab <at> gnu.org>
Subject: [PATCH] gnu: Add emacs-gnus-harvest.
Date: Tue, 28 Jan 2020 19:10:44 -0500

* gnu/packages/emacs-xyz.scm (emacs-gnus-harvest): New variable.
---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e834dfffb3..8a955f06bc 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -21237,3 +21237,31 @@ mode-line text (lighter) of major and minor modes.")
       (description "@code{unkillable-scratch} helps prevent killing buffers
 matching a given regexp.")
       (license license:gpl2+))))
+
+(define-public emacs-gnus-harvest
+  ;; Use the latest commit, as there are no tagged releases.
+  (let ((commit "feda071a87b799bd5d23cacde3ee71f0b166e75d")
+        (revision "0"))
+    (package
+      (name "emacs-gnus-harvest")
+      (version (git-version "1.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/jwiegley/gnus-harvest.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "08zb7vc3v3wdxkzgi902vlc5ybfvm8fxrvm5drnwfsjj9873pbcb"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       `(("sqlite" ,sqlite)))
+      (home-page "https://github.com/jwiegley/gnus-harvest")
+      (synopsis
+       "Harvest email addresses from read/written Gnus articles")
+      (description "@code{gnus-harvest} notices email address in every
+message or post you read or write, and collects them in a SQLite
+database, which can be easily and quickly queried to determine the
+completion list.  Optionally uses @code{bbdb} and @code{message-x}.")
+      (license license:gpl3+))))
-- 
2.25.0

Message #8 received at 39336 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Amin Bandali <mab <at> gnu.org>
Cc: 39336 <at> debbugs.gnu.org
Subject: Re: [bug#39336] [PATCH] gnu: Add emacs-gnus-harvest.
Date: Sun, 02 Feb 2020 14:48:34 +0100

Hello,

Amin Bandali <mab <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-gnus-harvest): New variable.

Thank you.

> +      (propagated-inputs
> +       `(("sqlite" ,sqlite)))

Must "sqlite" be a propagated input? IOW, could you patch source so it
can be an input instead?

> +      (description "@code{gnus-harvest} notices email address in every
> +message or post you read or write, and collects them in a SQLite
> +database, which can be easily and quickly queried to determine the
> +completion list.  Optionally uses @code{bbdb} and @code{message-x}.")

Would it make sense to add "emacs-message-x" as a propagated input too?

Regards,

-- 
Nicolas Goaziou

Message #11 received at 39336 <at> debbugs.gnu.org (full text, mbox):

From: Amin Bandali <mab <at> gnu.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 39336 <at> debbugs.gnu.org
Subject: Re: [bug#39336] [PATCH] gnu: Add emacs-gnus-harvest.
Date: Sun, 02 Feb 2020 13:06:26 -0500

[Message part 1 (text/plain, inline)]

Hi,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

[...]
>
> Must "sqlite" be a propagated input? IOW, could you patch source so it
> can be an input instead?
>

Indeed, I see no particular preason to have it as a propagated input.
The v2 attached below implements your suggestion of making it an input
and patching gnus-harvest.el to use it.

>
>> +      (description "@code{gnus-harvest} notices email address in every
>> +message or post you read or write, and collects them in a SQLite
>> +database, which can be easily and quickly queried to determine the
>> +completion list.  Optionally uses @code{bbdb} and @code{message-x}.")
>
> Would it make sense to add "emacs-message-x" as a propagated input too?
>

Summarizing our short chat in #guix, I'm a bit torn on this.  I would
personally probably add message-x to my profile whenever I wanted to use
gnus-harvest, but I'm not sure if I'd want to impose that onto others.
Especially since message-x, like bbdb, is an optional dependency and is
mentioned in the package description.  Of course, if it turns out that
people really always want message-x automatically pulled in along with
gnus-harvest, we could then add it as a propagated input.

-amin

                                 * * *

[0001-gnu-Add-emacs-gnus-harvest.patch (text/x-patch, inline)]

From 6e56509fca510da3a07107d9ebf00c52de0a39b5 Mon Sep 17 00:00:00 2001
From: Amin Bandali <mab <at> gnu.org>
Date: Sun, 2 Feb 2020 12:52:54 -0500
Subject: [PATCH v2] gnu: Add emacs-gnus-harvest.

* gnu/packages/emacs-xyz.scm (emacs-gnus-harvest): New variable.
---
 gnu/packages/emacs-xyz.scm | 39 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8265b44d88..d302067216 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -21357,3 +21357,42 @@ sense on the @samp{Newsgroups} header, whereas mail alias expansion makes
 sense in the @samp{To} and @samp{Cc} headers).  When in the message body, this
 executes a different function (default: @code{indent-relative}).")
       (license license:gpl2+))))
+
+(define-public emacs-gnus-harvest
+  (let ((commit "feda071a87b799bd5d23cacde3ee71f0b166e75d")
+        (revision "0"))
+    (package
+      (name "emacs-gnus-harvest")
+      (version (git-version "1.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/jwiegley/gnus-harvest.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "08zb7vc3v3wdxkzgi902vlc5ybfvm8fxrvm5drnwfsjj9873pbcb"))))
+      (build-system emacs-build-system)
+      (inputs
+       `(("sqlite" ,sqlite)))
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-before 'build 'patch-exec-paths
+             (lambda* (#:key inputs #:allow-other-keys)
+               (let ((sqlite (assoc-ref inputs "sqlite"))
+                     (file "gnus-harvest.el"))
+                 (make-file-writable file)
+                 (emacs-substitute-variables file
+                   ("gnus-harvest-sqlite-program"
+                    (string-append sqlite "/bin/sqlite3"))))
+               #t)))))
+      (home-page "https://github.com/jwiegley/gnus-harvest")
+      (synopsis
+       "Harvest email addresses from read/written Gnus articles")
+      (description "@code{gnus-harvest} notices email address in every
+message or post you read or write, and collects them in a SQLite
+database, which can be easily and quickly queried to determine the
+completion list.  Optionally uses @code{bbdb} and @code{message-x}.")
+      (license license:gpl3+))))
-- 
2.25.0

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 39336-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 39336-done <at> debbugs.gnu.org
Subject: Re: [bug#39336] [PATCH] gnu: Add emacs-gnus-harvest.
Date: Thu, 06 Feb 2020 19:22:54 +0100

Applied as 57f06234c7cb64a1d9c6d3fd1a9837b43b20a7eb.

Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.