GNU bug report logs - #39332
[PATCH] system: Add btrfs-progs to %BASE-PACKAGES.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39332 in the body.
You can then email your comments to 39332 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] system: Add btrfs-progs to %BASE-PACKAGES.
Date: Tue, 28 Jan 2020 17:26:51 -0500

* gnu/system.scm (%base-packages): Add btrfs-progs.
---
 gnu/system.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/system.scm b/gnu/system.scm
index 01baa248a2..7cb6bef99d 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -586,7 +586,8 @@ of PROVENANCE-SERVICE-TYPE to its services."
          ;; already depends on it anyway.
          kmod eudev
 
-         e2fsprogs kbd
+         btrfs-progs e2fsprogs
+         kbd
 
          bash-completion
 
-- 
2.25.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: guix-patches <at> gnu.org
Subject: Re: [bug#39332] [PATCH] system: Add btrfs-progs to %BASE-PACKAGES.
Date: Tue, 28 Jan 2020 23:42:16 +0100

On 28.01.20 23:26, Leo Famulari wrote:
> * gnu/system.scm (%base-packages): Add btrfs-progs.

This adds btrfs-progs, zstd and lzo to the closure with a total of
7.7MiB. So that doesn't seem to big. I'm just wondering if we need btrfs
support here at all, as I would call btrfs still kind of exotic apart
from *SUSE distros and Facebook's backend.

Message #11 received at 39332 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: 39332 <at> debbugs.gnu.org
Subject: Re: [bug#39332] [PATCH] system: Add btrfs-progs to %BASE-PACKAGES.
Date: Tue, 28 Jan 2020 18:14:45 -0500

On Tue, Jan 28, 2020 at 11:42:16PM +0100, Jonathan Brielmaier wrote:
> This adds btrfs-progs, zstd and lzo to the closure with a total of
> 7.7MiB. So that doesn't seem to big. I'm just wondering if we need btrfs
> support here at all, as I would call btrfs still kind of exotic apart
> from *SUSE distros and Facebook's backend.

Yeah, maybe it is too niche. I use it on all my machines but that's just
me. Let's wait to see if there are more comments before deciding.

Message #14 received at 39332 <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Leo Famulari <leo <at> famulari.name>
Cc: 39332 <at> debbugs.gnu.org, Jonathan Brielmaier <jonathan.brielmaier <at> web.de>,
 Guix-patches <guix-patches-bounces+brice+lists=waegenei.re <at> gnu.org>
Subject: Re: [bug#39332] [PATCH] system: Add btrfs-progs to %BASE-PACKAGES.
Date: Wed, 29 Jan 2020 11:19:18 +0000

On 2020-01-28 23:14, Leo Famulari wrote:
> On Tue, Jan 28, 2020 at 11:42:16PM +0100, Jonathan Brielmaier wrote:
>> This adds btrfs-progs, zstd and lzo to the closure with a total of
>> 7.7MiB. So that doesn't seem to big. I'm just wondering if we need 
>> btrfs
>> support here at all, as I would call btrfs still kind of exotic apart
>> from *SUSE distros and Facebook's backend.
> 
> Yeah, maybe it is too niche. I use it on all my machines but that's 
> just
> me. Let's wait to see if there are more comments before deciding.

Maybe %base-packages is the wrong place to add it. But it should at 
least be added to the system profile if a file-systems entry uses btrfs 
which isn't the case as I recall.

Message #19 received at 39332-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 39332-done <at> debbugs.gnu.org
Subject: Re: [bug#39332] [PATCH] system: Add btrfs-progs to %BASE-PACKAGES.
Date: Fri, 7 Feb 2020 19:21:45 -0500

On Wed, Jan 29, 2020 at 11:19:18AM +0000, Brice Waegeneire wrote:
> On 2020-01-28 23:14, Leo Famulari wrote:
> > On Tue, Jan 28, 2020 at 11:42:16PM +0100, Jonathan Brielmaier wrote:
> > > This adds btrfs-progs, zstd and lzo to the closure with a total of
> > > 7.7MiB. So that doesn't seem to big. I'm just wondering if we need
> > > btrfs
> > > support here at all, as I would call btrfs still kind of exotic apart
> > > from *SUSE distros and Facebook's backend.
> > 
> > Yeah, maybe it is too niche. I use it on all my machines but that's just
> > me. Let's wait to see if there are more comments before deciding.
> 
> Maybe %base-packages is the wrong place to add it. But it should at least be
> added to the system profile if a file-systems entry uses btrfs which isn't
> the case as I recall.

You're right, that's a much better idea!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.