GNU bug report logs - #39318
[core-updates] 'make-desktop-entry-file' is not exported

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39318 in the body.
You can then email your comments to 39318 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: bug-guix <at> gnu.org
Subject: [core-updates] 'make-desktop-entry-file' is not exported
Date: Tue, 28 Jan 2020 00:40:30 +0100

[Message part 1 (text/plain, inline)]

Hello,

On the 'core-updates' branch, emacs-exwm, tome4 and drascula fails to
build because 'make-desktop-entry-file' is not available.

[signature.asc (application/pgp-signature, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Marius Bakke <mbakke <at> fastmail.com>, bug-guix <at> gnu.org
Subject: Re: [core-updates] 'make-desktop-entry-file' is not exported
Date: Tue, 28 Jan 2020 08:47:46 +0100

[Message part 1 (text/plain, inline)]

My bad I guess :p
Should I just export it?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 39318 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>, 39318 <at> debbugs.gnu.org
Subject: Re: [core-updates] 'make-desktop-entry-file' is not exported
Date: Wed, 29 Jan 2020 11:34:49 +0100

[Message part 1 (text/plain, inline)]

Pierre Neidhardt <mail <at> ambrevar.xyz> writes:

> My bad I guess :p
> Should I just export it?

It's good if you test that it works, too!  :-)

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 39318 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Marius Bakke <mbakke <at> fastmail.com>, 39318 <at> debbugs.gnu.org
Subject: Re: [core-updates] 'make-desktop-entry-file' is not exported
Date: Wed, 29 Jan 2020 12:12:40 +0100

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> It's good if you test that it works, too!  :-)

It's strange because I did test it.
My guess is that the export disappeared during a conflict resolution.
I remember merging the patch months after initially testing it, so a
conflict must have been introduced in the meantime.

Anyways, will fix!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 39318 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Marius Bakke <mbakke <at> fastmail.com>, 39318 <at> debbugs.gnu.org
Subject: Re: [core-updates] 'make-desktop-entry-file' is not exported
Date: Thu, 30 Jan 2020 16:49:24 +0100

[Message part 1 (text/plain, inline)]

I've tried to test but it rebuilds the world, looks like there is no
substitute for core-updates.
I've pushed anyways, let me know if that works for you.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 39318-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>, 39318-done <at> debbugs.gnu.org
Subject: Re: [core-updates] 'make-desktop-entry-file' is not exported
Date: Thu, 30 Jan 2020 17:12:31 +0100

[Message part 1 (text/plain, inline)]

Pierre Neidhardt <mail <at> ambrevar.xyz> writes:

> I've tried to test but it rebuilds the world, looks like there is no
> substitute for core-updates.
> I've pushed anyways, let me know if that works for you.

Obviously the CI system can not offer substitutes in advance for a
world-rebuilding change!  :-)

I feel slightly offended by being asked to try your untested patch.  Are
you under the impression that I _don't_ have to rebuild the world?

Thanks anyway, closing this issue as I am fairly confident it is solved.

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 39318-done <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Marius Bakke <mbakke <at> fastmail.com>, 39318-done <at> debbugs.gnu.org
Subject: Re: [core-updates] 'make-desktop-entry-file' is not exported
Date: Thu, 30 Jan 2020 19:51:03 +0100

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Obviously the CI system can not offer substitutes in advance for a
> world-rebuilding change!  :-)
>
> I feel slightly offended by being asked to try your untested patch.  Are
> you under the impression that I _don't_ have to rebuild the world?

Duh, my bad, sorry I was probably too distracted with other things at
Guix Days, I completely missed that the world obviously had to be rebuilt.
I guess I'm not used to dealing with core-updates :p

Actually, this brings up a genuine question: how do you test core-updates
for these type of changes?  Do we really have a rebuild the whole thing on
every iteration?

Cheers, and sorry for the mishaps!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 39318-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>, 39318-done <at> debbugs.gnu.org
Subject: Re: [core-updates] 'make-desktop-entry-file' is not exported
Date: Thu, 30 Jan 2020 22:35:11 +0100

[Message part 1 (text/plain, inline)]

Pierre Neidhardt <mail <at> ambrevar.xyz> writes:

> Marius Bakke <mbakke <at> fastmail.com> writes:
>
>> Obviously the CI system can not offer substitutes in advance for a
>> world-rebuilding change!  :-)
>>
>> I feel slightly offended by being asked to try your untested patch.  Are
>> you under the impression that I _don't_ have to rebuild the world?
>
> Duh, my bad, sorry I was probably too distracted with other things at
> Guix Days, I completely missed that the world obviously had to be rebuilt.
> I guess I'm not used to dealing with core-updates :p
>
> Actually, this brings up a genuine question: how do you test core-updates
> for these type of changes?  Do we really have a rebuild the whole thing on
> every iteration?

Changing (guix build utils) is an extreme case, but pretty much.  I keep
a TODO list of things I want to do on that branch, and once it gets big
enough, I try to implement all at once before starting the Big Rebuild.

Then go do something else until a node in the graph fails to build.
Berlin typically has substitutes all the way up to 'guix', so it's "not
that bad" unless you are changing the really low layers.

> Cheers, and sorry for the mishaps!

No worries, and sorry for the angry comment.  :-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.