GNU bug report logs - #39306
[PATCH] gnu: Add xsettingsd.

Previous Next

Full log

Message #8 received at 39306 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: David Wilson <david <at> daviwil.com>, 39306 <at> debbugs.gnu.org
Subject: Re: [bug#39306] [PATCH] gnu: Add xsettingsd.
Date: Thu, 30 Jan 2020 13:14:59 +0100

[Message part 1 (text/plain, inline)]

David Wilson <david <at> daviwil.com> writes:

> * gnu/packages/wm.scm (xsettingsd): New variable.

I wonder if xdisorg.scm is better suited for this package, as it seems
mostly unrelated to window management.  WDYT?

[...]

> +       #:tests? #f ;; Tests require Google's gtest framework

gtest is provided by the 'googletest' package.  Can you try adding it?

Also, for margin comments, we only use one ';', without capitalizing the
comment.

Other than that LGTM.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.