GNU bug report logs - #39293
[PATCH] Base bookmark-bmenu-mode on 'tabulated-list-mode'

Previous Next

Full log

View this message in rfc822 format

From: Matthias Meulien <orontee <at> gmail.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 39293 <at> debbugs.gnu.org
Subject: bug#39293: [PATCH] Base bookmark-bmenu-mode on 'tabulated-list-mode'
Date: Sat, 23 May 2020 22:31:06 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> The attached patch changes bookmark-bmenu-mode to be based on 
> tabulated-list-mode instead of special-mode. 
> 
> This allows us to simplify the code in several cases.  In 
> addition, we get many features for free, such as sorting columns 
> by clicking on the column headers, changing size of columns.

Both features looks interesting to me. Thanks for working on that!

> In the future, this will obviously include any new feature added 
> to 'tabulated-list-mode'. 
> 
> The only functional step backwards is that we no longer support 
> the optional "inline" header line -- a bookmark.el-specific hack 
> to have a header without using 'header-line-format'.  I don't 
> believe this feature is very useful since the lack of such 
> support for anything similar in e.g. 'package-menu-mode' has not 
> caused any problems.  It seems to have been added together with 
> 'header-line-format' as a fire escape if the latter caused any 
> problems.

I am the one who introduced `header-line-format` in bookmark.el 
(7a78e19f24) and I confirm that I kept the legacy header "just in 
case".  The new behavior has been enabled by default since 2013, 
and I've not heard any complaint.
-- 
Matthias Meulien

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.