GNU bug report logs - #39291
M-: history doesn't store erroneous input

Previous Next

Full log

Message #34 received at 39291-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Federico Tedin <federicotedin <at> gmail.com>
Cc: juri <at> linkov.net, pogonyshev <at> gmail.com, monnier <at> iro.umontreal.ca,
 39291-done <at> debbugs.gnu.org
Subject: Re: bug#39291: M-: history doesn't store erroneous input
Date: Fri, 31 Jan 2020 11:20:20 +0200

> From: Federico Tedin <federicotedin <at> gmail.com>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  39291 <at> debbugs.gnu.org,  pogonyshev <at> gmail.com,  Juri Linkov <juri <at> linkov.net>
> Date: Fri, 31 Jan 2020 01:44:34 +0100
> 
> > AFAIK they don't depend on Lisp variables, no, so it should be safe to
> > move the call to `string_to_object` to after the `unbind_to`.
> >
> Thanks for the information. In that case, the patch I sent should be the
> right fix for this bug.

Thanks, pushed to the release branch.

> * src/minibuf.c (read_minibuf): Parse input string after saving the
> string to the history list instead of before, in case parsing
> fails. (Bug#39291)
       ^^
Please in the future leave 2 blanks between sentences, per our
conventions.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.