GNU bug report logs - #39291
M-: history doesn't store erroneous input

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Pogonyshev <pogonyshev <at> gmail.com>
Subject: bug#39291: closed (Re: bug#39291: M-: history doesn't store
 erroneous input)
Date: Fri, 31 Jan 2020 09:21:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#39291: M-: history doesn't store erroneous input

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 39291 <at> debbugs.gnu.org.

-- 
39291: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39291
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Federico Tedin <federicotedin <at> gmail.com>
Cc: juri <at> linkov.net, pogonyshev <at> gmail.com, monnier <at> iro.umontreal.ca,
 39291-done <at> debbugs.gnu.org
Subject: Re: bug#39291: M-: history doesn't store erroneous input
Date: Fri, 31 Jan 2020 11:20:20 +0200

> From: Federico Tedin <federicotedin <at> gmail.com>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  39291 <at> debbugs.gnu.org,  pogonyshev <at> gmail.com,  Juri Linkov <juri <at> linkov.net>
> Date: Fri, 31 Jan 2020 01:44:34 +0100
> 
> > AFAIK they don't depend on Lisp variables, no, so it should be safe to
> > move the call to `string_to_object` to after the `unbind_to`.
> >
> Thanks for the information. In that case, the patch I sent should be the
> right fix for this bug.

Thanks, pushed to the release branch.

> * src/minibuf.c (read_minibuf): Parse input string after saving the
> string to the history list instead of before, in case parsing
> fails. (Bug#39291)
       ^^
Please in the future leave 2 blanks between sentences, per our
conventions.

[Message part 3 (message/rfc822, inline)]

From: Paul Pogonyshev <pogonyshev <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: M-: history doesn't store erroneous input
Date: Sun, 26 Jan 2020 16:16:23 +0100

[Message part 4 (text/plain, inline)]

M-: (oops-i-forgot-to-type-the-closing-paren RET
=> End of file during parsing

Error itself is fine, but the problem is if you now
type M-: again, you won't find your input in the
history and have to retype everything from scratch
instead of just fixing the typo.

This is a regression in trunk compared at least to
26.3.

[Message part 5 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.