GNU bug report logs - #39291
M-: history doesn't store erroneous input

Previous Next

Full log

View this message in rfc822 format

From: Federico Tedin <federicotedin <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 39291 <at> debbugs.gnu.org, pogonyshev <at> gmail.com, Juri Linkov <juri <at> linkov.net>
Subject: bug#39291: M-: history doesn't store erroneous input
Date: Wed, 29 Jan 2020 22:32:16 +0100

[Message part 1 (text/plain, inline)]

> Federico, please look into fixing this regression.
>
> TIA

I found that the minibuffer input string in `read_minibuf' was being
added to the history list after we tried to parse an object from it (if
`expflag' was true). So if the parsing failed, then the value wasn't
added to the history. I'm attaching a patch with my changes.

My only doubt is that now, the call to `string_to_object' (which calls
`read-from-string', which calls `read1', and then `read0') is located
outside the context (not sure what the right term is) set up with
`specbind'. Could this be a problem? Do any of these functions depend on
the context set up in `read_minibuf'?  (They don't appear to, just want
to be sure).

Thanks.

[minibuf.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.