Subject: bug#39291: closed (Re: bug#39291: M-: history doesn't store erroneous input)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 31 Jan 2020 09:21:02 +0000

Your bug report

#39291: M-: history doesn't store erroneous input

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
39291: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39291
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#39291: M-: history doesn't store erroneous input
From: Eli Zaretskii <[email-masked]>
To: Federico Tedin <[email-masked]>
Cc: [email-masked], [email-masked], [email-masked], [email-masked]
Date: Fri, 31 Jan 2020 11:20:20 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: Federico Tedin <[email-masked]>
> Cc: Eli Zaretskii <[email-masked]>,  [email-masked],  [email-masked],  Juri Linkov <[email-masked]>
> Date: Fri, 31 Jan 2020 01:44:34 +0100
> 
> > AFAIK they don't depend on Lisp variables, no, so it should be safe to
> > move the call to `string_to_object` to after the `unbind_to`.
> >
> Thanks for the information. In that case, the patch I sent should be the
> right fix for this bug.

Thanks, pushed to the release branch.

> * src/minibuf.c (read_minibuf): Parse input string after saving the
> string to the history list instead of before, in case parsing
> fails. (Bug#39291)
       ^^
Please in the future leave 2 blanks between sentences, per our
conventions.

Subject: M-: history doesn't store erroneous input
From: Paul Pogonyshev <[email-masked]>
To: [email-masked]
Date: Sun, 26 Jan 2020 16:16:23 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

M-: (oops-i-forgot-to-type-the-closing-paren RET
=> End of file during parsing

Error itself is fine, but the problem is if you now
type M-: again, you won't find your input in the
history and have to retype everything from scratch
instead of just fixing the typo.

This is a regression in trunk compared at least to
26.3.