From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 26 10:16:39 2020 Received: (at submit) by debbugs.gnu.org; 26 Jan 2020 15:16:39 +0000 Received: from localhost ([127.0.0.1]:57286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivjeR-0002FF-9i for submit@debbugs.gnu.org; Sun, 26 Jan 2020 10:16:39 -0500 Received: from lists.gnu.org ([209.51.188.17]:55183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivjeP-0002F8-P7 for submit@debbugs.gnu.org; Sun, 26 Jan 2020 10:16:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50119) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivjeO-0001sX-OU for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 10:16:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivjeN-0001XG-TW for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 10:16:36 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:33613) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ivjeN-0001Wk-Nu for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 10:16:35 -0500 Received: by mail-wr1-x42d.google.com with SMTP id b6so7884701wrq.0 for ; Sun, 26 Jan 2020 07:16:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=cAyT+6XHngGXSbf2THrj166RxAacgbJo6cJWzR5wN2Q=; b=ebTEWxl54yL0JJ9QcANv/C4kPI4M0xqsEjf0N5ystadX8m2ZOz/FITP3iM12oiyxeA fvfp0ZqYC20sbKJ2E6+a7e7ElmaOXhIAbsJAOa15ziVnQSXCqiy+nNoFXc+E9Ycf4b6K ppp1kTO5SPlbRTqXgRYLch1/uqa1vYS2T+HvmKXPKguFbtc5jS/yEXm0Ne63VzYGM3u5 aPdeuyF3XullP8x8vTBWajCCH+0fePVCnPKCqKHNZLP10L46x4v3dzkW0vHND7N5Phko Six4Pk5Um/Nh2WpRGciHJHbflWXMArqlkCeQq8l6/JjdDIgei3r+bSbzmrkNmuypDDeL fAxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=cAyT+6XHngGXSbf2THrj166RxAacgbJo6cJWzR5wN2Q=; b=UHK8g/tGoskrZgt5H9RG2JYBG7nyu7UU3lU/kBpUYWeOeEuqg97gs8klnjjTpwi2F8 iGrsS5y+14xqXcCM59h+XRPcNgNKLLc040oWxsOMhQ+XihSMJOLXKTD6HidJmKPvlo5e Cw+Dlg0whHjX8yk+0aFrSsJzSo+5R/0QPxZ+1Ce9dbyHjRBSHRg/563IYUcgosd2ejZJ hLy+RMJxG11ZL5n0hWAEivmL3lOR4sz+pfsWNQFyyhLczwL893npJs5mHrtvW9qFbl9o x30QzVzwIjePQ8z9P8nDOX8L98M5sBusnSrRD6zL83YEJ4lN9XQ86XMd3ecJFIpva64W alzg== X-Gm-Message-State: APjAAAWXXCgA2iGUgr7pVEp5Ee/XnfB0kn250pU53F2M6xZ9Q1dSs8/u 4KbNgxOW2hSdEGsvKLHmPRlwiRD1HZYPz95URxRL X-Google-Smtp-Source: APXvYqyqefjn/a+nOO7r5sT4a2HqP9ETvrncwuwwXnZ3MMRYYkUkcbB3w68Qybk2btf8h4rHXfgxWH6XuH1qvOo1pak= X-Received: by 2002:adf:cf0a:: with SMTP id o10mr15632275wrj.325.1580051794069; Sun, 26 Jan 2020 07:16:34 -0800 (PST) MIME-Version: 1.0 From: Paul Pogonyshev Date: Sun, 26 Jan 2020 16:16:23 +0100 Message-ID: Subject: M-: history doesn't store erroneous input To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000e98c25059d0c793f" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42d X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: M-: (oops-i-forgot-to-type-the-closing-paren RET => End of file during parsing Error itself is fine, but the problem is if you now type M-: again, you won't find your input in the history and have to retype everything from scratch instead of just fixing the typo. Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pogonyshev[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 HTML_MESSAGE BODY: HTML included in message -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000e98c25059d0c793f Content-Type: text/plain; charset="UTF-8" M-: (oops-i-forgot-to-type-the-closing-paren RET => End of file during parsing Error itself is fine, but the problem is if you now type M-: again, you won't find your input in the history and have to retype everything from scratch instead of just fixing the typo. This is a regression in trunk compared at least to 26.3. --000000000000e98c25059d0c793f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
M-: (oops-i-forgot-to-type-the-closing-paren RET
=3D&g= t; End of file during parsing

Error itself is fine, = but the problem is if you now
type M-: again, you won't find = your input in the
history and have to retype everything from scra= tch
instead of just fixing the typo.

Thi= s is a regression in trunk compared at least to
26.3.
=
--000000000000e98c25059d0c793f-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 28 18:53:28 2020 Received: (at 39291) by debbugs.gnu.org; 28 Jan 2020 23:53:28 +0000 Received: from localhost ([127.0.0.1]:33040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwafg-0002md-4f for submit@debbugs.gnu.org; Tue, 28 Jan 2020 18:53:28 -0500 Received: from black.elm.relay.mailchannels.net ([23.83.212.19]:22557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwafd-0002mU-Cw for 39291@debbugs.gnu.org; Tue, 28 Jan 2020 18:53:26 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 94171580AB2; Tue, 28 Jan 2020 23:53:23 +0000 (UTC) Received: from pdx1-sub0-mail-a93.g.dreamhost.com (100-96-86-194.trex.outbound.svc.cluster.local [100.96.86.194]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 8D115580BEB; Tue, 28 Jan 2020 23:53:22 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a93.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Tue, 28 Jan 2020 23:53:23 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Coil-Vacuous: 2e83ca2d2368daed_1580255603237_2181890084 X-MC-Loop-Signature: 1580255603237:2484901711 X-MC-Ingress-Time: 1580255603237 Received: from pdx1-sub0-mail-a93.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a93.g.dreamhost.com (Postfix) with ESMTP id 3B0CC81267; Tue, 28 Jan 2020 15:53:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=NWaXGz7Nrj3GLv3ybiC2JVkbI0E=; b= TmRxABU0foFIsEv6Zs7SCGbD4TDQ1gERjCLBk8v0L7RvanXW44ifM46WPqq+Xrlz W4ZThu3koBRwhccswfnTAiX6NFnrgppR2ksJVSL7FPx0Y8uPDQlQfEMui/FdRH/L StBAhXNxdhBF6e2QODbUdRsVBSsLwRcmPmhzlcyEF1M= Received: from mail.jurta.org (m91-129-105-126.cust.tele2.ee [91.129.105.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a93.g.dreamhost.com (Postfix) with ESMTPSA id 253E380EF4; Tue, 28 Jan 2020 15:53:17 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a93 From: Juri Linkov To: Paul Pogonyshev Subject: Re: bug#39291: M-: history doesn't store erroneous input Organization: LINKOV.NET References: Date: Wed, 29 Jan 2020 01:35:33 +0200 In-Reply-To: (Paul Pogonyshev's message of "Sun, 26 Jan 2020 16:16:23 +0100") Message-ID: <87mua7b1dm.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.60 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrfeehgddtjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuffhomhgrihhnpehgnhhurdhorhhgnecukfhppeeluddruddvledruddthedruddvieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedruddviedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehpohhgohhnhihshhgvvhesghhmrghilhdrtghomh X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39291 Cc: 39291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > M-: (oops-i-forgot-to-type-the-closing-paren RET > => End of file during parsing > > Error itself is fine, but the problem is if you now > type M-: again, you won't find your input in the > history and have to retype everything from scratch > instead of just fixing the typo. > > This is a regression in trunk compared at least to > 26.3. This was changed by http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9042ece787c via https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38317#23 and https://lists.gnu.org/archive/html/emacs-devel/2019-12/msg00241.html From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 29 12:16:22 2020 Received: (at 39291) by debbugs.gnu.org; 29 Jan 2020 17:16:22 +0000 Received: from localhost ([127.0.0.1]:34553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwqww-0000oq-EO for submit@debbugs.gnu.org; Wed, 29 Jan 2020 12:16:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwqwu-0000oc-7R for 39291@debbugs.gnu.org; Wed, 29 Jan 2020 12:16:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iwqwo-00033g-0I; Wed, 29 Jan 2020 12:16:14 -0500 Received: from [176.228.60.248] (port=3861 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iwqwl-0000Rw-0e; Wed, 29 Jan 2020 12:16:13 -0500 Date: Wed, 29 Jan 2020 19:16:09 +0200 Message-Id: <83sgjymbdy.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov , Federico Tedin In-reply-to: <87mua7b1dm.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 29 Jan 2020 01:35:33 +0200) Subject: Re: bug#39291: M-: history doesn't store erroneous input References: <87mua7b1dm.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39291 Cc: 39291@debbugs.gnu.org, pogonyshev@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Juri Linkov > Date: Wed, 29 Jan 2020 01:35:33 +0200 > Cc: 39291@debbugs.gnu.org > > > M-: (oops-i-forgot-to-type-the-closing-paren RET > > => End of file during parsing > > > > Error itself is fine, but the problem is if you now > > type M-: again, you won't find your input in the > > history and have to retype everything from scratch > > instead of just fixing the typo. > > > > This is a regression in trunk compared at least to > > 26.3. > > This was changed by > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9042ece787c > via https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38317#23 > and https://lists.gnu.org/archive/html/emacs-devel/2019-12/msg00241.html Federico, please look into fixing this regression. TIA From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 29 13:09:58 2020 Received: (at 39291) by debbugs.gnu.org; 29 Jan 2020 18:09:58 +0000 Received: from localhost ([127.0.0.1]:34573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwrmn-00027l-Ni for submit@debbugs.gnu.org; Wed, 29 Jan 2020 13:09:57 -0500 Received: from mail-io1-f46.google.com ([209.85.166.46]:40956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwrml-00027V-OJ for 39291@debbugs.gnu.org; Wed, 29 Jan 2020 13:09:56 -0500 Received: by mail-io1-f46.google.com with SMTP id x1so754100iop.7 for <39291@debbugs.gnu.org>; Wed, 29 Jan 2020 10:09:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XT+sPByJJnqqYtfJFnI91Bh025xAi4Bi+pWvQ36Qdlk=; b=N1pvAtrbpQrcGSt6SRB/XJGCgEZm9YY4p37Jp0Be5Z2HsL/6Knlo5GQZBgkTxWwt5C xK7TjHPCdL4KbJmhB380JKb5CufAVg0UxGweA/gjZl0y9zljuU+Pp7GFoNFJOghnWLGc AoWSywNXDZo5o6/S0CFd3VjsA6YsSGAbInfmGq0wAjd7Zir69PblADbiWqN66uDsTkt6 YY4+v/FFl4pv5zhwMBVpHr8qynTrnmcYukisyCTS9D0mTWnwP0jTkaX0lDlO3ND9U37U 6haRtnu87j8o8XKCR10gOQknfJJrEcCTRDKNJkXSjkv5mE8RkJZFWintGIooedSVDkjD 3+rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XT+sPByJJnqqYtfJFnI91Bh025xAi4Bi+pWvQ36Qdlk=; b=kSJ+Z+YRg+LvRCzhcaFetDTuCk9kiMuqI3+rhbQXoeZZmIlo76kx6mKLBUQGtnQ3Zs cfsBVd7EMybfqUBAAIRHqokr3MNINQ06G5Z3LhlQhozxL1b9TKh00sq+wVJQrJzC5zB9 ZwybRrvhg4MzJ/v2lN5JEPeeOwyHK0MLkzxXdR/w7fhmdTZiSwWuYO6fGnFNPQnijNyi KZCJel18i5EKQuIVaFnU2eNxw4KpJqbvOfW9e89q2WYIae30jq2FwbCKphhVA8O9c0E1 6OZYhGWLXayohIa6htUau3LQMbIUzoSjfTddvYYlK1W/nNHLWl1oI+BNbOby2jzr69nR W5jA== X-Gm-Message-State: APjAAAUkrq6KD9dbfYtOc9KfUQzUEUyJYn7EmMi50D/w3HzW8MyuL2GI QpFrWzksq2cWMS0Mg0/w62+BjfZCR6sK2Pmpc+0= X-Google-Smtp-Source: APXvYqxQc5EDiHidofWMblnHLxpHIrplNIFbVqfRs9a7ZY8SAd5otbPIhdmb0v83xIIcUzHt/K/RBh32MKOwqcDoEJ8= X-Received: by 2002:a6b:39c4:: with SMTP id g187mr580645ioa.271.1580321389968; Wed, 29 Jan 2020 10:09:49 -0800 (PST) MIME-Version: 1.0 References: <87mua7b1dm.fsf@mail.linkov.net> <83sgjymbdy.fsf@gnu.org> In-Reply-To: <83sgjymbdy.fsf@gnu.org> From: Federico Tedin Date: Wed, 29 Jan 2020 19:09:38 +0100 Message-ID: Subject: Re: bug#39291: M-: history doesn't store erroneous input To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000001480dd059d4b3f46" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39291 Cc: 39291@debbugs.gnu.org, pogonyshev@gmail.com, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000001480dd059d4b3f46 Content-Type: text/plain; charset="UTF-8" On Wed, 29 Jan 2020 at 18:16 Eli Zaretskii wrote: > > From: Juri Linkov > > Date: Wed, 29 Jan 2020 01:35:33 +0200 > > Cc: 39291@debbugs.gnu.org > > > > > M-: (oops-i-forgot-to-type-the-closing-paren RET > > > => End of file during parsing > > > > > > Error itself is fine, but the problem is if you now > > > type M-: again, you won't find your input in the > > > history and have to retype everything from scratch > > > instead of just fixing the typo. > > > > > > This is a regression in trunk compared at least to > > > 26.3. > > > > This was changed by > > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9042ece787c > > via https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38317#23 > > and https://lists.gnu.org/archive/html/emacs-devel/2019-12/msg00241.html > > Federico, please look into fixing this regression. > > TIA Thanks for letting me know, I will take a look at it. > --0000000000001480dd059d4b3f46 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, 29 Jan 2020 at 18:16 Eli Zaretskii <eliz@gnu.org> wrote:
> From: Juri Linkov <juri@linkov.net>
> Date: Wed, 29 Jan 2020 01:35:33 +0200
> Cc: 39291@d= ebbugs.gnu.org
>
> > M-: (oops-i-forgot-to-type-the-closing-paren RET
> > =3D> End of file during parsing
> >
> > Error itself is fine, but the problem is if you now
> > type M-: again, you won't find your input in the
> > history and have to retype everything from scratch
> > instead of just fixing the typo.
> >
> > This is a regression in trunk compared at least to
> > 26.3.
>
> This was changed by
> http://git.savannah.gnu.org/= cgit/emacs.git/commit/?id=3D9042ece787c
> via https://debbugs.gnu.org/cgi/bugrepo= rt.cgi?bug=3D38317#23
> and https://lists.gnu.org/a= rchive/html/emacs-devel/2019-12/msg00241.html

Federico, please look into fixing this regression.

TIA

Thanks for le= tting me know, I will take a look at it.
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39291 Cc: 39291@debbugs.gnu.org, pogonyshev@gmail.com, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain > Federico, please look into fixing this regression. > > TIA I found that the minibuffer input string in `read_minibuf' was being added to the history list after we tried to parse an object from it (if `expflag' was true). So if the parsing failed, then the value wasn't added to the history. I'm attaching a patch with my changes. My only doubt is that now, the call to `string_to_object' (which calls `read-from-string', which calls `read1', and then `read0') is located outside the context (not sure what the right term is) set up with `specbind'. Could this be a problem? Do any of these functions depend on the context set up in `read_minibuf'? (They don't appear to, just want to be sure). Thanks. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=minibuf.patch Content-Description: patch >From 6a35a1390d1f1924d0fd52dbb885af66d089273c Mon Sep 17 00:00:00 2001 From: Federico Tedin Date: Wed, 29 Jan 2020 22:24:40 +0100 Subject: [PATCH 1/1] Ensure input is added to history in read_minibuf * src/minibuf.c (read_minibuf): Parse input string after saving the string to the history list instead of before, in case parsing fails. (Bug#39291) --- src/minibuf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/minibuf.c b/src/minibuf.c index 8ebdff1252..9d870ce364 100644 --- a/src/minibuf.c +++ b/src/minibuf.c @@ -697,10 +697,6 @@ read_minibuf (Lisp_Object map, Lisp_Object initial, Lisp_Object prompt, else histstring = Qnil; - /* If Lisp form desired instead of string, parse it. */ - if (expflag) - val = string_to_object (val, defalt); - /* The appropriate frame will get selected in set-window-configuration. */ unbind_to (count, Qnil); @@ -711,6 +707,10 @@ read_minibuf (Lisp_Object map, Lisp_Object initial, Lisp_Object prompt, if (! (NILP (Vhistory_add_new_input) || NILP (histstring))) call2 (intern ("add-to-history"), histvar, histstring); + /* If Lisp form desired instead of string, parse it. */ + if (expflag) + val = string_to_object (val, defalt); + return val; } -- 2.17.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 30 09:14:54 2020 Received: (at 39291) by debbugs.gnu.org; 30 Jan 2020 14:14:54 +0000 Received: from localhost ([127.0.0.1]:35094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixAas-0005LA-3P for submit@debbugs.gnu.org; Thu, 30 Jan 2020 09:14:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixAap-0005Kw-Nb for 39291@debbugs.gnu.org; Thu, 30 Jan 2020 09:14:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixAag-0001TX-US; Thu, 30 Jan 2020 09:14:42 -0500 Received: from [176.228.60.248] (port=4727 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixAag-0004jc-87; Thu, 30 Jan 2020 09:14:42 -0500 Date: Thu, 30 Jan 2020 16:14:42 +0200 Message-Id: <83k159m3ot.fsf@gnu.org> From: Eli Zaretskii To: Federico Tedin , Stefan Monnier In-reply-to: <87blqm0x0f.fsf@gmail.com> (message from Federico Tedin on Wed, 29 Jan 2020 22:32:16 +0100) Subject: Re: bug#39291: M-: history doesn't store erroneous input References: <87mua7b1dm.fsf@mail.linkov.net> <83sgjymbdy.fsf@gnu.org> <87blqm0x0f.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39291 Cc: 39291@debbugs.gnu.org, pogonyshev@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Federico Tedin > Cc: Juri Linkov , 39291@debbugs.gnu.org, pogonyshev@gmail.com > Date: Wed, 29 Jan 2020 22:32:16 +0100 > > I found that the minibuffer input string in `read_minibuf' was being > added to the history list after we tried to parse an object from it (if > `expflag' was true). So if the parsing failed, then the value wasn't > added to the history. I'm attaching a patch with my changes. Thanks. > My only doubt is that now, the call to `string_to_object' (which calls > `read-from-string', which calls `read1', and then `read0') is located > outside the context (not sure what the right term is) set up with > `specbind'. Could this be a problem? Do any of these functions depend on > the context set up in `read_minibuf'? (They don't appear to, just want > to be sure). Why is it a problem to move the call to unbind_to to after the call to add-to-history? AFAIU, the original code, before you changed it, actually did that. It just didn't call string_to_object, but I'm not sure why would that change anything. Does anyone see a problem here? Stefan, any comments? From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 30 09:21:03 2020 Received: (at 39291) by debbugs.gnu.org; 30 Jan 2020 14:21:03 +0000 Received: from localhost ([127.0.0.1]:35108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixAgp-0005Vo-3v for submit@debbugs.gnu.org; Thu, 30 Jan 2020 09:21:03 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixAgm-0005Uo-Uu for 39291@debbugs.gnu.org; Thu, 30 Jan 2020 09:21:01 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9D38E440CD3; Thu, 30 Jan 2020 09:20:55 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 19350440BDB; Thu, 30 Jan 2020 09:20:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1580394054; bh=pxFN/+DXy9MWrC/+dPt1P90pb3DgUG1tVbmOmzJwWD0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IpfxartOY4/wPGbe+c4jHumQr7hnlv1YAQuDtr0xDtmCEUwhxXtNteMU8D5BRcLGt 1DsLPf1uKyFDntjK+wuP2vjRBAmIcVeVaGwi4ZVGrw20doAdoqKIPdpOZMDX1v/qER xkGwSAefaqtgjSU2jk15gOvSfplwY7tYQiej5312FZAPE4twM+w2PC23GNB8X122W0 +Kfov1iKHYnmteiG+nZsszmoB5IgqR5KXdMXDfjZOHHsxMoeCMzStr5CK88a680Ph1 hc/U+FAMHhzmu9c/pBcb6id1yuV8jbHAhBO0jPy3NABk1sk/HGbt+ABB57V8JeMQIX SI7Xfn8GYwc4Q== Received: from pastel (unknown [45.72.213.248]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 811A8120FC5; Thu, 30 Jan 2020 09:20:53 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#39291: M-: history doesn't store erroneous input Message-ID: References: <87mua7b1dm.fsf@mail.linkov.net> <83sgjymbdy.fsf@gnu.org> <87blqm0x0f.fsf@gmail.com> <83k159m3ot.fsf@gnu.org> Date: Thu, 30 Jan 2020 09:20:52 -0500 In-Reply-To: <83k159m3ot.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 30 Jan 2020 16:14:42 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39291 Cc: juri@linkov.net, pogonyshev@gmail.com, 39291@debbugs.gnu.org, Federico Tedin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Why is it a problem to move the call to unbind_to to after the call to > add-to-history? Because it would make `add-to-history` add to the minibuffer-local value rather than to the callingbuffer-local value, as the comment explains: /* Add the value to the appropriate history list, if any. This is done after the previous buffer has been made current again, in case the history variable is buffer-local. */ -- Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 30 09:23:21 2020 Received: (at 39291) by debbugs.gnu.org; 30 Jan 2020 14:23:21 +0000 Received: from localhost ([127.0.0.1]:35114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixAj3-0005ZG-Ho for submit@debbugs.gnu.org; Thu, 30 Jan 2020 09:23:21 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixAj1-0005Z2-LW for 39291@debbugs.gnu.org; Thu, 30 Jan 2020 09:23:19 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6586A440CD4; Thu, 30 Jan 2020 09:23:14 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D55FE440BDB; Thu, 30 Jan 2020 09:23:12 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1580394192; bh=UUpVDd3QA3Ik5EggPTe6vQTIDBrJNH1A5XmhHNlHx+Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=M0TqreNNohAXruyqd7VJPhBVIvEwEVZ5Ha3c1c9OObMDZUYm3QnR7OsaRM4/NRZlb Ly2Zy8T1Poh9ifnh6gzXibtMSroHbx7J/b3o5Fg/CgM9y/0kk3pQwTmSclAn/knTlg AaeEh1B4lHtvQ6YLPIEUoXqQCjQTnfD3GGzOsJFn0kinjnCe3/ggiwPBczva1aU6FD gHqJ0v2uJS6ZlOD9kNEesvwHVIaVQUil8oHF31QLIXj7yQT1NDoCL5ZihIjm70eyVy 9iD/k9FdsahKdPb8G/OoyQUwkorVIpsE+GUHcV+XFH4HdHYaXg5Qk9mBIVHa8Dsccc sV2OIqdJ5nDMg== Received: from pastel (unknown [45.72.213.248]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 96C391204BC; Thu, 30 Jan 2020 09:23:12 -0500 (EST) From: Stefan Monnier To: Federico Tedin Subject: Re: bug#39291: M-: history doesn't store erroneous input Message-ID: References: <87mua7b1dm.fsf@mail.linkov.net> <83sgjymbdy.fsf@gnu.org> <87blqm0x0f.fsf@gmail.com> Date: Thu, 30 Jan 2020 09:23:11 -0500 In-Reply-To: <87blqm0x0f.fsf@gmail.com> (Federico Tedin's message of "Wed, 29 Jan 2020 22:32:16 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39291 Cc: Eli Zaretskii , 39291@debbugs.gnu.org, pogonyshev@gmail.com, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > My only doubt is that now, the call to `string_to_object' (which calls > `read-from-string', which calls `read1', and then `read0') is located > outside the context (not sure what the right term is) set up with > `specbind'. Could this be a problem? Do any of these functions depend on > the context set up in `read_minibuf'? (They don't appear to, just want > to be sure). AFAIK they don't depend on Lisp variables, no, so it should be safe to move the call to `string_to_object` to after the `unbind_to`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 30 19:44:43 2020 Received: (at 39291) by debbugs.gnu.org; 31 Jan 2020 00:44:43 +0000 Received: from localhost ([127.0.0.1]:36406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixKQM-0005iw-Vd for submit@debbugs.gnu.org; Thu, 30 Jan 2020 19:44:43 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:40182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixKQM-0005ik-4G for 39291@debbugs.gnu.org; Thu, 30 Jan 2020 19:44:42 -0500 Received: by mail-wm1-f54.google.com with SMTP id t14so6635831wmi.5 for <39291@debbugs.gnu.org>; Thu, 30 Jan 2020 16:44:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=tOTN9Py0otnFqtWXsbtwLQ0+TILfFMIvw6+ApoGfY4I=; b=g44xKO29fJuMvPagUXd+rycnD9LiH7I+t8lGrdlVTrUTt7SVRmPLh9sXJyM4JgCb9S hsxaGuINAA4GU3umiJvq9nyrm9tukexHHfK63nkkvDimXLLpLwFqTwa5TNssJnMyZNfQ Neh3w+D0qHdEvipsmRhsYoKCFsp3+R/5AE/1S+8dtOZ2q3163oRa0ZUnbl6Avdcdfqgo xI2amrlZPgkEv+IgrVppDOVwrgu2IThysE417XRvVtkmbtz937SLVzusp9c/WBpSqf5A 8HQ7kxIp02R8tbbZPVwgMM2ox1CreddEHd2CcwN34sk4thC69gouxM3FqRWSB/qTb/w5 u3tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=tOTN9Py0otnFqtWXsbtwLQ0+TILfFMIvw6+ApoGfY4I=; b=MdDj08PtIjmKij1GgpM2RjnS4wXucfZr6YZqJ+QH/1B0nH8EjGMgtUjiiqhnR3vaEm nyVBhcgQgkWdX/0Arg/1mF7UXqL4/WHX1y7S+2LLFAPlrKIjKjXsylkWqdidCvpDTNWE cDR/9OHqh1Q8R893dNNnehs4n+n9F2P7tXOCujpIBTeSHEsjEFYS3WQU1kDG6wpaYZU9 mCfS7OIFpkIPStuw7Cxlh28Q7s8vDtkcy1zodrebj+hPFUbHbatbtGjnOKQWlaKwV0N7 gf2qeotNESlwlTUald6KOC88Boo8m07WiN4YbO8Xm2AKzisMszSi9JdoeLxIi1mlOWUB o0qQ== X-Gm-Message-State: APjAAAXM6gUO4wEZqT4gypYWqUQ5je6FD7B86/sF4aWPCvAAlYyniZoj OTA6aiWZczMtzeZhbYdJbS8= X-Google-Smtp-Source: APXvYqzSKVrPxiTb3RR1baJSoj69W5Mw13NN7mnIXoltsaUTR1oOjsi4iWXaZOJkf/ep1xOah0hVpQ== X-Received: by 2002:a05:600c:2409:: with SMTP id 9mr8313479wmp.109.1580431476235; Thu, 30 Jan 2020 16:44:36 -0800 (PST) Received: from lead ([2a02:8109:8ac0:2ff0:d7c:b490:1ada:2ab5]) by smtp.gmail.com with ESMTPSA id b137sm9109216wme.26.2020.01.30.16.44.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Jan 2020 16:44:35 -0800 (PST) From: Federico Tedin To: Stefan Monnier Subject: Re: bug#39291: M-: history doesn't store erroneous input References: <87mua7b1dm.fsf@mail.linkov.net> <83sgjymbdy.fsf@gnu.org> <87blqm0x0f.fsf@gmail.com> Date: Fri, 31 Jan 2020 01:44:34 +0100 In-Reply-To: (Stefan Monnier's message of "Thu, 30 Jan 2020 09:23:11 -0500") Message-ID: <87d0b0sbd9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39291 Cc: Eli Zaretskii , 39291@debbugs.gnu.org, pogonyshev@gmail.com, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > AFAIK they don't depend on Lisp variables, no, so it should be safe to > move the call to `string_to_object` to after the `unbind_to`. > > > Stefan Thanks for the information. In that case, the patch I sent should be the right fix for this bug. - Fede From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 31 04:20:50 2020 Received: (at 39291-done) by debbugs.gnu.org; 31 Jan 2020 09:20:50 +0000 Received: from localhost ([127.0.0.1]:36568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixSTq-00017d-8H for submit@debbugs.gnu.org; Fri, 31 Jan 2020 04:20:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixSTp-00017P-02 for 39291-done@debbugs.gnu.org; Fri, 31 Jan 2020 04:20:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixSTj-0003nI-Nq; Fri, 31 Jan 2020 04:20:43 -0500 Received: from [176.228.60.248] (port=3395 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixSTi-0008Pn-AF; Fri, 31 Jan 2020 04:20:43 -0500 Date: Fri, 31 Jan 2020 11:20:20 +0200 Message-Id: <83tv4ckmnf.fsf@gnu.org> From: Eli Zaretskii To: Federico Tedin In-reply-to: <87d0b0sbd9.fsf@gmail.com> (message from Federico Tedin on Fri, 31 Jan 2020 01:44:34 +0100) Subject: Re: bug#39291: M-: history doesn't store erroneous input References: <87mua7b1dm.fsf@mail.linkov.net> <83sgjymbdy.fsf@gnu.org> <87blqm0x0f.fsf@gmail.com> <87d0b0sbd9.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39291-done Cc: juri@linkov.net, pogonyshev@gmail.com, monnier@iro.umontreal.ca, 39291-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Federico Tedin > Cc: Eli Zaretskii , 39291@debbugs.gnu.org, pogonyshev@gmail.com, Juri Linkov > Date: Fri, 31 Jan 2020 01:44:34 +0100 > > > AFAIK they don't depend on Lisp variables, no, so it should be safe to > > move the call to `string_to_object` to after the `unbind_to`. > > > Thanks for the information. In that case, the patch I sent should be the > right fix for this bug. Thanks, pushed to the release branch. > * src/minibuf.c (read_minibuf): Parse input string after saving the > string to the history list instead of before, in case parsing > fails. (Bug#39291) ^^ Please in the future leave 2 blanks between sentences, per our conventions. From unknown Wed Sep 10 06:21:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 28 Feb 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator