From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 26 09:21:16 2020 Received: (at submit) by debbugs.gnu.org; 26 Jan 2020 14:21:16 +0000 Received: from localhost ([127.0.0.1]:56652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivimq-0000iH-6i for submit@debbugs.gnu.org; Sun, 26 Jan 2020 09:21:16 -0500 Received: from lists.gnu.org ([209.51.188.17]:47039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivimn-0000i8-7b for submit@debbugs.gnu.org; Sun, 26 Jan 2020 09:21:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42216) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iviml-0007ZL-Vl for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 09:21:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivimk-0003gK-O5 for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 09:21:11 -0500 Received: from mail76c50.megamailservers.eu ([91.136.10.86]:41994 helo=mail70c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ivimk-0003dI-6p for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 09:21:10 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1580048465; bh=AQg2+twX73CKR2wL20INOLPWkhRByBE38JOYVNcI2eo=; h=From:Subject:Date:To:From; b=QeGYj0M01H6KJTbmJyHcLqjfTksqbBKQOigMKA/659NvH35DAkHEohEpVeoHnyWLd 4SYxnOkPzB4Jb0pOs3QBIOIoDh7k9yM20L3WkxSkylgC8IhQT4706WxF9BVNKhjeEZ phVKcae48Pyy8XDzBorXdSFNsLpZy5Am/OaT6JHo= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 00QEL3LO009167 for ; Sun, 26 Jan 2020 14:21:05 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_DE8C5A97-330D-4D1C-8825-0638123C13C1" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [PATCH] Correct regexp for flags in 'format' doc string Message-Id: <1435B249-47D1-4546-9B3F-6C67FAD16EB5@acm.org> Date: Sun, 26 Jan 2020 15:21:02 +0100 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0214.5E2DA051.0004, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=c6bVvi1l c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=M51BFTxLslgA:10 a=48AkvT27whSlDIdDpAkA:9 a=CjuIK1q_8ugA:10 a=1EqHv2zIUh71slR-qCUA:9 a=B2y7HmGcmWMA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.10.86 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_DE8C5A97-330D-4D1C-8825-0638123C13C1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii The doc string for 'format' contains where field is [0-9]+ followed by a literal dollar "$", flags is [+ #-0]+, width is [0-9]+, and precision is a literal period "." followed by [0-9]+. The spec for flags isn't a correct regexp; the hyphen should be last. = This matters, because people copy it into their code without thinking = (observed in the wild). Patch acceptable for emacs-27? --Apple-Mail=_DE8C5A97-330D-4D1C-8825-0638123C13C1 Content-Disposition: attachment; filename=0001-Correct-regexp-for-flags-in-format-doc-string.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Correct-regexp-for-flags-in-format-doc-string.patch" Content-Transfer-Encoding: quoted-printable =46rom=205245a818d978a96c17c3ec7b99d93e32a07f90e6=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sun,=2026=20Jan=202020=2015:07:45=20+0100=0A= Subject:=20[PATCH]=20Correct=20regexp=20for=20flags=20in=20`format'=20= doc=20string=0A=0A*=20src/editfns.c=20(Fformat):=20Use=20the=20correct=20= regexp=20for=20describing=20the=0Aflags=20in=20a=20%-sequence=20(place=20= the=20hyphen=20last).=0A---=0A=20src/editfns.c=20|=202=20+-=0A=201=20= file=20changed,=201=20insertion(+),=201=20deletion(-)=0A=0Adiff=20--git=20= a/src/editfns.c=20b/src/editfns.c=0Aindex=204e35784e55..3f1b3aa4b7=20= 100644=0A---=20a/src/editfns.c=0A+++=20b/src/editfns.c=0A@@=20-3031,7=20= +3031,7=20@@=20DEFUN=20("format",=20Fformat,=20Sformat,=201,=20MANY,=20= 0,=0A=20=20=20%character=0A=20=0A=20= where=20field=20is=20[0-9]+=20followed=20by=20a=20literal=20dollar=20= "$",=20flags=20is=0A-[+=20#-0]+,=20width=20is=20[0-9]+,=20and=20= precision=20is=20a=20literal=20period=20"."=0A+[+=20#0-]+,=20width=20is=20= [0-9]+,=20and=20precision=20is=20a=20literal=20period=20"."=0A=20= followed=20by=20[0-9]+.=0A=20=0A=20If=20a=20%-sequence=20is=20numbered=20= with=20a=20field=20with=20positive=20value=20N,=20the=0A--=20=0A2.21.0=20= (Apple=20Git-122.2)=0A=0A= --Apple-Mail=_DE8C5A97-330D-4D1C-8825-0638123C13C1-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 26 13:08:29 2020 Received: (at 39290-done) by debbugs.gnu.org; 26 Jan 2020 18:08:29 +0000 Received: from localhost ([127.0.0.1]:57458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivmKi-0002FB-Rq for submit@debbugs.gnu.org; Sun, 26 Jan 2020 13:08:29 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:51614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivmKh-0002Ey-Im for 39290-done@debbugs.gnu.org; Sun, 26 Jan 2020 13:08:28 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8B11316007A; Sun, 26 Jan 2020 10:08:21 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id uFduWLN9AWhx; Sun, 26 Jan 2020 10:08:20 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E344816007F; Sun, 26 Jan 2020 10:08:20 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id K4rtbeuAt-Nw; Sun, 26 Jan 2020 10:08:20 -0800 (PST) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id BFED716007A; Sun, 26 Jan 2020 10:08:20 -0800 (PST) To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= From: Paul Eggert Subject: [PATCH] Correct regexp for flags in 'format' doc string Organization: UCLA Computer Science Department Message-ID: <5bdcd24b-73bd-63ed-07e6-b5d262e1e676@cs.ucla.edu> Date: Sun, 26 Jan 2020 10:08:17 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39290-done Cc: 39290-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thanks, I installed that in your name into the emacs-27 branch. I think doc fixes like that are still good for the emacs-27 branch. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 26 14:19:32 2020 Received: (at 39290) by debbugs.gnu.org; 26 Jan 2020 19:19:32 +0000 Received: from localhost ([127.0.0.1]:57501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivnRT-0003x9-NU for submit@debbugs.gnu.org; Sun, 26 Jan 2020 14:19:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivnRR-0003wv-Go for 39290@debbugs.gnu.org; Sun, 26 Jan 2020 14:19:30 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ivnRL-0004KV-Tw; Sun, 26 Jan 2020 14:19:23 -0500 Received: from [176.228.60.248] (port=3381 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ivnRL-0001hb-0W; Sun, 26 Jan 2020 14:19:23 -0500 Date: Sun, 26 Jan 2020 21:19:13 +0200 Message-Id: <83wo9enhzi.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <5bdcd24b-73bd-63ed-07e6-b5d262e1e676@cs.ucla.edu> (message from Paul Eggert on Sun, 26 Jan 2020 10:08:17 -0800) Subject: Re: bug#39290: [PATCH] Correct regexp for flags in 'format' doc string References: <1435B249-47D1-4546-9B3F-6C67FAD16EB5@acm.org> <5bdcd24b-73bd-63ed-07e6-b5d262e1e676@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39290 Cc: mattiase@acm.org, 39290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Paul Eggert > Date: Sun, 26 Jan 2020 10:08:17 -0800 > Cc: 39290-done@debbugs.gnu.org > > Thanks, I installed that in your name into the emacs-27 branch. I think doc > fixes like that are still good for the emacs-27 branch. Doc fixes are always good for the release branch. It's in CONTRIBUTE. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 26 14:21:48 2020 Received: (at 39290) by debbugs.gnu.org; 26 Jan 2020 19:21:48 +0000 Received: from localhost ([127.0.0.1]:57505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivnTg-00040z-7j for submit@debbugs.gnu.org; Sun, 26 Jan 2020 14:21:48 -0500 Received: from mail79c50.megamailservers.eu ([91.136.10.89]:45788 helo=mail70c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivnTd-00040n-RG for 39290@debbugs.gnu.org; Sun, 26 Jan 2020 14:21:46 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1580066492; bh=+llmhqfe4BVuRo8RfqkL825Wnth/JDI7dujhfFYiKek=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=NZBmD5sUS8p4tnfU517I1w3wi5E0gU5N3UlMOgRgpGtaaAns7lYNoYzMf+9q/VaDH GFUGOmPW/CSDvT+6hv7bvplkLYrd3xYm8H/jiRDDVvqpg4XHc1KHSJDWetu95B+QBi F1B68E5mShaKhYZXURizuA8FQh0qBw7KtU0GRWXs= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 00QJLSKZ005513; Sun, 26 Jan 2020 19:21:30 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: bug#39290: [PATCH] Correct regexp for flags in 'format' doc string From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83wo9enhzi.fsf@gnu.org> Date: Sun, 26 Jan 2020 20:21:28 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <0BA1EDD9-7510-4FB5-BEC2-70A2CC711C8D@acm.org> References: <1435B249-47D1-4546-9B3F-6C67FAD16EB5@acm.org> <5bdcd24b-73bd-63ed-07e6-b5d262e1e676@cs.ucla.edu> <83wo9enhzi.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0212.5E2DE6BB.0030, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=c6bVvi1l c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=dwXAcH0LYz-ai53ehTAA:9 a=CjuIK1q_8ugA:10 a=ncZ9vwaUYPMA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 39290 Cc: 39290@debbugs.gnu.org, Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 26 jan. 2020 kl. 20.19 skrev Eli Zaretskii : >=20 >> Thanks, I installed that in your name into the emacs-27 branch. I = think doc=20 >> fixes like that are still good for the emacs-27 branch. >=20 > Doc fixes are always good for the release branch. It's in CONTRIBUTE. Thank you both! From unknown Wed Sep 10 01:08:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 24 Feb 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator