From unknown Fri Jun 13 11:45:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input. Resent-From: Jesse Gibbons Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Jan 2020 01:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39275 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 39275@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.157991520811140 (code B ref -1); Sat, 25 Jan 2020 01:21:01 +0000 Received: (at submit) by debbugs.gnu.org; 25 Jan 2020 01:20:08 +0000 Received: from localhost ([127.0.0.1]:54874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivA7M-0002tc-1c for submit@debbugs.gnu.org; Fri, 24 Jan 2020 20:20:08 -0500 Received: from lists.gnu.org ([209.51.188.17]:44366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivA7J-0002tQ-Lm for submit@debbugs.gnu.org; Fri, 24 Jan 2020 20:20:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38603) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivA7H-0007Ce-Q0 for guix-patches@gnu.org; Fri, 24 Jan 2020 20:20:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_05, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivA7G-0003cI-Rv for guix-patches@gnu.org; Fri, 24 Jan 2020 20:20:03 -0500 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:38560) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ivA7G-0003Z9-BP for guix-patches@gnu.org; Fri, 24 Jan 2020 20:20:02 -0500 Received: by mail-pf1-x42a.google.com with SMTP id x185so1942376pfc.5 for ; Fri, 24 Jan 2020 17:20:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:date:user-agent:mime-version :content-transfer-encoding; bh=wXzkPbNhX8nqCfbc1g0K7OcbkwsK8aHfFAHBIMgE7v8=; b=lZh4tTOil9qPSOb7u8Hb67/tkJ0lDVLW19+CkNUR8Qj1GOohhrM7ypTQzlLaIjQj+/ ii3ldHZIIRGK7DG72Dn5K430wCsY89J/JB2lRcA+a15bkc4M5mEdFbvNoijrXZzAgdtJ P+vg8y1BAUZuGLXfAsNh9cYl45tFk1xuqKBOKQMpaf9u/IxWBpuPMny1I/sYMSW+H92x 6iDvUGLcU6QP9MajX4smi42szCgL/rdiWp+18G7IEqfJUNQOmfoxu0xREqMs4/clnKdw KRUI/rhbJwYsOaLH5Q0zplR8wGuXHgTObMTx2XGKfIYJFTkdcEV6QvjkmHWJ2xoFbxvQ QH1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:user-agent :mime-version:content-transfer-encoding; bh=wXzkPbNhX8nqCfbc1g0K7OcbkwsK8aHfFAHBIMgE7v8=; b=nNCLG++xwz50LMTN7IKU/rHN4gFEzHHQ7hXKjU3Y/RtFpgUIId69Q0WNlBifVeGnYu sBS7q4JAvvlE1xq+5dDR5sA4H2GpKNN6K4Wbpqfwcgbs46F9kXzMHiVQO/9fpVjFdCWt 6stVig980KnNNeTFnl/GAN70NpCKiiWjiHXNKChUuNmXDwvMocV6aUD88KZ/5ic2CRc6 rJ+ZO7PeT60SsqC85wbaRi8pW/F2+CW8jKE/fFBehdFTE9t8Y0gJJWV3AukSk9WN/3Ry 30WMh0aEu03MsWF8dJjOuCuz8Tg+9CeqDJFJWDc288Nk5w0rxf1gOiE88v7G+ccNNZuv O3Bg== X-Gm-Message-State: APjAAAWcZ8XPU5SjsHN4VXpAU98/a4Q76Y9BrR2fIfTO5hKT9NpKUiFc kCvg1hu1PDwSRs5bViogAIMRCwgR X-Google-Smtp-Source: APXvYqwh1N1RZQixlTq7wUMJi7YEeKfUdsvVP6+sQ1ve4mrmV3rrjV+943pxnZbWtOi65ciAzv9fYg== X-Received: by 2002:a65:6088:: with SMTP id t8mr7281624pgu.329.1579915199238; Fri, 24 Jan 2020 17:19:59 -0800 (PST) Received: from [192.168.1.13] ([199.68.53.171]) by smtp.gmail.com with ESMTPSA id b98sm7421214pjc.16.2020.01.24.17.19.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2020 17:19:58 -0800 (PST) Message-ID: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@gmail.com> From: Jesse Gibbons Date: Fri, 24 Jan 2020 18:19:57 -0700 Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::42a X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/video.scm (vlc) [inputs]: Add FluidSynth. --- gnu/packages/video.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index ee7108753f..53d9a794f8 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -1118,6 +1118,7 @@ videoformats depend on [...] Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (jgibbons2357[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (jgibbons2357[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 2.0 SPOOFED_FREEMAIL No description available. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) * gnu/packages/video.scm (vlc) [inputs]: Add FluidSynth. --- gnu/packages/video.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index ee7108753f..53d9a794f8 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -1118,6 +1118,7 @@ videoformats depend on the configuration flags of ffmpeg.") ("dbus" ,dbus) ("eudev" ,eudev) ("flac" ,flac) + ("fluidsynth" ,fluidsynth) ("ffmpeg" ,ffmpeg) ("fontconfig" ,fontconfig) ("freetype" ,freetype) From unknown Fri Jun 13 11:45:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Jan 2020 08:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39275 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jgibbons2357@gmail.com Cc: 39275@debbugs.gnu.org Received: via spool by 39275-submit@debbugs.gnu.org id=B39275.157994131525740 (code B ref 39275); Sat, 25 Jan 2020 08:36:01 +0000 Received: (at 39275) by debbugs.gnu.org; 25 Jan 2020 08:35:15 +0000 Received: from localhost ([127.0.0.1]:54947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivGuR-0006h5-Gp for submit@debbugs.gnu.org; Sat, 25 Jan 2020 03:35:15 -0500 Received: from mira.cbaines.net ([212.71.252.8]:48004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivGuP-0006gx-9E for 39275@debbugs.gnu.org; Sat, 25 Jan 2020 03:35:13 -0500 Received: from localhost (unknown [46.237.162.0]) by mira.cbaines.net (Postfix) with ESMTPSA id 182FC17A05; Sat, 25 Jan 2020 08:35:12 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id cd0fd2a3; Sat, 25 Jan 2020 08:35:09 +0000 (UTC) References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@gmail.com> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines In-reply-to: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@gmail.com> Date: Sat, 25 Jan 2020 08:35:07 +0000 Message-ID: <871rro6iis.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Jesse Gibbons writes: > * gnu/packages/video.scm (vlc) [inputs]: Add FluidSynth. > --- > gnu/packages/video.scm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index ee7108753f..53d9a794f8 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -1118,6 +1118,7 @@ videoformats depend on the configuration flags of > ffmpeg.") > ("dbus" ,dbus) > ("eudev" ,eudev) > ("flac" ,flac) > + ("fluidsynth" ,fluidsynth) > ("ffmpeg" ,ffmpeg) > ("fontconfig" ,fontconfig) > ("freetype" ,freetype) Hi Jesse, It would be good to put something in the commit message about why this is happening, as it's not obvious to me at least. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4r/btfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XczQw//b8laG3y8dbmTqN/yifAq7xtLUO0p48yLwAU/7omVl+SSuabLBvgIKlii z/A/pqVoB8wsbJPK5uSTlYEdXzv811j/1n4LNihe7pVDoOrjf6rvuV1tpMcRiXr6 GN3z1vxiGvXSOznziShvGt91tjW0FXvRtyktppmjqgavbkqTgs4MHvhgPXY9no2u 5iTbJjA52wBJQVJgWhjLBg4tVBKamyP+jvxwEOkTI4wMdGlooX/e2rkqIHNhbh4N tFO6hs8yDsrANHAqCTbGAoSSUvBc0Af/oJdpv/nJcahvgTaMnAU6HTNMembQ9WPM qKiP/haDXxntY1j2xaz7rRDh/N4sX4BREEyhm25Oxce0t9BFnx5YeUlBknxBZKQh M/0W62EZhOr0jFInh+U1pAbrrJEODM84tiYHElvybgf5kdB8x81yKm1Mgvx8BGhS OHdfkj7ja+weRleqmHnbUqpXEgcp2Orwwo91d2jFV8AKcu5ZxduHkFz03x4UXpI/ e6C56GGuTORrnt0o4OXj6o89CEuXjc5rQYOhOJSOQ4ZGe2caAwKHeI4GyhAKdCxE Kf2LGf1exg1I2zL+foCcYt2RrmGTAhDgDXiJiTisOfWhHdXkklFfKOaRjYrEjKjO /CsDlr7EDfQGReJYz5OW1B+NugzKKiiPo4os1BlCEGj9ZbKFe08= =kq5j -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Jun 13 11:45:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Jan 2020 11:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39275 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines , jgibbons2357@gmail.com Cc: 39275@debbugs.gnu.org Received: via spool by 39275-submit@debbugs.gnu.org id=B39275.15799518359126 (code B ref 39275); Sat, 25 Jan 2020 11:31:02 +0000 Received: (at 39275) by debbugs.gnu.org; 25 Jan 2020 11:30:35 +0000 Received: from localhost ([127.0.0.1]:55015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivJe7-0002N8-7F for submit@debbugs.gnu.org; Sat, 25 Jan 2020 06:30:35 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:47366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivJe5-0002My-1F for 39275@debbugs.gnu.org; Sat, 25 Jan 2020 06:30:33 -0500 Received: from localhost (unknown [185.17.13.127]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 729503361DF0; Sat, 25 Jan 2020 12:30:31 +0100 (CET) Date: Sat, 25 Jan 2020 12:30:27 +0100 From: Danny Milosavljevic Message-ID: <20200125123027.50a6ab1a@scratchpost.org> In-Reply-To: <871rro6iis.fsf@cbaines.net> References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@gmail.com> <871rro6iis.fsf@cbaines.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/uw5eHZ8XpWtrHVD=+zrG1fG"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/uw5eHZ8XpWtrHVD=+zrG1fG Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, I'd prefer to change the subject to "gnu: vlc: Add MIDI support.". > It would be good to put something in the commit message about why this > is happening, as it's not obvious to me at least. I disagree in general because I've seen before what that leads to: Half the source code (the comments) end up in the commit messages instead. Eventually (because of some merge or something) those get lost, or (because of a new commit) those get hidden. Now someone is going to overlook it. So I'd put documentation into comments, except when it's ephemeral ("news"). Also, in the special case of Guix the reason why we add an input later is "we forgot to add it earlier and it was optional to the package and thus the package built" most of the time. So the commit message would always be "we forgot earlier". In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and nobody noticed. We could have the subject say "Add MIDI support" because it communicates mo= re clearly what this commit does for users. And that's the news :) --Sig_/uw5eHZ8XpWtrHVD=+zrG1fG Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4sJtMACgkQ5xo1VCww uqW6kgf+N9sb5cn0u0bbHONcvsSF8EDZsCFubO2yiQFvQ6TnV2WxWZEOOlI8LuNH Zuwhg3sFDarX9lp2ol3ZMb/rTrmKR7STm3NRFW4bZeVp8kQYxAt7VW5kl29oRR+n U77/9rNpyeOd0OOcfG6+6suumMWC2VSlw3DbjtcGrwFxJX0n+Z9y8EPn8/WqXW3p q82laSqg9X/z8e4FT17e8XQJJkBhPSzcEeT/R0ykxc02SDDVSal53EoRNoIuJZqJ 5/n/S7SXbtxU1DkEUHuDA/eajZZpif9pJIq/xy+sGHOSJ2vJqgpGQ26P7TEJCZ9p IPXYWDMUpMMTG0VOd/OCqyV85SZngg== =Nvop -----END PGP SIGNATURE----- --Sig_/uw5eHZ8XpWtrHVD=+zrG1fG-- From unknown Fri Jun 13 11:45:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Jan 2020 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39275 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: 39275@debbugs.gnu.org, jgibbons2357@gmail.com Received: via spool by 39275-submit@debbugs.gnu.org id=B39275.158003419629545 (code B ref 39275); Sun, 26 Jan 2020 10:24:02 +0000 Received: (at 39275) by debbugs.gnu.org; 26 Jan 2020 10:23:16 +0000 Received: from localhost ([127.0.0.1]:56538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivf4W-0007gT-2x for submit@debbugs.gnu.org; Sun, 26 Jan 2020 05:23:16 -0500 Received: from mira.cbaines.net ([212.71.252.8]:48860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivf4U-0007gL-Ot for 39275@debbugs.gnu.org; Sun, 26 Jan 2020 05:23:15 -0500 Received: from localhost (unknown [46.237.162.0]) by mira.cbaines.net (Postfix) with ESMTPSA id C0F6817924; Sun, 26 Jan 2020 10:23:13 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 186f420e; Sun, 26 Jan 2020 10:23:11 +0000 (UTC) References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@gmail.com> <871rro6iis.fsf@cbaines.net> <20200125123027.50a6ab1a@scratchpost.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines In-reply-to: <20200125123027.50a6ab1a@scratchpost.org> Date: Sun, 26 Jan 2020 10:23:09 +0000 Message-ID: <87r1zmikj6.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > Hi, > > I'd prefer to change the subject to "gnu: vlc: Add MIDI support.". > >> It would be good to put something in the commit message about why this >> is happening, as it's not obvious to me at least. > > I disagree in general because I've seen before what that leads to: > Half the source code (the comments) end up in the commit messages instead. > Eventually (because of some merge or something) those get lost, or > (because of a new commit) those get hidden. > Now someone is going to overlook it. I'm not suggesting documenting code in commit messages, just saying something about the motivation/intention with the change is useful. The message you suggest meets this criteria perfectly. > So I'd put documentation into comments, except when it's ephemeral ("news"). > > Also, in the special case of Guix the reason why we add an input later is > "we forgot to add it earlier and it was optional to the package and thus the > package built" most of the time. So the commit message would always be > "we forgot earlier". So I would say that "we forgot earlier" isn't a motivation, or descriptive of intent (although maybe it meets the "why this is happening" I mentioned earlier, but that was maybe poorly explained).. > In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and nobody > noticed. > > We could have the subject say "Add MIDI support" because it communicates more > clearly what this commit does for users. And that's the news :) Yeah, I think that's good. At least in the context I was looking at this, trying to review the change, knowing what the intent is allows me to check if that's been satisfied (trying to play some MIDI content with VLC before and after). Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4taI1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdIXA/8DFwiy59RysatwCaD7WUTjwtjcmL50rvaGt4mD+hoxK7RuxJY/9zWEJ8M ArkgrBby4JeTiV9m5gsu3WSSF/f6mVr6W3lSPsQGLIFL8/5Xs3ZLvIrulM6Lua0c Q6WnLZtQqaf4Um+5NsVxEUkP+ZgNLawLfwGsCBd52TpBEJXEakx3bw8f2uVt7yFR lgkdljrRP+DjhbS55ZkJYCqFwH5rA4ohHz8NccjTihdI4vuVhJqSogt/4yLvJgHG tVzmc1QUG1fecdTgwj04oZ9ntPR83516Ow79Y+9vJ6P+chb0obGgV3eDXUFegQ3o OvlgpfkvER/seY5CWqrC67MilTG+kD2ANDr1YYLiUithd3szm0ooelD+0jkk12tq WrZ/Jbp1RhfMuE14jskGst/V17+jzOUeTfjFXATJ76LsOVWY3xzU0EAr74VQsitD 75YQDIFTtENmDHic+wrqqiW/dELC6UGamct38kCJZEzLutU3VbxuOP1VjUuY3pxy K3Xgesz8HYYURx7tSEvVau+wxT1JOfqalkgkk+v9ND/qviNw59poS6eO99G67b0M OnxBQV7itLrAPSqhgynIjRvF2pC/05kfe8lNxEr96kB/ddAt55g5GcBVQknpltxz hFw2T6aY0soDCxlDyYxBVlkP7JdPJSqUQzh79rl9cvgksCIGwg8= =QQ0Q -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Jun 13 11:45:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input. Resent-From: Jesse Gibbons Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Jan 2020 00:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39275 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines , Danny Milosavljevic Cc: 39275@debbugs.gnu.org Received: via spool by 39275-submit@debbugs.gnu.org id=B39275.158008658214044 (code B ref 39275); Mon, 27 Jan 2020 00:57:02 +0000 Received: (at 39275) by debbugs.gnu.org; 27 Jan 2020 00:56:22 +0000 Received: from localhost ([127.0.0.1]:57672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivshS-0003eR-KW for submit@debbugs.gnu.org; Sun, 26 Jan 2020 19:56:22 -0500 Received: from mail-pj1-f66.google.com ([209.85.216.66]:53538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivshR-0003eE-AL for 39275@debbugs.gnu.org; Sun, 26 Jan 2020 19:56:21 -0500 Received: by mail-pj1-f66.google.com with SMTP id n96so2284585pjc.3 for <39275@debbugs.gnu.org>; Sun, 26 Jan 2020 16:56:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=/SMT27xEpeWBGmKZN1BmTjjZrWYhLeN+8LZ0sBo6YqI=; b=Se1R7dRbyd3DQp192qFVVRxsSdbIESrFS03cPEpGGcwto3b3lpxZg5rGrwN2uirD5p kXiFNJubfX+6OIv9asj9NFZ5iO0D73/4kpfu/ydIcly4klpvjIq5OOIBjX/RJQxbacoY Dk0daGtAYt96XmE6TeY/Mkgaqm107eIa4A/wkjhe+O43tNawGyitDHWs3TBBo3WFvOM8 bl1BnZz+NnK2dJHYzyxJty58oJMsUgHsnWi1UqJnTDBC2bm1bH/d0x/LqSAbwvActFkx IVytwfoULEp62QP/syp5ZBOTj3ySs+2D/oEHUt3OgIOA60K7JvYwaRYXY593ZAwndwmg cRvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=/SMT27xEpeWBGmKZN1BmTjjZrWYhLeN+8LZ0sBo6YqI=; b=N9uNxyvuZ629KykiY4lFyLYs2mOHFFrXe+3UIxa/KFJRuI3GTmmGNJj53QilRcX17J gxMZPJTvGxjc23qhCvQ6+LA6URU7M312Yeilev0d/gPp/QWUPvJQ718fd1OxEa31Azyx ktIjPCnmHaEOXxQGsOSSCene+UTFac8vf5o2n1MFbujLRO5pvHh+7XquyNdwV7xP4SEA AW1TYhuJwc8yDOHd1sHw330v0ycEVHZZXldQbgkwP8VXX0Lbdijexaakv/ipBVLiESvt hOg+0M6HzupG874f+gkiLZduXJG444W4o6NsGge8KnhRN6PZ+kzENdfzjeQeaMjqP/KU UjyA== X-Gm-Message-State: APjAAAWHAxYzAi7wKL05MtGaNbeVmUCt1q08yCCfMQaKcY3B+0KqTYD+ 55LnD2XQXhQLic4RAEcpWBDb0Qqf X-Google-Smtp-Source: APXvYqyvxnfs0Rfzx8feEZi1QLWovCG2W3yZqbTKA0xBRoPcZS7LqJBiHl6P/gk+QDCIK8bzqPJ6OA== X-Received: by 2002:a17:902:680c:: with SMTP id h12mr10911537plk.102.1580086575289; Sun, 26 Jan 2020 16:56:15 -0800 (PST) Received: from [192.168.1.13] ([199.68.53.171]) by smtp.gmail.com with ESMTPSA id i17sm13413424pfr.67.2020.01.26.16.56.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jan 2020 16:56:14 -0800 (PST) Message-ID: <999e82b162db35d396932eb2c1d5a20f68c00959.camel@gmail.com> From: Jesse Gibbons Date: Sun, 26 Jan 2020 17:56:13 -0700 In-Reply-To: <87r1zmikj6.fsf@cbaines.net> References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@gmail.com> <871rro6iis.fsf@cbaines.net> <20200125123027.50a6ab1a@scratchpost.org> <87r1zmikj6.fsf@cbaines.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On Sun, 2020-01-26 at 10:23 +0000, Christopher Baines wrote: > Error verifying signature: Failed to execute gpg. > Danny Milosavljevic writes: > > > Hi, > > > > I'd prefer to change the subject to "gnu: vlc: Add MIDI support.". > > > > > It would be good to put something in the commit message about why > > > this > > > is happening, as it's not obvious to me at least. > > > > I disagree in general because I've seen before what that leads to: > > Half the source code (the comments) end up in the commit messages > > instead. > > Eventually (because of some merge or something) those get lost, or > > (because of a new commit) those get hidden. > > Now someone is going to overlook it. > > I'm not suggesting documenting code in commit messages, just saying > something about the motivation/intention with the change is useful. > The > message you suggest meets this criteria perfectly. > > > So I'd put documentation into comments, except when it's ephemeral > > ("news"). > > > > Also, in the special case of Guix the reason why we add an input > > later is > > "we forgot to add it earlier and it was optional to the package and > > thus the > > package built" most of the time. So the commit message would > > always be > > "we forgot earlier". > > So I would say that "we forgot earlier" isn't a motivation, or > descriptive of intent (although maybe it meets the "why this is > happening" I mentioned earlier, but that was maybe poorly > explained).. > > > In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and > > nobody > > noticed. > > > > We could have the subject say "Add MIDI support" because it > > communicates more > > clearly what this commit does for users. And that's the news :) > > Yeah, I think that's good. At least in the context I was looking at > this, trying to review the change, knowing what the intent is allows > me > to check if that's been satisfied (trying to play some MIDI content > with > VLC before and after). > > Chris Sorry for not explaining the intention. Do you want me to send a new patch mentioning the added MIDI support? Should I put that in the commit title, or in a comment? From unknown Fri Jun 13 11:45:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Jan 2020 08:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39275 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jesse Gibbons Cc: Danny Milosavljevic , 39275@debbugs.gnu.org Received: via spool by 39275-submit@debbugs.gnu.org id=B39275.158011259722576 (code B ref 39275); Mon, 27 Jan 2020 08:10:01 +0000 Received: (at 39275) by debbugs.gnu.org; 27 Jan 2020 08:09:57 +0000 Received: from localhost ([127.0.0.1]:57786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivzT3-0005s4-89 for submit@debbugs.gnu.org; Mon, 27 Jan 2020 03:09:57 -0500 Received: from mira.cbaines.net ([212.71.252.8]:49614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivzT0-0005ru-N3 for 39275@debbugs.gnu.org; Mon, 27 Jan 2020 03:09:55 -0500 Received: from localhost (unknown [46.237.162.0]) by mira.cbaines.net (Postfix) with ESMTPSA id 8120317A0A; Mon, 27 Jan 2020 08:09:53 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 05d99897; Mon, 27 Jan 2020 08:09:51 +0000 (UTC) References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@gmail.com> <871rro6iis.fsf@cbaines.net> <20200125123027.50a6ab1a@scratchpost.org> <87r1zmikj6.fsf@cbaines.net> <999e82b162db35d396932eb2c1d5a20f68c00959.camel@gmail.com> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines In-reply-to: <999e82b162db35d396932eb2c1d5a20f68c00959.camel@gmail.com> Date: Mon, 27 Jan 2020 08:09:48 +0000 Message-ID: <87o8upialv.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Jesse Gibbons writes: > On Sun, 2020-01-26 at 10:23 +0000, Christopher Baines wrote: >> Error verifying signature: Failed to execute gpg. >> Danny Milosavljevic writes: >> >> > Hi, >> > >> > I'd prefer to change the subject to "gnu: vlc: Add MIDI support.". >> > >> > > It would be good to put something in the commit message about why >> > > this >> > > is happening, as it's not obvious to me at least. >> > >> > I disagree in general because I've seen before what that leads to: >> > Half the source code (the comments) end up in the commit messages >> > instead. >> > Eventually (because of some merge or something) those get lost, or >> > (because of a new commit) those get hidden. >> > Now someone is going to overlook it. >> >> I'm not suggesting documenting code in commit messages, just saying >> something about the motivation/intention with the change is useful. >> The >> message you suggest meets this criteria perfectly. >> >> > So I'd put documentation into comments, except when it's ephemeral >> > ("news"). >> > >> > Also, in the special case of Guix the reason why we add an input >> > later is >> > "we forgot to add it earlier and it was optional to the package and >> > thus the >> > package built" most of the time. So the commit message would >> > always be >> > "we forgot earlier". >> >> So I would say that "we forgot earlier" isn't a motivation, or >> descriptive of intent (although maybe it meets the "why this is >> happening" I mentioned earlier, but that was maybe poorly >> explained).. >> >> > In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and >> > nobody >> > noticed. >> > >> > We could have the subject say "Add MIDI support" because it >> > communicates more >> > clearly what this commit does for users. And that's the news :) >> >> Yeah, I think that's good. At least in the context I was looking at >> this, trying to review the change, knowing what the intent is allows >> me >> to check if that's been satisfied (trying to play some MIDI content >> with >> VLC before and after). >> >> Chris > > Sorry for not explaining the intention. Do you want me to send a new > patch mentioning the added MIDI support? Should I put that in the > commit title, or in a comment? Sending a new patch would be great. Adding something anywhere in the commit message is fine by me. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKSBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4umsxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xe6Vw/3UBcW3H6i1pLsnSrmqUYyJqcPi4cYF4RoI+MytogkvoWNAdocSyFwS26V /d486+3WVgTH+iBQjAeFGBBOWk4qaHPqhxbo5ri+xrrlcKH3G4Qm4t4okMai1Y4I uRcTAQ8ktZzOf0/f7p0pxopTBgf4Hh2no7N8Qa59jRieWc8QDzRr2sC/DPiyC9QE 0iurU4zJGG2NjHx5tUDt/5zuAlhR9HO74ZZHBQx7QPAoafmqJSAhex9pClMYjkEV irRJCKeI+ylbi+uXtg9LN9yX8HbG6TcFhgSRWp8FFva4i+bV737BQXlcE0sm7p87 5F7cUvE/c2BbbngTqpQ0mxmmz80C1iLvjHUS2iJTjsYXd4k7D5MwnyRIvEKh63Vp VQPSV0jq0WAwmdXOB816nTjejUZWwBQyJ1y3w4wM2bH2Oc1g0gCNpFhg7pka/Ewk 4yfSQB2OcN927XMRYniKZU5lQ1GdHY8iNO8IQVtFiMDthACMOqqNCYlJjT2pdWW6 PvzXC2ZxWd2ihdPlGZ0CNqHu6BsFkGqUEqanOKBib4mW4NqqobClB7G0qBlA2clr niGGbdct+W/GoaYocnN7cplW6B5cQmjrszRIDUPm6uYqYt1+U1vV994Oh2gxiPqV IMv1sK7RW+ksgHV+R88dbv92ByVx7aYJMfQoENlLLycjzqO8NQ== =yV0R -----END PGP SIGNATURE----- --=-=-=--