GNU bug report logs - #39269
[PATCH 1/2] guix: qt-build-system: Add phase `check-setup`.

Previous Next

Package: guix-patches;

Reported by: Hartmut Goebel <h.goebel <at> crazy-compilers.com>

Date: Fri, 24 Jan 2020 16:24:02 UTC

Severity: normal

Tags: patch

Merged with 39268, 39270

Done: Hartmut Goebel <h.goebel <at> crazy-compilers.com>

Bug is archived. No further changes may be made.

Full log

Message #16 received at 39269 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 39269 <at> debbugs.gnu.org
Subject: Re: [bug#39269] [PATCH 1/2] guix: qt-build-system: Add phase
 `check-setup`.
Date: Sat, 25 Jan 2020 20:34:39 +0100

[Message part 1 (text/plain, inline)]
Hartmut Goebel 写道：
> * guix/build/qt-build-system.scm (check-setup): New function.
>   (%standard-phases): Add as new phase `check-setup before 
>   `check.

LGTM with one tweak: please rename this to ‘set-up-tests’ or 
similar.

Guix's phase naming implies that ‘check-setup’ checks something 
called setup.

Thanks!

T G-R

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 5 years and 119 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.