GNU bug report logs - #39262
[PATCH] gnu: geoclue: Update to 2.5.5

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Martin Becze <mjbecze <at> riseup.net>
Subject: bug#39262: closed (Re: [bug#39262] [PATCH] gnu: geoclue: Update
 to 2.5.5)
Date: Mon, 10 Feb 2020 22:37:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#39262: [PATCH] gnu: geoclue: Update to 2.5.5

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 39262 <at> debbugs.gnu.org.

-- 
39262: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39262
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Martin Becze <mjbecze <at> riseup.net>
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>,
 39262-done <at> debbugs.gnu.org
Subject: Re: [bug#39262] [PATCH] gnu: geoclue: Update to 2.5.5
Date: Mon, 10 Feb 2020 23:36:08 +0100

Hi Martin!

Martin Becze <mjbecze <at> riseup.net> skribis:

>> Did you test if it works together with ModemManager? Maybe with a LTE
>> card in a laptop or so.
>
> No, I have the hardware enroute so I should be able to test soonish. I
> can disable again if that is preferred.
>
>>From a97cd8090561a8c596e377c403cbb3081947a28a Mon Sep 17 00:00:00 2001
> From: Martin Becze <mjbecze <at> riseup.net>
> Date: Fri, 24 Jan 2020 07:41:35 -0500
> Subject: [PATCH v2] gnu: geoclue: Update to 2.5.5
>
> * gnu/packages/gnome.scm (geoclue): Update to 2.5.5

Pushed as 50e96d25b74ba37193fb102920b446eff03b97ed.

That said, if you have feedback regarding the tests Jonathan suggested
above, we can always adjust!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Martin Becze <mjbecze <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: Martin Becze <mjbecze <at> riseup.net>
Subject: [PATCH] gnu: geoclue: Update to 2.5.5
Date: Fri, 24 Jan 2020 07:51:44 -0500

* gnu/packages/gnome.scm (geoclue): Update to 2.5.5
---
 gnu/packages/gnome.scm | 33 +++++++++++----------------------
 1 file changed, 11 insertions(+), 22 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index e843bdfe08..4710eb1db3 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -40,7 +40,7 @@
 ;;; Copyright © 2019 Jelle Licht <jlicht <at> fsfe.org>
 ;;; Copyright © 2019 Jonathan Frederickson <jonathan <at> terracrypt.net>
 ;;; Copyright © 2019 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
-;;; Copyright © 2019 Martin Becze <mjbecze <at> riseup.net>
+;;; Copyright © 2019, 2020 Martin Becze <mjbecze <at> riseup.net>
 ;;; Copyright © 2019 David Wilson <david <at> daviwil.com>
 ;;; Copyright © 2019, 2020 Raghav Gururajan <raghavgururajan <at> disroot.org>
 ;;; Copyright © 2019 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
@@ -4074,40 +4074,29 @@ output devices.")
 (define-public geoclue
   (package
     (name "geoclue")
-    (version "2.4.8")
+    (version "2.5.5")
     (source
      (origin
        (method url-fetch)
-       (uri (string-append "https://www.freedesktop.org/software/" name
-                           "/releases/" (version-major+minor version) "/"
-                           name "-" version ".tar.xz"))
+       (uri (string-append "https://gitlab.freedesktop.org/geoclue/geoclue/-/archive/" version "/geoclue-" version ".tar.bz2"))
        (sha256
         (base32
-         "08yg1r7m0n9hwyvcy769qkmkf8lslqwv69cjfffwnc3zm5km25qj"))
+         "1b7jqrsn4x7mxjxj8hvb2dl2cmhrpb9vibs4rvkkanky5nsx3sai"))
        (patches (search-patches "geoclue-config.patch"))))
-    (build-system glib-or-gtk-build-system)
+    (build-system meson-build-system)
     (arguments
-     '(;; The tests want to run the system bus.
-       #:tests? #f
-       #:configure-flags (list ;; Disable bits requiring ModemManager.
-                               "--disable-3g-source"
-                               "--disable-cdma-source"
-                               "--disable-modem-gps-source"
-                               "--with-dbus-service-user=geoclue")
-       #:phases
-       (modify-phases %standard-phases
-         (add-before 'configure 'patch-/bin/true
-                     (lambda _
-                       (substitute* "configure"
-                         (("/bin/true") (which "true")))
-                       #t)))))
+     '(#:configure-flags (list "-Dbus-srv-user=geoclue")))
     (native-inputs
      `(("pkg-config" ,pkg-config)
        ("gobject-introspection" ,gobject-introspection)
+       ("modem-manager" ,modem-manager)
+       ("libnotify" ,libnotify)
+       ("gtk-doc", gtk-doc)
        ("intltool" ,intltool)))
     (inputs
      `(("avahi" ,avahi)
-       ("glib" ,glib)
+       ("glib:bin" ,glib "bin")
+       ("glib-networking" ,glib-networking)
        ("json-glib" ,json-glib)
        ("libsoup" ,libsoup)))
     (home-page "https://www.freedesktop.org/wiki/Software/GeoClue/")
-- 
2.25.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.