GNU bug report logs - #39214
Updates to etc/guix-install.sh

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#39214: closed (Updates to etc/guix-install.sh)
Date: Sun, 26 Jan 2020 22:21:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 26 Jan 2020 23:19:51 +0100
with message-id <87tv4h6et4.fsf <at> gnu.org>
and subject line Re: [bug#39214] Updates to etc/guix-install.sh
has caused the debbugs.gnu.org bug report #39214,
regarding Updates to etc/guix-install.sh
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
39214: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39214
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Prafulla Giri <pratheblackdiamond <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Updates to etc/guix-install.sh
Date: Tue, 21 Jan 2020 12:56:34 +0545

[Message part 3 (text/plain, inline)]

Esteemed Maintainer,

Attached are two patches as a follow-up to
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=39049 that was just recently
applied to the main source tree.

Patch 1 exports the INFOPATH and makes the up-to-date guix info manual
available to the user via both /usr/bin/info and $GUIX_PROFILE/bin/info
(previously `info guix` would either show the out-of-date info file
installed during installation or throw a "No menu item 'guix' in node
'(dir)Top" error if the $GUIX_PROFILE/bin/info was invoked, or if the info
pages weren't installed during installation).

Patch 2 adds a defensive test against (highly unlikely) cases where
/etc/profile.d might not exist, and creates it. The function does not quit
on failure because it is possible that /etc/profile is still configured to
read /etc/profile.d/*.sh files. Even if it is not, guix.sh will merely sit
in /etc/profile.d and cause no changes to the user's environment.

These changes caused no regressions in my local machine.

I hope this helps more foreign distro users in their journey with Guix.

[Message part 4 (text/html, inline)]

[0001-guix-install.sh-Export-INFOPATH-to-contain-updated-g.patch (text/x-patch, attachment)]

[0002-guix-install.sh-Create-etc-profile.d-if-it-does-not-.patch (text/x-patch, attachment)]

[Message part 7 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Prafulla Giri <pratheblackdiamond <at> gmail.com>
Cc: 39214-done <at> debbugs.gnu.org
Subject: Re: [bug#39214] Updates to etc/guix-install.sh
Date: Sun, 26 Jan 2020 23:19:51 +0100

Hello,

Prafulla Giri <pratheblackdiamond <at> gmail.com> skribis:

> From 0f98891feb2cc3cb4c529c65d789cdfc955cfc41 Mon Sep 17 00:00:00 2001
> From: Prafulla Giri <pratheblackdiamond <at> gmail.com>
> Date: Tue, 21 Jan 2020 12:25:24 +0545
> Subject: [PATCH 1/2] guix-install.sh: Export INFOPATH to contain updated guix
>  info-pages
>
> * etc/guix-install.sh (sys_create_init_profile): Export INFOPATH to include
> the updated info-pages from ~/.config/guix/current/share/info.  This also makes
> sure that both /usr/bin/info and $GUIX_PROFILE/bin/info can read guix info pages
> without throwing "no menu item 'guix' in node dir(Top)" error.

> From dcd2180c36dc0319ebc3ab821879015e30bba94e Mon Sep 17 00:00:00 2001
> From: Prafulla Giri <pratheblackdiamond <at> gmail.com>
> Date: Tue, 21 Jan 2020 12:34:10 +0545
> Subject: [PATCH 2/2] guix-install.sh: Create /etc/profile.d if it does not
>  exist
> 
> * etc/guix-install.sh (sys_create_init_profile): Add code to create
> /etc/profile.d if it somehow does not exist; the function still carries
> on because it is possible that /etc/profile is still configured to read
> the *.sh files from /etc/profile.d, if they exist.

Applied both, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.