From unknown Wed Jun 18 23:07:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#39192 <39192@debbugs.gnu.org> To: bug#39192 <39192@debbugs.gnu.org> Subject: Status: [PATCH] gnu: hexedit: Make F1 help more reliable Reply-To: bug#39192 <39192@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:07:40 +0000 retitle 39192 [PATCH] gnu: hexedit: Make F1 help more reliable reassign 39192 guix-patches submitter 39192 Jakub K=C4=85dzio=C5=82ka severity 39192 normal tag 39192 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 19 07:44:41 2020 Received: (at submit) by debbugs.gnu.org; 19 Jan 2020 12:44:41 +0000 Received: from localhost ([127.0.0.1]:42725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1it9wX-0000gY-5u for submit@debbugs.gnu.org; Sun, 19 Jan 2020 07:44:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:57369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1it9wW-0000gR-2K for submit@debbugs.gnu.org; Sun, 19 Jan 2020 07:44:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58832) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1it9wU-0002sJ-QC for guix-patches@gnu.org; Sun, 19 Jan 2020 07:44:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1it9wT-0003hb-Ox for guix-patches@gnu.org; Sun, 19 Jan 2020 07:44:38 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:50368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1it9wT-0003hG-FZ for guix-patches@gnu.org; Sun, 19 Jan 2020 07:44:37 -0500 Received: (qmail 10316 invoked by uid 1009); 19 Jan 2020 13:44:36 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25699. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.0086 secs); 19 Jan 2020 12:44:36 -0000 Received: from unknown (HELO zdrowyportier.kadziolka.net) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 19 Jan 2020 13:44:36 +0100 Date: Sun, 19 Jan 2020 13:44:34 +0100 From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= To: guix-patches@gnu.org Subject: [PATCH] gnu: hexedit: Make F1 help more reliable Message-ID: <20200119124434.aatfpdm6ihiig354@zdrowyportier.kadziolka.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 37.59.186.212 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/hexedit.scm (hexedit)[arguments](patch-man-path): New phase. [inputs]: Add MAN-DB. --- gnu/packages/hexedit.scm | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/gnu/packages/hexedit.scm b/gnu/packages/hexedit.scm index 39dcb2e0f7..e788c7f766 100644 --- a/gnu/packages/hexedit.scm +++ b/gnu/packages/hexedit.scm @@ -24,6 +24,7 @@ #:use-module (gnu packages) #:use-module (gnu packages autotools) #:use-module (gnu packages compression) + #:use-module (gnu packages man) #:use-module (gnu packages ncurses) #:use-module (guix download) #:use-module (guix git-download) @@ -43,12 +44,24 @@ (base32 "1xsxa5mip892jkvz9jshj73y6c7j3mgp8y393ciihqlyf2nmfs67")))) (build-system gnu-build-system) - (arguments '(#:tests? #f)) ; no check target + (arguments + `(#:tests? #f ; no check target + #:phases + (modify-phases %standard-phases + ;; Make F1 open the man page even if man-db is not in the profile + (add-after 'unpack 'patch-man-path + (lambda _ + (substitute* "interact.c" + (("\"man\"") + (string-append "\"" (assoc-ref %build-inputs "man-db") "/bin/man\"")) + (("\"hexedit\"") + (string-append "\"" (assoc-ref %outputs "out") "/share/man/man1/hexedit.1.gz\"")))))))) (native-inputs `(("autoconf" ,autoconf) ("automake" ,automake))) (inputs - `(("ncurses" ,ncurses))) + `(("ncurses" ,ncurses) + ("man-db" ,man-db))) (synopsis "View and edit files or devices in hexadecimal or ASCII") (description "hexedit shows a file both in ASCII and in hexadecimal. The file can be a device as the file is read a piece at a time. You can modify -- 2.25.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 27 18:36:15 2020 Received: (at 39192) by debbugs.gnu.org; 27 Jan 2020 23:36:15 +0000 Received: from localhost ([127.0.0.1]:59249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwDvT-0000Z7-C4 for submit@debbugs.gnu.org; Mon, 27 Jan 2020 18:36:15 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:60153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwDvR-0000Yo-BM for 39192@debbugs.gnu.org; Mon, 27 Jan 2020 18:36:13 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 2E0645A1; Mon, 27 Jan 2020 18:36:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 27 Jan 2020 18:36:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=8cG91d8btwCTDWrfdIApOt8Gd+ PgeciM4/ivZpZhBX8=; b=uiEA7xcqSGrfF8H6dsyAw4PfofKSQeTDGSy9c+XP7m A4UK+rD17y0osE3ARXNo6sQoxq99/zP1+j9q0VApwzdBySPDg72xhhW+0JUuAeyc lICOCDYpdCasdsOAEN3mjpPVDU/cr0bgGoEG8qGY+M50v6fHpnlHU425v3LqhwqX V7qmQ8t+KQCB0A/bC3vMc0TNHTxV7lIzG3Tm58qb7NrFlU9i8gvOZQtc4tL1F4P5 fUAq0bAuti3X6udSpBU4UalItMT7D2+9P5fakWJvX8U/0v6ypxGpRAared8Q902+ 3eBvAFTivSiwQ06QvrEssrAy9Qns8nmGAmNHqXcK/5Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=8cG91d 8btwCTDWrfdIApOt8Gd+PgeciM4/ivZpZhBX8=; b=bTAIvvt1YG44ZhYncDHGlB Ow4/zS7AIHWr0lxtzNoScAcFSIf5ROB32BUt3Ql2wvaHZJB1wSr2anUz82p+wKRi Qusu5J+NPB9xARuC7bLh6us2v3xM2NLtfCVLqcWTauCVa+PAVcJkInK0/9VfSmEw /REgc+nULKHJnZY4ViyRDEqDFn3ccIMTaF9nnXdBDpri/kwIHvZR2w7FbYH4TVqp 3pwGTEWlsLM8Na9sBSdJ/OM04J5lbrOHRrnJfRH4OangIuncyWRchsPsXxIepGFV q/RVdh7bJSPEE3xA7WcZx428mrZEgPfxvlrWBsUQZOFzWwFj0/MBPgdB/+KpG0OQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrfeefgddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtderre dtreejnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhmqeenucfkphepkeegrddvtddvrdeiledrvdehfeenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-3035.bb.online.no [84.202.69.253]) by mail.messagingengine.com (Postfix) with ESMTPA id 10B9D328005E; Mon, 27 Jan 2020 18:36:05 -0500 (EST) From: Marius Bakke To: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= , 39192@debbugs.gnu.org Subject: Re: [bug#39192] [PATCH] gnu: hexedit: Make F1 help more reliable In-Reply-To: <20200119124434.aatfpdm6ihiig354@zdrowyportier.kadziolka.net> References: <20200119124434.aatfpdm6ihiig354@zdrowyportier.kadziolka.net> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Tue, 28 Jan 2020 00:36:04 +0100 Message-ID: <87mua8qxp7.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39192 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jakub K=C4=85dzio=C5=82ka writes: > * gnu/packages/hexedit.scm (hexedit)[arguments](patch-man-path): New > phase. > [inputs]: Add MAN-DB. While this change is harmless, I think we can generally expect "man" to be available. Does the program crash if man-db is not installed? Or does it print an actionable error message? In the latter case I'm inclined to leave things as-is, in the former case let's patch it. But no strong opinion, mostly curious :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl4vc+QACgkQoqBt8qM6 VPo0lgf+Nvrlt8r7As39VldrTb9HnFNkg/TzTSchC4ufp/i2emLYw8VAWIw0w4p8 6oesmWiWx4c4PezHDE3iXUl4uIlKUHXTywsRrPja4oQNwH0HGd3kX+0FlGg2NOXS MIxwZG0HRURjN9LB4jwkUP1tCv5GGzG0+/qFkM2dnfxeqRRXIdzwdMlRxWXAPJRv sXgDzAyZuvJV0s5uinFFpERz6lWM9hX/0FTKNeXFQNtJmQd/HyaU+aSGTt7Oj+Nd djtC91ZJZronfM+VFMAtKBCBrfqwBrCZmiCpz//fNjvM5jsMyWZ7w6GfqMnP+WPW H7TxmvSri3lTcVh//PdKSpsUiwaJ4w== =cKgW -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 28 02:36:59 2020 Received: (at 39192) by debbugs.gnu.org; 28 Jan 2020 07:36:59 +0000 Received: from localhost ([127.0.0.1]:59393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwLQg-0005fZ-Vz for submit@debbugs.gnu.org; Tue, 28 Jan 2020 02:36:59 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:50608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwLQf-0005fQ-98 for 39192@debbugs.gnu.org; Tue, 28 Jan 2020 02:36:58 -0500 Received: (qmail 13277 invoked by uid 1009); 28 Jan 2020 08:36:55 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25708. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.01008 secs); 28 Jan 2020 07:36:55 -0000 Received: from unknown (HELO zdrowyportier.kadziolka.net) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 28 Jan 2020 08:36:55 +0100 Date: Tue, 28 Jan 2020 08:36:53 +0100 From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= To: Marius Bakke Subject: Re: [bug#39192] [PATCH] gnu: hexedit: Make F1 help more reliable Message-ID: <20200128073653.fvcvzitgphtuxzok@zdrowyportier.kadziolka.net> References: <20200119124434.aatfpdm6ihiig354@zdrowyportier.kadziolka.net> <87mua8qxp7.fsf@devup.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87mua8qxp7.fsf@devup.no> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39192 Cc: 39192@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Jan 28, 2020 at 12:36:04AM +0100, Marius Bakke wrote: > Jakub Kądziołka writes: > > > * gnu/packages/hexedit.scm (hexedit)[arguments](patch-man-path): New > > phase. > > [inputs]: Add MAN-DB. > > While this change is harmless, I think we can generally expect "man" to > be available. Does the program crash if man-db is not installed? Or > does it print an actionable error message? > > In the latter case I'm inclined to leave things as-is, in the former > case let's patch it. But no strong opinion, mostly curious :-) Currently, the problem appears when hexedit is used in a `guix environment', and man-db is not specified as an input for the environment. In this case (assuming --pure hasn't been used), man prints an error message saying "no manpage for hexedit" when the user presses F1, but it cannot be seen until one exits hexedit. For a new user, this is not a trivial feat. Moreover, the error is confusing - it suggests that the manpage just hasn't been packaged. When man isn't found at all, no error message is printed, the F1 key just makes the screen blink. This could happen in a --pure environment. In hindsight, this is something I should've explained in my first message. Sorry about that. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 29 05:08:25 2020 Received: (at 39192-done) by debbugs.gnu.org; 29 Jan 2020 10:08:25 +0000 Received: from localhost ([127.0.0.1]:33238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwkGn-0000xo-An for submit@debbugs.gnu.org; Wed, 29 Jan 2020 05:08:25 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwkGl-0000xO-BI for 39192-done@debbugs.gnu.org; Wed, 29 Jan 2020 05:08:23 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id EF4EC220F4; Wed, 29 Jan 2020 05:08:17 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 29 Jan 2020 05:08:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=UUsLNeHx33RjvEOtR+X9PgXQ++ UtVoE0xBlJojK9TLY=; b=xh27+HBFErRPRnypWjysv1djEMPqG1u7piSfr3nXCW tCWSxRd/tsON/2Nujge05c+QtTOTRrPqvbgEeo7JGeK4etcTYOfOijXFkS31l97q cMi/X1ukN8qAtKlU5QiFeb5daBXA7bnZ7dzeu1+QbgRW9Ev8lIUdR6E9ozA/jJSS QJsjTYPi+lRLBNfJiTd0aoNy5+n7C47OrC8/34k+qsxaNbYg8j4lbDwNQLcJhj2x Y3Kz4QGVo6f1B3woUtWgzOCrjLQqRvZQcfc9Ad3I4McFxlYgLUYiO+aZx6iEzqYY PeuHBq26FJWdxpcCqB2pogckHUNDjt+PNr+RgdjmiupQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=UUsLNe Hx33RjvEOtR+X9PgXQ++UtVoE0xBlJojK9TLY=; b=dGULsux5QLKWr+lXIAp6b/ OaTDBIdFJAEly/lAKo5qTAwDdPkoFMDnA/yy1jwpVxPsRLIJnKGtKzLHgWn0QcPc eWHQ4ymT6Lt7ZzTMnP5WugqqKOSpiYytC2lQPD8P+KjEWkxH2BsAZeFy9nWyu0sZ Bd4JvKlniNsDrTr+RZFhGAYe+//oxx7F9z6TWPfE1WvnCN58/HwB70qS7Sd0vOkk 8JiRtsuxdWSFz2siwa5jdRV0PvFh0cieONvg/Qis9zQv1wT8QAPUkH0vGkGzkHgx QvHXFHGYj3bQRx62Rqai+N1AxxCPVLPLd447VMOoj5vBo076CAZp4YGSMPAV+jAQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrfeeigddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtderre dtreejnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhmqeenucfkphepkeegrddvtddvrdeiledrvdehfeenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-3035.bb.online.no [84.202.69.253]) by mail.messagingengine.com (Postfix) with ESMTPA id 6853A3060840; Wed, 29 Jan 2020 05:08:17 -0500 (EST) From: Marius Bakke To: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= Subject: Re: [bug#39192] [PATCH] gnu: hexedit: Make F1 help more reliable In-Reply-To: <20200128073653.fvcvzitgphtuxzok@zdrowyportier.kadziolka.net> References: <20200119124434.aatfpdm6ihiig354@zdrowyportier.kadziolka.net> <87mua8qxp7.fsf@devup.no> <20200128073653.fvcvzitgphtuxzok@zdrowyportier.kadziolka.net> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Wed, 29 Jan 2020 11:08:14 +0100 Message-ID: <87d0b2r2wh.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39192-done Cc: 39192-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jakub K=C4=85dzio=C5=82ka writes: > On Tue, Jan 28, 2020 at 12:36:04AM +0100, Marius Bakke wrote: >> Jakub K=C4=85dzio=C5=82ka writes: >>=20 >> > * gnu/packages/hexedit.scm (hexedit)[arguments](patch-man-path): New >> > phase. >> > [inputs]: Add MAN-DB. >>=20 >> While this change is harmless, I think we can generally expect "man" to >> be available. Does the program crash if man-db is not installed? Or >> does it print an actionable error message? >>=20 >> In the latter case I'm inclined to leave things as-is, in the former >> case let's patch it. But no strong opinion, mostly curious :-) > > Currently, the problem appears when hexedit is used in a `guix > environment', and man-db is not specified as an input for the > environment. In this case (assuming --pure hasn't been used), man prints > an error message saying "no manpage for hexedit" when the user presses > F1, but it cannot be seen until one exits hexedit. For a new user, this > is not a trivial feat. Moreover, the error is confusing - it suggests > that the manpage just hasn't been packaged. Right. The problem of manpages being unavailable unless man-db is included in the profile is not unique to hexedit. 'git foo --help' has the same problem in a --pure environment. But at least then you get a good error message. > When man isn't found at all, no error message is printed, the F1 key > just makes the screen blink. This could happen in a --pure environment. I see, not great. Sounds like a good reason to add man-db as an input in this case. > In hindsight, this is something I should've explained in my first message. > Sorry about that. No worries, these things are difficult. :-) Pushed in 602059e79, with a few cosmetic modifications: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/hexedit.scm b/gnu/packages/hexedit.scm index 368a902ce3..e1a029167a 100644 --- a/gnu/packages/hexedit.scm +++ b/gnu/packages/hexedit.scm @@ -49,20 +49,22 @@ `(#:tests? #f ; no check target #:phases (modify-phases %standard-phases - ;; Make F1 open the man page even if man-db is not in the profile + ;; Make F1 open the man page even if man-db is not in the profile. (add-after 'unpack 'patch-man-path - (lambda _ + (lambda* (#:key inputs outputs #:allow-other-keys) (substitute* "interact.c" (("\"man\"") - (string-append "\"" (assoc-ref %build-inputs "man-db") "/bin/man\"")) + (string-append "\"" (assoc-ref inputs "man-db") "/bin/man\"")) (("\"hexedit\"") - (string-append "\"" (assoc-ref %outputs "out") "/share/man/man1/hexedit.1.gz\"")))))))) + (string-append "\"" (assoc-ref outputs "out") + "/share/man/man1/hexedit.1.gz\""))) + #t))))) (native-inputs `(("autoconf" ,autoconf) ("automake" ,automake))) (inputs - `(("ncurses" ,ncurses) - ("man-db" ,man-db))) + `(("man-db" ,man-db) + ("ncurses" ,ncurses))) (synopsis "View and edit files or devices in hexadecimal or ASCII") (description "hexedit shows a file both in ASCII and in hexadecimal. The file can be a device as the file is read a piece at a time. You can modify --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl4xWY4ACgkQoqBt8qM6 VPr9pgf/T2wCh8f5fOCbbNB+5fKQAC63Au55LvY6ITItDeh1Kbx7uU3sBD+33T3R /9FgqcPWzGWeQwfYBUre0qs9v9yolMnvM8ocLdeQtacW2UpTz4nLfvQDHUc5f6gu XmtJUKbKcXdutnqCEAGsy/ejHkTEavhhhk0vwC/Q1A1rHbEwKuYHkvtKZGwBjVgG FTHHd2lerOQ+rdQdfLN9w8H6djj0s/IN3cV8L3qPu4ZzOBXLb9U+XNwD0BJ9YTMr OuUiheAevlRIk5O0lalnbTthpnc9AQBwznp2FuRpJSAwsLAq1yqUj6ySwdCIPOqP 8rAuwzshOq4pQhwUbNTgFauHY8VaGw== =g07s -----END PGP SIGNATURE----- --==-=-=-- From unknown Wed Jun 18 23:07:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 26 Feb 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator