From unknown Sun Jun 22 07:49:56 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#39156] [PATCH] gnu: nim: Fix substitution in stdlib_osproc.c Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Jan 2020 22:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39156 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 39156@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15792128995725 (code B ref -1); Thu, 16 Jan 2020 22:15:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Jan 2020 22:14:59 +0000 Received: from localhost ([127.0.0.1]:38498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isDPm-0001UG-M5 for submit@debbugs.gnu.org; Thu, 16 Jan 2020 17:14:59 -0500 Received: from lists.gnu.org ([209.51.188.17]:60528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isDPj-0001U7-4R for submit@debbugs.gnu.org; Thu, 16 Jan 2020 17:14:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43268) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isDPi-0000re-7Y for guix-patches@gnu.org; Thu, 16 Jan 2020 17:14:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isDPf-0004aG-JP for guix-patches@gnu.org; Thu, 16 Jan 2020 17:14:54 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:42132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1isDPf-0004TA-98 for guix-patches@gnu.org; Thu, 16 Jan 2020 17:14:51 -0500 Received: (qmail 8451 invoked by uid 1009); 16 Jan 2020 23:14:43 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25696. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.008548 secs); 16 Jan 2020 22:14:43 -0000 Received: from unknown (HELO zdrowyportier.kadziolka.net) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 16 Jan 2020 23:14:42 +0100 Date: Thu, 16 Jan 2020 23:14:41 +0100 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200116221441.mu62k4v3u6ekemn4@zdrowyportier.kadziolka.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 37.59.186.212 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/nim.scm (nim)[arguments](patch-more-shebangs): Patch the string length too. --- gnu/packages/nim.scm | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gnu/packages/nim.scm b/gnu/packages/nim.scm index 5694eae63b..22dac0b58a 100644 --- a/gnu/packages/nim.scm +++ b/gnu/packages/nim.scm @@ -50,10 +50,12 @@ #t))) (add-after 'patch-source-shebangs 'patch-more-shebangs (lambda _ - (substitute* (append '("tests/stdlib/tosprocterminate.nim" - "lib/pure/osproc.nim") - (find-files "c_code" "stdlib_osproc.c")) - (("/bin/sh") (which "sh"))) + (let ((sh (which "sh"))) + (substitute* '("tests/stdlib/tosprocterminate.nim" + "lib/pure/osproc.nim") + (("/bin/sh") sh)) + (substitute* (find-files "c_code" "stdlib_osproc.c") + (("\"/bin/sh\", 7") (format "~s, ~s" sh (string-length sh))))) #t)) (replace 'build (lambda _ -- 2.24.1 From unknown Sun Jun 22 07:49:56 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#39156] Test case for the patch References: <20200116221441.mu62k4v3u6ekemn4@zdrowyportier.kadziolka.net> In-Reply-To: <20200116221441.mu62k4v3u6ekemn4@zdrowyportier.kadziolka.net> Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Jan 2020 17:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39156 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 39156@debbugs.gnu.org Received: via spool by 39156-submit@debbugs.gnu.org id=B39156.157962920132068 (code B ref 39156); Tue, 21 Jan 2020 17:54:02 +0000 Received: (at 39156) by debbugs.gnu.org; 21 Jan 2020 17:53:21 +0000 Received: from localhost ([127.0.0.1]:48420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itxiH-0008L4-A4 for submit@debbugs.gnu.org; Tue, 21 Jan 2020 12:53:21 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:40410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itxiC-0008Kn-09 for 39156@debbugs.gnu.org; Tue, 21 Jan 2020 12:53:16 -0500 Received: (qmail 21912 invoked by uid 1009); 21 Jan 2020 18:53:09 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25701. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.017354 secs); 21 Jan 2020 17:53:09 -0000 Received: from unknown (HELO zdrowyportier.kadziolka.net) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 21 Jan 2020 18:53:09 +0100 Date: Tue, 21 Jan 2020 18:53:08 +0100 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200121175308.qbsgnqizvzxgyady@zdrowyportier.kadziolka.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I realized that I was somewhat unclear on what benefit this patch brings. Without the patch, compiling any nim programs is broken, for example: ~/tmp$ cat > hello.nim echo("Hello") ~/tmp$ ~/guix/pre-inst-env guix environment --ad-hoc nim -- nim c hello.nim Hint: used config file '/gnu/store/k19xvhqgh3x0f7ax25r15l5bw16lzism-nim-0.17.2/config/nim.cfg' [Conf] Hint: system [Processing] Hint: hello [Processing] CC: hello Error: invocation of external compiler program failed. File exists Additional info: Could not find command: '/gnu/st'. OS error: No such file or directory 17 From unknown Sun Jun 22 07:49:56 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Subject: bug#39156: closed (Re: [bug#39156] [PATCH] gnu: nim: Fix substitution in stdlib_osproc.c) Message-ID: References: <87lfq0a6y7.fsf@nckx> <20200116221441.mu62k4v3u6ekemn4@zdrowyportier.kadziolka.net> X-Gnu-PR-Message: they-closed 39156 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 39156@debbugs.gnu.org Date: Tue, 21 Jan 2020 20:31:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1579638662-1204-1" This is a multi-part message in MIME format... ------------=_1579638662-1204-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #39156: [PATCH] gnu: nim: Fix substitution in stdlib_osproc.c which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 39156@debbugs.gnu.org. --=20 39156: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39156 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1579638662-1204-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 39156-done) by debbugs.gnu.org; 21 Jan 2020 20:30:18 +0000 Received: from localhost ([127.0.0.1]:48546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iu0AA-00085F-8M for submit@debbugs.gnu.org; Tue, 21 Jan 2020 15:30:18 -0500 Received: from tobias.gr ([80.241.217.52]:44188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iu0A5-0007z3-5G for 39156-done@debbugs.gnu.org; Tue, 21 Jan 2020 15:30:13 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id f20407da; Tue, 21 Jan 2020 20:30:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=91Z+ecf1zh7h38w8+sUW4b s+LvhLdHO4nTMzIskrdUA=; b=KFK+Q9h71D3wuVE18SkGJrMYMFXz/lJHGr/FMd FytjTn/3eJtDRJyVO4s2XuihyGERUeAGxkhp9gopN5lwubZTyo1RIAasuvCUc6qJ SHhRdJjj5M2+MDIHPXZvdnmj0ndw6E1WvIzGvOMiCXj3auWKUeWIMOA6LsP4wcGp GBVzVLtzycWfYGrPsKxywhvI7e/YZW/LyxbJMihKzb5PYhZb3hOyFFMjECf+fsxQ 2/Ko94GObTR1vyf6JDvE0lJ69h/ngFY8mpVzlFxxgHpyhvpOxCXFzRp4ua04lDB0 wK8xEYqjffMxdk3J19k7KxGCYTyHiDjcj4jSgG8ESsLVlLrQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 2914eb0a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 21 Jan 2020 20:30:07 +0000 (UTC) From: Tobias Geerinckx-Rice To: 39156-done@debbugs.gnu.org Subject: Re: [bug#39156] [PATCH] gnu: nim: Fix substitution in stdlib_osproc.c References: <20200116221441.mu62k4v3u6ekemn4@zdrowyportier.kadziolka.net> In-reply-to: <20200116221441.mu62k4v3u6ekemn4@zdrowyportier.kadziolka.net> Date: Tue, 21 Jan 2020 21:30:08 +0100 Message-ID: <87lfq0a6y7.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39156-done Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Jakub, Jakub K=C4=85dzio=C5=82ka =E5=86=99=E9=81=93=EF=BC=9A > * gnu/packages/nim.scm (nim)[arguments](patch-more-shebangs):=20 > Patch the > string length too. Thanks! Pushed as 79e074ea10875ff75ca613179c70de12d64b19f5. I tweaked only the commit message a bit, removing the=20 unconventional =E2=80=98(patch-more-shebangs)=E2=80=99. Now I see that Lud= o'=20 didn't seem to mind in 489703898380ab1a0db86f82c4861a33bf97b5fd.=20 Oh well. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl4nX1AACgkQ2Imw8BjF STzmeRAAl5b6USIVoWlX2CP2euItQraEVz0y3qpKP0hZ83eUU4I7gfHRvqjQLkYj RTDs+u6DLujR1SKvi6LfQ5CVIuoxHqiXn+r/cA4TRim92lG12nKb0jio5Uw/TNRK M45N82YdSnzl5Njaw1NNmVRWpTrzS0gchY/avZfV9QccFHJI5HoRPuBQxyYhL1BD umutTUaHTboyP5Gb4qREgQnhjPM1fq305qbZNjDy3NBznY8aHNr9Q0mfHOuN7hx0 ZaO6cnEMLkIWLt2tD7qYeZ2xkFKxe2L5C7KKrjoX1pobkpLW4ManG3oqc+KD0Mgd OOY1GP38kcX1y64U1Kx3cjAUavox2Ph9cyiLs955EOGRKS8Kwvq675sLBViSwaTt IUJIafH+n4rQevSdYhoO9IyD7eXspeKDLQIodaGZlFfl7E/lDVXOEBYUv8cyR47F fl9idjbjxsP3vHfBNbJwrbGBbul3rG2kIX5L0Muc33jPfZ8oHXIKkwMQ02KhD2yJ YRmz0epMGKPiyGzk9TvsbGZvRyDMBnMc7Febm6vD3TpQQF9ar17mBDApSLZXXe5P uivbpy7IEOWJC9XbEglNvR/8atUYvVAtpbt4yg71miA1ys0toTC/cIv4UY1aCZTu rAwN3LacWdrYIgFwab6B2HHFkcBrPeSxDWq6HGUI5v7yV5ypDpE= =1uvd -----END PGP SIGNATURE----- --=-=-=-- ------------=_1579638662-1204-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 16 Jan 2020 22:14:59 +0000 Received: from localhost ([127.0.0.1]:38498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isDPm-0001UG-M5 for submit@debbugs.gnu.org; Thu, 16 Jan 2020 17:14:59 -0500 Received: from lists.gnu.org ([209.51.188.17]:60528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isDPj-0001U7-4R for submit@debbugs.gnu.org; Thu, 16 Jan 2020 17:14:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43268) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isDPi-0000re-7Y for guix-patches@gnu.org; Thu, 16 Jan 2020 17:14:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isDPf-0004aG-JP for guix-patches@gnu.org; Thu, 16 Jan 2020 17:14:54 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:42132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1isDPf-0004TA-98 for guix-patches@gnu.org; Thu, 16 Jan 2020 17:14:51 -0500 Received: (qmail 8451 invoked by uid 1009); 16 Jan 2020 23:14:43 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25696. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.008548 secs); 16 Jan 2020 22:14:43 -0000 Received: from unknown (HELO zdrowyportier.kadziolka.net) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 16 Jan 2020 23:14:42 +0100 Date: Thu, 16 Jan 2020 23:14:41 +0100 From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= To: guix-patches@gnu.org Subject: [PATCH] gnu: nim: Fix substitution in stdlib_osproc.c Message-ID: <20200116221441.mu62k4v3u6ekemn4@zdrowyportier.kadziolka.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 37.59.186.212 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/nim.scm (nim)[arguments](patch-more-shebangs): Patch the string length too. --- gnu/packages/nim.scm | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gnu/packages/nim.scm b/gnu/packages/nim.scm index 5694eae63b..22dac0b58a 100644 --- a/gnu/packages/nim.scm +++ b/gnu/packages/nim.scm @@ -50,10 +50,12 @@ #t))) (add-after 'patch-source-shebangs 'patch-more-shebangs (lambda _ - (substitute* (append '("tests/stdlib/tosprocterminate.nim" - "lib/pure/osproc.nim") - (find-files "c_code" "stdlib_osproc.c")) - (("/bin/sh") (which "sh"))) + (let ((sh (which "sh"))) + (substitute* '("tests/stdlib/tosprocterminate.nim" + "lib/pure/osproc.nim") + (("/bin/sh") sh)) + (substitute* (find-files "c_code" "stdlib_osproc.c") + (("\"/bin/sh\", 7") (format "~s, ~s" sh (string-length sh))))) #t)) (replace 'build (lambda _ -- 2.24.1 ------------=_1579638662-1204-1--