From unknown Thu Jun 19 13:59:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#39155 <39155@debbugs.gnu.org> To: bug#39155 <39155@debbugs.gnu.org> Subject: Status: [PATCH] gnu: tuxguitar: Build and install alsa plugin. Reply-To: bug#39155 <39155@debbugs.gnu.org> Date: Thu, 19 Jun 2025 20:59:15 +0000 retitle 39155 [PATCH] gnu: tuxguitar: Build and install alsa plugin. reassign 39155 guix-patches submitter 39155 Mike Rosset severity 39155 normal tag 39155 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 16 14:48:49 2020 Received: (at submit) by debbugs.gnu.org; 16 Jan 2020 19:48:49 +0000 Received: from localhost ([127.0.0.1]:38372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isB8K-0006IC-TQ for submit@debbugs.gnu.org; Thu, 16 Jan 2020 14:48:49 -0500 Received: from lists.gnu.org ([209.51.188.17]:57332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isB8J-0006I4-1z for submit@debbugs.gnu.org; Thu, 16 Jan 2020 14:48:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51120) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isB8H-0003t7-1h for guix-patches@gnu.org; Thu, 16 Jan 2020 14:48:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isB8F-0002ts-DF for guix-patches@gnu.org; Thu, 16 Jan 2020 14:48:44 -0500 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:40267) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1isB8E-0002qt-GA for guix-patches@gnu.org; Thu, 16 Jan 2020 14:48:43 -0500 Received: by mail-pf1-x444.google.com with SMTP id q8so10725004pfh.7 for ; Thu, 16 Jan 2020 11:48:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FmlrtFbOlOTOiqeJdisB/KNDZYNR6BjOWG5dFyIluKg=; b=sMS7n/PIB6sfNEN8pQBPKbAP9cCGmO58YizTSt6xHmYaGiRs9MBLsitPvfqOxmevNS 4b/7wiczKdGgnw4mPyfs63fJoKZu1Ms6DBcuXDbqfRzWyJOyA6B2mqbh0MK2RbJsyymY r3Fs9visWYUedk25D/Oiix9MkGWVgDHAUBghFj2YQCnQPsDKHNR6lBrW+zeD27lWdaXQ G6EAEr43r0rh4Pq4yY5fHIwuFQ3tvwQy+0fM5qBRXVnkS1jjQKy5hlJe5UhBmL1LBQtW lFb9EXVIK9QNeYUniYh4zGlzKddlqP9at5oC8a+bFz77TPMIxedtfIiGDrupl2PgNAxJ BTcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FmlrtFbOlOTOiqeJdisB/KNDZYNR6BjOWG5dFyIluKg=; b=eixfKKMnN3gSj2YHl2Ab4bZR0OkUT2Grq/P0D3XzPegl+j5kLzSXWprFaI1U8I7gIc jhBx6vEJIdowtV19GXdT1SkWB+fOvOnC9xtpNjn+6czRlmN5NMq2TCsOCOm7H6QUArcv OZgfj6tPq143S44nOxwEfazokkGx4fasRLaTct0TdZQdBBxfDaAlm7mkVh5CSd30CUZB 7zm4NLacx+eBPxYs/eFvhlPiJTEsI+Uib8iVt9oPQgnuO7C+0zyZaUv8bJqPoZQ6vJcx P7m4e1QC7ywNXqwvBT68NYuH2Oe6O0zlrIem0ogprqDTgBGk6anpWeJzfpkeRdjWBZxo CyKA== X-Gm-Message-State: APjAAAWJ1x4t061Vzbtf+iOoWQs/ZgKqO0NXmTddjZ8mmWPA1C9Vl9cH bj4B9LGsj7Yy7cxQfZEHgUVKhqci X-Google-Smtp-Source: APXvYqzlTAA0YFpsgs+eZFIfmosQxgyEwO8BcR/V5vMoDu/cPa5Pc1q3QuyKLyDgjTOL8lS9VYQKPw== X-Received: by 2002:a63:de4a:: with SMTP id y10mr41419624pgi.367.1579204119568; Thu, 16 Jan 2020 11:48:39 -0800 (PST) Received: from neutron.hitronhub.home (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id q199sm27453491pfq.163.2020.01.16.11.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 11:48:38 -0800 (PST) From: Mike Rosset To: guix-patches@gnu.org Subject: [PATCH] gnu: tuxguitar: Build and install alsa plugin. Date: Thu, 16 Jan 2020 11:48:26 -0800 Message-Id: <20200116194826.9330-1-mike.rosset@gmail.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::444 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit Cc: Mike Rosset X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/music.scm (tuxguitar): Allows midi sound output when using a synthesizer like timidity. [inputs]: Adds alsa-lib as an input. [phases]: No longer change build directory context between phases. [install]: Now install desktop, mime and manual files. --- gnu/packages/music.scm | 90 +++++++++++++++++++++++++++--------------- 1 file changed, 59 insertions(+), 31 deletions(-) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index ad369bd3a8..15594ab0ba 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -1746,60 +1746,86 @@ is subjective.") (arguments `(#:build-target "build" #:jdk ,icedtea-8 - #:tests? #f ; no tests + #:tests? #f #:phases (modify-phases %standard-phases - (add-after 'unpack 'enter-dir - (lambda _ (chdir "TuxGuitar-lib") #t)) - (add-after 'build 'build-libraries + (replace 'build (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((initial-classpath (getenv "CLASSPATH")) (build-dir (lambda (dir) - (chdir "..") - (setenv "CLASSPATH" - (string-join (cons initial-classpath - (find-files (getcwd) "\\.jar$")) - ":")) - (chdir dir) - (if (file-exists? "build.xml") - ((assoc-ref %standard-phases 'build) - #:build-target "build") - (begin - ;; Generate default build.xml. - ((@@ (guix build ant-build-system) default-build.xml) - (string-append (string-downcase dir) ".jar") - (string-append (assoc-ref outputs "out") - "/share/java")) - ((assoc-ref %standard-phases 'build))))))) - (map build-dir '("TuxGuitar-editor-utils" + (setenv + "CLASSPATH" + (string-join (cons initial-classpath + (find-files (getcwd) "\\.jar$")) + ":")) + (with-directory-excursion dir + (if (file-exists? "build.xml") + ((assoc-ref %standard-phases 'build) + #:build-target "build") + (begin + ;; Generate default build.xml. + ((@@ (guix build ant-build-system) + default-build.xml) + (string-append (string-downcase dir) ".jar") + (string-append (assoc-ref outputs "out") + "/share/java")) + ((assoc-ref %standard-phases 'build)))))))) + (map build-dir '("TuxGuitar-lib" + "TuxGuitar-editor-utils" "TuxGuitar-ui-toolkit" "TuxGuitar-ui-toolkit-swt" - "TuxGuitar-awt-graphics"))))) - (add-after 'build-libraries 'build-application + "TuxGuitar-viewer" + "TuxGuitar" + "TuxGuitar-gm-utils" + "TuxGuitar-alsa" + "TuxGuitar-midi" + "TuxGuitar-midi-ui")) + #t))) + (add-after 'build 'build-jni (lambda _ - (chdir "../TuxGuitar") - ((assoc-ref %standard-phases 'build) - #:build-target "build"))) + (setenv "CC" "gcc") + (setenv "CFLAGS" (string-append + "-fpic -I" + (getcwd) + "/build-scripts/native-modules/common-include")) + (invoke "make" "-C" "./TuxGuitar-alsa/jni" "-f" "GNUmakefile"))) (replace 'install (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) (bin (string-append out "/bin")) (share (string-append out "/share")) + (jni-lib (string-append out "/lib")) (lib (string-append share "/java")) - (swt (assoc-ref inputs "java-swt"))) + (swt (assoc-ref inputs "java-swt")) + (mime (string-append share "/mime/packages")) + (app (string-append share "/applications")) + (man (string-append share "/man/man1"))) + (mkdir-p bin) ;; Install all jars. (for-each (lambda (file) (install-file file lib)) - (find-files ".." "\\.jar$")) + (find-files "." "\\.jar$")) + + ;; Install jni libraries + (for-each (lambda (file) + (install-file file jni-lib)) + (find-files "." "\\-jni.so$")) ;; Install all resources. - (copy-recursively "share" share) + (copy-recursively "./TuxGuitar/share" share) + + ;; Install desktop and mime files + (install-file "./misc/tuxguitar.xml" mime) + (install-file "./misc/tuxguitar.desktop" app) + + ;; Install manaual + (install-file "./misc/tuxguitar.1" man) ;; Create wrapper. (call-with-output-file (string-append bin "/tuxguitar") (lambda (port) - (let ((classpath (string-join (append (find-files lib "\\.jar$") + (let ((classpath (string-join (append (find-files lib "\\.jar$") (find-files swt "\\.jar$")) ":"))) (format @@ -1810,12 +1836,14 @@ is subjective.") " -Dtuxguitar.home.path=" out " -Dtuxguitar.share.path=" out "/share" " -Dswt.library.path=" swt "/lib" + " -Djava.library.path=" out "/lib" " org.herac.tuxguitar.app.TGMainSingleton" " \"$1\" \"$2\""))))) (chmod (string-append bin "/tuxguitar") #o555) #t)))))) (inputs - `(("java-swt" ,java-swt))) + `(("alsa-lib" ,alsa-lib) + ("java-swt" ,java-swt))) (home-page "http://tuxguitar.com.ar/") (synopsis "Multitrack tablature editor and player") (description -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 21:02:37 2020 Received: (at 39155-done) by debbugs.gnu.org; 24 Jan 2020 02:02:37 +0000 Received: from localhost ([127.0.0.1]:53369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuoIv-0007hz-3q for submit@debbugs.gnu.org; Thu, 23 Jan 2020 21:02:37 -0500 Received: from mout02.posteo.de ([185.67.36.66]:49129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuoIs-0007hj-AZ for 39155-done@debbugs.gnu.org; Thu, 23 Jan 2020 21:02:35 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id B7E142400FB for <39155-done@debbugs.gnu.org>; Fri, 24 Jan 2020 03:02:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1579831347; bh=HbhZUmA+ktB7Es4vyimZ3lcelmgzm9ZsokQx5SFuAn4=; h=From:To:Cc:Subject:Date:From; b=guwXd4lJ9uZTrzWwPxDQHrCAU0Q9XceSQ1CjSyL8eapvdw2zlJRskYWA9Ptd8hkh7 5GpZBpPsXyrQL9mwhBqHZuyz8O/0Apt8K5QECmvcvlQA2gG/Mqvm5mws3cBIhf5aHU Aciw2uJ9syZbHGOEKjcKpCr482y0ET4LUF1dfAkTZo4XK3/HzoEFiiT4FARNkX+8S9 N+JnLumYlUF4/uFsG7ZlnMJrY8tTRRRp5veIa0YRm1meEcevGcliXsWMc/p/AVeVNc Rzh88vkE9r0zr16FkuHfgJLrrtlo5HU6Wc38LK//2/Wa8QPmXbh9zfYup5M2MRUVMm Kz3vH6a/Z+Iog== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 483j824Y8Pz9rxG; Fri, 24 Jan 2020 03:02:26 +0100 (CET) From: Kei Kebreau To: Mike Rosset Subject: Re: [bug#39155] [PATCH] gnu: tuxguitar: Build and install alsa plugin. References: <20200116194826.9330-1-mike.rosset@gmail.com> Date: Thu, 23 Jan 2020 21:02:25 -0500 In-Reply-To: <20200116194826.9330-1-mike.rosset@gmail.com> (Mike Rosset's message of "Thu, 16 Jan 2020 11:48:26 -0800") Message-ID: <87muada9xq.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39155-done Cc: 39155-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Mike! Mike Rosset writes: > * gnu/packages/music.scm (tuxguitar): Allows midi sound output when using > a synthesizer like timidity. > > [inputs]: Adds alsa-lib as an input. > [phases]: No longer change build directory context between phases. > [install]: Now install desktop, mime and manual files. I've changed the format of this log message a bit so it's less repetitive. > --- > gnu/packages/music.scm | 90 +++++++++++++++++++++++++++--------------- > 1 file changed, 59 insertions(+), 31 deletions(-) > > diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm > index ad369bd3a8..15594ab0ba 100644 > --- a/gnu/packages/music.scm > +++ b/gnu/packages/music.scm > @@ -1746,60 +1746,86 @@ is subjective.") > (arguments > `(#:build-target "build" > #:jdk ,icedtea-8 > - #:tests? #f ; no tests > + #:tests? #f I left this comment in since it notes that TuxGuitar actually doesn't have a test suite, and that we haven't just disabled it for another reason. > #:phases > (modify-phases %standard-phases > - (add-after 'unpack 'enter-dir > - (lambda _ (chdir "TuxGuitar-lib") #t)) > - (add-after 'build 'build-libraries > + (replace 'build > (lambda* (#:key inputs outputs #:allow-other-keys) > (let* ((initial-classpath (getenv "CLASSPATH")) > (build-dir (lambda (dir) > - (chdir "..") > - (setenv "CLASSPATH" > - (string-join (cons initial-classpath > - (find-files (getcwd) "\\.jar$")) > - ":")) > - (chdir dir) > - (if (file-exists? "build.xml") > - ((assoc-ref %standard-phases 'build) > - #:build-target "build") > - (begin > - ;; Generate default build.xml. > - ((@@ (guix build ant-build-system) default-build.xml) > - (string-append (string-downcase dir) ".jar") > - (string-append (assoc-ref outputs "out") > - "/share/java")) > - ((assoc-ref %standard-phases 'build))))))) > - (map build-dir '("TuxGuitar-editor-utils" > + (setenv > + "CLASSPATH" > + (string-join (cons initial-classpath > + (find-files (getcwd) "\\.jar$")) > + ":")) > + (with-directory-excursion dir > + (if (file-exists? "build.xml") > + ((assoc-ref %standard-phases 'build) > + #:build-target "build") > + (begin > + ;; Generate default build.xml. > + ((@@ (guix build ant-build-system) > + default-build.xml) > + (string-append (string-downcase dir) ".jar") > + (string-append (assoc-ref outputs "out") > + "/share/java")) > + ((assoc-ref %standard-phases 'build)))))))) > + (map build-dir '("TuxGuitar-lib" > + "TuxGuitar-editor-utils" > "TuxGuitar-ui-toolkit" > "TuxGuitar-ui-toolkit-swt" > - "TuxGuitar-awt-graphics"))))) > - (add-after 'build-libraries 'build-application > + "TuxGuitar-viewer" > + "TuxGuitar" > + "TuxGuitar-gm-utils" > + "TuxGuitar-alsa" > + "TuxGuitar-midi" > + "TuxGuitar-midi-ui")) > + #t))) > + (add-after 'build 'build-jni > (lambda _ > - (chdir "../TuxGuitar") > - ((assoc-ref %standard-phases 'build) > - #:build-target "build"))) > + (setenv "CC" "gcc") > + (setenv "CFLAGS" (string-append > + "-fpic -I" > + (getcwd) > + "/build-scripts/native-modules/common-include")) > + (invoke "make" "-C" "./TuxGuitar-alsa/jni" "-f" "GNUmakefile"))) > (replace 'install > (lambda* (#:key inputs outputs #:allow-other-keys) > (let* ((out (assoc-ref outputs "out")) > (bin (string-append out "/bin")) > (share (string-append out "/share")) > + (jni-lib (string-append out "/lib")) > (lib (string-append share "/java")) > - (swt (assoc-ref inputs "java-swt"))) > + (swt (assoc-ref inputs "java-swt")) > + (mime (string-append share "/mime/packages")) > + (app (string-append share "/applications")) > + (man (string-append share "/man/man1"))) > + > (mkdir-p bin) > ;; Install all jars. > (for-each (lambda (file) > (install-file file lib)) > - (find-files ".." "\\.jar$")) > + (find-files "." "\\.jar$")) > + > + ;; Install jni libraries > + (for-each (lambda (file) > + (install-file file jni-lib)) > + (find-files "." "\\-jni.so$")) > > ;; Install all resources. > - (copy-recursively "share" share) > + (copy-recursively "./TuxGuitar/share" share) > + > + ;; Install desktop and mime files > + (install-file "./misc/tuxguitar.xml" mime) > + (install-file "./misc/tuxguitar.desktop" app) > + > + ;; Install manaual > + (install-file "./misc/tuxguitar.1" man) > > ;; Create wrapper. > (call-with-output-file (string-append bin "/tuxguitar") > (lambda (port) > - (let ((classpath (string-join (append (find-files lib "\\.jar$") > + (let ((classpath (string-join (append (find-files lib "\\.jar$") > (find-files swt "\\.jar$")) > ":"))) > (format > @@ -1810,12 +1836,14 @@ is subjective.") > " -Dtuxguitar.home.path=" out > " -Dtuxguitar.share.path=" out "/share" > " -Dswt.library.path=" swt "/lib" > + " -Djava.library.path=" out "/lib" > " org.herac.tuxguitar.app.TGMainSingleton" > " \"$1\" \"$2\""))))) > (chmod (string-append bin "/tuxguitar") #o555) > #t)))))) > (inputs > - `(("java-swt" ,java-swt))) > + `(("alsa-lib" ,alsa-lib) > + ("java-swt" ,java-swt))) > (home-page "http://tuxguitar.com.ar/") > (synopsis "Multitrack tablature editor and player") > (description The rest of this LGTM! This has been pushed to master as commit 44e70dee184c4e4190349def71dc07f05822f591. Thanks for contributing! Now we guitarists can hear our beautiful tablature! :-) Kei From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 21:16:16 2020 Received: (at 39155-done) by debbugs.gnu.org; 24 Jan 2020 02:16:16 +0000 Received: from localhost ([127.0.0.1]:53382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuoW8-000834-01 for submit@debbugs.gnu.org; Thu, 23 Jan 2020 21:16:16 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:53313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuoW6-00082j-Bv for 39155-done@debbugs.gnu.org; Thu, 23 Jan 2020 21:16:14 -0500 Received: by mail-pj1-f68.google.com with SMTP id n96so343016pjc.3 for <39155-done@debbugs.gnu.org>; Thu, 23 Jan 2020 18:16:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=JkVITsNzi7Z721KrYP8z7JQDQvkJbWwHgygU7pdLRt4=; b=NPqeHwr6AG9dFv04NqqPJopMm8cJW54BR4s89DhDUJjyD//Y+ezh/JrNGW31DbfYOV zkBNxKBFCjjPIsY/g8WNcGJJIWUzRhEA4zXl6hXko2ScFggRy8/f8tBmmNrb2X8nkqcV JDgHbsvEeKmC6MDRxeVjY4xfl+rio0goVDefbQWD/32JJyw6RSBdaAzoVuhLAQ1btK6i KRdHAmb8cvTSA2tPFSN+e0rNVN3S70lIE0t5U5mmNA9L2SVbWoYb2I3aw7Iyo4w0olyL ol7N1F0sXAmg46kD7ObENdllsqD5sxU1Ej5wJ2jNb6D8HLOFmpMdpjZEpq8de01DxL5R ChcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=JkVITsNzi7Z721KrYP8z7JQDQvkJbWwHgygU7pdLRt4=; b=YqWeXJ3xk+isXIJleXCpxccWzXtlkDYl3zaruIAp7ybpFHTFVfFdgUPoUUcs1rlZ9o 0Hutn0Q7BE/Yxn5mA6bMGQGCkLOHnWF6i4VQHIObGHRwbKE8UGYLkK5tZnHfRXPTQ527 j3u60jaspbQhTmfOheqzgxKXRpal3G7T7d+5U0tht74+gtPllAGOJvlajSdXUcuVqF9s aFF5NZ+wipEyn+CuKpBujOs2FYi5+0+Zrj42nGv3Q+AfV2JK3LALUlbhn7n5W0vBkS+s HqKNa++drOL+qmSWMLq1xH51ipkqyF+SyjMcWvSpPHE3zKw1yNU1Os23Fde0AGAKWzJ9 MrqA== X-Gm-Message-State: APjAAAVwiTsIpNOgwNPy3kFBgsN4UKJs2Xun+xzGo2ZtAqM0b2mNNphF L5sQpV1dQWaIrsgZ1KcSulDv72uo X-Google-Smtp-Source: APXvYqz8feY6kz6pc4T8pdDd2sQlZGeF00Y8RM/VubIQt1/fxxCLe4wUPSy3z6Vho+9F+fJIPda52Q== X-Received: by 2002:a17:90a:e657:: with SMTP id ep23mr697156pjb.105.1579832168127; Thu, 23 Jan 2020 18:16:08 -0800 (PST) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id w5sm4118412pjt.32.2020.01.23.18.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2020 18:16:07 -0800 (PST) References: <20200116194826.9330-1-mike.rosset@gmail.com> <87muada9xq.fsf@posteo.net> User-agent: mu4e 1.2.0; emacs 26.3 From: Mike Rosset To: Kei Kebreau Subject: Re: [bug#39155] [PATCH] gnu: tuxguitar: Build and install alsa plugin. In-reply-to: <87muada9xq.fsf@posteo.net> Date: Thu, 23 Jan 2020 18:16:06 -0800 Message-ID: <87o8uteh09.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39155-done Cc: 39155-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> --- >> gnu/packages/music.scm | 90 +++++++++++++++++++++++++++--------------- >> 1 file changed, 59 insertions(+), 31 deletions(-) >> >> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm >> index ad369bd3a8..15594ab0ba 100644 >> --- a/gnu/packages/music.scm >> +++ b/gnu/packages/music.scm >> @@ -1746,60 +1746,86 @@ is subjective.") >> (arguments >> `(#:build-target "build" >> #:jdk ,icedtea-8 >> - #:tests? #f ; no tests >> + #:tests? #f > > I left this comment in since it notes that TuxGuitar actually doesn't > have a test suite, and that we haven't just disabled it for another reason. Hello Kei, Apologies for removing this comment. I had not thought of this when I removed it, thanks for reviewing this and merging. Mike From unknown Thu Jun 19 13:59:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 21 Feb 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator