GNU bug report logs - #39145
28.0.50; dired: Show broken/circular links in different font

Previous Next

Full log

View this message in rfc822 format

From: Tino Calancha <tino.calancha <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: 39145 <at> debbugs.gnu.org
Subject: bug#39145: 28.0.50; dired: Show broken/circular links in different font
Date: Mon, 24 Aug 2020 19:52:50 +0200

Juri Linkov <juri <at> linkov.net> writes:

>> @@ -538,6 +549,18 @@ dired-font-lock-keywords
>>     (list dired-re-dir
>>  	 '(".+" (dired-move-to-filename) nil (0 dired-directory-face)))
>>     ;;
>> +   ;; Broken Symbolic link.
>> +   (list dired-re-sym
>> +         (list (lambda (end)
>> +                 (let* ((file (dired-file-name-at-point))
>> +                        (truename (ignore-errors (file-truename file))))
>> +                   ;; either links to unexistent files or circular links
>> +                   (and (not (and truename (file-exists-p truename)))
>> +	                (search-forward-regexp ".+-> ?.+" end t))))
>> +               '(dired-move-to-filename)
>
> Does this mean file-exists-p will be called on every file in the directory?
No it doesn't.
It will called only on symbolic links w/ a truename in such a dir.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.