Subject: Re: bug#39145: 28.0.50; dired: Show broken/circular links in different font

From: Glenn Morris <[email-masked]>
Date: Wed, 15 Jan 2020 17:28:47 -0500

Tino Calancha wrote:

> +(defface dired-broken-symlink
> +  '((((class color))
> +     :foreground "yellow1" :background "red1" :weight bold)
> +    (t :weight bold :slant italic :underline t))
> +  "Face used for broken symbolic links."
> +  :group 'dired-faces
> +  :version "28.1")
> +
> +(defvar dired-broken-symlink-face 'dired-broken-symlink
> +  "Face name used for broken symbolic links.")

Why have a variable at all, why not just customize the face?
(If it's just for consistency with existing dired stuff, consider
breaking that consistency.)