From unknown Sun Jun 22 11:33:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#39142 <39142@debbugs.gnu.org> To: bug#39142 <39142@debbugs.gnu.org> Subject: Status: Update USB_ModeSwitch. Reply-To: bug#39142 <39142@debbugs.gnu.org> Date: Sun, 22 Jun 2025 18:33:42 +0000 retitle 39142 Update USB_ModeSwitch. reassign 39142 guix-patches submitter 39142 "pelzflorian (Florian Pelz)" severity 39142 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 15 07:48:19 2020 Received: (at submit) by debbugs.gnu.org; 15 Jan 2020 12:48:20 +0000 Received: from localhost ([127.0.0.1]:34354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iri5r-0007nc-Nk for submit@debbugs.gnu.org; Wed, 15 Jan 2020 07:48:19 -0500 Received: from lists.gnu.org ([209.51.188.17]:33045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iri5q-0007nU-9o for submit@debbugs.gnu.org; Wed, 15 Jan 2020 07:48:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51653) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iri5o-0003Dk-UM for guix-patches@gnu.org; Wed, 15 Jan 2020 07:48:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iri5n-00041U-Px for guix-patches@gnu.org; Wed, 15 Jan 2020 07:48:16 -0500 Received: from pelzflorian.de ([5.45.111.108]:44796 helo=mail.pelzflorian.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iri5n-0003zx-AZ for guix-patches@gnu.org; Wed, 15 Jan 2020 07:48:15 -0500 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id AD4033604F7 for ; Wed, 15 Jan 2020 13:48:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1579092492; bh=uz6xJe27ZdJ34f+RrZyuzBf2FrsVSMazbWhPAIBRlsc=; h=Date:From:To:Subject; b=fHHiKTDi4apaTQyxgjpqBYmcgyVreRQZOvD8i3eABviEi/ZMdJj/u2HPNgZeqqr7j 6kdLnEV/VfXUlbLZjxUo0b7pwbR9ymdQX4w8216km5ZgzC28XLnhqY4HVBk734E5N+ tXLda1ncJWIW8++eaOsvYb9+g+L3JQXbFvaUyY2g= Date: Wed, 15 Jan 2020 13:48:10 +0100 From: "pelzflorian (Florian Pelz)" To: guix-patches@gnu.org Subject: Update USB_ModeSwitch. Message-ID: <20200115124810.j3myokleoa7le3sq@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 5.45.111.108 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This series updates USB_ModeSwitch and its data package to their November release. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 15 07:50:39 2020 Received: (at 39142) by debbugs.gnu.org; 15 Jan 2020 12:50:39 +0000 Received: from localhost ([127.0.0.1]:34359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iri87-0007rM-4e for submit@debbugs.gnu.org; Wed, 15 Jan 2020 07:50:39 -0500 Received: from pelzflorian.de ([5.45.111.108]:34552 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iri82-0007rB-91 for 39142@debbugs.gnu.org; Wed, 15 Jan 2020 07:50:37 -0500 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 6E04F3604F7 for <39142@debbugs.gnu.org>; Wed, 15 Jan 2020 13:50:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1579092633; bh=YL6DfqWaEvLoc730Mqi4BDjw+uoPWvKys9p6raUJA2E=; h=Date:From:To:Subject; b=0cNu8CnR06rIS5K/2Mz1w/3mcVWtM6jfvKi5p8XF+QscojHjtrLooCyZmBudqvqGA +vQ9EsIpjHw71DtyV+1CW9J/leOEy85YK4sVkKHX1ozgS53CG0c8fvqgEXNTSWYEoL yB1mq8xufsBa6Q10TeMt1rlJCA5u6iycA8RMFheY= Date: Wed, 15 Jan 2020 13:50:31 +0100 From: Florian Pelz To: 39142@debbugs.gnu.org Subject: [PATCH 1/2] gnu: USB_ModeSwitch: Update to 2.6.0. Message-ID: <20200115125031.ky2czidsqep3of4m@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39142 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/usb-modeswitch.scm (usb-modeswitch): Update to 2.6.0. [source]: Remove snippet that deletes jimtcl, which is no longer bundled. Remove patch. Use HTTPS. [arguments]: Adapt to changed file names. [home-page] Use HTTPS. [license]: Fix missing BSD-2 license. * gnu/packages/patches/usb-modeswitch-accept-config-arg.patch: Delete file. * gnu/local.mk (dist_patch_DATA): Remove it. --- gnu/local.mk | 1 - .../usb-modeswitch-accept-config-arg.patch | 42 ------------------- gnu/packages/usb-modeswitch.scm | 23 ++++------ 3 files changed, 8 insertions(+), 58 deletions(-) delete mode 100644 gnu/packages/patches/usb-modeswitch-accept-config-arg.patch diff --git a/gnu/local.mk b/gnu/local.mk index 32ef715bb5..cca5765a56 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1444,7 +1444,6 @@ dist_patch_DATA = \ %D%/packages/patches/util-linux-tests.patch \ %D%/packages/patches/upower-builddir.patch \ %D%/packages/patches/upx-fix-CVE-2017-15056.patch \ - %D%/packages/patches/usb-modeswitch-accept-config-arg.patch \ %D%/packages/patches/valgrind-enable-arm.patch \ %D%/packages/patches/vboot-utils-fix-format-load-address.patch \ %D%/packages/patches/vboot-utils-fix-tests-show-contents.patch \ diff --git a/gnu/packages/patches/usb-modeswitch-accept-config-arg.patch b/gnu/packages/patches/usb-modeswitch-accept-config-arg.patch deleted file mode 100644 index 9c050f7ee6..0000000000 --- a/gnu/packages/patches/usb-modeswitch-accept-config-arg.patch +++ /dev/null @@ -1,42 +0,0 @@ ---- old/usb_modeswitch.tcl 1970-01-01 01:00:00.000000000 +0100 -+++ usb_modeswitch.tcl 2019-06-12 08:39:42.140000000 +0200 -@@ -41,7 +41,7 @@ - global scsi usb config match device flags setup devdir loginit - - set flags(config) "" --Log "[ParseGlobalConfig]" -+Log "[ParseGlobalConfig $argv]" - - if {$flags(stordelay) > 0} { - SetStorageDelay $flags(stordelay) -@@ -496,9 +496,21 @@ - # end of proc {MatchDevice} - - --proc {ParseGlobalConfig} {} { -+proc {ParseGlobalConfig} {argv} { - - global flags -+ -+set configFileParam "" -+for {set i 0} {$i < [llength $argv]} {incr i} { -+ switch -glob -- [set v [lindex $argv $i]] { -+ --config-file=* { -+ set configFileParam $v -+ } -+ } -+} -+if {$configFileParam != ""} { -+ set configFile [string range $configFileParam [string length "--config-file="] end] -+} else { - set configFile "" - set places [list /etc/usb_modeswitch.conf /etc/sysconfig/usb_modeswitch /etc/default/usb_modeswitch] - foreach cfg $places { -@@ -507,6 +519,7 @@ - break - } - } -+} - if {$configFile == ""} {return} - - set rc [open $configFile r] diff --git a/gnu/packages/usb-modeswitch.scm b/gnu/packages/usb-modeswitch.scm index 7e4526ae46..8f3edc7f43 100644 --- a/gnu/packages/usb-modeswitch.scm +++ b/gnu/packages/usb-modeswitch.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2019 Florian Pelz +;;; Copyright © 2019, 2020 Florian Pelz ;;; ;;; This file is part of GNU Guix. ;;; @@ -76,23 +76,15 @@ file for use with USB_ModeSwitch.") (define-public usb-modeswitch (package (name "usb-modeswitch") - (version "2.5.2") + (version "2.6.0") (source (origin (method url-fetch) (uri (string-append - "http://www.draisberghof.de/usb_modeswitch/" + "https://www.draisberghof.de/usb_modeswitch/" "usb-modeswitch-" version ".tar.bz2")) (sha256 (base32 - "19ifi80g9ns5dmspchjvfj4ykxssq9yrci8m227dgb3yr04srzxb")) - (modules '((guix build utils))) - (snippet - ;; Remove bundled jimtcl. - '(begin - (delete-file-recursively "jim") - #t)) - (patches - (search-patches "usb-modeswitch-accept-config-arg.patch")))) + "18wbbxc5cfsmikba0msdvd5qlaga27b32nhrzicyd9mdddp265f2")))) (native-inputs `(("pkg-config" ,pkg-config))) (inputs `(("libusb" ,libusb) ("jimtcl" ,jimtcl) @@ -145,7 +137,7 @@ file for use with USB_ModeSwitch.") (rename-file "usb_modeswitch.sh" "usb_modeswitch") (install-file "usb_modeswitch" udev) - (rename-file "usb_modeswitch.tcl" "usb_modeswitch_dispatcher") + (rename-file "usb_modeswitch_dispatcher.tcl" "usb_modeswitch_dispatcher") (substitute* "usb_modeswitch_dispatcher" (("/usr/bin/tclsh") (string-append jimtcl "/bin/jimsh")) @@ -155,7 +147,7 @@ file for use with USB_ModeSwitch.") (install-file "usb_modeswitch_dispatcher" dispatcher-bin) #t))))))) - (home-page "http://www.draisberghof.de/usb_modeswitch/") + (home-page "https://www.draisberghof.de/usb_modeswitch/") (synopsis "Mode switching tool for controlling `multi-mode' USB devices") (description "USB_ModeSwitch is a mode switching tool for controlling USB devices with multiple @dfn{modes}. When plugged in for the first time many @@ -163,4 +155,5 @@ USB devices (primarily high-speed WAN modems) act like a flash storage containing installers for Windows drivers. USB_ModeSwitch replays the sequence the Windows drivers would send to switch their mode from storage to modem (or whatever the thing is supposed to do).") - (license license:gpl2+))) + (license (list license:gpl2+ ;"this program" according to home page + license:bsd-2)))) ;dispatcher.c -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 15 07:51:00 2020 Received: (at 39142) by debbugs.gnu.org; 15 Jan 2020 12:51:00 +0000 Received: from localhost ([127.0.0.1]:34362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iri8S-0007ry-Hy for submit@debbugs.gnu.org; Wed, 15 Jan 2020 07:51:00 -0500 Received: from pelzflorian.de ([5.45.111.108]:34558 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iri8Q-0007rl-4O for 39142@debbugs.gnu.org; Wed, 15 Jan 2020 07:50:58 -0500 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 673B23604F7 for <39142@debbugs.gnu.org>; Wed, 15 Jan 2020 13:50:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1579092657; bh=YVxXXkc2WS5Ojy3ONIo41qjncdX1IB5Oyl/2s5lMKJQ=; h=Date:From:To:Subject; b=o3To6POzEbQKiOzUDRYSWS9gnXd30S/K8YKs0KZ629C9OQvquFQRKJbZfDZU0FiXq 4beBkL2au2abohUUtbs6vCBkeqVMa36wQ/5kKDGbyuHiWcDzNSXaJkXcNTwa6QXsAu CvNLlUhfz2QKO4IgMAmI4BWmPNY9UQXPy6PQ2DQw= Date: Wed, 15 Jan 2020 13:50:56 +0100 From: Florian Pelz To: 39142@debbugs.gnu.org Subject: [PATCH 2/2] gnu: USB_ModeSwitch data: Update to 20191128. Message-ID: <20200115125056.qfayoyyotuyttudp@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39142 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/usb-modeswitch.scm (usb-modeswitch-data): Update to 20191128. [source] Use HTTPS. [home-page] Use HTTPS. --- gnu/packages/usb-modeswitch.scm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gnu/packages/usb-modeswitch.scm b/gnu/packages/usb-modeswitch.scm index 8f3edc7f43..6de810d23d 100644 --- a/gnu/packages/usb-modeswitch.scm +++ b/gnu/packages/usb-modeswitch.scm @@ -32,15 +32,15 @@ (define-public usb-modeswitch-data (package (name "usb-modeswitch-data") - (version "20170806") + (version "20191128") (source (origin (method url-fetch) (uri (string-append - "http://www.draisberghof.de/usb_modeswitch/" + "https://www.draisberghof.de/usb_modeswitch/" "usb-modeswitch-data-" version ".tar.bz2")) (sha256 (base32 - "0b1wari3aza6qjggqd0hk2zsh93k1q8scgmwh6f8wr0flpr3whff")))) + "1ygahl3r26r38ai8yyblq9nhf3v5i6n6r6672p5wf88wg5h9n0rz")))) (build-system trivial-build-system) (native-inputs `(("tar" ,tar) ("bzip2" ,bzip2))) @@ -67,7 +67,7 @@ (install-file (string-append files "/40-usb_modeswitch.rules") udev-dir) (install-file (string-append files "/COPYING") license-dir))))) - (home-page "http://www.draisberghof.de/usb_modeswitch/") + (home-page "https://www.draisberghof.de/usb_modeswitch/") (synopsis "Data package for USB_ModeSwitch") (description "This package contains data about devices and a UDEV rules file for use with USB_ModeSwitch.") -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 18 06:29:49 2020 Received: (at 39142) by debbugs.gnu.org; 18 Jan 2020 11:29:49 +0000 Received: from localhost ([127.0.0.1]:40588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ismIX-0001vm-Bx for submit@debbugs.gnu.org; Sat, 18 Jan 2020 06:29:49 -0500 Received: from mira.cbaines.net ([212.71.252.8]:40962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ismIU-0001vb-F8 for 39142@debbugs.gnu.org; Sat, 18 Jan 2020 06:29:47 -0500 Received: from localhost (unknown [46.237.162.0]) by mira.cbaines.net (Postfix) with ESMTPSA id 7EDA21785F; Sat, 18 Jan 2020 11:29:45 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id c22954b8; Sat, 18 Jan 2020 11:29:43 +0000 (UTC) References: <20200115124810.j3myokleoa7le3sq@pelzflorian.localdomain> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: pelzflorian@pelzflorian.de Subject: Re: [bug#39142] Update USB_ModeSwitch. In-reply-to: <20200115124810.j3myokleoa7le3sq@pelzflorian.localdomain> Date: Sat, 18 Jan 2020 11:29:41 +0000 Message-ID: <87sgkdovdm.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39142 Cc: 39142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain pelzflorian (Florian Pelz) writes: > This series updates USB_ModeSwitch and its data package to their > November release. Both patches look good to me :) There's a somewhat uninformative comparison of Guix without these patches, and Guix with these patches here [1]. 1: https://guix-patches-data.cbaines.net/compare?base_commit=9edae6c05cd879393d59702f033f4c3ccce30dba&target_commit=0115c829cc1021b01b1686c5d28a7f6004390c83 But what it does show is that there aren't any additional lint warnings, and the derivations can be computed. I also tried building the derivations on x86_64-linux, and they built :D --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4i7CVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcKIw/+LqEmOWOksdjGPfRSIwvOIosnMr5peMDLrXdwZL0aSszlvG7tWYr9M3vI 1gED69rhc18yt5I8Apebgeqi0N4il9N1meqbEW+VPI3VUcts7JRwc+hmS2JNnOiH V3txFzCnWec1WVJCta91am9oz9tftnQqRFYlymLA090lxRIOb7ni88J2VPMzp/bJ BfxwYbrvRK/sZmsu/lB4WghUzMBY9+jNo5LkGA8q5sLcDT+eO9cIkvE4ZcRlu8/W 58Sk4N9/NfrNgl+fch2CvKFMnVUPx8v7hYKev5eN5mhXUk2vb2hMasDcoOFLOuks nr8Qty7PjZztaZth2zXVSIu/P+Q9Cmy/ffFjpOUjPUSlh9g2GKbx08piodZztfH2 uTpdTLEDUUZ8ZiS1lshdZfNzJMhtunmsmVb75y6ohzx4t5UgiqJSCmSlhcInIAkH vigH3GbithWDVybBB41+8tzpzV3ldNIywaOzJgekFbuYEAmSbI3+4GIl0eEgq2K0 wAyUkCsfDCJerVIizARgxCvdzaZZoN3Ba2VFraAojy2YpelIhwaJZqQiT+k7QAXZ XfM7WtE+3swXhzqvnHEEksRLr3rAOe1nVTjPfsTsQQ7L/o8jCuDX3sqEfcAaHS8m k62w2PyvlKiILCzmq0vLSJylnT03WXJASFUSK6Qn9K0ROP+EEak= =XfhU -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 18 06:52:54 2020 Received: (at 39142) by debbugs.gnu.org; 18 Jan 2020 11:52:55 +0000 Received: from localhost ([127.0.0.1]:40604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ismes-0002Uv-Pk for submit@debbugs.gnu.org; Sat, 18 Jan 2020 06:52:54 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:41740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ismeq-0002Um-R0 for 39142@debbugs.gnu.org; Sat, 18 Jan 2020 06:52:54 -0500 Received: from localhost (unknown [185.17.13.127]) by dd26836.kasserver.com (Postfix) with ESMTPSA id EE121336344E; Sat, 18 Jan 2020 12:52:50 +0100 (CET) Date: Sat, 18 Jan 2020 12:52:38 +0100 From: Danny Milosavljevic To: Christopher Baines Subject: Re: [bug#39142] Update USB_ModeSwitch. Message-ID: <20200118125238.3423c25d@scratchpost.org> In-Reply-To: <87sgkdovdm.fsf@cbaines.net> References: <20200115124810.j3myokleoa7le3sq@pelzflorian.localdomain> <87sgkdovdm.fsf@cbaines.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/4dhUZAtHeJw7t+avFNaR0ns"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39142 Cc: 39142@debbugs.gnu.org, pelzflorian@pelzflorian.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/4dhUZAtHeJw7t+avFNaR0ns Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, On Sat, 18 Jan 2020 11:29:41 +0000 Christopher Baines wrote: > 1: https://guix-patches-data.cbaines.net/compare?base_commit=3D9edae6c05c= d879393d59702f033f4c3ccce30dba&target_commit=3D0115c829cc1021b01b1686c5d28a= 7f6004390c83 Very nice! In general, I suggest to also list license changes. Whether we like it or not, in practice those happen and it's important to know (especially to know when they stay the same). --Sig_/4dhUZAtHeJw7t+avFNaR0ns Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4i8YYACgkQ5xo1VCww uqXy7gf9G/n5TW5GIlKjHUF35tQ/UNdZ1/wEjVe94RLjS8MTXo0kv/MOLP0JQBdA nr8PB7Ia9NK/UVfdqLWp5bh4bU/hlDxoNSzbaVSuB4E2zlMRdZ1bKpFYfTYgOxZV qdfqxyPXF/jq96OxkHBEBT5rwd9B/YK0PliKdEP33eNBWNrlYd4oLs0OQ5j4o10S HIteCnEhSm+Dg/ZGDgNI0dkDXfkPkA3TpiE5yVgZ63V+F5cgC6Mqm2qoekKs+lOG wmCmaQr1xl6f0QcgG8pVt2TgJWCBuU0GCTbBH0urkTzz3iU3/lSRzm72bqyk391I 5yGZB+apBZ+PE6Z7fGF46INj7gsZCA== =iWEG -----END PGP SIGNATURE----- --Sig_/4dhUZAtHeJw7t+avFNaR0ns-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 18 07:02:55 2020 Received: (at 39142) by debbugs.gnu.org; 18 Jan 2020 12:02:55 +0000 Received: from localhost ([127.0.0.1]:40616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ismoY-0002o2-W0 for submit@debbugs.gnu.org; Sat, 18 Jan 2020 07:02:55 -0500 Received: from mira.cbaines.net ([212.71.252.8]:40992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ismoW-0002nq-Ad for 39142@debbugs.gnu.org; Sat, 18 Jan 2020 07:02:53 -0500 Received: from localhost (unknown [46.237.162.0]) by mira.cbaines.net (Postfix) with ESMTPSA id 3FC3817884; Sat, 18 Jan 2020 12:02:51 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id cc4df1a3; Sat, 18 Jan 2020 12:02:48 +0000 (UTC) References: <20200115124810.j3myokleoa7le3sq@pelzflorian.localdomain> <87sgkdovdm.fsf@cbaines.net> <20200118125238.3423c25d@scratchpost.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: Danny Milosavljevic Subject: Re: [bug#39142] Update USB_ModeSwitch. In-reply-to: <20200118125238.3423c25d@scratchpost.org> Date: Sat, 18 Jan 2020 12:02:46 +0000 Message-ID: <87r1zxotuh.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39142 Cc: 39142@debbugs.gnu.org, pelzflorian@pelzflorian.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > Hi, > > On Sat, 18 Jan 2020 11:29:41 +0000 > Christopher Baines wrote: > >> 1: https://guix-patches-data.cbaines.net/compare?base_commit=9edae6c05cd879393d59702f033f4c3ccce30dba&target_commit=0115c829cc1021b01b1686c5d28a7f6004390c83 > > Very nice! Thanks :) > In general, I suggest to also list license changes. Whether we like it or > not, in practice those happen and it's important to know (especially to know > when they stay the same). So, the Guix Data Service does know what licenses are associated with a package. I guess it could list packages where that's changed on the main comparison page, is that what you're referring to? In my mind at least, the primary issue when reviewing packages is making sure the license list for the package corresponds with the actual licenses that apply to the contents. That's a little harder, as you'd have to download the source tarball, and run licensecheck or something similar, but hopefully that can be automated at some point! Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4i8+ZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XeYEw/+PoB4qYWm/bpW7Or6oRKyj5M1rXWZx58f1RMxRhdPJlO+WDSUl6Bqz7rr +Q7VE9+OCC0L9YTRNUPalPMrR6GmxG8STW+Ff+H8sLK6cMuFwOMxOfTdaet8JwFW ha9huyheL+KPnAI7xKf1R0Iu7HD+2aZA4qQFZYsWtKiwUqve7FdbonEssQddFI9W 33eopZpUornreFRjGvTeBSg4+WDLLwlCtbEVsuJbFGguHwNOHAmz2M75jp5HVCsk AdXdw+soan0rn34nkhWc+5fASeWErxtr3JIeBpy336DpSWn/ttzQs+Ukke2dyEK8 xFG8yLGdy0QP1b1Wtc83lz8dDiE0VrmTqBHQFdNf1p5tYSMQ/t4JdvmGOpAPwrmq X+I6gc0hqyRpB0vIf93WuF9F+eCv/D8n1HQ6n+BubFNDfMioWLYw4xLvEBfrxwjj 4gyIGxP8tvKn3Gja+wKYkfbbZ8T4RlzuW0/IVJsW16AGiBrgGH1JA1m1ortHaxLq F/Tlg2walCkRl1ZUinA5h0yZFrRmhmjsi8bYWsqFIjfvUaCWNQJnJl3DztfK62B+ Jy5ZJwlXCQomp6iLGqS+oOPMYW+AGXJaix9trbOZKIM+9dPPrXXNc3c1nVd7i1W9 MgRsZbAeDWF2TjTfjd0/A7i94jv+FjPn10HD/xHqQTTb0LYWysk= =QRnO -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 19 05:11:48 2020 Received: (at 39142) by debbugs.gnu.org; 19 Jan 2020 10:11:48 +0000 Received: from localhost ([127.0.0.1]:42624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1it7YZ-0001T7-Sm for submit@debbugs.gnu.org; Sun, 19 Jan 2020 05:11:48 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:56724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1it7YX-0001Sy-Da for 39142@debbugs.gnu.org; Sun, 19 Jan 2020 05:11:46 -0500 Received: from localhost (unknown [185.17.13.127]) by dd26836.kasserver.com (Postfix) with ESMTPSA id A112F3360D1E; Sun, 19 Jan 2020 11:11:43 +0100 (CET) Date: Sun, 19 Jan 2020 11:11:29 +0100 From: Danny Milosavljevic To: Christopher Baines Subject: Re: [bug#39142] Update USB_ModeSwitch. Message-ID: <20200119111129.48f3eaa3@scratchpost.org> In-Reply-To: <87r1zxotuh.fsf@cbaines.net> References: <20200115124810.j3myokleoa7le3sq@pelzflorian.localdomain> <87sgkdovdm.fsf@cbaines.net> <20200118125238.3423c25d@scratchpost.org> <87r1zxotuh.fsf@cbaines.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/fVghyVtP_/x67Pbmws8L9Lt"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39142 Cc: 39142@debbugs.gnu.org, pelzflorian@pelzflorian.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/fVghyVtP_/x67Pbmws8L9Lt Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, On Sat, 18 Jan 2020 12:02:46 +0000 Christopher Baines wrote: > > In general, I suggest to also list license changes. Whether we like it= or > > not, in practice those happen and it's important to know (especially to= know > > when they stay the same). =20 >=20 > So, the Guix Data Service does know what licenses are associated with a > package. I guess it could list packages where that's changed on the main > comparison page, is that what you're referring to? Yes, on that ".../compare" page, just like "Version changes" there could be an always-visible section "License changes". > In my mind at least, the primary issue when reviewing packages is making > sure the license list for the package corresponds with the actual > licenses that apply to the contents. That's a little harder, as you'd > have to download the source tarball, and run licensecheck or something > similar, but hopefully that can be automated at some point! I'm not sure that that could ever be reliably automated (after all, the sou= rce code can say whatever license text in the comments--we can't have an exhaustive list). In general it would already be much help to automate basically grep -ri 'gnu general' $(grep -ril license .) just in order to reduce the workload. But I think we already package third party license checkers for that, no need to do that for Guix Data Service. --Sig_/fVghyVtP_/x67Pbmws8L9Lt Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4kK1EACgkQ5xo1VCww uqVRYwgAiok6svZdsi1bfimftZTMZtLBuuWgWbw6VOI+ucEwBx/SUhbZcNo2Eo4d eI7h0ekuIeDAXm9RFEPjwMTshRNUko5HlH16uIm/1ZjSSUWi1Pf4bQdNOi5m1hIK HTUxgCH9wNXewxtWqx+ySBzS3b9OOs+FWg0yxuCcRjF4BdmKcCcO7aMgeAd58ZLE Ax8q1zApqpcPUyA4l0qC4heh0Xa1MyhNu8dW74AeIwctcJAoPJyrX8zs7M+9pJC7 wbcrtD/sKfsHxpA7cGJbSbstmeTkgGw72HpapWOnHbw/I2IJcPzjNH3Btohcbsh2 3z2mDBaQp324yhIpX/nJMsPY/dYQgg== =zPj2 -----END PGP SIGNATURE----- --Sig_/fVghyVtP_/x67Pbmws8L9Lt-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 04:03:51 2020 Received: (at 39142-done) by debbugs.gnu.org; 20 Jan 2020 09:03:51 +0000 Received: from localhost ([127.0.0.1]:44338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itSyJ-0006oP-Fs for submit@debbugs.gnu.org; Mon, 20 Jan 2020 04:03:51 -0500 Received: from pelzflorian.de ([5.45.111.108]:52892 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itSyD-0006o9-9e for 39142-done@debbugs.gnu.org; Mon, 20 Jan 2020 04:03:45 -0500 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id B8BAA3604F7; Mon, 20 Jan 2020 10:03:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1579511019; bh=caBkCmrWdL8LQWZ4Z+OqrfbAnJ86ToTIx4FnzECY/go=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=rjlNIoZYP2zF4z3dVho2WjnXV1L/jZbDL7uXs6SEPZn4Unhq17pGQ8WdXXoTczRz3 dzNsqigvqQTm02dUSXosueY9BqGJ6M/vxd+kQ7bem1KQweLlb12w6viOlJzZEualdD 5MXcAg3CYOHQdBjSEVBD5JeEfos0js0wQLKUlPOU= Date: Mon, 20 Jan 2020 10:03:38 +0100 From: "pelzflorian (Florian Pelz)" To: Christopher Baines Subject: Re: [bug#39142] Update USB_ModeSwitch. Message-ID: <20200120090338.5otoyrppuhsp4p23@pelzflorian.localdomain> References: <20200115124810.j3myokleoa7le3sq@pelzflorian.localdomain> <87sgkdovdm.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sgkdovdm.fsf@cbaines.net> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39142-done Cc: 39142-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Jan 18, 2020 at 11:29:41AM +0000, Christopher Baines wrote: > > pelzflorian (Florian Pelz) writes: > > > This series updates USB_ModeSwitch and its data package to their > > November release. > > Both patches look good to me :) > Thank you for the review! Pushed as d0759f613480c13b8c81716eb46dc3606b3a34b0 and 17fe068ed7372dbae09043885b8f091105bef143. Closing this bug. > There's a somewhat uninformative comparison of Guix without these > patches, and Guix with these patches here [1]. > > 1: https://guix-patches-data.cbaines.net/compare?base_commit=9edae6c05cd879393d59702f033f4c3ccce30dba&target_commit=0115c829cc1021b01b1686c5d28a7f6004390c83 > > But what it does show is that there aren't any additional lint warnings, > and the derivations can be computed. > I do not see the first patch there, but it should be OK. I have built it on armhf and x86_64 and successfully modeswitched. Regards, Florian From unknown Sun Jun 22 11:33:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 17 Feb 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator