GNU bug report logs - #39138
28.0.50; Add variables for shell command output buffer names

Previous Next

Package: emacs;

Reported by: Tino Calancha <tino.calancha <at> gmail.com>

Date: Tue, 14 Jan 2020 21:32:01 UTC

Severity: wishlist

Tags: fixed, moreinfo, patch

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: 39138 <at> debbugs.gnu.org
Subject: bug#39138: 28.0.50; Add variables for shell command output buffer names
Date: Tue, 14 Jan 2020 23:43:00 +0100

Tino Calancha <tino.calancha <at> gmail.com> writes:

> --- a/lisp/net/tramp.el
> +++ b/lisp/net/tramp.el
> @@ -3658,8 +3658,8 @@ tramp-handle-shell-command
>  	    (current-buffer))
>  	   (t (get-buffer-create
>  	       (if asynchronous
> -		   "*Async Shell Command*"
> -		 "*Shell Command Output*")))))
> +		   shell-command-buffer-name-async
> +		 shell-command-buffer-name)))))
>  	 (error-buffer
>  	  (cond
>  	   ((bufferp error-buffer) error-buffer)

OK for me. However, I will tweak this a little bit once committed, in
order to keep Tramp's backward compatibility. Likely like this:

(or (bound-and-true-p shell-command-buffer-name-async) "*Async Shell Command*")

etc. Plus a comment, which Emacs version has introduced the variables,
in order to know when this compatibility hack can be removed.

Best regards, Michael.
This bug report was last modified 4 years and 288 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.